Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.
Moderator: OpenTTD Developers
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 03 Jul 2020 19:07
Hmmm, ok, so I'm running openttd.exe from the "F:\Projets\OpenTTD JGR\out\build\x64-Release" folder but the "42524557-BeeReward-v6.tar" folder is located "E:\MagicBuzz\OneDrive\Documents\OpenTTD\content_download\game".
I will try to move the GS file and its libraries to the "F:\Projets\OpenTTD JGR\out\build\x64-Release\game" folder then
JGR
Tycoon
Posts: 2560 Joined: 08 Aug 2005 13:46Location: Ipswich
Post
by JGR 03 Jul 2020 19:20
MagicBuzz wrote: ↑ 03 Jul 2020 19:07
Hmmm, ok, so I'm running openttd.exe from the "F:\Projets\OpenTTD JGR\out\build\x64-Release" folder but the "42524557-BeeReward-v6.tar" folder is located "E:\MagicBuzz\OneDrive\Documents\OpenTTD\content_download\game".
I will try to move the GS file and its libraries to the "F:\Projets\OpenTTD JGR\out\build\x64-Release\game" folder then
You don't need to move the GS itself. The AI/GS compat files compat_*.nut, are probably there things which can't be found.
Don't worry about it too much for now, I ought to have something done next week.
Edit: I've pushed an update.
Is this still not working, and if so, what output do you get from the AI/Game Script Debug window?
mrjack2
Engineer
Posts: 74 Joined: 21 Jan 2016 23:04
Post
by mrjack2 05 Jul 2020 07:12
Got a crash in template replacement when I tried to move a misplaced locomotive from the back to the front of the train. This is in 33.2 but (from a quick look) I can't see anything relevant in the changelog since then.
[+] Spoiler *** OpenTTD Crash Report ***
Attachments
crash.sav (822.23 KiB) Downloaded 63 times
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 05 Jul 2020 10:01
Hello JGR, I'm not sure, but I think it doesn't work.
Right now the GS doesn't propose me new deal, so I can't verify the delay.
But the debug message looks like to be the one you added :
Attachments
Nevers Transport, Jan 31st, 1846.sav (731.33 KiB) Downloaded 54 times
JGR
Tycoon
Posts: 2560 Joined: 08 Aug 2005 13:46Location: Ipswich
Post
by JGR 05 Jul 2020 10:48
mrjack2 wrote: ↑ 05 Jul 2020 07:12
Got a crash in template replacement when I tried to move a misplaced locomotive from the back to the front of the train. This is in 33.2 but (from a quick look) I can't see anything relevant in the changelog since then.
[+] Spoiler *** OpenTTD Crash Report ***
Thanks for the bug report.
This will be fixed by the next release. In the meantime, you should delete or disable the broken template replacement.
MagicBuzz wrote: ↑ 05 Jul 2020 10:01
Hello JGR, I'm not sure, but I think it doesn't work.
Right now the GS doesn't propose me new deal, so I can't verify the delay.
But the debug message looks like to be the one you added :
Nevers Transport, Jul 17th, 1846.png
It works fine here, and corrects the issue that was initially reported.
What else is wrong with it?
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 05 Jul 2020 11:31
Ok sorry. As I told you, I wasn't able to test it really : the GS currently doesn't propose new deal, so I can't check the end date of deals
But in the GS debug windows I saw "API compatibility script not found" and I though this message was your fix that wasn't able to work.
I will do more tests this evening, right now my wife and my children don't let me playing
JGR
Tycoon
Posts: 2560 Joined: 08 Aug 2005 13:46Location: Ipswich
Post
by JGR 05 Jul 2020 12:24
MagicBuzz wrote: ↑ 05 Jul 2020 11:31
Ok sorry. As I told you, I wasn't able to test it really : the GS currently doesn't propose new deal, so I can't check the end date of deals
But in the GS debug windows I saw "API compatibility script not found" and I though this message was your fix that wasn't able to work.
I will do more tests this evening, right now my wife and my children don't let me playing
No rush, I'll be busy with family today as well.
It's the API compatibility scripts directory which we need. If they are not found, it won't work. Tomorrow I'll adjust the messages to make this less unclear.
The latest cmake changes were supposed to have fixed that issue.
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 06 Jul 2020 13:03
Hello,
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 06 Jul 2020 13:30
I'm not sure, but I think the problem comes from this function :
Code: Select all
// Reset the timeout of the goal.
function CompanyGoal::ResetTimeout()
{
local years = GSController.GetSetting("wait_years");
this.timeout = years * 365 * 74;
while (years >= 4) {
this.timeout += 74; // Add one day for every 4 years.
years -= 4;
}
if (years >= 2) this.timeout += 74 / 2; // And 1/2 a day for 2 years.
}
Might be changed to : ?
Code: Select all
// Reset the timeout of the goal.
function CompanyGoal::ResetTimeout()
{
local years = GSController.GetSetting("wait_years");
local daylength_factor = GSDate.GetDayLengthFactor();
this.timeout = years * 365 * 74 * daylength_factor;
while (years >= 4 * daylength_factor) {
this.timeout += 74 * daylength_factor; // Add one day for every 4 years.
years -= 4 * daylength_factor;
}
if (years >= 2 * daylength_factor) this.timeout += 74 * daylength_factor / 2; // And 1/2 a day for 2 years.
}
-- Edit : ok, it looks like I found how to fix it myself
Attachments
compat_brgs.nut (999 Bytes) Downloaded 85 times
Nevers Transport, Nov 3rd, 1849.png (177.76 KiB) Not downloaded yet
JGR
Tycoon
Posts: 2560 Joined: 08 Aug 2005 13:46Location: Ipswich
Post
by JGR 06 Jul 2020 13:47
MagicBuzz wrote: ↑ 06 Jul 2020 13:03
Hello,
This time it works fine.
I have just some doubts about the way you implemented it.
In the GS settings, I can choose how long will last the deals from 1 year to 10 years.
But with you implementation, the actual delay isn't "x years", but "x / daylengthfactor years".
As a result, with a day length factor of 9, a 10 years deal will last for... 13 months.
This is "logic" regarding to the game, but it isn't user friendly.
I see 2 solutions :
- you implement it differently so the GS handle the date properly by multiplying the deal duration by the daylength factor (not sure you can do this from game source)
- the GS must be reworked to handle properly the daylength API you provided in order to compute the deal duration correctly
I see what you mean, but on the other hand that means that easiness is proportional to day length.
The user shouldn't be expected to have to manually adjust unspecified other parameters in inverse proportion to day length.
This would also require the parameter units to change as "year" is now too big a unit.
Given that most players won't touch the parameters it is important that the default is reasonable regardless of the day length.
MagicBuzz wrote: ↑ 06 Jul 2020 13:30
I'm not sure, but I think the problem comes from this function :
Code: Select all
// Reset the timeout of the goal.
function CompanyGoal::ResetTimeout()
{
local years = GSController.GetSetting("wait_years");
this.timeout = years * 365 * 74;
while (years >= 4) {
this.timeout += 74; // Add one day for every 4 years.
years -= 4;
}
if (years >= 2) this.timeout += 74 / 2; // And 1/2 a day for 2 years.
}
Might be changed to : ?
Code: Select all
// Reset the timeout of the goal.
function CompanyGoal::ResetTimeout()
{
local years = GSController.GetSetting("wait_years");
local daylength_factor = GSDate.GetDayLengthFactor();
this.timeout = years * 365 * 74 * daylength_factor;
while (years >= 4 * daylength_factor) {
this.timeout += 74 * daylength_factor; // Add one day for every 4 years.
years -= 4 * daylength_factor;
}
if (years >= 2 * daylength_factor) this.timeout += 74 * daylength_factor / 2; // And 1/2 a day for 2 years.
}
The complexity in this function is due to an attempt to handle leap years (this is where the "4" is coming from).
A more reasonable implementation (which scaled the goal duration) would be:
Code: Select all
// Reset the timeout of the goal.
function CompanyGoal::ResetTimeout()
{
local years = GSController.GetSetting("wait_years");
local daylength_factor = GSDate.GetDayLengthFactor();
this.timeout = (years * 1461 * 74 * daylength_factor) / 4;
}
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 06 Jul 2020 14:40
You're right, but actually, for this specific script, I'm not sure the deal timeout is really a challenge.
I see it more likely to help refreshing deals with better ones times to times.
Default value is 10 years of a deal, and as soon as the deal timeout, a new one is proposed.
So the only chanlenge is for the few last months : you may build a new route but the vehicles are too slow to deliver cargo before timeout.
But for the rest of the timeout, 10 year is not a challenge at all : you will be able to build a route (even without pausing game) in a few months, you'll never need more than 1 year to finish it.
The only moment where it could be a bit challenging is at the begining few years, where you have a very little money : but at this time, you may admit it's more frustrating than challenging to loose a deal after spending all you money in a new route
d0mi3l
Engineer
Posts: 23 Joined: 16 Aug 2013 18:04Location: Poland
Post
by d0mi3l 06 Jul 2020 15:36
I cant delete preset on NewGRF setting windows. Could you take a look in v. 0.34.4.
JGR
Tycoon
Posts: 2560 Joined: 08 Aug 2005 13:46Location: Ipswich
Post
by JGR 06 Jul 2020 18:48
mrbeanisgood wrote: ↑ 24 Jun 2020 02:49
In 0.34.3
Savegame Attached
Sorry I never replied a few months ago; I have been having an issue where 100% of my passengers are "to any station" using cargodist. This has been occuring in my save where I am attempting to recreate the UK rail infrastructure on a 10:1 scale. However, when I started a completely new section of the network that was not attached to any other portion, cargodist magically started working. I hooked up some temporary trains and busses between Waterloo and Paddington stations on the map with no luck. I had been previously resigned to running this save without cargo dist but seeing that it now works in portions of the save I want to see if I can make it work.
The Great Western Rail network does not work, including London Paddington. However, London Waterloo and the newest Southwestern Rail trains/stations I put in are working.
If anyone figures out why this is happening, PLEASE let me know!!!
Thank you all, and thank you for this wonderful version of Openttd!! I can only attempt this because of the JGR Patch Pack
The linkgraph jobs in your savegame had incorrect dates associated with them, this is probably an issue in converting from JokerPP, I'll investigate this.
A fixed copy of the savegame you provided is attached, you will need to wait a short while.
If you still have a copy of the JokerPP save that might be of interest.
MagicBuzz wrote: ↑ 06 Jul 2020 14:40
You're right, but actually, for this specific script, I'm not sure the deal timeout is really a challenge.
I see it more likely to help refreshing deals with better ones times to times.
Default value is 10 years of a deal, and as soon as the deal timeout, a new one is proposed.
So the only chanlenge is for the few last months : you may build a new route but the vehicles are too slow to deliver cargo before timeout.
But for the rest of the timeout, 10 year is not a challenge at all : you will be able to build a route (even without pausing game) in a few months, you'll never need more than 1 year to finish it.
The only moment where it could be a bit challenging is at the begining few years, where you have a very little money : but at this time, you may admit it's more frustrating than challenging to loose a deal after spending all you money in a new route
Just editing the parameter text to explain might be easier, I will look into it at some point.
mrjack2 wrote: ↑ 05 Jul 2020 07:12
Got a crash in template replacement when I tried to move a misplaced locomotive from the back to the front of the train. This is in 33.2 but (from a quick look) I can't see anything relevant in the changelog since then.
This is fixed now and will be in the next release.
ZaphodB
Engineer
Posts: 6 Joined: 17 Apr 2020 12:03
Post
by ZaphodB 07 Jul 2020 06:07
Thank you very much for these patches. I really enjoy playing the game with them!
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 07 Jul 2020 13:41
Hello,
I found a small bug and a behaviour that seems to me anormal.
Anormal behaviour : "too heavy" messages are shown as news, not vehicle message. I my opinion it should be show as "lost vehicle" or "old vehicule" popup, not as newspaper.
Bug : I got some alerts about too heavy trains. Then I sent them to autoreplace with more powerfull engines using the template remplacement. This changes the vehicle number. As a result, I get an invalid vehicle message when showing stacked news after the vehicule is actually replaced. I suggest simply discarding any message related to invalid vehicle. I think this is the case for the "vehicle message" (popup disapears when deleting the vehicle from depot by exemple). If you keep the "newspaper" style, take care about discarding invalid vehicle : don't discard disasters messages
Attachments
Nevers Transport, Jun 13th, 1853.png (426.85 KiB) Not downloaded yet
wallyweb
Tycoon
Posts: 6102 Joined: 27 Nov 2004 15:05Location: Canada
Post
by wallyweb 07 Jul 2020 14:56
MagicBuzz wrote: ↑ 07 Jul 2020 13:41
Hello,
I found a small bug and a behaviour that seems to me anormal.
Anormal behaviour : "too heavy" messages are shown as news, not vehicle message. I my opinion it should be show as "lost vehicle" or "old vehicule" popup, not as newspaper.
Bug : I got some alerts about too heavy trains. Then I sent them to autoreplace with more powerfull engines using the template remplacement. This changes the vehicle number. As a result, I get an invalid vehicle message when showing stacked news after the vehicule is actually replaced. I suggest simply discarding any message related to invalid vehicle. I think this is the case for the "vehicle message" (popup disapears when deleting the vehicle from depot by exemple). If you keep the "newspaper" style, take care about discarding invalid vehicle : don't discard disasters messages
I agree with MagicBuzz re the newpaper issue. Too heavy trains is not a disaster. A red warning box would be more appropriate. I like to build realistically long trains (64 tiles >140 wagons) and head end power is definitely a consideration. Mind you, I do this while assembling the train in the depot and I do not rely upon auto-replace. Also, sort of fun watching a train slowly accelerate while building up momentum on the flat, only to have it stall when half way up a slope and the only way out is to reverse the train and send it to a depot for more engines ( which should be added behind the first engine to preserve the train number).
JGR
Tycoon
Posts: 2560 Joined: 08 Aug 2005 13:46Location: Ipswich
Post
by JGR 07 Jul 2020 19:31
ZaphodB wrote: ↑ 07 Jul 2020 06:07
Thank you very much for these patches. I really enjoy playing the game with them!
I think there is a very minor bug with the departure board feature. When an vehicle has an order to go via a station immediately followed by an order to stop at the same station, the vehicle doesn't appear as an arrival at that station. It will appear as an arrival at subsequent stations but with the "via" station listed twice. (This might seem like a strange thing to do, but I like having "via" on the departure board!)
I hope it's not stepping on anyone's toes by attempting to see why this happens. But I think the code at line 623 in departures.cpp should be checking that the order is not a "via" order (i.e. not ONSF_NO_STOP_AT_DESTINATION_STATION or ONSF_NO_STOP_AT_ANY_STATION) before registering a collision. Similarly, at line 646, it should perhaps not add to the calling at list if it is just a "via" order.
Thanks again!
Thanks for investigating this. This is fixed and will be in the next release.
MagicBuzz wrote: ↑ 07 Jul 2020 13:41
Hello,
I found a small bug and a behaviour that seems to me anormal.
Anormal behaviour : "too heavy" messages are shown as news, not vehicle message. I my opinion it should be show as "lost vehicle" or "old vehicule" popup, not as newspaper.
Bug : I got some alerts about too heavy trains. Then I sent them to autoreplace with more powerfull engines using the template remplacement. This changes the vehicle number. As a result, I get an invalid vehicle message when showing stacked news after the vehicule is actually replaced. I suggest simply discarding any message related to invalid vehicle. I think this is the case for the "vehicle message" (popup disapears when deleting the vehicle from depot by exemple). If you keep the "newspaper" style, take care about discarding invalid vehicle : don't discard disasters messages
Thanks for reporting this. This is fixed now.
nirasa
Engineer
Posts: 83 Joined: 03 Sep 2015 07:11Location: Czech republic
Post
by nirasa 13 Jul 2020 08:40
I have Linux and I compile this program. I can't make a package for 0.35 = missing ./configure - the package doesn't exist. Did you change anything?
Sorry for my english
nirasa
MagicBuzz
Tycoon
Posts: 1354 Joined: 15 Feb 2003 17:32Location: Vergezac, France
Post
by MagicBuzz 13 Jul 2020 09:10
I think JGR obviously changed something.
With Visual Studio 2019 on Windows 10... it compiles but instead of running with english language, it started with arabic language
arabic.png (74.54 KiB) Viewed 1974 times
-- Edit : in fact, most of languages disapeared. There is not even standard English. Something went wrong during trunk merge I guess.
languages short list.png (46.56 KiB) Viewed 1969 times
JGR
Tycoon
Posts: 2560 Joined: 08 Aug 2005 13:46Location: Ipswich
Post
by JGR 13 Jul 2020 09:33
nirasa wrote: ↑ 13 Jul 2020 08:40
I have Linux and I compile this program. I can't make a package for 0.35 = missing ./configure - the package doesn't exist. Did you change anything?
Sorry for my english
nirasa
Trunk recently adopted CMake. You'll need to use that instead of configure.
Run:
Code: Select all
mkdir build
cd build
cmake ..
make
or see
here .
MagicBuzz wrote: ↑ 13 Jul 2020 09:10
I think JGR obviously changed something.
With Visual Studio 2019 on Windows 10... it compiles but instead of running with english language, it started with arabic language
arabic.png
-- Edit : in fact, most of languages disapeared. There is not even standard English. Something went wrong during trunk merge I guess.
languages short list.png
Odd, I've got no issues with languages here.
Which commit are you using? 9ad158cd0a (from your screenshot) does not look like a commit from the repo.
I've yet to try CMake with MSVC, but typically CMake problems can be resolved by deleting the build directory and starting again.
In general for Windows users I'd suggest using the pre-built binaries.
Users browsing this forum: No registered users and 42 guests
