FIRS Industry Replacement Set - Development

Discuss, get help with, or post new graphics for TTDPatch and OpenTTD, using the NewGRF system, here. Graphics for plain TTD also acceptable here.

Moderator: Graphics Moderators

User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: FIRS Industry Replacement Set - Development & Translations

Post by wallyweb »

andythenorth wrote: 11 Dec 2019 11:18 Not buying. No Moose, no sale.
We have added your name to our Special Person Advisory Machine. Because you are a special person you will be advised daily as to the status of your order which is pending the establishment of a proper Genuine Faux Moose Wallet industry chain. 8)
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5657
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: FIRS Industry Replacement Set - Development & Translations

Post by andythenorth »

Time for a FIRS version 4 alpha. :)

Unlike the previous FIRS 4 test, this one has a new grfid, separating it from FIRS 3. Also the correct version info is now displayed in-game / filename.

Needs minimum OpenTTD 1.9, as it requires OpenTTD support for up to 16 cargos in/out.

Major changes are:
  • use more than 3 cargos in / 2 out at certain industries, notably ports and harbours
  • major rework of Steeltown
  • major rework of Arctic Basic
  • minor rework of Tropic Basic
  • all production code rewritten as the newgrf spec changed with 16 cargo in/out support
It's very possible that there are bugs in the new production code, and it would be super useful to find those ASAP :)

Download FIRS 4 Alpha 1
firs-4.0.0-alpha-1.tar
(5.76 MiB) Downloaded 375 times

OpenTTD Issue
There is a known bug in OpenTTD 1.9 where the industry directory window crashes the game. Basically, don't do that, or use OpenTTD nightly where it's fixed. https://github.com/OpenTTD/OpenTTD/issues/7631

Docs
I'm also testing alternatives for publishing the FIRS docs, as it's no longer possible to use OpenTTD Coop for this.

This link is not permanent, but eh: Test v4 Docs
Last edited by andythenorth on 15 Dec 2019 07:16, edited 1 time in total.
User avatar
kamnet
Moderator
Moderator
Posts: 8548
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: FIRS Industry Replacement Set - Development & Translations

Post by kamnet »

andythenorth wrote: 14 Dec 2019 08:31 OpenTTD Issue
There is a known bug in OpenTTD 1.9 where the industry directory window crashes the game. Basically, don't do that, or use OpenTTD 1.10 or nightly where it's fixed. https://github.com/OpenTTD/OpenTTD/issues/7631
Using OpenTTD 1.10 beta 1, I got the industry directory to crash the game when I set FIRS to Steeltown. Save and crash log attached.

Code: Select all

Assertion failed at line 164 of d:\a\1\s\src\strings_func.h: n < this -> num_param
Attachments
crash-2019-12-15.zip
(484.3 KiB) Downloaded 127 times
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5657
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: FIRS Industry Replacement Set - Development & Translations

Post by andythenorth »

Also in v4, Scrap Yard / Junk Yard production now depends on town population, so big towns will cause enormous scrap metal production :twisted:
kamnet wrote: 15 Dec 2019 05:59 Using OpenTTD 1.10 beta 1, I got the industry directory to crash the game when I set FIRS to Steeltown. Save and crash log attached.
You're right, fix #7631 isn't in OpenTTD 1.10.0-beta-1, my mistake :) It is merged so it will be in OpenTTD nightlies, I've amended the earlier post, thanks.
cbtendo
Engineer
Engineer
Posts: 2
Joined: 15 Dec 2019 16:48

Re: FIRS Industry Replacement Set - Development & Translations

Post by cbtendo »

I'm trying to start a new game using jgr patch pack and firs 4 alpha, I got this error after the map has been generated

Image
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5657
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: FIRS Industry Replacement Set - Development & Translations

Post by andythenorth »

cbtendo wrote: 15 Dec 2019 16:53 I'm trying to start a new game using jgr patch pack and firs 4 alpha
Thanks for the report!

I admire what JGR does with the patchpack, but there's no FIRS support for JGRPP, sorry :)

Works fine for me in vanilla OpenTTD.
cbtendo
Engineer
Engineer
Posts: 2
Joined: 15 Dec 2019 16:48

Re: FIRS Industry Replacement Set - Development & Translations

Post by cbtendo »

andythenorth wrote: 15 Dec 2019 16:57
cbtendo wrote: 15 Dec 2019 16:53 I'm trying to start a new game using jgr patch pack and firs 4 alpha
Thanks for the report!

I admire what JGR does with the patchpack, but there's no FIRS support for JGRPP, sorry :)

Works fine for me in vanilla OpenTTD.
So, I tried using firs in the latest nightly build, using FIRS 4 in extreme mode, I got fishing ground error.
then I tried changing it into in a hot country mode, i got diamond mine error.
then I tried changing it into steeltown, I got no error.

then I disable all newgrf except firs 4 and set it to extreme mode, I got no error. the same also happened in JGRPP, if I deactivate all newgrf except firs, I got no error in extreme mode.
I think this is conflicting newgrf. Could anyone help narrow down which might be the issue? Here's my newgrf list
[+] Spoiler

Code: Select all

F1250008|50FB3D273893DED2B688E50332514FFE|firs-4.0.0-alpha-1\firs-4.0.0-alpha-1\firs.grf = 5 0 0 0 0 0 16 150 80 300
4A595001|BBA9F50E894D063E20773A66E15B8FAD|2cc_bus_set-v10\2ccbusset.grf = 4 3 3 7 6 7
4E4D0325|DACB1F8EC7F42730F6AFBA6F1B0749ED|2cc_rapid_transit_for_me-1\2ccrtfm.grf = 4 4 1 1 1 1 1 1 1 1 1 1 1
544D0101|7305E4DD26832283F7E8ABFE1F62192A|2cc_trainsinnml-3.0alpha3\2ccts.grf = 4 4 1 1 1 1 1 1 1 1 1 1 1
FBFB0010|2A0082F909643FFB6624BD510EBDDA4D|2cc_trams-0.1.0beta2\trams-2cc.grf = 0 1
44440A01|FCEEC76CF44EC23E7FE9C88048CF11CC|av8_aviators_aircraft_set-2.21\pb_av8w.grf = 1 0 0 0 0 1
5A425801|B10930FC85F8C693D5AA08CFF30202EF|chinese_true_town_names-1.0\chinese_true_town_names.grf = 
50430901|C3AE624A4F431B28FCB52CDB7F7867FA|chips_custom_docks-1.0\chips_docks.grf = 0 0 0 0 0
43485053|BD7D7783BDFCA29CF1149CF9271FD8BB|chips_station_set-1.9.0\chips.grf = 
4C4D0201|F4D9597764DCB3ED985A79978F233A8C|dutch_signals-1\dutchsignals.grf = 
58534453|2E100BCA91DB8371CD9D57DBEC3AB0C8|dutch_stations_set-1.0.0alpha\dutchstatw.grf = 
504A0112|80D0B8699A417CC03CD06BC74E8796D0|dutch_station_addition_part_2-0.4\dstatadd_part2_v0_4.grf = 
504A0113|0B65D0779D65427BC135FC624278FEA3|dutch_station_addition_part_3-001\dstatadd_part3_v001.grf = 
504A0110|E8244C5278CB2408A818854DC11F8940|dutch_station_addition_set-0.8\dstatadd_v0_8.grf = 
FBFB0601|E167E84751FD2E61967944010AF5C56D|dutch_trainset_2-2.1.0\dutchtrains.grf = 0 0 4 4 1 1
FBFB0602|DBB6827E16FBB0540AD2CD99C59B68C9|the_dutch_trainset_addon-1.0\dutch_trainset_addon.grf = 4 4 1
52571203|2E00A55DF056E0F4BD7BBC2517514DC7|egrvts2-202\egrvts2.grf = 0 62 3 0
454E1901|83C370E282A6EABD81B358D898C8E7CD|future_reality_inspired_maglevs-1.2\frims_maglev_set_1.2.grf = 1 2 2 2 2 1 1 1 1 1 1 1 1 0 1
44440A11|D701E3219A08351B1705A7860644A9A2|general_av8ion-1.0\genav8.grf = 
41501202|B13DD8FB0D7C34CACAC2FE68BD137BB9|heqs_heavy_equipment_set-1.5.2\heqs.grf = 9 9 1 1 1 1
455B0101|D224D77DBA44740B1DB42DCCAA67B25A|indonesian_town_names-0.9\indonesia-beta-8.grf = 
4A430002|93EAC5F5396584B92D4C5F0AAAF3F6C5|industrial_stations_renewal-1.0.2\indstatr.grf = 0 1
5043A010|1B83986FEE421A06589FFB66D5364E11|isr_rail__road_depots-0.2\isr_depot.grf = 0
504A0013|8C19753CB66905E869534611828C2654|isrdwestyle_objects-1.1\isrdwe_objects_v1_1.grf = 
504A0103|7040A4DC88302927794941CD853A47CF|isrstyle_dock-1.4\isrdock_v1_4.grf = 
45520C00|FCF4EE39F19C02D9E8603D07621DDD99|japanese_town_names.0.6\jpset_namw.grf = 
52453200|DBA84425F161E178ABAFBC3232509240|japanset_landscape-3.1\jpland.grf = 1 0 1 2
2C320A01|065916BDB63F43BBB4A686E1B4954004|japanese_signals-3.0\jpsignals.grf = 1
45530500|D9BE5AFA481FC3E0A96E6EB72B455612|japanese_stations-3.6\jpstations.grf = 1 1 1 1
44503000|0BF5A48500990CF4CBFED5D7CC6ED120|japanese_tracks-3.2\jptracks.grf = 0 0 0 2 2 1 1 1 3 1 0
535A0D00|21AC703CAB2BE6A80FAF2344366FE0C1|japanese_train_set-3.3\jptrains.grf = 0 1 1 2 1 0 1 1 0 1 0 0
44501401|5B9D588504701CCC2BB14CDB1F18D06B|japanese_maglevs-3.1\jptrainsadd.grf = 0 0 0 0 0 1 1 1
454E1301|1FFB499CFEE765FF7F591D7D8C040AD0|japanese_suspended_monorail_set-1.0\jpsusmon.grf = 1 2 2
4B570101|04C0F5160683940421285B980D72EC47|keio_railway_set-3.0beta2\jptaddon.grf = 10 5 3 3 0 0
44483031|462AEF0B6FD5F93F593E7AF549D91FA6|jnr_ed75-1.0\ed75.grf = 
544B0202|C336DF8D4ED416B99892E403303C9CA7|korean_bus_set-0.3.6\ko_bus_set.grf = 5 0 0 0 0 0 3 5 0 0
544B5555|3C6D4F008CCA9EB6F5C0F09846F5D910|korea_train_set-1.6.10\ko_train_set.grf = 0 10 10 10 10 0 3 5 0 0 2 0 0 0 0 2 0
454E0202|AC1ADFB1CBF3066671DE6D454C7B43AF|maglev_track_set_v2-2.2\maglev_track_set.grf = 0 2 2 2 2 3 1 1 1 1 1 1 1 2 3 4 5 0
44450602|315AB806C5B8E61EEFDBBC2EEC7E824E|mops_generic_nrt_road_vehicles_-0.6.5\moprv65.grf = 2 2 4 2 2 2 0 2 2 2 0
454E2101|AF88DC41C74FC64B8479F256665A0C76|nats__nagoya_area_train_set-0.4.1.1\nats.grf = 1 2 2
444A5401|B9E9E16F258B32DC91E8BABEF037AFA7|nutracks-r247\nutracks.grf = 1 2 5 1975 0 0 80 125 180 230 350 56 56 37 20 14 14 9 20
4D50006A|3A797B1A7E3968A91CB45199BCF52520|ore_unloader_station-0.1\iorestat.grf = 1
4A530117|CA32127C974FD70434F9CA4E0AD4A501|ecs__firs_vehicle_set-2014.11.26\efrefit.grf = 
4D430207|8602C9039D1F4E68FDBFF966360C11AE|polroad-44\polroad.grf = 2 1 2 0 0 1 1 1
52495302|5E2D6D85CF9D5D4BE7F045E81A17F1A0|recycled_infrastructure_set-4.0\ris.grf = 0 1 1 1 1 0 0 0 1 1 1 0 0 0 0 0 0 1 0 0 1 0 1 3 0 0 1 1 2 2 1 0
52545303|9305831333D743549C5B7A8DCB2D78A4|recycled_track_set-0.1\rts.grf = 0 1 1 1 1 0 0 0 1 1 1 0 0 0 0 0 0 1 0 0 1 0 1 3 0 0 1 1 2 2 1 0
1560B248|76BE5A3BA8C66817C14CFA05177D20D9|redfish-0.4\redfish.grf = 1 1 0
454E2001|EB36821EDDFAAC0E5E18CD296E55D7FA|real_international_maglev_set-1.5\rims.grf = 1 2 2 0 2 1 1 1 1 1 1 1 1 0 0 1
9787EAFE|04ACD20A006E345283D6464678AFFA8B|road_hog-1.4.1\road-hog.grf = 1 0 0
4A430105|CB8F923BC8983DE30A783B288A3F63B7|stadler_gtw_trenord_atr115125-1.0\stadler_gtw_trenord.grf = 
54420101|A6B5EAE6320FC2C1A3A62D6D7295E029|toei_interconnection_addon_set-1.7alpha\tias.grf = 2 2 2 3 1
6D6B77E0|40746D85AEE624BB26A981D9EA9BD5A2|tokyo_metro_set-3\tokyometro.grf = 2 2
74677462|1D2A4E03D9F30922788C166254C27619|total_bridge_renewal_set-1.2\total_bridges.grf = 
56430001|2AD089EE6B73F25D79F286AD43765914|total_town_replacement_set-3.14\ttrs3w.grf = 1 0 0 1
58580101|C49269BB422614D7F0DBCC7D9060A19D|traxx_locomotive_set-0.2.0.1\traxx.grf = 0 0
55460101|2C6D5E48C2B5265384A557F856BC9275|urermm-1.02\u_rermm.grf = 1
4A4B0102|E266EACC1B3452D7538497F1332100DB|korean_bus_set_expansion-v1.17.0\kbs_expand_1.17.0.grf = 5 5 5 5 0 0 2 3 1 0 0 0 0 0
4B4B1101|AF908557A71573681F5A0A72015B1378|vace__vtol_aircraft_for_everyon-4\vace.grf = 0 0
444A5903|A6F5779EF9AACF8417D5C06956613CEB|vactrain_set_1.1.fork-1.1.3\vactrain.grf = 2020 2028 0 0 0
4341121F|76460247317559F33BAE02EC30110698|iron_horse_2-2.3.0\iron-horse.grf = 1 0 2
49485102|6D64983AC3AE3854D078B40F487E722E|iron_horse_2_addon-0.1\ih_addonset.grf = 2
34371099|E30E3F3D806AC87FC15358AC2213CFED|RattRoadsAll.grf = 0 0 1
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5657
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: FIRS Industry Replacement Set - Development & Translations

Post by andythenorth »

I'll investigate some more, thanks :)

These errors are definitely possible, they're exactly what I'd expect to see from bugs in the new production code, or from an older incompatible version of OpenTTD.
User avatar
kamnet
Moderator
Moderator
Posts: 8548
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: FIRS Industry Replacement Set - Development & Translations

Post by kamnet »

I got FIRS 4.0 Beta one to produce the same errors that cbtendo go, by loading FIRS along with any other industry set based on FIRS 2/3 code. And it caused a never-ending cycle of errors to pop up in the middle of the screen, and you can't clear them away fast enough, and it covers up any of the other boxes to exit the game or the program, so you have to force the OS to terminate the program. And I got it to do it on OpenTTD 1.9.3, 10.0.0 Beta 1, today's nightly and JGRPP 0.32.4.

:D
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5657
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: FIRS Industry Replacement Set - Development & Translations

Post by andythenorth »

kamnet wrote: 31 Dec 2019 05:48I got FIRS 4.0 Beta one to produce the same errors that cbtendo go, by loading FIRS along with any other industry set based on FIRS 2/3 code.
Any specific grfs? :) I tried to repro with older FIRS, with Auz Industries and with SPI, can't trigger this. Sounds lolz though :twisted:
User avatar
kamnet
Moderator
Moderator
Posts: 8548
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: FIRS Industry Replacement Set - Development & Translations

Post by kamnet »

andythenorth wrote: 31 Dec 2019 08:24
kamnet wrote: 31 Dec 2019 05:48I got FIRS 4.0 Beta one to produce the same errors that cbtendo go, by loading FIRS along with any other industry set based on FIRS 2/3 code.
Any specific grfs? :) I tried to repro with older FIRS, with Auz Industries and with SPI, can't trigger this. Sounds lolz though :twisted:
North American Industry Set, Apollo Rocket Industry Set, and I can't remember what else now.

Funny thing, it played fine, it didn't look like any cargo chains were broken, you just had to play around the big error box. :)
Diesel Power
Traffic Manager
Traffic Manager
Posts: 222
Joined: 18 Jun 2016 19:05

Re: FIRS Industry Replacement Set - Development & Translations

Post by Diesel Power »

Just a quick one, the Iron ore mine isn't snow aware. think it's the only industry that isn't.
User avatar
ignasigh
Engineer
Engineer
Posts: 57
Joined: 23 Feb 2008 07:37

FIRS bug with Fishing Grounds

Post by ignasigh »

With latest FIRST (v3) the Fishing grounds do not have fish as production if your industry type is EXTREME. However it works if it is temperate.

Not sure who can take a look at it.
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5657
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: FIRS Industry Replacement Set - Development & Translations

Post by andythenorth »

So.

FIRS v4 will remove Extreme.

FIRS v4 is an update to make use of both 16 cargos per industry and the increased cargo limits per game. :)

Extreme doesn't adapt well to those changes. :oops:

The plan is to develop new complex economies, with more coherent themes than Extreme. FIRS v4 Steeltown is the first of these. FIRS Basic economies are also tweaked in v4 to use 16-cargo industries in a couple of cases.

Reworking an economy takes about a year or more, so if I wait to add more, FIRS v4 with new Steeltown won't be released until 2021 earliest.:shock:

So FIRS v4 will remove Extreme.

FIRS v4 will also remove In A Hot Country.

Those economies will remain present in FIRS v3, which will still be available on Bananas. Super!
User avatar
kamnet
Moderator
Moderator
Posts: 8548
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: FIRS Industry Replacement Set - Development & Translations

Post by kamnet »

This makes me both happy and sad, as I'm definitely an "Extreme" kinda guy. ;)

Still, Andythenorth is a forward-thinking, if not outright brilliant, developer who has never rested on his laurels. Pushing FIRS forward will, no doubt, bring a lot of happiness to others.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: FIRS Industry Replacement Set - Development & Translations

Post by wallyweb »

I hope he adds Canadian maple syrup and beaver pelts to his new list of cargoes. 8)
Post Reply

Return to “Graphics Development”

Who is online

Users browsing this forum: Google Adsense [Bot] and 4 guests