JGR's Patch Pack

[JGR]

It's not case of adding a parameter. It's a case of actually adding the code for these vehicles to be able to overtake. It's not disabled, it's simply not there.

I had a go at adding the missing code, there wasn't much more required.

It's on github if anyone fancies testing it.

[Diesel Power]

Really?! I figured if it was that simple it would've been done years ago.

[JGR]

I would like to remind suggestion about possibility of cloning/using template consist of expired vehicles

This is done now, it'll be in the next release.

[Wahazar]

Thanks for great work!

I have one more suggestion: permanent (until visit in dock) decrease of speed for ship (if advanced breakdowns are enabled), as it is already done for trains and road vehicles.
Reason is same as for road vehicles: disable avoiding maintenance payment by removing depots -
such "cheat" give even higher handicap than for road vehicles due to high ship purchase costs.

[3iff]

It's definitely the compatibility files that are causing the crash. Vehicle groups can be organized in a hierarcy since 1.9.0, so AIGroup::CreateGroup got an extra parameter: the parent group of the new group.

compat_1.2.nut should contain the following excerpt:

Code: Select all

/* 1.9 adds parent_group_id to CreateGroup function */
AIGroup._CreateGroup <- AIGroup.CreateGroup;
AIGroup.CreateGroup <- function(vehicle_type)
{
	return AIGroup._CreateGroup(vehicle_type, AIGroup.GROUP_INVALID);
} 

If this part is not there in your file, then your compatibility files are not up to date

Spot on. I never normally update those files as they never change...but once a fresh install worked perfectly I realised that something had changed When Trunk (and this patch) upgraded to 1.9.0, some AI/Compat*.nut files had code added.

It's now working perfectly. Apologies for the false bug report.

[eekee]

Funny story: I tried improved breakdowns on my slow game today. It's a game I started too early; I have only one engine and it only does 43mph. It can take trains 6 months or more to get from source to destination. To handle all the cargo, I have a lot of trains, there's a lot of traffic. With improved breakdowns on, even after the breakdown clears, a train may be stuck doing less than half its maximum speed until it's next service. What happens? Well, I've had queues 300 tiles long, 150 tiles back to a drop-off station and 150 tiles behind it. The industries are FIRS and I make heavy use of engineering and farm supplies to boost production. When a supply train is stuck behind another or is itself stuck doing less than half its maximum speed, what happens? Production of the affected industry drops to 1/3, meaning all the trains needed to support its full production queue up waiting to enter the station, which itself is likely to inhibit the supply train reaching the station... Fortunately, the latter situation hasn't actually triggered devastating queuing, but the potential is there for this one feature in this particular game to be worse than any other disaster the game offers! I can patch up after a destroyed UFO far quicker than it took that 300 tile queue to clear! It's a really big event when this happens!

Edit: Of course, when a train is running so slowly, it has more time to break down again, too!

[JGR]

Funny story: I tried improved breakdowns on my slow game today. It's a game I started too early; I have only one engine and it only does 43mph. It can take trains 6 months or more to get from source to destination. To handle all the cargo, I have a lot of trains, there's a lot of traffic. With improved breakdowns on, even after the breakdown clears, a train may be stuck doing less than half its maximum speed until it's next service. What happens? Well, I've had queues 300 tiles long, 150 tiles back to a drop-off station and 150 tiles behind it. The industries are FIRS and I make heavy use of engineering and farm supplies to boost production. When a supply train is stuck behind another or is itself stuck doing less than half its maximum speed, what happens? Production of the affected industry drops to 1/3, meaning all the trains needed to support its full production queue up waiting to enter the station, which itself is likely to inhibit the supply train reaching the station... Fortunately, the latter situation hasn't actually triggered devastating queuing, but the potential is there for this one feature in this particular game to be worse than any other disaster the game offers! I can patch up after a destroyed UFO far quicker than it took that 300 tile queue to clear! It's a really big event when this happens!

Edit: Of course, when a train is running so slowly, it has more time to break down again, too!

I tend to give vehicles with medium/long order lists more than one "service at depot" order.
This way if they do break down or otherwise need servicing they don't usually have to go too far before the next service order.

If you have queues that long resulting from a single breakdown you probably need more slack/capacity in your layout.
When I use trains with full load orders, I often place some queuing sidings before the loading stations so that if trains come in faster than cargo is available to be loaded, they can queue up there without blocking unrelated traffic, or worse blocking traffic trying to leave the loading station.

[Diesel Power]

sooooo, now NRT has been merged, will it be in the pack soon?

[SimYouLater]

sooooo, now NRT has been merged, will it be in the pack soon?

Don't rush him. I ask, but I never push.

EDIT: To be clear...

I asked JGR about the real time daylength patch, because I wasn't sure if he would see it. When he looked and said no guarantees, I said thanks and left the topic alone.

This is not the same, you're asking him to put out a patch pack... something he's already going to do... sooner. Don't, it's inconsiderate to assume NRT being added to JGR's patch pack will be easy or quick, and it's inconsiderate to ask someone to work faster on a project they volunteered for.

[Diesel Power]

2 messages in 2 weeks is hardly pushy. JGR has mentioned in the past that it will be included when it's merged, this has now happened. I wasn't demanding it's release tomorrow, Just enquiring wether he is aware of this and if it's in the pipe line.

[peter1138]

Pretty sure he's busy swearing at us changing lots of underlying code and causing massive conflicts. Sorry JGR!

[JGR]

2 messages in 2 weeks is hardly pushy. JGR has mentioned in the past that it will be included when it's merged, this has now happened. I wasn't demanding it's release tomorrow, Just enquiring wether he is aware of this and if it's in the pipe line.

There are a few issues outstanding in the most recent patchpack release at the moment, once these are all resolved and I've done some testing I'll do another release.
Once that is out of the way I will start looking at NRT and other upstream changes.

Pretty sure he's busy swearing at us changing lots of underlying code and causing massive conflicts. Sorry JGR!

No need to apologise at all. I am very happy to merge improvements, features, and so on.

[acs121]

2 messages in 2 weeks is hardly pushy. JGR has mentioned in the past that it will be included when it's merged, this has now happened. I wasn't demanding it's release tomorrow, Just enquiring wether he is aware of this and if it's in the pipe line.

Let's not worry, JGR is going to update it sooner or later anyways.
There's not even a stable version containing NRT and the latest changes yet AFAIK.

[eekee]

I tend to give vehicles with medium/long order lists more than one "service at depot" order.
This way if they do break down or otherwise need servicing they don't usually have to go too far before the next service order.

I will if I decide to enable improved breakdowns again.

If you have queues that long resulting from a single breakdown you probably need more slack/capacity in your layout.

Yeah. I think it was at capacity before I started serving another high-capacity industry and added a bunch of passenger trains on one of the main lines. It's taken quite a lot of work to increase the capacity, but it wasn't too difficult in the end.

When I use trains with full load orders, I often place some queuing sidings before the loading stations so that if trains come in faster than cargo is available to be loaded, they can queue up there without blocking unrelated traffic, or worse blocking traffic trying to leave the loading station.

Yup. In some cases I've got them queuing in depots, more often I've taken care there's enough length leading in, but it doesn't look like I've been that careful with every station.

[Diesel Power]

There's not even a stable version containing NRT and the latest changes yet AFAIK.

NRT has been merged with master and will be available in nightlies.

[SimYouLater]

2 messages in 2 weeks is hardly pushy. JGR has mentioned in the past that it will be included when it's merged, this has now happened. I wasn't demanding it's release tomorrow, Just enquiring wether he is aware of this and if it's in the pipe line.

Sorry. It's just that if I'm told it's rude to nicely ask for a feature (someone criticized me about quoting JGR into a topic) then I don't see why anyone else should be allowed to ask about anything.

[acs121]

There's not even a stable version containing NRT and the latest changes yet AFAIK.

NRT has been merged with master and will be available in nightlies.

Nightlies are NOT stable versions.
Nightlies are, like the word says, nightly releases for the purpose of testing new features, etc.

[SimYouLater]

There's not even a stable version containing NRT and the latest changes yet AFAIK.

NRT has been merged with master and will be available in nightlies.

Nightlies are NOT stable versions.
Nightlies are, like the word says, nightly releases for the purpose of testing new features, etc.

Master is the new Stable, while Nightlies are still Nightlies. So yes, it is in stable.

[jfs]

Master is the new Stable, while Nightlies are still Nightlies. So yes, it is in stable.

You have no idea what you're talking about.

Stable = a release version that has a version number. For example 1.9.1 is a stable version, it has a version number and is not called "beta" or "release candidate". A stable version is generally tagged from a branch that has been thoroughly tested, and only received bugfixes and not new features, or other changes the developers consider risky in terms of potentially introducing new bugs.

Master = a term used in the git version control system to refer to the main development branch. Most software projects that use git for version control has the master be an unstable development version where all new features go in to. This means the master version will typically have many unknown and/or unfixed bugs. In OpenTTD the master branch is considered unstable.
The thing called master in git is directly equivalent to the thing called trunk in SVN.

Nightly = an automatic build from a certain development branch. In the case of OpenTTD nightly builds are made from the master branch, and because the master branch is unstable the nightly builds are considered unstable.

[MarkShot]

Jon,

Yesterday, I used your TIME TABLE|AUTOMATIC|SEPARATE function to smooth out the delivery of engineering supplies to multiple oil well heads.

It was beautiful to watch. All these small trains leaving the creating depot at once and after a few minutes being dispersed quite evenly in arrival at the well heads.

And it was perfect. Just how perfect? The same trains going up and down were routinely passing each other at the same time points.

Thank you!