JGR's Patch Pack

[JGR]

Annoyingly, I've just found a regression in v0.29.1.
Avoid moving orders by dragging for the time being.

[mak]

"The currently selected base graphics is missing 4 sprites. Please check for updates for the baseset." I use abase but still get the same with zbase and OpenGFX.

OpenTTD's master branch has added new sprites over the years. If you download the latest development version of OpenGFX, this error will go away. zBase is slow in its development, but it will be updated eventually. Unfortunately, aBase is no longer being developed, it was abandoned by its author.

Thanks kamnet,

pray tell me where to get the latest developement of OpenGFX.
Please be aware I am a complete and utter numpty and will require step by step guide and words of one syllable.

Thank you

[kamnet]

pray tell me where to get the latest developement of OpenGFX.

The current stable version is here, and should fix the issue:
https://www.openttd.org/downloads/openg ... atest.html

If it doesn't, the latest nightly development version is here:
http://bundles.openttdcoop.org/opengfx/nightlies/LATEST

Detailed installation instructions are included in the files.

[mak]

Kamnet

I thank you.

I have the latest stable but will try the nightly.

EDIT: No luck will leave it for now as it does not seem to having an effect on the game.

Thanks for your attempt.

[agentw4b]

Crash log 0.29.0.

If this is a known error, I apologize for the unnecessary message.

[JGR]

Crash log 0.29.0.

If this is a known error, I apologize for the unnecessary message.

This issue looks to be one that is already fixed in 0.29.1.
No need to apologise though, thanks for reporting it.

[stb]

Hi there,
It seems Fast Forward is too fast!!!

[Gwyd]

Fast forward is when the game runs as fast as it can using as much of your PC's capacity as possible. If it's too fast, it's due to your computer's power.

[stb]

Ohh, so they did a lot to optimize the code that the performance jumped extremely.

[peter1138]

Basically window elements now update at the same speed regardless of the fast-forward setting, so things like click/release timers and subtle animations now work correctly in FFWD. As a side effect, this leaves more CPU time for the gameloop to run, and run it does...

[mrjack2]

With the two railtypes on a tile, is there a way to convert just one track and leave the other track unchanged? The convert tool still does full squares...

[Ro(V)eO]

Hey, it's me, again ^^

With 29.2, I get the following error while trying to make the application:

Code: Select all

../Downloads/OpenTTD-PP29.2/src/saveload/extended_ver_sl.cpp:197:16: error: 
      redeclaration of '_sl_version' with a different type: 'uint16'
      (aka 'unsigned short') vs 'SaveLoadVersion'
        extern uint16 _sl_version;
                      ^
../Downloads/OpenTTD-PP29.2/src/saveload/saveload.h:908:25: note: 
      previous declaration is here
        extern SaveLoadVersion _sl_version;
                               ^
1 error generated.
make[1]: *** [saveload/extended_ver_sl.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 1

Any suggestions JGR?

[JGR]

With the two railtypes on a tile, is there a way to convert just one track and leave the other track unchanged? The convert tool still does full squares...

No, this requires removing the track and re-building it with the new rail type at present.

Hey, it's me, again ^^

With 29.2, I get the following error while trying to make the application:

Code: Select all

../Downloads/OpenTTD-PP29.2/src/saveload/extended_ver_sl.cpp:197:16: error: 
      redeclaration of '_sl_version' with a different type: 'uint16'
      (aka 'unsigned short') vs 'SaveLoadVersion'
        extern uint16 _sl_version;
                      ^
../Downloads/OpenTTD-PP29.2/src/saveload/saveload.h:908:25: note: 
      previous declaration is here
        extern SaveLoadVersion _sl_version;
                               ^
1 error generated.
make[1]: *** [saveload/extended_ver_sl.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 1

Any suggestions JGR?

Thanks for reporting this, I've committed a fix.

[Ro(V)eO]

Thanks for reporting this, I've committed a fix.

You're welcome! Obviously, I like the PP-features so I DO want to get the latest patch running
And how better than with reporting issues?


Next try, this time without terminating errors

Thanks JGR, great work!

[Redirect Left]

A minor glitch that occurs in the current version, and i do mean minor.

If you buy a unit whilst paused (which i often do, as i do larger build projects in paused mode), the window for that vehicle shows 'send vehicle to depot' instead of the option to clone or copy the vehicle. As soon as you unpause the game, it switches to the correct one. Looks like it doesn't set the right default property when you create the vehicle, but as soon as the loop is turned back on, it instantly knows "oops, wrong display, its stopped in a depot".

It isn't game breaking, its just a bit irritating for me personally, i might be the only person who builds in this manner! It's still possible to clone the vehicle by going to the depot window and pressing the clone button on that, so its just an extra bit of mouse running really to a different button.

[JGR]

A minor glitch that occurs in the current version, and i do mean minor.

If you buy a unit whilst paused (which i often do, as i do larger build projects in paused mode), the window for that vehicle shows 'send vehicle to depot' instead of the option to clone or copy the vehicle. As soon as you unpause the game, it switches to the correct one. Looks like it doesn't set the right default property when you create the vehicle, but as soon as the loop is turned back on, it instantly knows "oops, wrong display, its stopped in a depot".

It isn't game breaking, its just a bit irritating for me personally, i might be the only person who builds in this manner! It's still possible to clone the vehicle by going to the depot window and pressing the clone button on that, so its just an extra bit of mouse running really to a different button.

I noticed this as well but then forgot about it, it's due to upstream trunk changes.
I've committed a fix, it'll be in the next release.

[Tintinfan]

Greetings JGR,

Thanks as always for your fine work. For once I'm not here to nag with a bug report, but I am curious to see if you can extended a feature I've noticed in the latest version to other areas. Click and drag areas for purchasing land is useful, is there any chance this could be extended to include objects? Many NewGRF objects would be easier to place with such a feature (like the eyecandy dutch motorways). Just a wee thought


Cheers,

Tin

[Emperor Jake]

Bug report: the ships are drifting

boat.gif (109.69 KiB) Viewed 3408 times

I first noticed it in the title screen. It seems that sometimes when ships turn around at a dock or buoy they face the wrong direction while travelling. Then I tested it with NewGRFs but it doesn't affect NewGRFs (i.e. FISH) that update the vehicle sprite as soon as it starts moving. Also the ships work correctly if you make the distance between the buoys bigger.

edit: after further playing I've seen ships do a little dance when leaving a dock, and travelling backwards until they change angle. So lots of strange ship behavour in general...

Tested in JGRPP 0.29.2 on Windows 10 64, doesn't happen in the 20190201 nightly

[JGR]

Bug report: the ships are drifting

boat.gif

I first noticed it in the title screen. It seems that sometimes when ships turn around at a dock or buoy they face the wrong direction while travelling. Then I tested it with NewGRFs but it doesn't affect NewGRFs (i.e. FISH) that update the vehicle sprite as soon as it starts moving. Also the ships work correctly if you make the distance between the buoys bigger.

edit: after further playing I've seen ships do a little dance when leaving a dock, and travelling backwards until they change angle. So lots of strange ship behavour in general...

Tested in JGRPP 0.29.2 on Windows 10 64, doesn't happen in the 20190201 nightly

Thanks for reporting this, I've committed a fix which will be in the next release.
This is due to an oversight on my part when merging in the ship rotation feature from trunk.

Greetings JGR,

Thanks as always for your fine work. For once I'm not here to nag with a bug report, but I am curious to see if you can extended a feature I've noticed in the latest version to other areas. Click and drag areas for purchasing land is useful, is there any chance this could be extended to include objects? Many NewGRF objects would be easier to place with such a feature (like the eyecandy dutch motorways). Just a wee thought


Cheers,

Tin

NewGRF Objects have a number of complications due to taking up more than one tile, and having NewGRF-controlled placement conditions.
In due course I will look into the feasibility of investigating what might be able to be done about this.

[Ayo]

Hi, is there a downloadable version of openttd with jgr's patch pack for MacOS? I'm programming illiterate so I wouldn't know how to compile it myself. Grateful for anyone who can post a link. Cheers!