JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

acs121 wrote:NML was an attempt to replace NFO, however most features of NFO still can't be done yet with NML.
Actually, NML is NOT an attempt to replace NFO. The NFO is still there under the covers as it were. Both NML and m4nfo are upper level languages that merely make NFO more human readable for ease of programming. My personal preference is to work directly from the NewGRF specs (NFO).

The only time I have to contend with OpenTTD or TTDPatch being slow is when I have a dozen programs open on my PC all at once. That's not the program's problem. That's just the idiot using his computer to do too many things at once. :P

Heh. The amazing thing is I actually got here from there. :mrgreen:
User avatar
orudge
Administrator
Administrator
Posts: 25137
Joined: 26 Jan 2001 20:18
Skype: orudge
Location: Banchory, UK
Contact:

Re: JGR's Patch Pack

Post by orudge »

The discussion that was here about vanilla OpenTTD vs patch packs has been split off to this topic. Please keep any follow-ups there.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

ino wrote:Nice. Tried it in many configuration and I still haven't managed to brake this looks-fragile feature yet.

A question though: why not also for passenger? If the reason is realistic, there's actually a train line in Tokyo that does that... (Granted, not exactly the same. Basically a 8-car train pulled into 4-car platform. The first four car is boarded/unboared, then the first 4 cars is detached from the rear, goes to different destination, then the rear 4 cars pull into the station)
I have to draw the line somewhere. Disallowing passenger trains is a reasonable compromise between realism and having simple enough rules for end-users to understand.
ino wrote:And I think I manage one bug:

Image

In other configuration it works as expected though (without conditional, or with next order conditional).
That should be fixed now, it hadn't occurred to me to use those two features together in that way.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

JGR wrote:I have to draw the line somewhere. Disallowing passenger trains is a reasonable compromise between realism and having simple enough rules for end-users to understand.
There might not be much of a compromise. From my experience, passenger platforms tend to be long enough to accommodate most pax trains. On the other hand, for freight, especially hopper/gondola service, very long trains tend to move slowly past an unloader/loader. I like it. :D

Anybody up for patching in coupling/decoupling and shunting? (\me hides beyond the asteroid belt) :mrgreen:
ino
Traffic Manager
Traffic Manager
Posts: 152
Joined: 09 Apr 2017 14:58

Re: JGR's Patch Pack

Post by ino »

wallyweb wrote:
JGR wrote:I have to draw the line somewhere. Disallowing passenger trains is a reasonable compromise between realism and having simple enough rules for end-users to understand.
There might not be much of a compromise. From my experience, passenger platforms tend to be long enough to accommodate most pax trains. On the other hand, for freight, especially hopper/gondola service, very long trains tend to move slowly past an unloader/loader. I like it. :D

Anybody up for patching in coupling/decoupling and shunting? (\me hides beyond the asteroid belt) :mrgreen:
Are there any technical difficulties regarding passenger trains? Because as I pointed out, there's an actual passenger train service that also operate like this. If it's technical difficulties, then I totally understand.

And I'd love coupling-decoupling-shunting, but to make it useful we likely need a whole new set of Order, and that's sound like it's going to be really complicated XD Also, allowing multiple trains per platforms (though in this case I remember reading that someone implement this in his/her personal version).

But really, after shunting we are going to need a gravity-based cargo wagon sorter!

/me come back to reality
User avatar
acs121
Tycoon
Tycoon
Posts: 1957
Joined: 03 Nov 2017 18:57
Location: Courbevoie, near Paris, France

Re: JGR's Patch Pack

Post by acs121 »

ino wrote:
wallyweb wrote:
JGR wrote:I have to draw the line somewhere. Disallowing passenger trains is a reasonable compromise between realism and having simple enough rules for end-users to understand.
There might not be much of a compromise. From my experience, passenger platforms tend to be long enough to accommodate most pax trains. On the other hand, for freight, especially hopper/gondola service, very long trains tend to move slowly past an unloader/loader. I like it. :D

Anybody up for patching in coupling/decoupling and shunting? (\me hides beyond the asteroid belt) :mrgreen:
Are there any technical difficulties regarding passenger trains? Because as I pointed out, there's an actual passenger train service that also operate like this. If it's technical difficulties, then I totally understand.

And I'd love coupling-decoupling-shunting, but to make it useful we likely need a whole new set of Order, and that's sound like it's going to be really complicated XD Also, allowing multiple trains per platforms (though in this case I remember reading that someone implement this in his/her personal version).

But really, after shunting we are going to need a gravity-based cargo wagon sorter!

/me come back to reality
I'd love coupling, decoupling etc. It wouldn't need much work though. Just reconsider depots as rail yards, tell your train "attach 8 grain wagons here, take them to ... and decouple them to let them load, get back to depot and attach more grain wagons and so on"
peter1138
OpenTTD Developer
OpenTTD Developer
Posts: 1732
Joined: 30 Mar 2005 09:43

Re: JGR's Patch Pack

Post by peter1138 »

acs121 wrote:I'd love coupling, decoupling etc. It wouldn't need much work though.
I welcome your Pull Request (master or JGRPP) with this feature implemented, then. :-)
He's like, some kind of OpenTTD developer.
User avatar
Gwyd
Chief Executive
Chief Executive
Posts: 721
Joined: 17 Apr 2017 16:52
Location: Western Ile-de-France Region

Re: JGR's Patch Pack

Post by Gwyd »

This has been brought up many times before I guess... But this would actually be rediculously hard. Or the choices needed for it would be. The UI changes are fine, but what is the name of the 2 new trains formed if each part has a loco? How do you tell the train where to split? What does the game do if it's just wagons left over? How can the game predict what it will connect to? And how will coupling restrictions work with this? How would orders handle merging/splitting services? And what if one part of a service merge hadn't arrived but was caught in traffic? Many, many difficult choices to make and (I'd guess, not that I actually know) very difficult to code.

On a seperate note, it'd mostly remove the need for depots for sorting trains.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

romazoon wrote:hello JGR

i think i managed to break the custom bridgehead...i wasn t very cautious, and i managed to replace a bridge wich had a custom bridge head while a tram already started to enter the custom tile. now it s stuck, can t do anything, i can t redo the custom bridge head because it says vehicle is on the bridge, i can t demolish it cause vehicle on the bridge...

good luck smashing that bug :)
KeldorKatarn wrote:@JGR I already fixed this in my version. Bridge upgrades preserve custom bridgehead for road and signal for rail data. Check my fork for that. Unfortunately, that won't help this player out ;) It can'T be fixed AFTER the fact.
Thanks, I've added a fix for this based on yours.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
acs121
Tycoon
Tycoon
Posts: 1957
Joined: 03 Nov 2017 18:57
Location: Courbevoie, near Paris, France

Re: JGR's Patch Pack

Post by acs121 »

romazoon wrote:hello JGR

i think i managed to break the custom bridgehead...i wasn t very cautious, and i managed to replace a bridge wich had a custom bridge head while a tram already started to enter the custom tile. now it s stuck, can t do anything, i can t redo the custom bridge head because it says vehicle is on the bridge, i can t demolish it cause vehicle on the bridge...

good luck smashing that bug :)

p.s : for the newgrf you will miss, send me a pm, but probably you won t need them as they are not involved in that situation ;)
Totally OT, but at least i don't have to ask for the savegame now :twisted:
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

I know a while ago there was a setting for 'same_industry_close', true means you can basically build lots of the same industry next to each other to create a huge production line.
This setting appears to have no effect anymore, and i'm stuck at the "too close to another industry" error - has this feature being intentionally removed, or is it renamed or done in another manner now?
Attachments
gaghs.png
gaghs.png (135.22 KiB) Viewed 3013 times
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: JGR's Patch Pack

Post by KeldorKatarn »

I THINK there're a setting called "multiple industries per town" or something, that prevents the same town from having multiple industries of the same type. but the NewGRFs themselves also can define certain restrictions on where industries can be built so... not sure exactly which is preventing that here.
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

KeldorKatarn wrote:I THINK there're a setting called "multiple industries per town" or something, that prevents the same town from having multiple industries of the same type. but the NewGRFs themselves also can define certain restrictions on where industries can be built so... not sure exactly which is preventing that here.
I don't have any GRFs that affect industries - unless for some reason a station or vehicle newgrf is affecting placement for some reason.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
ecolortest
Engineer
Engineer
Posts: 19
Joined: 12 Oct 2016 07:46

Re: JGR's Patch Pack

Post by ecolortest »

Crash in wine

ERROR>fixme:dbghelp:MiniDumpWriteDump NIY MiniDumpWithDataSegs
ERROR>err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x5f4d6f

so how to fix it?

My device is mac book pro earlly 2011 13-inch
Version macos High sierra Version 10.13.4
Processor 2.3 GHz Intel Core i5
Memory 8gb 1600 mhz ddr3
grphics Intel hd Graphics 3000 512 MB
User avatar
Doorslammer
Tycoon
Tycoon
Posts: 1037
Joined: 16 Oct 2007 11:08
Location: Perth, Western Australia
Contact:

Re: JGR's Patch Pack

Post by Doorslammer »

Loving the patch pack, absolutely thrilling to have network sharing back again.

Quick question though. Is there any plans to have an option to disable the Income/Transfer/Loss figures that rise from the trains as they finish unloading. It seems that when there is enough vehicles on screen to do so, it does cause a monumental slowdown on the system.
Image
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

another suggestion i realised would be quite handy playing today;
As you know, if you click a train, it will give a quick GUI overview of where it calls, with little numbers over all its stops.

Is it possible, that when you click on a station, it gives a similar overview, but for all trains that call there - this would quickly help me identify where this station has direct links to, and spot any missing useful links for passengers to get to and from there.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

Redirect Left wrote:Is it possible, that when you click on a station, it gives a similar overview, but for all trains that call there - this would quickly help me identify where this station has direct links to, and spot any missing useful links for passengers to get to and from there.
When you click to open the station's window, there are little engine/RV/ship/airplane images on the bottom right. Clicking on one of these will show all the respective vehicles which have that station on their schedule. Perhaps this could be modified to show something similar to the industry chains.
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

wallyweb wrote:
Redirect Left wrote:Is it possible, that when you click on a station, it gives a similar overview, but for all trains that call there - this would quickly help me identify where this station has direct links to, and spot any missing useful links for passengers to get to and from there.
When you click to open the station's window, there are little engine/RV/ship/airplane images on the bottom right. Clicking on one of these will show all the respective vehicles which have that station on their schedule. Perhaps this could be modified to show something similar to the industry chains.
This is currently what I am using, and going through each vehicle or group of vehicles. However, its is rather tedious. if we can have the same sort of display, just a little balloon above all stations with trains that call there and also at the station you clicked on, i'd be happy with pretty much anything that wasn't quite as tedious as the current best way.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

Good idea with vehicles links to the station. In my opinion, if station is clicked, it should show all direct links to the other stations. It would be great for debugging cargodist.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

ecolortest wrote:Crash in wine

ERROR>fixme:dbghelp:MiniDumpWriteDump NIY MiniDumpWithDataSegs
ERROR>err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x5f4d6f

so how to fix it?

My device is mac book pro earlly 2011 13-inch
Version macos High sierra Version 10.13.4
Processor 2.3 GHz Intel Core i5
Memory 8gb 1600 mhz ddr3
grphics Intel hd Graphics 3000 512 MB
Can you post the crash.log file?
Redirect Left wrote:another suggestion i realised would be quite handy playing today;
As you know, if you click a train, it will give a quick GUI overview of where it calls, with little numbers over all its stops.

Is it possible, that when you click on a station, it gives a similar overview, but for all trains that call there - this would quickly help me identify where this station has direct links to, and spot any missing useful links for passengers to get to and from there.
Isn't this more or less what the cargo dest link graph overlay does?
The departure boards can also be quite useful here.
My todo list is currently very long, so developing this sort of feature is not likely to occur soon.
If you/someone else can develop a reasonable quality patch to implement it that may be a more pragmatic way to go.
Ex TTDPatch Coder
Patch Pack, Github
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 20 guests