JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7241
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

cpeosphoros wrote:Hi there, is it better to post issues here or open then on the GitHUb repo?

Thanks
My guess is either would work, but a lot of people do just post the bugs here, and JGR is fairly active here.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
vrn
Engineer
Engineer
Posts: 66
Joined: 07 Mar 2018 17:00

Re: JGR's Patch Pack

Post by vrn »

There seems to be a problem with 32bpp graphics in the 32-bit Windows build of jgrpp-0.23.0.
As an example, BRIX 0.0.2 bridges:
[+] Spoiler
vanilla OpenTTD:
Image
JGRPP:
Image
Same happens with some bridges and buildings of zBase baseset:
[+] Spoiler
Image
Image
As kamnet advised on my Reddit post, I attached the save files at the bottom.
Attachments
32bpp jgrpp test.sav
With BRIX and some other GRFs
(170.81 KiB) Downloaded 60 times
32bpp jgrpp test3.sav
no GRFs loaded
(161.73 KiB) Downloaded 59 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

vrn wrote:There seems to be a problem with 32bpp graphics in the 32-bit Windows build of jgrpp-0.23.0.
As an example, BRIX 0.0.2 bridges:
[+] Spoiler
vanilla OpenTTD:
Image
JGRPP:
Image
Same happens with some bridges and buildings of zBase baseset:
[+] Spoiler
Image
Image
As kamnet advised on my Reddit post, I attached the save files at the bottom.
Thanks for reporting this. I've been unable to reproduce it so far (using the 32-bit windows build in Wine).
Can you post your config file (openttd.cfg)?
Ex TTDPatch Coder
Patch Pack, Github
cpeosphoros
Engineer
Engineer
Posts: 7
Joined: 05 Mar 2018 16:31

Re: JGR's Patch Pack

Post by cpeosphoros »

I'd like to suggest a small QOL improvement to the patch pack, which is already present in the current vanilla trunk.
tunnel_corners.png
tunnel_corners.png (276.53 KiB) Viewed 4568 times
As shown in the picture, suppose I want to make a tunnel (or any other terrain lowerment) immediately to the side of an already built tile. The patch pack (v. 0.23) doesn't allow me to lower the two corners marked in red - so I have to buldoze the railway line there, lower them, build the tunnel, then rebuild the rails over the slopes.

In vanilla, if I try to lower those two corners, it allows the operation - with the expected results, a flat slope to build the tunnel over and the side rail is correctly left on the side slopes.

With rails it's almost no problem, buldozing and rebuilding them, but vanilla also allows that trick for other buildings like industries an city tiles - so, if it would be possible to integrate that in the patch, it would be nice.

(Edited for spelling)
ino
Traffic Manager
Traffic Manager
Posts: 152
Joined: 09 Apr 2017 14:58

Re: JGR's Patch Pack

Post by ino »

cpeosphoros wrote: As shown in the picture, suppose I want to make a tunnel (or any other terrain lowerment) immediately to the side of an already built tile. The patch pack (v. 0.23) doesn't allow me to lower the two corners marked in red - so I have to buldoze the railway line there, lower them, build the tunnel, then rebuild the rails over the slopes.

In vanilla, if I try to lower those two corners, it allows the operation - with the expected results, a flat slope to build the tunnel over and the side rail is correctly left on the side slopes.

With rails it's almost no problem, buldozing and rebuilding them, but vanilla also allows that trick for other buildings like industries an city tiles - so, if it would be possible to integrate that in the patch, it would be nice.

(Edited for spelling)
That always works fine for me though, even in the patch pack.
cpeosphoros
Engineer
Engineer
Posts: 7
Joined: 05 Mar 2018 16:31

Re: JGR's Patch Pack

Post by cpeosphoros »

ino wrote:That always works fine for me though, even in the patch pack.
Sadly, not for me:
errormessage.png
errormessage.png (123.36 KiB) Viewed 4564 times
vrn
Engineer
Engineer
Posts: 66
Joined: 07 Mar 2018 17:00

Re: JGR's Patch Pack

Post by vrn »

JGR wrote: Can you post your config file (openttd.cfg)?
Here it is. It's shared between vanilla OpenTTD, JGRPP and the other builds I'm using. Could this cause the aformentioned problems?
cpeosphoros wrote: ...The patch pack (v. 0.23) doesn't allow me to lower the two corners marked in red...
IIRC there's a setting wether to allow terraforming under buildings and infrastructure, could you check this?
Attachments
openttd.cfg
(39.42 KiB) Downloaded 59 times
cpeosphoros
Engineer
Engineer
Posts: 7
Joined: 05 Mar 2018 16:31

Re: JGR's Patch Pack

Post by cpeosphoros »

vrn wrote:
cpeosphoros wrote: ...The patch pack (v. 0.23) doesn't allow me to lower the two corners marked in red...
IIRC there's a setting wether to allow terraforming under buildings and infrastructure, could you check this?
Yes, that did the trick, thank you. ;)
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

vrn wrote:There seems to be a problem with 32bpp graphics in the 32-bit Windows build of jgrpp-0.23.0.
As an example, BRIX 0.0.2 bridges:
[+] Spoiler
vanilla OpenTTD:
Image
JGRPP:
Image
Same happens with some bridges and buildings of zBase baseset:
[+] Spoiler
Image
Image
As kamnet advised on my Reddit post, I attached the save files at the bottom.
This is a bug in an optimisation I made in the non-SSE 32bpp blitter implementation.
It is fixed now and will be in the next release.
Ex TTDPatch Coder
Patch Pack, Github
Tsylatac
Engineer
Engineer
Posts: 50
Joined: 26 Dec 2015 01:04

Re: JGR's Patch Pack

Post by Tsylatac »

I crash out trying to open my save in 0.23.0. It warns me that the save may be corrupted, but it opens fine in 0.22.1.

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Sat Mar 10 00:49:42 2018
In game date: 1802-02-01 (0, 1)

Crash reason:
 Exception: E1212012
 Location:  00007FF8C5384008
 Message:   Assertion failed at line 3430 of /home/jgr/openttd/cross-win64/src/saveload/afterload.cpp: order->GetTravelTime() == 0

OpenTTD version:
 Version:    jgrpp-0.23.0 (0)
 NewGRF ver: 18006d40
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Feb 10 2018 11:29:58
 Configure:  ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
 C86D3B28 00007FF8 0000002F 00000000 0384ABF0 00000000 0384AC1F 00000000
 E1212012 00000000 00000000 00000000 C5384008 00007FF8 00000000 00000000
 00000001 00000000 007E5D47 00000000 F247554D 00002316 C86D38F8 00007FF8
 00000000 00000000 C890A41A 00007FF8 0384AB98 00000000 D32FCB41 00000000
 00000000 00000000 00001FD0 00000000 0384ABF0 00000000 00610D97 00000000
 00000000 00000000 00004030 00000000 0384ABF0 00000000 0054A29D 00000000
 ECDD90DB 00002FC6 0384ABF0 00000000 0384AC1F 00000000 0057E9B5 00000000
 00000016 00000000 0384ABF0 00000000 00000000 00000000 0000004F 00000000
 6000E093 6EB867B0 00000000 00000001 00000000 00000004 00000000 00000028
 00000003 00000000 0384AF00 00000000 00000000 00000000 00000074 00000000
 0384AF00 00000000 0597C950 00000000 64616F4C 20676E69 72756F79 76617320
 6D616765 61632065 64657375 65704F20 4454546E 206F7420 73617263 540A2E68
 20736968 70207369 61626F72 20796C62 73756163 62206465 20612079 72726F63
 69747075 69206E6F 6874206E 61732065 61676576 0A2E656D 61656C50 66206573
 20656C69 75622061 65722067 74726F70 646E6120 74746120 20686361 73696874
 76617320 6D616765 000A2E65 00000000 00000000 00000000 059C5D80 00000000
 00000010 00000000 00000003 00007FF8 C86D3670 00007FF8 059C5D70 00000000
 059C5D70 00000000 00000080 00000000 00000003 00000000 00000018 00000000
 059B19E0 00000000 05972340 00000000 C86D3500 00007FF8 C86D3600 00007FF8
 00000001 00000000 00000002 00000000 00000002 00000000 00000010 00000000
 FFFFECA2 00000001 00000001 00000000 00020000 00000000 05960300 00000001
 05960150 00000000 00000003 00000000 00000002 00000000 00000000 00000000
 0599C660 00000000 00000080 00000000 00000004 00000000 00000030 00000000
 FFFFECA1 00000000 00000002 00000000 00000002 00000000 C86D36F8 00007FF8

Registers:
 RAX: 000000000384AB48 RBX: 000000000000002F RCX: 000000000384AC40 RDX: 000000000384AB00
 RSI: 000000000384ABF0 RDI: 000000000384AC1F RBP: 0000000001E06280 RSP: 000000000384AAA0
 R8:  0000000000000000 R9:  0000000000000000 R10: 0000000000000000 R11: 0000000000000004
 R12: 0000000000000016 R13: 0000000000D600C8 R14: 000000000057E790 R15: 0000000000000001
 RIP: 00007FF8C5384008 EFLAGS: 00000202

 Bytes at instruction pointer:
 48 8B 8C 24 C0 00 00 00 48 33 CC E8 A8 E6 06 00 48 81 C4 D8 00 00 00 C3

Operating system:
 Name:     Windows
 Release:  6.2.9200 ()
 Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
 Blitter:      32bpp-sse2-anim
 Graphics set: OpenGFX (5580)
 Language:     C:\Program Files\OpenTTD\openttd-custom-jgrpp-0.23.0-MINGW-win64\lang\english_US.lng
 Music driver: win32
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: win32
 Sound set:    OpenSFX (87)
 Video driver: win32

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 0):
  0: Human
 GS: Villages Is Villages (v9)

Libraries:
 FreeType:   2.6.0
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
 C:\Program Files\OpenTTD\openttd-custom-jgrpp-0.23.0-MINGW-win64\openttd.exe handle: 0000000000400000 size: 39492866 crc: 0AF4D385 date: 2018-03-10 00:36:35
 C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007ff8c8ac0000 size: 1954048 crc: E8BB04BB date: 2018-02-10 06:15:34
 C:\WINDOWS\System32\KERNEL32.DLL handle: 00007ff8c60a0000 size: 702568 crc: 26053BED date: 2017-09-29 13:42:04
 C:\WINDOWS\System32\KERNELBASE.dll handle: 00007ff8c5370000 size: 2514944 crc: 18AD50CB date: 2018-02-10 06:15:53
 C:\WINDOWS\System32\ADVAPI32.dll handle: 00007ff8c6290000 size: 649304 crc: 1EA4BBC8 date: 2018-01-01 12:47:06
 C:\WINDOWS\System32\msvcrt.dll handle: 00007ff8c88d0000 size: 630752 crc: D96A352D date: 2018-01-08 04:41:19
 C:\WINDOWS\System32\sechost.dll handle: 00007ff8c8870000 size: 371424 crc: 5F5ADC2E date: 2017-09-29 13:41:43
 C:\WINDOWS\System32\RPCRT4.dll handle: 00007ff8c8970000 size: 1173576 crc: 05459EFD date: 2018-01-01 12:43:31
 C:\WINDOWS\System32\GDI32.dll handle: 00007ff8c6510000 size: 154008 crc: 988E7AE4 date: 2017-09-29 13:41:28
 C:\WINDOWS\System32\gdi32full.dll handle: 00007ff8c5df0000 size: 1636376 crc: 7EBC1C7F date: 2018-01-08 04:41:21
 C:\WINDOWS\System32\msvcp_win.dll handle: 00007ff8c5d50000 size: 628632 crc: 97093F9A date: 2018-02-10 06:02:17
 C:\WINDOWS\System32\ucrtbase.dll handle: 00007ff8c4f90000 size: 1002592 crc: DAF7FB12 date: 2018-02-10 06:14:51
 C:\WINDOWS\System32\USER32.dll handle: 00007ff8c7da0000 size: 1634288 crc: AB65005C date: 2018-01-08 04:40:34
 C:\WINDOWS\System32\win32u.dll handle: 00007ff8c5d30000 size: 119440 crc: 7CB2506F date: 2017-09-29 13:41:31
 C:\WINDOWS\System32\IMM32.dll handle: 00007ff8c6260000 size: 173640 crc: D95A028D date: 2017-09-29 13:41:45
 C:\WINDOWS\System32\combase.dll handle: 00007ff8c84d0000 size: 3180720 crc: 87207CC3 date: 2017-09-29 13:41:44
 C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007ff8c4ec0000 size: 464408 crc: E51422D3 date: 2018-01-08 04:41:19
 C:\WINDOWS\System32\SHELL32.dll handle: 00007ff8c6540000 size: 21351624 crc: C362AAFB date: 2018-02-10 06:08:43
 C:\WINDOWS\System32\cfgmgr32.dll handle: 00007ff8c4f40000 size: 287944 crc: B2701D08 date: 2017-09-29 13:41:44
 C:\WINDOWS\System32\shcore.dll handle: 00007ff8c61b0000 size: 671024 crc: 34F13DE7 date: 2017-09-29 13:41:37
 C:\WINDOWS\System32\windows.storage.dll handle: 00007ff8c55e0000 size: 7675784 crc: EFC10185 date: 2018-02-10 06:08:03
 C:\WINDOWS\System32\shlwapi.dll handle: 00007ff8c6340000 size: 327008 crc: 6A326994 date: 2017-09-29 13:41:57
 C:\WINDOWS\System32\kernel.appcore.dll handle: 00007ff8c4e10000 size: 54368 crc: 292B0640 date: 2017-09-29 13:41:30
 C:\WINDOWS\System32\powrprof.dll handle: 00007ff8c4e50000 size: 299688 crc: 2A10AD8C date: 2017-09-29 13:41:43
 C:\WINDOWS\System32\profapi.dll handle: 00007ff8c4e30000 size: 93640 crc: 37910F15 date: 2017-09-29 13:41:44
 C:\WINDOWS\System32\WS2_32.dll handle: 00007ff8c7d10000 size: 428352 crc: D6B4E02D date: 2017-09-29 13:41:43
 C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007ff8c2a50000 size: 123072 crc: C756E1A2 date: 2017-09-29 13:41:25
 C:\WINDOWS\SYSTEM32\WINMMBASE.dll handle: 00007ff8c2a00000 size: 159680 crc: 0801FBAD date: 2017-09-29 13:41:25
 C:\WINDOWS\system32\uxtheme.dll handle: 00007ff8c3450000 size: 587776 crc: EECA9649 date: 2017-09-29 13:42:00
 C:\WINDOWS\System32\MSCTF.dll handle: 00007ff8c63a0000 size: 1463856 crc: 8AD1E1B5 date: 2018-01-08 04:41:01
 C:\WINDOWS\System32\OLEAUT32.dll handle: 00007ff8c7fb0000 size: 793960 crc: 1C598840 date: 2017-09-29 13:41:43
 C:\Program Files\Common Files\microsoft shared\ink\tiptsf.dll handle: 00007ff8aab10000 size: 675736 crc: F272614E date: 2017-09-29 14:43:09
 C:\WINDOWS\SYSTEM32\TextInputFramework.dll handle: 00007ff8bca00000 size: 617304 crc: 40AD10FB date: 2018-02-10 06:02:15
 C:\WINDOWS\SYSTEM32\CoreMessaging.dll handle: 00007ff8c21d0000 size: 898216 crc: D40FE329 date: 2018-01-01 12:46:23
 C:\WINDOWS\SYSTEM32\CoreUIComponents.dll handle: 00007ff8bf860000 size: 3074824 crc: AC875490 date: 2017-09-29 13:41:28
 C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 00007ff8c3f50000 size: 187064 crc: BCFBDC90 date: 2017-09-29 13:41:43
 C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007ff8c22e0000 size: 1269616 crc: 4A31FEED date: 2017-09-29 13:41:44
 C:\WINDOWS\system32\dwmapi.dll handle: 00007ff8c36c0000 size: 147864 crc: E074A2FB date: 2017-09-29 13:41:41
 C:\WINDOWS\System32\ole32.dll handle: 00007ff8c7b20000 size: 1336344 crc: 0C53C4BE date: 2018-01-01 12:34:51
 C:\WINDOWS\System32\clbcatq.dll handle: 00007ff8c7c70000 size: 626592 crc: CCEF35B2 date: 2017-09-29 13:41:41
 C:\WINDOWS\system32\mswsock.dll handle: 00007ff8c4640000 size: 402992 crc: C9E3ADEF date: 2017-09-29 13:41:44
 C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007ff8bdb60000 size: 438608 crc: 967DA176 date: 2017-09-29 13:41:23
 C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 00007ff8c4c20000 size: 150528 crc: 8531EECF date: 2017-09-29 13:41:44
 C:\WINDOWS\SYSTEM32\PROPSYS.dll handle: 00007ff8c2d10000 size: 1777848 crc: EB7DC555 date: 2017-09-29 13:41:31
 C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007ff8acd20000 size: 244224 crc: 1C9D0D5D date: 2017-09-29 13:41:23
 C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007ff8ab890000 size: 23352 crc: 92FC8D38 date: 2017-09-29 13:41:25
 C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007ff8c10d0000 size: 30048 crc: 8A8EFA03 date: 2017-09-29 13:41:23
 C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007ff8b9250000 size: 1170008 crc: B9349960 date: 2018-02-10 06:04:29
 C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007ff8c0190000 size: 28672 crc: E81668A1 date: 2017-09-29 13:41:23
 C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007ff8aa700000 size: 106472 crc: BEC2999B date: 2017-09-29 13:41:23
 C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007ff8c0180000 size: 24576 crc: AFE10C07 date: 2017-09-29 13:41:23
 C:\Windows\System32\uiautomationcore.dll handle: 00007ff8aac90000 size: 2087424 crc: 96FC0075 date: 2017-09-29 13:41:26
 C:\WINDOWS\SYSTEM32\sxs.dll handle: 00007ff8c4c70000 size: 624032 crc: CD9F653F date: 2017-09-29 13:42:01
 C:\WINDOWS\SYSTEM32\OLEACC.dll handle: 00007ff8b3830000 size: 423424 crc: 0A43F24D date: 2017-09-29 13:41:56
 C:\WINDOWS\SYSTEM32\twinapi.dll handle: 00007ff8c1120000 size: 506880 crc: A4101F8F date: 2018-02-10 04:38:20
 C:\WINDOWS\SYSTEM32\twinapi.appcore.dll handle: 00007ff8c3840000 size: 1554216 crc: D2739C18 date: 2018-01-08 04:40:08
 C:\WINDOWS\SYSTEM32\RMCLIENT.dll handle: 00007ff8c37e0000 size: 125560 crc: 48DD5649 date: 2017-09-29 13:41:31
 C:\WINDOWS\SYSTEM32\bcrypt.dll handle: 00007ff8c4910000 size: 137544 crc: B75F4C6B date: 2018-01-08 04:40:10
 C:\WINDOWS\System32\psapi.dll handle: 00007ff8c8840000 size: 18712 crc: DD419C6C date: 2017-09-29 13:41:41

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.19.0, savegame version 196, not modified, _openttd_newgrf_version = 0x18006cde
New game mode: 1 landscape: 1
Added NewGRF: GRF ID 4A44FAB1, checksum 81D015C3929F1EC2C34574BE7D6420E0, filename: newcc_set-0.2\newcc.grf (md5sum matches)
Added NewGRF: GRF ID 43414E61, checksum 3233EAB371490D899A348A0AE8C59591, filename: ottdc_grfpack\1_other\townnames\canadian\CaNames.grf (md5sum matches)
Added NewGRF: GRF ID 44419501, checksum 12422F3F4301D08201F9FF6F3B5308BF, filename: crazytownnames\crazynames.grf (md5sum matches)
Added NewGRF: GRF ID 4D413031, checksum E7BC25985A2F25B34A19738B398BB3C4, filename: ottdc_grfpack\1_other\townnames\estonian\estoniantownnames.grf (md5sum matches)
Added NewGRF: GRF ID 46544E06, checksum BEDDB58AB99231E1D5A20A27B5062D62, filename: fictown_names-0.1.0a\fictownnames.grf (md5sum matches)
Added NewGRF: GRF ID 4D470701, checksum 46D7675DEBCD076F69F7A34A816F190E, filename: ottdc_grfpack\1_other\townnames\french\frenchtowns.grf (md5sum matches)
Added NewGRF: GRF ID 44550002, checksum 59CADBDBCF2BE70FB6B7CFE7536C057D, filename: ottdc_grfpack\1_other\townnames\german\germantowns.grf (md5sum matches)
Added NewGRF: GRF ID 67726D05, checksum 0E45B3110B6E06C4F256110649C437E9, filename: pokemon_town_names-1\pokemon-names.grf (md5sum matches)
Added NewGRF: GRF ID 45530201, checksum 05270B9EB28E86B34754FA34C6EA11E8, filename: ottdc_grfpack\1_other\townnames\spanish\spn_nmsw.grf (md5sum matches)
Added NewGRF: GRF ID 545701A0, checksum 555F623E72514D23BC2FA2F5BB5DE56B, filename: us_town_names-0.31\ustowns.grf (md5sum matches)
Added NewGRF: GRF ID 46429006, checksum BE358E05F2AE2D1DFE8E85ED45495BF1, filename: ottdc_grfpack\1_other\separators\landscape.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum 136D889FDAEAA3491F8320248A04425C, filename: opengfx_landscape-1.1.2\ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 46727806, checksum BBE029FCDD7A16F85876D417FF318D23, filename: opengfx_trees-0.8.0\opengfx+trees.grf (md5sum matches)
Added NewGRF: GRF ID 46429002, checksum 8FB0984C37C6EEBFEE21C84C2EC8869C, filename: ottdc_grfpack\1_other\separators\infrstructure.grf (md5sum matches)
Added NewGRF: GRF ID 47470705, checksum D9144A59A210360F1A48350F04C6595D, filename: auz_lineside_objects-27\auz_lineside_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47470901, checksum CDEF5B917AB130B36B4D0186F9C006F1, filename: auz_roadside_objects-25\auz_roadside_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47471502, checksum 098B574E41A47B41F8B2218DCAF634D0, filename: auzwaterobjects-7\auz_water_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47472301, checksum EFA4AAE357BAAB3EB6F497ED750323DC, filename: auzfakerailwaylines-9\auzfakerailwaylines.grf (md5sum matches)
Added NewGRF: GRF ID 47472501, checksum F777881337B49E2040886DCC4E1B8BA1, filename: auzfakerailwaylinesaddons-5\auzfakerailwaylines_add-ons.grf (md5sum matches)
Added NewGRF: GRF ID 504A0107, checksum 92B822D319E71F920908801AD5751D26, filename: beach_objects-1.2\beach_v1_2.grf (md5sum matches)
Added NewGRF: GRF ID 0100403A, checksum 672F6BEE2570A5820049B6154AC756F1, filename: city_objects-b08.1.5\co08.1.5.grf (md5sum matches)
Added NewGRF: GRF ID 504A0102, checksum 29EA308A78B7740794B80A117D14BF34, filename: dutch_delta_works-1.1\dutchdeltaworks_v1_1.grf (md5sum matches)
Added NewGRF: GRF ID 444C4F53, checksum 39F25FC87E91F7C4E45D9CC11F0FB52B, filename: dutch_landmark_objects_set-0.2\dlos.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0501, checksum 60082E7DF1D3976274AB86843C3E07B2, filename: dutch_road_furniture-0.7.1\dutchroadfurniture.grf (md5sum matches)
Added NewGRF: GRF ID 44573553, checksum EF7529EBEAF35758EE07E628B25F608D, filename: dwenewobjects-v0.1\dwe_newobj.grf (md5sum matches)
Added NewGRF: GRF ID 54470301, checksum 1D76727A4AC75F28AA1BA864258BB38A, filename: fake_bridges-0.2\fakebridge.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0301, checksum D961A46B2CC37A04CD4FCBEDD2311A53, filename: foobars_tram_tracks-1.0.1\foobarstramtracks.grf (md5sum matches)
Added NewGRF: GRF ID BEBE0100, checksum E24EEEA0E1760CE5CBE2DE202859A3F2, filename: farm_objects-3\farmobjects.grf (md5sum matches)
Added NewGRF: GRF ID 52577801, checksum 20B5D8122F2B4AD74ADDA30E44BA8233, filename: opengfx_biggui-2.0.0\ogfx-biggui.grf (md5sum matches)
Added NewGRF: GRF ID 4C530301, checksum F1BD2B034BAFB1041071447AE952B208, filename: brick_tram_depot-1.0.0\bricktramdepot.grf (md5sum matches)
Added NewGRF: GRF ID 504A0013, checksum E2FB4F9E66207F8016B7303323FDD00C, filename: isrdwestyle_objects-1.0\isrdwe_objects_v1_0.grf (md5sum matches)
Added NewGRF: GRF ID 6D620C00, checksum E1DB74D22EF54328944DC767C4F8594F, filename: marico\marico.grf (md5sum matches)
Added NewGRF: GRF ID 43415000, checksum 436B31E54B135D218E6CAAC583AD2208, filename: ogfx-airports\ogfx-airports.grf (md5sum matches)
Added NewGRF: GRF ID 54470203, checksum F84B6D37659F23D19E176C99BC48DEF6, filename: opengfx_airports_as_objects-0.3\airportobjects.grf (md5sum matches)
Added NewGRF: GRF ID 49464E4F, checksum 9EE9117BD4511BD6879429ECF8DC9335, filename: sno__supercheeses_newobjects-0.3.1\sno-supercheesesnewobjects.grf (md5sum matches)
Added NewGRF: GRF ID 4D4D9910, checksum 3CD3F4D0D98DDC0DB08E9AD74B88A9E2, filename: the_lighthouse_set-1.2\the_lighthouse_set_v1.2.grf (md5sum matches)
Added NewGRF: GRF ID 504A5457, checksum D795341420C564012E262FAB630018C5, filename: town_walls_objects-0.1\townwalls_v0_1.grf (md5sum matches)
Added NewGRF: GRF ID 444E0800, checksum 334F8C4697455569073434DB107F864A, filename: vast_objects-0.3.0\vastobjects.grf (md5sum matches)
Added NewGRF: GRF ID 444E0C00, checksum B5D2AB5FC93A09E1FAB5F0DB82307ECF, filename: vast_fences-0.2.0\vastfences.grf (md5sum matches)
Added NewGRF: GRF ID 415A0301, checksum 8667797182D6F6C670D7BE5D677ACB45, filename: american_road_replacement_set-2.0.0\americanroads.grf (md5sum matches)
Added NewGRF: GRF ID 46727800, checksum 3B58B9177D1A1B54D356F64B93526116, filename: smits-1.0\smits.grf (md5sum matches)
Added NewGRF: GRF ID 44503000, checksum 0BF5A48500990CF4CBFED5D7CC6ED120, filename: japanese_tracks-3.2\jptracks.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0A01, checksum F72870562FBD9CC015A0CCDC60588F86, filename: useless_tracks-0.1.0\uselesstracks.grf (md5sum matches)
Added NewGRF: GRF ID 504A5143, checksum 7E018F7AB3A045ACBED32E2932883516, filename: qatenary-0.1\qatenary_v0_1.grf (md5sum matches)
Added NewGRF: GRF ID 415A0501, checksum 37F4A01391FE088BD22740A89E22F78B, filename: Total_Bridge_Renewal_Set_ARRS-1.0.0\total_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 4672780A, checksum F19F58D3DA48012F20DD0DF707EBCC61, filename: monkey_bar_bridge-1.6\monkeybarbridge.grf (md5sum matches)
Added NewGRF: GRF ID 634D0101, checksum FB64064E543A06749797B920A1CF520D, filename: betabridges-0.7\betabridgesttrs07.grf (md5sum matches)
Added NewGRF: GRF ID 00000002, checksum 7D5AA45F332F9F205C605BFF1B03C217, filename: csdsignalset_v2.01-1\csdsignalsetw.grf (md5sum matches)
Added NewGRF: GRF ID 46429004, checksum 2AA504F45E3F67753A0F07EBB2417A67, filename: ottdc_grfpack\1_other\separators\newindustries.grf (md5sum matches)
Added NewGRF: GRF ID F1250006, checksum 05978AF75D1A1ACC8D8FBEE2BC5061C9, filename: firs_2-2.1.5\firs.grf (md5sum matches)
Added NewGRF: GRF ID 46429005, checksum A356711BD741FB811600BFD01470379E, filename: ottdc_grfpack\1_other\separators\town-buildings.grf (md5sum matches)
Added NewGRF: GRF ID 52453400, checksum B2E27B74A3894198A00139CFCF09D011, filename: japanese_buildings-3.1\jpbuild.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum B21E7D6ADD69B1C07643939764FB4878, filename: swedish_houses-1.1.2\swehouses.grf (md5sum matches)
Added NewGRF: GRF ID 01020001, checksum 138630A34714F6D4C2E6FB5494FE4036, filename: real_arcade_town_set-0.2\realarcade.grf (md5sum matches)
Added NewGRF: GRF ID 4E4C4853, checksum 1787E1E0E308EB5C4E1A8EFC4A059D71, filename: dutch_terraced_houses-0.3b\nlhs.grf (md5sum matches)
Added NewGRF: GRF ID 43414361, checksum 4FF21D837F0C19EF91DB383B62FB3151, filename: ottdc_grfpack\6_town_buildings\nacity\NACityw.grf (md5sum matches)
Added NewGRF: GRF ID 56430001, checksum 2AD089EE6B73F25D79F286AD43765914, filename: total_town_replacement_set-3.14\ttrs3w.grf (md5sum matches)
Added NewGRF: GRF ID 304FE908, checksum F7BCFC491F02F1EDC2D47B28EE2E91D8, filename: city_hqs-rb\chq01.grf (md5sum matches)
Added NewGRF: GRF ID 46429001, checksum 96715B253307A55DA94B02E43C792602, filename: ottdc_grfpack\1_other\separators\stations.grf (md5sum matches)
Added NewGRF: GRF ID 4D480201, checksum 9E914C31E5FC7FC3F686D009BD55F331, filename: alexandra_palace-1.0.0\alexandrapalace.grf (md5sum matches)
Added NewGRF: GRF ID 4A430001, checksum 4CF50E2A770F6672A77A8842A3129ECA, filename: british_stations_set-0.0.4final\dstatsw.grf (md5sum matches)
Added NewGRF: GRF ID 43415463, checksum 422B1603DC1CEDA4E59E715E12EAD332, filename: ottdc_grfpack\7_stations\canstn\canstnw.grf (md5sum matches)
Added NewGRF: GRF ID 43485053, checksum 3C4699AA326D6397DA937AD436DE8906, filename: chips_station_set-1.7.0\chips.grf (md5sum matches)
Added NewGRF: GRF ID 58534453, checksum 2E100BCA91DB8371CD9D57DBEC3AB0C8, filename: ottdc_grfpack\7_stations\dutchstat\dutchstatw.grf (md5sum matches)
Added NewGRF: GRF ID 504A0110, checksum E8244C5278CB2408A818854DC11F8940, filename: dutch_station_addition_set-0.8\dstatadd_v0_8.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 504A0103, checksum F4056FECA93218E2B1FC015B0C7844A2, filename: isrstyle_dock-1.3\isrdock_v1_3.grf (md5sum matches)
Added NewGRF: GRF ID 45530500, checksum D9BE5AFA481FC3E0A96E6EB72B455612, filename: japanese_stations-3.6\jpstations.grf (md5sum matches)
Added NewGRF: GRF ID 58534D00, checksum 6F4C28B41F5127046DED0320D0BE533B, filename: MTSS\modern_set.grf (md5sum matches)
Added NewGRF: GRF ID 6D620601, checksum 537A2B9E5F0644BC360248B2B802D086, filename: newstats\newstats.grf (md5sum matches)
Added NewGRF: GRF ID 504E0001, checksum E7781323D2B0086E2E76342DAA036054, filename: ottdc_grfpack\7_stations\ukwaypoints\ukwaypointsw.grf (md5sum matches)
Added NewGRF: GRF ID 444E0400, checksum 735D3D74D5DCADBF1FD6EF7A9C5A3519, filename: vast_station_tiles-0.2.0\vast.grf (md5sum matches)
Added NewGRF: GRF ID 46429003, checksum 28996AB1BCB293EF81D43E1A2E8E29F4, filename: ottdc_grfpack\1_other\separators\vehicles.grf (md5sum matches)
Added NewGRF: GRF ID 544D0101, checksum 390EA6B640721D3A80200F2A1474B183, filename: 2cc_trainsinnml-2.0alpha1\2ccts.grf (md5sum matches)
Added NewGRF: GRF ID 454E0101, checksum B3FA4F3C0E4D122F2DD3F399A00F6756, filename: modern_maglev_trains-1.2\mmt.grf (md5sum matches)
Added NewGRF: GRF ID 444A5901, checksum 23CEC795D97265752C21EA8F02564A61, filename: vacuum_tube_train-0.22\vactrain.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21\pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 44440A11, checksum D701E3219A08351B1705A7860644A9A2, filename: general_av8ion-1.0\genav8.grf (md5sum matches)
Added NewGRF: GRF ID 4B4B1101, checksum AF908557A71573681F5A0A72015B1378, filename: vace__vtol_aircraft_for_everyon-4\vace.grf (md5sum matches)
Added NewGRF: GRF ID 52571203, checksum 7CE88A25DDB058C1BE577B88D049B274, filename: egrvts2-188\egrvts2.grf (md5sum matches)
Added NewGRF: GRF ID 41501202, checksum B13DD8FB0D7C34CACAC2FE68BD137BB9, filename: heqs_heavy_equipment_set-1.5.2\heqs.grf (md5sum matches)
Added NewGRF: GRF ID 485A0101, checksum 7636EC20949478C0576AE6CDACE9EC84, filename: hover_vehicles-1\hoverv.grf (md5sum matches)
Added NewGRF: GRF ID 4A4D0101, checksum AFE4E75999A3FF92D4B01DBEE9A803E9, filename: sailing_ships-0.62\ss.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 0DA3A80B986BC3C17C20CA4CE9CA26AA, filename: fish_2-2.0.3\fish.grf (md5sum matches)
Tick 1280: settings changed
Setting changed: construction.command_pause_level : 1 -> 3
Tick 1280: settings changed
Setting changed: construction.command_pause_level : 3 -> 0
Tick 1280: settings changed
Setting changed: construction.command_pause_level : 0 -> 1
Tick 2169: settings changed
Setting changed: construction.max_bridge_length : 64 -> 32
Tick 2169: settings changed
Setting changed: construction.max_tunnel_length : 128 -> 64
Tick 3649: settings changed
Setting changed: construction.command_pause_level : 1 -> 3
Tick 3649: settings changed
Setting changed: construction.command_pause_level : 3 -> 1
Tick 11790: settings changed
Setting changed: construction.command_pause_level : 1 -> 0
Tick 11790: settings changed
Setting changed: construction.command_pause_level : 0 -> 3
Tick 11790: settings changed
Setting changed: construction.command_pause_level : 3 -> 1
Tick 56337: settings changed
Setting changed: construction.command_pause_level : 1 -> 3
Tick 56337: settings changed
Setting changed: construction.command_pause_level : 3 -> 1
Tick 5406: game loaded
Revision text changed to jgrpp-0.20.0, savegame version 196, not modified, _openttd_newgrf_version = 0x18006cee
Tick 27634: game loaded
Revision text changed to jgrpp-0.21.0, savegame version 196, not modified, _openttd_newgrf_version = 0x18006d08
Tick 52186: game loaded
Revision text changed to jgrpp-0.22.1, savegame version 196, not modified, _openttd_newgrf_version = 0x18006d1f
Tick 54256: game loaded
Revision text changed to jgrpp-0.23.0, savegame version 196, not modified, _openttd_newgrf_version = 0x18006d40
---- gamelog end ----

Command Log:
 Showing most recent 0 of 0 commands

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x00007FF8C5384008 RaiseException + 104
[01] openttd              0x000000000057E9B5 HandleSavegameLoadCrash (/home/jgr/openttd/cross-win64/src/saveload/afterload.cpp:470)
[02] msvcrt               0x00007FF8C88FA786 raise + 518
[03] msvcrt               0x00007FF8C88FEBAE abort + 46
[04] openttd              0x000000000053A10F error(char const*, ...) + 95 (/home/jgr/openttd/cross-win64/src/openttd.cpp:132)
[05] openttd              0x00000000005880B0 AfterLoadGame() + 30048 (/home/jgr/openttd/cross-win64/src/saveload/afterload.cpp:3430)
[06] openttd              0x000000000059B23D DoLoad (/home/jgr/openttd/cross-win64/src/saveload/saveload.cpp:2999)
[07] openttd              0x000000000059F593 SaveOrLoad(char const*, SaveLoadOperation, DetailedFileType, Subdirectory, bool) + 307 (/home/jgr/openttd/cross-win64/src/saveload/saveload.cpp:3110)
[08] openttd              0x000000000053C2BF SafeLoad(char const*, SaveLoadOperation, DetailedFileType, GameMode, Subdirectory, LoadFilter*) + 223 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1096)
[09] openttd              0x000000000053C46C SwitchToMode(SwitchMode) + 316 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1185)
[10] openttd              0x000000000053DF2E GameLoop() + 78 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1645)
[11] openttd              0x0000000000676859 VideoDriver_Win32::MainLoop() + 457 (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:1291)
[12] openttd              0x000000000053BB07 openttd_main(int, char**) + 5527 (/home/jgr/openttd/cross-win64/src/openttd.cpp:925)
[13] openttd              0x000000000054AE9F WinMain + 239 (/home/jgr/openttd/cross-win64/src/os/windows/win32.cpp:469)
[14] openttd              0x00000000004013ED __tmainCRTStartup + 573 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:332)
[15] openttd              0x00000000004014FB WinMainCRTStartup + 27 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:184)
[16] KERNEL32             0x00007FF8C60B1FE4 BaseThreadInitThunk + 20
[17] ntdll                0x00007FF8C8B2EFC1 RtlUserThreadStart + 33

*** End of additional info ***
Attachments
Ravenholm Transportation Co., 1802-02-01.sav
(4.82 MiB) Downloaded 58 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Tsylatac wrote:I crash out trying to open my save in 0.23.0. It warns me that the save may be corrupted, but it opens fine in 0.22.1.
Thanks for letting me know about this.
I've reduced the strictness of the savegame validation so that the savegame will load, this will be in the next release.
Ex TTDPatch Coder
Patch Pack, Github
Tsylatac
Engineer
Engineer
Posts: 50
Joined: 26 Dec 2015 01:04

Re: JGR's Patch Pack

Post by Tsylatac »

JGR wrote:Thanks for letting me know about this.
I've reduced the strictness of the savegame validation so that the savegame will load, this will be in the next release.
Thank you for the fix!
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

I propose to include Juanjo depot patch:
viewtopic.php?f=33&t=56101
which allow to design large depots similar to multi-platform stations and bring challenge with limited depot capacity.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
SimYouLater
Chief Executive
Chief Executive
Posts: 675
Joined: 03 Apr 2016 20:19

Re: JGR's Patch Pack

Post by SimYouLater »

McZapkie wrote:I propose to include Juanjo depot patch:
viewtopic.php?f=33&t=56101
which allow to design large depots similar to multi-platform stations and bring challenge with limited depot capacity.
I second this. This looks like it will change the logistics of depots drastically.
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.
Dou
Engineer
Engineer
Posts: 5
Joined: 12 Dec 2017 08:15

Re: JGR's Patch Pack

Post by Dou »

Are there any News about a compilded version for mac?
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

McZapkie wrote:I propose to include Juanjo depot patch:
viewtopic.php?f=33&t=56101
which allow to design large depots similar to multi-platform stations and bring challenge with limited depot capacity.
I will look into it, but I can't make any promises. I am quite busy with other matters at present.
Dou wrote:Are there any News about a compilded version for mac?
I don't own any Apple hardware or software, so it's not practical for me to compile or test for Macs.
Ex TTDPatch Coder
Patch Pack, Github
cpeosphoros
Engineer
Engineer
Posts: 7
Joined: 05 Mar 2018 16:31

Re: JGR's Patch Pack

Post by cpeosphoros »

SimYouLater wrote:
McZapkie wrote:I propose to include Juanjo depot patch:
viewtopic.php?f=33&t=56101
which allow to design large depots similar to multi-platform stations and bring challenge with limited depot capacity.
I second this. This looks like it will change the logistics of depots drastically.
Please, if you include this, make it an option to totally turn it off in game.
German_RLI
Engineer
Engineer
Posts: 8
Joined: 07 Apr 2013 16:01

Re: JGR's Patch Pack

Post by German_RLI »

The load/unload by cargo type orders are great, however the auto-refit with this feature is broken - it tries to refit vehicles regardless of that setting, which results in train reffited to cargoes that wouldn't load. It is somewhere in economy.cpp HandleStationRefit() function (or in callees of that) but I have no idea how to fix that.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

German_RLI wrote:The load/unload by cargo type orders are great, however the auto-refit with this feature is broken - it tries to refit vehicles regardless of that setting, which results in train reffited to cargoes that wouldn't load. It is somewhere in economy.cpp HandleStationRefit() function (or in callees of that) but I have no idea how to fix that.
Thanks for letting me know. This only required a minor change which I've pushed to the repo.
Ex TTDPatch Coder
Patch Pack, Github
BW89
Engineer
Engineer
Posts: 105
Joined: 10 May 2015 11:42

Re: JGR's Patch Pack

Post by BW89 »

Found a little Bug/Glitch in 0.23.
Attachments
bug_ver0.23.png
(502.91 KiB) Not downloaded yet
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 14 guests