JGR's Patch Pack

[SimYouLater]

Can someone help me figure out how to put my NewGRFs and save game from the PC version of this patch pack to the Android version?

[pelya]

Copy them to your SD card to Android/data/org.openttd.jgrpp/files/.openttd/save

[SimYouLater]

Copy them to your SD card to Android/data/org.openttd.jgrpp/files/.openttd/save

Found it. For some reason the Android/data/org.openttd.jgrpp folder wasn't showing up before. Also, my phone doesn't have external SD cards.

[SimYouLater]

I am not seeing town names. At all. Screenshot to demonstrate with new game and no GRFs.

[XaTriX]

Hi there

First of all, thanks JGR for the patch pack

Is that build known as desync-less for large MP game ? Hundreds of trains, few players, large map, new industries, ... ?

XaT

[SimYouLater]

Hi there

First of all, thanks JGR for the patch pack

Is that build known as desync-less for large MP game ? Hundreds of trains, few players, large map, new industries, ... ?

XaT

The screenshot isn't from a multiplayer game.

I first had the issue with a 16???x8??? map with many GRFs, however...

I tested it with, and provided that screenshot of, a brand new 64x64 map with no GRFs loaded. This is not a NewGRF issue, it's game-wide.

[JGR]

I am not seeing town names. At all. Screenshot to demonstrate with new game and no GRFs.

A config, savegame and any other info which you can supply would be helpful.
This is not an issue which has previously been observed.

Hi there

First of all, thanks JGR for the patch pack

Is that build known as desync-less for large MP game ? Hundreds of trains, few players, large map, new industries, ... ?

XaT

There are no known desync bugs at present.

[SimYouLater]

I am not seeing town names. At all. Screenshot to demonstrate with new game and no GRFs.

A config, savegame and any other info which you can supply would be helpful.
This is not an issue which has previously been observed.

Hi there

First of all, thanks JGR for the patch pack

Is that build known as desync-less for large MP game ? Hundreds of trains, few players, large map, new industries, ... ?

XaT

There are no known desync bugs at present.

(Removed due to passwords inside)

Will be uploading a zip of my entire OpenTTD folder if needed.

[ST2]

just a hint/sidenote @SimYouLater:

maybe you'll want to hide "server_password", "rcon_password" and "admin_password" next time(s) when sharing cfg files ^^

[SimYouLater]

just a hint/sidenote @SimYouLater:

maybe you'll want to hide "server_password", "rcon_password" and "admin_password" next time(s) when sharing cfg files ^^

Ah, I guess I'll want new passwords. Good thing I only used those passwords with OpenTTD.

[SimYouLater]

How would I post a copy of my install? It's too large for the forums.

[ST2]

Ah, I guess I'll want new passwords. Good thing I only used those passwords with OpenTTD.

A bit talking on the side, because never tested JGR's Patch Pack outside SP mode, but I think most important is: version and settings used (without PW's this time ^^).

One of the common errors that I've seen, or lets calling it "not used to", is trying to run several and/or modified instances of OpenTTD without taking care of where the "openttd.cfg" file is.
And JGR's Patch Pack, when unzipped and run, will load the "openttd.cfg" file of a Vanilla version, if installed. And vice-versa.

So, my suggestion is: place "openttd.cfg" on the same folder as the executable openttd file (even if empty, openttd will build it), and this way you can run different instances, versions, or with different settings. Whatever comes to your mind ^^

[Chico008]

Hi

Don't know if it has been asked yet, but i have a problem compiling

i'm using the r27935 from svn, then apply the diff file
configure and make or OK, but when i launch a dedicated server, i can't connect using the client provided on first page

There is a version mismatch
dedicated server got version : jgrpp-0.22.1-M-
win32/64 clients are : jgrpp-0.22.1

How can i compile to get the same versions on the dedicated serveur ?

[Chico008]

Answering to myself

had to modify the findversion.sh like this (but launch it manually once before in case, and make sure you have the .ottdrev-vc file

Code: Select all

elif [ -f "$ROOT_DIR/.ottdrev-vc" ]; then
        VERSION_DATA="`cat "$ROOT_DIR/.ottdrev-vc" | sed -n -e '1 p;'`"
        HASH_DATA="`cat "$ROOT_DIR/.ottdrev-vc" | sed -n -e '2 p;'`"
        REV="`echo "$VERSION_DATA" | cut -f 1 -d'       '`"
        REV_NR="`echo "$VERSION_DATA" | cut -f 2 -d'    '`"
        MODIFIED="`echo "$VERSION_DATA" | cut -f 3 -d'  '`"
        CLEAN_REV="`echo "$VERSION_DATA" | cut -f 4 -d' '`"
#        if [ "$MODIFIED" = "2" ]; then
#                CLEAN_REV="`echo "$CLEAN_REV" | sed -e 's/M$//'`"
#        fi
#        BRANCH="`echo "$REV" | sed -n -e "s|^${CLEAN_REV}M\?-\(.\+\)$|\1|p"`"
#        REV="$CLEAN_REV"
#        if ! $ROOT_DIR/version_utils.sh -o; then
#                MODIFIED="1"
#        else
#                CURRENT_HASH="`$ROOT_DIR/version_utils.sh -s`"
#                if [ "$CURRENT_HASH" != "$HASH_DATA" ]; then
#                        MODIFIED="2"
#                        if [ -n "$BRANCH" ]; then
#                                BRANCH="$BRANCH-"
#                        fi
 #                       BRANCH="${BRANCH}H`echo "$CURRENT_HASH" | cut -c 1-8`"
#                fi
#        fi
 

[SimYouLater]

Ah, I guess I'll want new passwords. Good thing I only used those passwords with OpenTTD.

A bit talking on the side, because never tested JGR's Patch Pack outside SP mode, but I think most important is: version and settings used (without PW's this time ^^).

One of the common errors that I've seen, or lets calling it "not used to", is trying to run several and/or modified instances of OpenTTD without taking care of where the "openttd.cfg" file is.
And JGR's Patch Pack, when unzipped and run, will load the "openttd.cfg" file of a Vanilla version, if installed. And vice-versa.

So, my suggestion is: place "openttd.cfg" on the same folder as the executable openttd file (even if empty, openttd will build it), and this way you can run different instances, versions, or with different settings. Whatever comes to your mind ^^

I don't have a copy of vanilla OpenTTD on my computer. I even removed other copies of JGR when I noticed there were some, no dice. I'll try redoing the install and see if that works.

EDIT
It looks like the cfg file went bad somehow. I had to start over with a fresh one, fortunately my NewGRF settings weren't the problem. Thank you!

[Wahazar]

I noticed, that "velocity reduced until depot visited" improved patch breakdown occurs in case of trains, but not in case of road vehicles (not tested ships and airplanes yet).
Is it a bug or feature? In my opinion, it is rather unwanted feature, together with repair payment, road vehicles have now a big advantage over trains - no need to send truck/buses to depot and pay for breakdowns.

[JGR]

Hi

Don't know if it has been asked yet, but i have a problem compiling

i'm using the r27935 from svn, then apply the diff file
configure and make or OK, but when i launch a dedicated server, i can't connect using the client provided on first page

There is a version mismatch
dedicated server got version : jgrpp-0.22.1-M-
win32/64 clients are : jgrpp-0.22.1

How can i compile to get the same versions on the dedicated serveur ?

This suggests that the patched source is not identical to that of the release, probably because one or more source files have have been manually edited in some way.
In general patching the version detection script is not a good solution as the whole point of the modification check is to avoid the multi-player desync issues which can occur when a modified build is incorrectly labelled as an unmodified release build, and is subsequently used with unmodified release builds.

I noticed, that "velocity reduced until depot visited" improved patch breakdown occurs in case of trains, but not in case of road vehicles (not tested ships and airplanes yet).
Is it a bug or feature? In my opinion, it is rather unwanted feature, together with repair payment, road vehicles have now a big advantage over trains - no need to send truck/buses to depot and pay for breakdowns.

The code suggests that this is intended.
Trains already have so many advantages over road vehicles that this does not seem to be a significant issue.

[Wahazar]

The code suggests that this is intended.
Trains already have so many advantages over road vehicles that this does not seem to be a significant issue.

Maybe this setting was justified in case of standalone breakdown patch, but in case of this patch pack,
with both patches: improved breakdown and repair payment are active - players can cheat by avoiding using depots, because there is no penalty for lack of service.

On the other hand, these permanent speed limits can be annoying, if there is 1 mph limit and you need t wait eons until train will reach depot. It was already pointed out in Improved Breakdown Patch thread.
Minimal velocity should be clamped by let say 10 mph.

[Auge]

Hello

… in case of this patch pack, with both patches: improved breakdown and repair payment are active - players can cheat by avoiding using depots [for road vehicles], because there is no penalty for lack of service.

On the other hand, these permanent speed limits can be annoying, if there is 1 mph limit and you need t wait eons until train will reach depot. It was already pointed out in Improved Breakdown Patch thread.
Minimal velocity should be clamped by let say 10 mph.

Did you ever found a speed limit of 1mph for a broken rail vehicle? I can't remember an experience of a speed limit lower than 40 km/h (kph) for a broken rail vehicle. I play the patchpack at least since two years (first documented translation for version 0.7.1 (2015-11-01) in the changelog of the opening posting).

So IMHO there is no reason to hyperventilate.

Tschö, Auge

[Wahazar]

Hello
Did you ever found a speed limit of 1mph for a broken rail vehicle?

Of course, I bought bankrupt company and got engine with 255 failures and 1mph speed limit. Additionally, the cost of the depot was above million GPB, so I was breathing heavily