JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7239
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

JGR wrote: Best be more careful with the SPAD button next time :P
Good job i'm not a real signaller, huh? I was restructuring an area, and during its wait at a red it had clearly reversed but then got stuck again, so when I ordered the SPAD it was facing the wrong direction and... oops. :x
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
nigelb7
Engineer
Engineer
Posts: 5
Joined: 17 Dec 2016 00:56
Location: Herndon, Va, USA

Re: JGR's Patch Pack

Post by nigelb7 »

I keep getting the message "Train xx is getting old and urgently needs replacing" but the message box has no graphic and the train number is not in the list of trains. For trains that do exist, the graphic appears and I can click on the train and find it. The "ghost train may have been one that crashed earlier in the game but I am not 100% certain on that. I am using the current version of the JGR patch.

Any help will be gratly appreciated.

Cheers,
Nigel
Last edited by nigelb7 on 18 Dec 2016 10:26, edited 1 time in total.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

nigelb7 wrote:I keep getting the message "Train xx is getting old and urgently needs replacing" but the message box has no graphic and the train number is not in the list of trains. For trains that do exist, the graphic appears and I can click on the train and find it. The "ghost train may have been one that crashed earlier in the game but I am not 100$ certain on that. I am using the current version of the JGR patch.

Any help will be gratly appreciated.

Cheers,
Nigel
Could you post a savegame which shows the issue, this should make it much easier to see what is happening, thanks.
Ex TTDPatch Coder
Patch Pack, Github
nigelb7
Engineer
Engineer
Posts: 5
Joined: 17 Dec 2016 00:56
Location: Herndon, Va, USA

Re: JGR's Patch Pack

Post by nigelb7 »

Thanks for your prompt response. I have a attached a saved game as requested. It uses a lot of British graphics (expat, living in the Colonies). Let me know if you have any questions, and if you need some of the missing numbers I can log them next time they appear.
Again, thanks for your help
Attachments
Tri-Star Transport, 14th Aug 1927.sav
File for "Ghost "Trains. May have to run for up to a year for the message to appear.
(605.37 KiB) Downloaded 88 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

nigelb7 wrote:Thanks for your prompt response. I have a attached a saved game as requested. It uses a lot of British graphics (expat, living in the Colonies). Let me know if you have any questions, and if you need some of the missing numbers I can log them next time they appear.
Again, thanks for your help
This is to do with virtual vehicles which are used as part of the template replacement patch, this should be fixed in the next release.
Thanks for letting me know about this bug.
Ex TTDPatch Coder
Patch Pack, Github
nigelb7
Engineer
Engineer
Posts: 5
Joined: 17 Dec 2016 00:56
Location: Herndon, Va, USA

Re: JGR's Patch Pack

Post by nigelb7 »

Thank you again. I did use the template replacement feature a few times so I think you have found the bug. Terrific patch anyway.

Cheers,
Nigel
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Redirect Left wrote:I've found a little glitch with signals on bridges.
If there is a crash on a bridge, the red signals will not clear after the train has been removed. You can force them back to green by ordering a train to ignore signals and power through the reds, after that has cleared it, the signals go back to green as normal and remaining in working order afterwards.

the two differing lines indicate the (approximate) location of the two trains. They collided head on, on the bridge after a bad SPAD order, human error, woo!. Arrows indicate the direction of each train.

Note the signal color on the bridge in the first image compared to the latter, after a train had SPAD'd its way across and then reset signals.
I've implemented a fix for this which will be in the next release, thanks for letting me know about it.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7239
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

No problem, glad I managed to help in my own tiny way p

Woo, usefulness! :mrgreen:
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
User avatar
3iff
Tycoon
Tycoon
Posts: 1093
Joined: 21 Oct 2005 09:26
Location: Birmingham, England

Re: JGR's Patch Pack

Post by 3iff »

JGR 0.16.0

A bug.

When instructing a vehicle to "go to nearest depot" and STOP, then the vehicle doesn't stop.
When instructing a vehicle to "go to a specific depot" and STOP, then the vehicle stops as expected.

It's a change from earlier versions (and expected behaviour) so I'm assuming it's a bug not a feature.
It seems to happen with all vehicle types.

Hopefully it's not a new setting I've overlooked.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

3iff wrote:JGR 0.16.0

A bug.

When instructing a vehicle to "go to nearest depot" and STOP, then the vehicle doesn't stop.
When instructing a vehicle to "go to a specific depot" and STOP, then the vehicle stops as expected.

It's a change from earlier versions (and expected behaviour) so I'm assuming it's a bug not a feature.
It seems to happen with all vehicle types.

Hopefully it's not a new setting I've overlooked.
I can't reproduce or see anything obviously wrong with "go to nearest depot" orders.
Have you got a savegame which exhibits the issue?
Ex TTDPatch Coder
Patch Pack, Github
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: JGR's Patch Pack

Post by ISA »

Hello! JGR is it possible that language changing will crash the game?
My friend complained me that after installing latest nightly and then adding Your patch the game crashed when using Estonian language. After changing it to English everything worked fine.

One more thing what he pointed out was that he was clicking on latest FIRS 2.0 industrie when the crash occurs and maybe the problem is somewhere else. As I cant get back to his PC I cant be more specific yet... I can maybe after Christmas

Ill add crash report what I mange to get from him

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Fri Dec 23 14:48:01 2016
In game date: 2000-01-01 (8, 23)

Crash reason:
 Exception: E1212012
 Location:  000007FEFC04A06D
 Message:   Assertion failed at line 75 of /home/jgr/openttd/cross-win64/src/fontcache.cpp: IsPrintable(key)

OpenTTD version:
 Version:    jgrpp-0.16.0 (0)
 NewGRF ver: 17006c20
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Nov 26 2016 22:59:39
 Configure:  ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
 00000016 00000000 00000000 00000000 00000008 00000000 771C9AA6 00000000
 E1212012 00000000 00000000 00000000 FC04A06D 000007FE 00000000 000007FE
 DA5C6FC0 0000000E 77221332 00000000 00012010 00000000 00000130 000007FE
 0022BFA9 00000000 0000002C 00000000 00000001 00000000 00000000 00000000
 00000000 00000000 772E0A7A 00000000 00012010 00000000 EDA5C6FC 00000000
 0022BCE8 00000000 0000002C 00000000 00000000 00000000 FC2A05E9 000007FE
 00000001 00000000 FC2C1925 000007FE 00000016 00000000 EDA5C6FC 00000000
 00000000 00000000 2E425E50 00000000 DF63E7C0 0000000E 772D80AA 00000000
 FC316180 000007FE 00000314 00000000 029A8EF0 00000000 00000001 00000000
 328B11D0 00000000 31EA2140 00000000 00000000 00000000 FC2C53AA 000007FE
 00000001 00000000 0022C340 00000000 2E425E50 00000000 00000000 00000000
 00366290 00000000 002D0230 00000000 00000000 00000000 00000000 00000000
 77323204 00000000 00000001 00000000 0022BDE8 00000000 E00000E0 00000003
 771BCB3A 00000000 771C9079 00000000 02E96FF8 00000000 0022BE18 00000000
 00000000 00000000 92000193 00000000 00000082 00000000 00000000 00000000
 00000000 00000000 772D2D84 00000000 772EC910 00000000 771D506C 00000000
 000B15E6 00000000 02000002 00000000 00000001 00000000 00000001 00000000
 00000001 00000000 E00000E0 00000000 00431674 00000000 00000202 00000000
 00000000 00000000 000B001F 00000000 00000032 00000000 00000259 00000000
 00000000 00000000 00000000 00000000 771B0000 00000000 00360870 00000000
 00000000 00000000 771D4EC1 00000000 000B15E6 00000000 77223428 00000000
 00000001 00000000 000B15E6 00000000 00000000 00000000 00000000 00000000
 00000001 00000000 00000010 00000000 00010003 00000000 00000001 00000000
 00360870 00000000 77222989 00000000 002D0000 00000000 FFFFFF01 FFFFFFFF

Registers:
 RAX: 0000000077F6C45C RBX: 0000000000000016 RCX: 000000000022B610 RDX: 0000000000000000
 RSI: 0000000000000000 RDI: 0000000000000008 RBP: 0000000000000000 RSP: 000000000022BC20
 R8:  0000000000000000 R9:  0000000000000000 R10: 0000000000000000 R11: 0000000000000206
 R12: 000007FEFC311130 R13: 000000000053F880 R14: 0000000000000001 R15: 0000000000000314
 RIP: 000007FEFC04A06D EFLAGS: 00000206

 Bytes at instruction pointer:
 48 81 C4 C8 00 00 00 C3 90 90 90 90 90 90 90 90 90 90 90 48 83 EC 28 65

Operating system:
 Name:     Windows
 Release:  6.1.7601 (Service Pack 1)
 Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (5588)
 Language:     E:\Peli\OpenTdd\lang\estonian.lng
 Music driver: win32
 Music set:    OpenMSX (96)
 Network:      no
 Sound driver: win32
 Sound set:    NoSound (2)
 Video driver: win32

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 0):
  0: Human

Libraries:
 FreeType:   2.6.0
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
 E:\Peli\OpenTdd\openttd.exe handle: 0000000000400000 size: 37757289 crc: C5F3B5F5 date: 2016-11-26 21:00:28
 C:\Windows\SYSTEM32\ntdll.dll handle: 00000000772b0000 size: 1732864 crc: 77D9DAE7 date: 2016-10-11 15:34:46
 C:\Program Files (x86)\AVG\Av\avghooka.dll handle: 000007feefdc0000 size: 353816 crc: E950C5E4 date: 2016-11-02 06:06:08
 C:\Windows\system32\kernel32.dll handle: 0000000077090000 size: 1163264 crc: C563B3C2 date: 2016-10-11 15:31:56
 C:\Windows\system32\KERNELBASE.dll handle: 000007fefc030000 size: 419840 crc: 8FB09551 date: 2016-10-11 15:31:56
 C:\Windows\system32\ADVAPI32.dll handle: 000007fefc320000 size: 880640 crc: 25260815 date: 2016-10-11 15:31:50
 C:\Windows\system32\msvcrt.dll handle: 000007fefc280000 size: 634880 crc: 9D1B448A date: 2012-09-14 00:20:57
 C:\Windows\SYSTEM32\sechost.dll handle: 000007fefdc80000 size: 113664 crc: 98A6ADF4 date: 2015-05-25 18:19:09
 C:\Windows\system32\RPCRT4.dll handle: 000007fefd720000 size: 1212928 crc: 3FDEE124 date: 2016-10-11 15:32:03
 C:\Windows\system32\GDI32.dll handle: 000007fefdc10000 size: 405504 crc: 3CDE120A date: 2016-05-18 16:09:22
 C:\Windows\system32\USER32.dll handle: 00000000771b0000 size: 1009152 crc: 17D5D526 date: 2016-08-16 17:36:50
 C:\Windows\system32\LPK.dll handle: 000007fefdcf0000 size: 41472 crc: CB92CDA3 date: 2016-11-02 15:32:08
 C:\Windows\system32\USP10.dll handle: 000007fefdb40000 size: 802304 crc: 3DC2D6D4 date: 2015-11-03 19:04:51
 C:\Windows\system32\IMM32.dll handle: 000007fefc400000 size: 167424 crc: 41B2805A date: 2009-07-14 01:41:09
 C:\Windows\system32\MSCTF.dll handle: 000007fefc430000 size: 1068544 crc: A62D43D0 date: 2016-10-11 15:31:58
 C:\Windows\system32\SHELL32.dll handle: 000007fefc870000 size: 14183424 crc: 8A311E9F date: 2016-08-29 15:31:19
 C:\Windows\system32\SHLWAPI.dll handle: 000007fefd9e0000 size: 448512 crc: 086DF743 date: 2010-11-21 03:24:22
 C:\Windows\system32\WINMM.dll handle: 000007fef75d0000 size: 217600 crc: 7BC1529F date: 2009-07-14 01:41:56
 C:\Windows\system32\WS2_32.dll handle: 000007fefdca0000 size: 296448 crc: EE1BC529 date: 2016-05-11 17:02:50
 C:\Windows\system32\NSI.dll handle: 000007fefe2b0000 size: 13824 crc: 53B46F6C date: 2009-07-14 01:41:53
 C:\Windows\system32\ole32.dll handle: 000007fefc660000 size: 2084864 crc: A92D057C date: 2016-03-17 22:56:24
 C:\Windows\system32\uxtheme.dll handle: 000007fefa690000 size: 332288 crc: B0A13DF9 date: 2009-07-14 01:41:56
 C:\Windows\system32\dwmapi.dll handle: 000007fefad60000 size: 82944 crc: F979E48B date: 2015-07-09 17:58:26
 C:\Windows\system32\CRYPTBASE.dll handle: 000007fefbb80000 size: 43520 crc: 068FA47E date: 2016-10-11 15:31:52
 C:\Windows\system32\mswsock.dll handle: 000007fefb4c0000 size: 327168 crc: 2E4865A8 date: 2016-05-11 17:02:42
 C:\Windows\System32\wshtcpip.dll handle: 000007fefaea0000 size: 13312 crc: 5D1E2C55 date: 2009-07-14 01:41:58
 C:\Windows\system32\MMDevAPI.DLL handle: 000007fefa280000 size: 284160 crc: CDF2EF81 date: 2009-07-14 01:41:26
 C:\Windows\system32\PROPSYS.dll handle: 000007fefa6f0000 size: 1212416 crc: B83FA3BE date: 2010-11-21 03:23:55
 C:\Windows\system32\OLEAUT32.dll handle: 000007fefda60000 size: 877056 crc: 25D02DB3 date: 2016-10-07 15:32:31
 C:\Windows\system32\wdmaud.drv handle: 000007fef5040000 size: 217088 crc: 12829973 date: 2010-11-21 03:24:32
 C:\Windows\system32\ksuser.dll handle: 0000000072160000 size: 5120 crc: 781141DD date: 2015-12-08 19:07:31
 C:\Windows\system32\AVRT.dll handle: 000007fef9b90000 size: 18432 crc: 5CE53CB7 date: 2009-07-14 01:40:05
 C:\Windows\system32\SETUPAPI.dll handle: 000007fefc0a0000 size: 1900544 crc: A364BD6A date: 2010-11-21 03:24:28
 C:\Windows\system32\CFGMGR32.dll handle: 000007fefbd20000 size: 207872 crc: 1984C339 date: 2010-11-21 03:24:00
 C:\Windows\system32\DEVOBJ.dll handle: 000007fefbee0000 size: 93184 crc: A7541AE2 date: 2009-07-14 01:40:28
 C:\Windows\system32\AUDIOSES.DLL handle: 000007fef4dd0000 size: 295936 crc: 4E4A3055 date: 2016-06-14 17:16:23
 C:\Windows\system32\msacm32.drv handle: 000007fef4c10000 size: 25600 crc: 2B579A05 date: 2009-07-14 01:38:50
 C:\Windows\system32\MSACM32.dll handle: 000007fef49f0000 size: 83456 crc: 3D67538B date: 2009-07-14 01:41:27
 C:\Windows\system32\midimap.dll handle: 000007fef49d0000 size: 20480 crc: CB902A13 date: 2009-07-14 01:41:23
 C:\Windows\system32\CLBCatQ.DLL handle: 000007fefc540000 size: 607744 crc: 939E35C9 date: 2009-07-14 01:40:15
 C:\Windows\system32\psapi.dll handle: 0000000077470000 size: 9216 crc: 84B5E9BA date: 2009-07-14 01:41:53

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.16.0, savegame version 195, not modified, _openttd_newgrf_version = 0x17006c20
New game mode: 1 landscape: 0
Added NewGRF: GRF ID F1250006, checksum 05978AF75D1A1ACC8D8FBEE2BC5061C9, filename: firs_2-2.1.5\firs.grf (md5sum matches)
Added NewGRF: GRF ID 544D0101, checksum 390EA6B640721D3A80200F2A1474B183, filename: 2cc_trainsinnml-2.0alpha1\2ccts.grf (md5sum matches)
Added NewGRF: GRF ID 474B0000, checksum 0465E1F8C4513D80CC9119F15B153910, filename: estonian_town_names-1.0.01\estonian_town_names.grf (md5sum matches)
Added NewGRF: GRF ID 52571203, checksum 7CE88A25DDB058C1BE577B88D049B274, filename: egrvts2-188\egrvts2.grf (md5sum matches)
Added NewGRF: GRF ID 4A530117, checksum CA32127C974FD70434F9CA4E0AD4A501, filename: ecs__firs_vehicle_set-2014.11.26\efrefit.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 0DA3A80B986BC3C17C20CA4CE9CA26AA, filename: fish_2-2.0.3\fish.grf (md5sum matches)
Added NewGRF: GRF ID 57A50001, checksum 318F3C3F17CA68EAD533BAC88B093094, filename: was_world_airliners_set-0.1\was.grf (md5sum matches)
Added NewGRF: GRF ID 42533036, checksum CE427F6E64E3C30544097207B34887BA, filename: brianum_x2014__millennium_z-1.0.1\brianum_x2014_z2.grf (md5sum matches)
Added NewGRF: GRF ID 42530102, checksum 8E89C313DA6149520F6AD09A56CEEFBC, filename: brianum_br_611-1.0\br611.grf (md5sum matches)
Added NewGRF: GRF ID 42530103, checksum FD2367199187888F80E358FE06723AFB, filename: brianum_br_628-1.0\br628.grf (md5sum matches)
Added NewGRF: GRF ID 42530101, checksum 13FFF2D7F704C544E3638AA6DB1C03FF, filename: brianum_br_641_alstom_coradia_-1.0\br641.grf (md5sum matches)
Added NewGRF: GRF ID 42533032, checksum F9E16508E98197A5404A7A22F28E13E5, filename: brianum_sh_50__sh_60-1.0.1\brianum_sh50.grf (md5sum matches)
Added NewGRF: GRF ID 42533031, checksum A6CF807078DE75D0209D53BE8BA6FDEC, filename: brianum_speed_limit_for_bridges-1.0\brianum_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 42533033, checksum E982D0EBB8FBEFD41CF1547EBF55F50F, filename: brianum_vacuummonorail_tube-1.0\brianum_vactrain_railtype.grf (md5sum matches)
Added NewGRF: GRF ID 42533034, checksum C46D3FE505219D3CD946FDE7FD33164C, filename: brianum_vakuummonorail_trains-1.02\brianum_vactrain_vehicles.grf (md5sum matches)
Added NewGRF: GRF ID 52577801, checksum 20B5D8122F2B4AD74ADDA30E44BA8233, filename: opengfx_biggui-2.0.0\ogfx-biggui.grf (md5sum matches)
Added NewGRF: GRF ID 46727806, checksum BBE029FCDD7A16F85876D417FF318D23, filename: opengfx_trees-0.8.0\opengfx+trees.grf (md5sum matches)
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2\ogfx-airports.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B33, checksum 437E4F6BDA52EB5CA9615196291514CA, filename: opengfx_industries-version\ogfx-industries.grf (md5sum matches)
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x000007FEFC04A06D RaiseException + 61
[01] msvcrt               0x000007FEFC2C1925 raise + 565
[02] msvcrt               0x000007FEFC2C53AA abort + 46
[03] openttd              0x000000000053049F error(char const*, ...) + 95 (/home/jgr/openttd/cross-win64/src/openttd.cpp:130)
[04] openttd              0x0000000000835271 SpriteFontCache::MapCharToGlyph(unsigned int) + 65 (/home/jgr/openttd/cross-win64/src/fontcache.cpp:75)
[05] openttd              0x00000000004B133E FallbackParagraphLayout::FallbackVisualRun::FallbackVisualRun(Font*, unsigned int const*, int, int) + 254 (/home/jgr/openttd/cross-win64/src/gfx_layout.cpp:302)
[06] openttd              0x00000000004B173C FallbackParagraphLayout::NextLine(int) + 828 (/home/jgr/openttd/cross-win64/src/gfx_layout.cpp:534)
[07] openttd              0x00000000004B22E3 Layouter::Layouter(char const*, int, TextColour, FontSize) + 259 (/home/jgr/openttd/cross-win64/src/gfx_layout.cpp:680)
[08] openttd              0x00000000004B0681 DrawStringMultiLine(int, int, int, int, char const*, TextColour, StringAlignment, bool, FontSize) + 113 (/home/jgr/openttd/cross-win64/src/gfx.cpp:629)
[09] openttd              0x00000000004B08DC DrawStringMultiLine(int, int, int, int, unsigned short, TextColour, StringAlignment, bool, FontSize) + 124 (/home/jgr/openttd/cross-win64/src/gfx.cpp:686)
[10] openttd              0x000000000085DA5A IndustryViewWindow::DrawInfo(unsigned int, unsigned int, unsigned int) + 1882 (/home/jgr/openttd/cross-win64/src/industry_gui.cpp:809)
[11] openttd              0x000000000085D2BC IndustryViewWindow::OnPaint() + 76 (/home/jgr/openttd/cross-win64/src/industry_gui.cpp:694)
[12] openttd              0x000000000067F43A DrawOverlappedWindowForAll(int, int, int, int) + 154 (/home/jgr/openttd/cross-win64/src/window.cpp:945)
[13] openttd              0x00000000004AE89F RedrawScreenRect(int, int, int, int) + 127 (/home/jgr/openttd/cross-win64/src/gfx.cpp:1300)
[14] openttd              0x00000000004AEA75 DrawDirtyBlocks() + 373 (/home/jgr/openttd/cross-win64/src/gfx.cpp:1392)
[15] openttd              0x00000000006814A3 UpdateWindows() + 243 (/home/jgr/openttd/cross-win64/src/window.cpp:3075)
[16] openttd              0x000000000065E548 VideoDriver_Win32::MainLoop() + 488 (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:1282)
[17] openttd              0x0000000000531E45 openttd_main(int, char**) + 5461 (/home/jgr/openttd/cross-win64/src/openttd.cpp:918)
[18] openttd              0x0000000000540D3F WinMain + 239 (/home/jgr/openttd/cross-win64/src/os/windows/win32.cpp:466)
[19] openttd              0x00000000004013ED __tmainCRTStartup + 573 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:332)
[20] openttd              0x00000000004014FB WinMainCRTStartup + 27 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:184)
[21] kernel32             0x00000000770A59CD BaseThreadInitThunk + 13
[22] ntdll                0x00000000772DA561 RtlUserThreadStart + 33

*** End of additional info ***
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

I want to report, that lines which describe vehicle route doesn't take into account latest station, when route is constructed.
(of course, if vehicle windows is closed and opened again, everything is OK, but during constructing, it is somewhat misleading, especially for ships/buoys).
Is it known bug?
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: JGR's Patch Pack

Post by ISA »

Hello!

Now I got a crash. While changeling plane color in the company window. I am aware that I don't have latest patch pack

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Mon Dec 26 05:19:02 2016
In game date: 2006-08-15 (46, 0)

Crash reason:
 Exception: E1212012
 Location:  767CC52F
 Message:   Assertion failed at line 65 of /home/jgr/openttd/cross-win32/src/object_cmd.cpp: IsTileType(t, MP_OBJECT)

Within context:
     0: DoCommandP: tile: 0x0, p1: 0x214, p2: 0x1, company: 0 (Drennington Transport), cmd: 0x2F (CmdSetCompanyColour), my_cmd: 1

OpenTTD version:
 Version:    jgrpp-0.14.0 (0)
 NewGRF ver: 17006be7
 Bits:       32
 Endian:     little
 Dedicated:  no
 Build date: Jul 27 2016 21:10:26
 Configure:  ./configure --host=i686-w64-mingw32 --prefix=/home/jgr/mingw32/ CFLAGS=-I/home/jgr/mingw32/include -D__MINGW64__ LDFLAGS=-L/home/jgr/mingw32/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw32/lib/liblzo2.a

Stack trace:
 E1212012 00000000 00000000 767CC52F 00000000 0028D0B0 76F2FDB9 007E1604
 74F764A8 74F203E0 00012010 00000000 FFFFFFFF 0028D0CC 76F2FDFE 007E1604
 773FFB8A 7741A37E FFFFFFFF 00000024 0028D138 0056F9B8 E1212012 00000000
 00000000 00000000 74F70290 0028D138 74F35E89 74F35E8F 00000016 B3273690
 28148008 2DDA6940 0028D488 773FFB8A 7741987C 00000000 00000024 0056F990
 00000001 0028D0F8 0028CAA4 0028DB34 74EF8CD5 C7FCB910 FFFFFFFE 0028D470
 74F38EA2 00000016 2DDA6940 0000002C 00000000 0100025C 00000000 00000160
 01010000 0028D098 76EFCF6C 0028DB34 77456325 073C9DAF FFFFFFFE 774130ED
 77412CE5 00000000 022AF730 00010003 00000000 0028D3A4 022AF728 0028D240
 76F2F840 02220000 00000000 022AF730 00000001 0028D3A4 00000001 0000001C
 0000000F 00000000 00FC23A0 00000010 007E1604 74EF8CD5 00000006 00000000
 00000000 00000780 00000410 00000000 00000161 0028D3A4 000002D9 00000000
 00007F01 00000000 00000001 0000002D 50022080 00000035 00000020 00000000
 00000000 000001CE 2B1CDEB0 022AF730 0260135C 00000000 022AF794 026013C8
 000001B1 0028D398 76F2FAE4 00000010 28148008 2DDA6940 76F2FB1C 00000001
 0028D2B0 09E90056 005E2E37 28DC7D18 00000000 02600E04 00000000 7FFFFFFF
 00C12891 00000000 00000000 76F2FB34 00000000 00000001 00000016 7FFFFFFF
 00000000 74F72BD0 02471580 74EDA53A 00000000 0028D2E0 74EEA8C1 02471C52
 00C12891 00000016 0028D2D0 7FFFFFFF 00000000 74F72BD0 02471580 0000000A
 00000000 00000006 00000006 02471C52 00C12891 00000016 0028D321 00000006
 00000000 0028D3DC 007FCA70 00000006 00000000 0000000A 00000000 02471C52
 00C12891 00003635 00000000 0028D348 00000030 00000017 007FC8B5 0028D344
 74EDA442 74F70090 0028D380 74EEA490 FFFFFFFF FFFFFFFF 0028D3DC 00000000
 00000000 0028D3DC 007FC21F 0028D354 00B77ED0 0028DB34 00B7802B 0028D6A8

Registers:
 EAX: 0028D07C EBX: 00000016 ECX: 00000000 EDX: 0008E3C8
 ESI: 74F73180 EDI: 00000000 EBP: 0028D0CC ESP: 0028D07C
 EIP: 767CC52F EFLAGS: 00000246

 Bytes at instruction pointer:
 C9 C2 10 00 CC CC CC CC CC 8B FF 55 8B EC 56 8B 75 08 83 FE F4 72 18 83

Operating system:
 Name:     Windows
 Release:  6.1.7601 (Service Pack 1)
 Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
 Blitter:      32bpp-sse2-anim
 Graphics set: OpenGFX (1002)
 Language:     F:\OpenTTDJGRPatchPack\lang\english_US.lng
 Music driver: win32
 Music set:    OpenMSX (96)
 Network:      no
 Sound driver: win32
 Sound set:    OpenSFX (87)
 Video driver: win32

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 0):
  0: Human

Libraries:
 FreeType:   2.6.0
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
 F:\OpenTTDJGRPatchPack\openttd.exe handle: 00400000 size: 30065563 crc: 0B283180 date: 2016-07-27 19:12:06
 C:\Windows\SysWOW64\ntdll.dll handle: 773e0000 size: 1314328 crc: 8C6BAA3F date: 2016-01-22 06:09:40
 C:\Windows\syswow64\kernel32.dll handle: 757a0000 size: 1114112 crc: 24BCAF6D date: 2016-01-22 06:06:50
 C:\Windows\syswow64\KERNELBASE.dll handle: 767c0000 size: 275456 crc: 506F630D date: 2016-01-22 06:06:50
 C:\Windows\syswow64\ADVAPI32.dll handle: 74d90000 size: 642560 crc: F6E0F780 date: 2016-01-22 05:59:06
 C:\Windows\syswow64\msvcrt.dll handle: 74ed0000 size: 690688 crc: DAB48B3A date: 2011-12-16 07:52:58
 C:\Windows\SysWOW64\sechost.dll handle: 74fd0000 size: 92160 crc: 80F53C42 date: 2015-05-25 18:01:39
 C:\Windows\syswow64\RPCRT4.dll handle: 753f0000 size: 665088 crc: E1377C01 date: 2016-01-22 06:06:50
 C:\Windows\syswow64\SspiCli.dll handle: 74d30000 size: 96768 crc: 6543E091 date: 2016-01-22 06:06:50
 C:\Windows\syswow64\CRYPTBASE.dll handle: 74d20000 size: 36352 crc: B616B931 date: 2016-01-22 04:51:55
 C:\Windows\syswow64\GDI32.dll handle: 76730000 size: 312320 crc: 1A426B7A date: 2015-12-08 21:52:53
 C:\Windows\syswow64\USER32.dll handle: 76ec0000 size: 833024 crc: F2B87461 date: 2015-11-10 18:37:39
 C:\Windows\syswow64\LPK.dll handle: 76b60000 size: 25600 crc: 3F8ADCEA date: 2015-09-02 02:47:18
 C:\Windows\syswow64\USP10.dll handle: 76e20000 size: 627712 crc: A1594BC1 date: 2015-11-03 18:56:18
 C:\Windows\syswow64\IMM32.DLL handle: 755c0000 size: 119808 crc: 38DB5163 date: 2010-11-21 03:24:25
 C:\Windows\syswow64\MSCTF.dll handle: 754e0000 size: 828928 crc: 9CA6751F date: 2015-01-17 02:30:42
 C:\Windows\syswow64\SHELL32.dll handle: 75ae0000 size: 12877824 crc: CAD6881B date: 2016-01-22 06:05:58
 C:\Windows\syswow64\SHLWAPI.dll handle: 75690000 size: 350208 crc: 23E05F73 date: 2010-11-21 03:23:48
 C:\Windows\system32\WINMM.DLL handle: 722f0000 size: 194048 crc: 849223C7 date: 2010-11-21 03:24:16
 C:\Windows\syswow64\WS2_32.dll handle: 76ba0000 size: 206848 crc: FD00A753 date: 2010-11-21 03:23:55
 C:\Windows\syswow64\NSI.dll handle: 773b0000 size: 8704 crc: 2ACE9671 date: 2009-07-14 01:16:11
 C:\Windows\syswow64\ole32.dll handle: 74ff0000 size: 1413632 crc: 6AF96159 date: 2016-01-16 18:36:37
 C:\Windows\system32\uxtheme.dll handle: 741c0000 size: 245760 crc: 60C5C746 date: 2009-07-14 01:11:24
 C:\Windows\system32\dwmapi.dll handle: 74150000 size: 67584 crc: 0A7DEB75 date: 2015-07-09 17:42:54
 C:\Windows\system32\mswsock.dll handle: 734e0000 size: 231424 crc: 2A2905A9 date: 2013-09-08 02:03:58
 C:\Windows\System32\wshtcpip.dll handle: 73420000 size: 9216 crc: BA963A19 date: 2009-07-14 01:16:20
 C:\Windows\system32\MMDevAPI.DLL handle: 722b0000 size: 213504 crc: 93C0AA4F date: 2010-11-21 03:23:51
 C:\Windows\system32\PROPSYS.dll handle: 73e80000 size: 988160 crc: 888D0BCB date: 2010-11-21 03:24:08
 C:\Windows\syswow64\OLEAUT32.dll handle: 756f0000 size: 571904 crc: 0EB7703D date: 2014-11-26 03:32:05
 C:\Windows\system32\wdmaud.drv handle: 721b0000 size: 172032 crc: D5B9F5FA date: 2010-11-21 03:24:00
 C:\Windows\system32\ksuser.dll handle: 5bd30000 size: 4608 crc: 1A5CD26B date: 2015-12-08 21:53:47
 C:\Windows\system32\AVRT.dll handle: 5bd40000 size: 14336 crc: 9818237B date: 2009-07-14 01:14:58
 C:\Windows\syswow64\SETUPAPI.dll handle: 75240000 size: 1667584 crc: 1D0104E8 date: 2010-11-21 03:23:51
 C:\Windows\syswow64\CFGMGR32.dll handle: 75180000 size: 145920 crc: 377B5190 date: 2011-05-24 10:39:38
 C:\Windows\syswow64\DEVOBJ.dll handle: 76fc0000 size: 64512 crc: 66B02A5A date: 2011-05-24 10:40:05
 C:\Windows\system32\AUDIOSES.DLL handle: 5eeb0000 size: 195584 crc: 4831E850 date: 2015-02-03 03:12:12
 C:\Windows\system32\msacm32.drv handle: 72c10000 size: 20992 crc: 73923147 date: 2009-07-14 01:14:08
 C:\Windows\system32\MSACM32.dll handle: 72c20000 size: 72192 crc: ABA25814 date: 2009-07-14 01:15:42
 C:\Windows\system32\midimap.dll handle: 72c00000 size: 16896 crc: C000494C date: 2009-07-14 01:15:40
 C:\Windows\syswow64\CLBCatQ.DLL handle: 74e40000 size: 522240 crc: 6C130B8A date: 2009-07-14 01:15:03
 C:\Windows\WinSxS\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.7601.18837_none_41e855142bd5705d\comctl32.dll handle: 73f80000 size: 1680896 crc: DF0F2F2B date: 2015-04-24 17:54:13
 C:\Windows\system32\ntmarta.dll handle: 73e50000 size: 121856 crc: EE55B9FC date: 2009-07-14 01:16:11
 C:\Windows\syswow64\WLDAP32.dll handle: 76940000 size: 269824 crc: 88472362 date: 2010-11-21 03:24:16
 C:\Windows\system32\CRYPTSP.dll handle: 74240000 size: 81408 crc: 404D9076 date: 2015-02-03 03:12:14
 C:\Windows\system32\rsaenh.dll handle: 74180000 size: 242936 crc: 1C7C0295 date: 2009-07-14 01:17:54
 C:\Windows\system32\RpcRtRemote.dll handle: 74170000 size: 46080 crc: 375FC97F date: 2010-11-21 03:24:14
 C:\Windows\system32\mssprxy.dll handle: 70d30000 size: 35328 crc: F549BB70 date: 2009-07-14 01:15:48
 C:\Windows\syswow64\psapi.dll handle: 74fb0000 size: 6144 crc: 25B988F9 date: 2009-07-14 01:16:12

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.14.0, savegame version 195, not modified, _openttd_newgrf_version = 0x17006be7
New game mode: 1 landscape: 1
Added NewGRF: GRF ID 4D4C0100, checksum 1E2A243600434194FB100E72E507D5EF, filename: dutchcatw.grf (md5sum matches)
Added NewGRF: GRF ID 47471401, checksum E1E56E8BEF19B02367795CB5EE82A737, filename: AuzBridges.grf (md5sum matches)
Added NewGRF: GRF ID 49464E4F, checksum BAC22546C151037276AA7775F17AB3A9, filename: SNO-Supercheese'sNewObjects.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum 4A83C54311B83BF4F91F9A94D94DBEFB, filename: ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 504A0105, checksum CE85335D194874E2743ED938E2C825C1, filename: ISRoverlap.grf (md5sum matches)
Added NewGRF: GRF ID 504A0106, checksum 45F465A20FB7A43EFA2E6D4E1A70A42B, filename: ISR_objects_v1_4.grf (md5sum matches)
Added NewGRF: GRF ID 42010000, checksum 6FE46BEACFA8B4191B9F8FEAEFBE819F, filename: gersignw.grf (md5sum matches)
Added NewGRF: GRF ID 53430101, checksum B62CFBA0EBF356B0E27ECCA89366464C, filename: sacsobjects1w.grf (md5sum matches)
Added NewGRF: GRF ID 6D620C00, checksum E1DB74D22EF54328944DC767C4F8594F, filename: marico.grf (md5sum matches)
Added NewGRF: GRF ID 504A4641, checksum 457DE3A141B99D6BE258981C993B6761, filename: fakeairportobjects_v0_1.grf (md5sum matches)
Added NewGRF: GRF ID 415A0301, checksum 8667797182D6F6C670D7BE5D677ACB45, filename: americanroads.grf (md5sum matches)
Added NewGRF: GRF ID 414B4108, checksum 10D8E23F2A5AAAA15E28FF61DE96C694, filename: xussr.grf (md5sum matches)
Added NewGRF: GRF ID 56430001, checksum 2B67D5836DDFE0E2CC2454E1540A85F2, filename: ttrs3w.grf (md5sum matches)
Added NewGRF: GRF ID 54470203, checksum F84B6D37659F23D19E176C99BC48DEF6, filename: airportobjects.grf (md5sum matches)
Added NewGRF: GRF ID F1250006, checksum F089738B67BF5AF1604CC2209E88B6C6, filename: firs.grf (md5sum matches)
Added NewGRF: GRF ID 6D620601, checksum 537A2B9E5F0644BC360248B2B802D086, filename: newstats.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 4D50003F, checksum 1DE407E8A75704008414044459D18E16, filename: ISRfencew.grf (md5sum matches)
Added NewGRF: GRF ID 4D50006A, checksum 75A9885D1A6494759243A60B434E9552, filename: iorestat.grf (md5sum matches)
Added NewGRF: GRF ID 44450004, checksum D173807A8A9A8A591552C3BC35E9FBEB, filename: mlss052.grf (md5sum matches)
Added NewGRF: GRF ID 44440502, checksum 9B2267C916691C45A2C85BE1FF54F7C3, filename: ussigzw.grf (md5sum matches)
Added NewGRF: GRF ID 415A0501, checksum 37F4A01391FE088BD22740A89E22F78B, filename: total_bridges_arrs.grf (md5sum matches)
Added NewGRF: GRF ID 415A0701, checksum AFFD2D15EA23F8A95A50EA5FDFC4D84E, filename: arrs_objects.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 44573452, checksum 48CF5FC0DEB895136F337A7E563FC66D, filename: dwe_stat_r.grf (md5sum matches)
Added NewGRF: GRF ID 44550001, checksum 57CFF33C80D650C6317D31DCC45483C9, filename: germanrvw.grf (md5sum matches)
Added NewGRF: GRF ID 9787EAFE, checksum 80E5007027E7146DBA189128066E60F2, filename: road-hog.grf (matches GRFID only)
Added NewGRF: GRF ID 41501202, checksum B13DD8FB0D7C34CACAC2FE68BD137BB9, filename: heqs.grf (md5sum matches)
Added NewGRF: GRF ID 48530002, checksum A5706340BE84D3B9D621609AEFB1A4D4, filename: HTS.grf (md5sum matches)
Added NewGRF: GRF ID 52571208, checksum DC83DAB2933FACCB91678D4F75ABCCC6, filename: cars.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0102, checksum B8D83E093D8BDB400B1CD0555E747C33, filename: dutchtramset.grf (md5sum matches)
Added NewGRF: GRF ID 49464556, checksum F1F4F773E4A978A242EC74AEACCBAAC0, filename: eyecandyroadvehicles.grf (md5sum matches)
Added NewGRF: GRF ID 4946424C, checksum 277B92187F074918F46CE65FD6D440EC, filename: hotairballoon.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 2ADD4E518A1AD4C0CB82CC30623B2CFF, filename: fish.grf (matches GRFID only)
Added NewGRF: GRF ID 6D620004, checksum 70649F1AFC954942173B0AA89C1E8B14, filename: newshipsw.grf (md5sum matches)
Added NewGRF: GRF ID 415A0101, checksum 9BFBC924B18D42D7F564E7CD6237981D, filename: wsfferryset.grf (md5sum matches)
Added NewGRF: GRF ID 57A50001, checksum 318F3C3F17CA68EAD533BAC88B093094, filename: was.grf (md5sum matches)
Added NewGRF: GRF ID 47541003, checksum 20CF2D86E0CF5ED3465A1C9BE3285957, filename: rusplanesottd.grf (md5sum matches)
Added NewGRF: GRF ID 53441101, checksum 3E2397532428AB013862B22EDBB396E5, filename: infra_green1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53441119, checksum 4201D77058BC82C4F2DC0294AFBA6DC3, filename: infra_green1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID 53441129, checksum 9CF044DD9054F863295D5AA8A1671999, filename: infra_green1x1_p3.grf (md5sum matches)
Added NewGRF: GRF ID 53541101, checksum ECB758CAF23442BC55A0976A3EEEF1DB, filename: infra_streets1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53541119, checksum 2DB55BAA1D2B2538D5C7B5BA9AEE4CB9, filename: infra_streets1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID 53541129, checksum 4E54EB92FBD36275FE8DFEE4E328A782, filename: infra_streets1x1_p3.grf (md5sum matches)
Added NewGRF: GRF ID 48570101, checksum 60EE47680819FD7645E06E63E4DA559B, filename: tars_mountain_lifts.grf (md5sum matches)
Added NewGRF: GRF ID 4E480101, checksum A75AEB1758966FB8CA8B0D7044B5C0A8, filename: nhfoundationsw.grf (md5sum matches)
Added NewGRF: GRF ID 535A1080, checksum 35A04D3C8395428EBC9B69ED1631D7CE, filename: oilrigsd.grf (md5sum matches)
Added NewGRF: GRF ID 47470705, checksum EC618A558B00DC5039D297E6AC90BEE0, filename: Auz_Lineside_Objects.grf (md5sum matches)
Added NewGRF: GRF ID 47470805, checksum BF7EE016E02A3F452490763A06D02F68, filename: AuzGroundTiles.grf (md5sum matches)
Added NewGRF: GRF ID 47470901, checksum 428BA5234AE87BE1E39463B1C7B3FAD0, filename: Auz_Roadside_Objects.grf (md5sum matches)
Added NewGRF: GRF ID 504A5457, checksum D795341420C564012E262FAB630018C5, filename: townwalls_v0_1.grf (md5sum matches)
Added NewGRF: GRF ID 4D4D9910, checksum B692C8F66B0AF0346067E8A9FAF3660E, filename: the_lighthouse_set_v1.0.grf (md5sum matches)
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: ogfx-airports.grf (matches GRFID only)
Added NewGRF: GRF ID 46727800, checksum 3B58B9177D1A1B54D356F64B93526116, filename: SMITS.grf (md5sum matches)
Added NewGRF: GRF ID 46727803, checksum 3A011F33641913D8520C3CF9833D6947, filename: shanghaitransrapid.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum F3A0A556505B7A94733D85B892C2070C, filename: swehouses.grf (md5sum matches)
Tick 11532: GRF config changed
Removed NewGRF: GRF ID 44440502, filename: ussigzw.grf (md5sum matches)
Tick 43227: GRF config changed
Removed NewGRF: GRF ID 415A0501, filename: total_bridges_arrs.grf (md5sum matches)
Tick 43227: GRF config changed
Removed NewGRF: GRF ID 47471401, filename: AuzBridges.grf (md5sum matches)
Tick 43227: GRF config changed
Added NewGRF: GRF ID 415A0501, checksum 37F4A01391FE088BD22740A89E22F78B, filename: total_bridges_arrs.grf (md5sum matches)
Tick 43227: GRF config changed
GRF order changed: 415A0501 moved 35 places downGRF ID 415A0501, filename: total_bridges_arrs.grf (md5sum matches)
Tick 43227: GRF config changed
GRF order changed: 415A0501 moved 43 places upGRF ID 415A0501, filename: total_bridges_arrs.grf (md5sum matches)
Tick 43227: GRF config changed
GRF order changed: 414B4108 moved 9 places upGRF ID 414B4108, filename: xussr.grf (md5sum matches)
Tick 43227: GRF config changed
Added NewGRF: GRF ID 4672780A, checksum B4E2FB43C2CCD3E26F4524E45DFEE4AF, filename: monkeybarbridge.grf (md5sum matches)
Tick 43227: GRF config changed
GRF order changed: 4672780A moved 4 places downGRF ID 4672780A, filename: monkeybarbridge.grf (md5sum matches)
Tick 43227: GRF config changed
Removed NewGRF: GRF ID 415A0501, filename: total_bridges_arrs.grf (md5sum matches)
Tick 43227: GRF config changed
Removed NewGRF: GRF ID 4672780A, filename: monkeybarbridge.grf (md5sum matches)
Tick 43227: GRF config changed
Added NewGRF: GRF ID 74677462, checksum 96C5D349E24E8078555F42EFAAC3124E, filename: total_bridges_TTRS3.grf (md5sum matches)
Tick 43227: GRF config changed
Added NewGRF: GRF ID 415A0501, checksum 37F4A01391FE088BD22740A89E22F78B, filename: total_bridges_arrs.grf (md5sum matches)
Removed NewGRF: GRF ID 74677462, filename: total_bridges_TTRS3.grf (md5sum matches)
Tick 37943: game loaded
Missing NewGRF: GRF ID 9787EAFE, filename: road-hog.grf (matches GRFID only)
Compatible NewGRF loaded: GRF ID 414E0201, checksum 0DA3A80B986BC3C17C20CA4CE9CA26AA, filename: fish.grf (md5sum matches)
Tick 37943: GRF config changed
Added NewGRF: GRF ID 9787EAFE, checksum AA0AE129891ABE9207656505652CF8F8, filename: road-hog.grf (md5sum matches)
Tick 64819: GRF config changed
GRF parameter changed: GRF ID 56430001, filename: ttrs3w.grf (md5sum matches)
Tick 64819: GRF config changed
GRF order changed: 415A0301 moved 1 places downGRF ID 415A0301, filename: americanroads.grf (md5sum matches)
GRF parameter changed: GRF ID 56430001, filename: ttrs3w.grf (md5sum matches)
Tick 11403: GRF config changed
Removed NewGRF: GRF ID 43415000, filename: ogfx-airports.grf (matches GRFID only)
Tick 11403: GRF config changed
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: ogfx-airports.grf (matches GRFID only)
Tick 11403: GRF config changed
Added NewGRF: GRF ID 9787EA81, checksum 344D22B14325AA88CA1D7B1272C1A7AC, filename: CanStn.grf (md5sum matches)
Tick 14822: game loaded
Missing NewGRF: GRF ID 43415000, filename: ogfx-airports.grf (matches GRFID only)
Tick 14822: GRF config changed
Added NewGRF: GRF ID 43415000, checksum E6842673F80421576E10354AF3845A74, filename: ogfx-airports.grf (md5sum matches)
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x767CC52F RaiseException + 88
[01] openttd              0x0056F9B8 CustomAbort (/home/jgr/openttd/cross-win32/src/os/windows/crashlog_win.cpp:585)
[02] msvcrt               0x74F38EA2 abort + 55
[03] openttd              0x0055F9F1 error(char const*, ...) (/home/jgr/openttd/cross-win32/src/openttd.cpp:129)
 <infinite loop>

*** End of additional info ***
Attachments
crash.png
(682.05 KiB) Not downloaded yet
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

ISA wrote:Hello! JGR is it possible that language changing will crash the game?
My friend complained me that after installing latest nightly and then adding Your patch the game crashed when using Estonian language. After changing it to English everything worked fine.

One more thing what he pointed out was that he was clicking on latest FIRS 2.0 industrie when the crash occurs and maybe the problem is somewhere else. As I cant get back to his PC I cant be more specific yet... I can maybe after Christmas

Ill add crash report what I mange to get from him
When you can access his PC, could you post a savegame?
Edit: Actually no need, I've reproduced this now.
In the industry window for FIRS 2 industries which list received cargo, I get an incorrect string or infinite loop if I switch to Estonian after loading the game, and an infinite loop if I switch before loading.
Edit 2: The same problem occurs with trunk OpenTTD, can I suggest that you raise a bug with the FIRS developers?
McZapkie wrote:I want to report, that lines which describe vehicle route doesn't take into account latest station, when route is constructed.
(of course, if vehicle windows is closed and opened again, everything is OK, but during constructing, it is somewhat misleading, especially for ships/buoys).
Is it known bug?
It's an issue for multiplayer clients, it should work fine for single player and multiplayer servers. I'll see about a possible fix later on.
Edit: This is fixed and will be in the next release.
ISA wrote:Hello!

Now I got a crash. While changeling plane color in the company window. I am aware that I don't have latest patch pack
Could you post a savegame for this as well?
Edit: Are you sure that your GRF config and edits are sensible? There have been some interesting-looking NewGRF changes, and the issue implies the presence of an orphaned NewGRF object instance.
Ex TTDPatch Coder
Patch Pack, Github
FrontierPharmacist
Engineer
Engineer
Posts: 2
Joined: 28 Dec 2016 16:51

Re: JGR's Patch Pack

Post by FrontierPharmacist »

JGR wrote:
McZapkie wrote:Is it possible to freeze vehicle running costs, if vehicle stay in depot?
With new station orders patch, timetable for depot patch and vehicle repairs cost patch, there should be no additional running costs for vehicle stopped in depot, regardless if stopped manually, by timetable or conditional station order.

shortly: I propose to disable counting running costs, if vehicle is inside depot and repair costs are turned on.

BTW, 'go do station if cargo accepted' is awesome tool in case of ECS.
GRFs already control running costs when stopped. I don't see that it's necessary to override them on this.
I humbly ask you to reconsider this. The reason is that conditional jump order have opened new interesting possibilities, for example:

1. If you have a route with transfer - for example ship unloading cargo at the dock for trucks to pick it up, you can order the trucks to stay in depot until the ship arrive and then return to depot after cargo is distributed to wait for another ship.
2. In ECS there are some seasonal products (fruits, grain) - with conditional jump you can make truck/train wain in depot until those products are harvested, instead of waiting whole year at the station.
3. In ECS production plants storage is limited. With conditional jump you can order a train to check which industry needs raw material and deliver it there or to wait in depot if none need it at the moment (very useful for distributing vehicles from vehicle factory to stimulate other facilities).

The problem is that all above is pointless if running cost of ACTIVATED (green flag) vehicle waiting in depot is the same as working vehicle. A global modification of running costs in depot could make such strategies valid and add some interesting complexity. It should not be purely GFR dependent as not every GFR maker is aware of it nor wishes to modify his sets.

Anyway, great job with this patch. Keep up the good work!

Best regards!
SimYouLater
Chief Executive
Chief Executive
Posts: 675
Joined: 03 Apr 2016 20:19

Re: JGR's Patch Pack

Post by SimYouLater »

Hey, there. Have you heard about NotRoadTypes? If so, can you keep an eye on it for future addition? Thanks for the great work!
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.
kaumi
Engineer
Engineer
Posts: 2
Joined: 30 Dec 2016 12:29

Re: JGR's Patch Pack

Post by kaumi »

Would you make chunnel option (as link : viewtopic.php?f=33&t=41775 ) in next version?
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

There is pay_for_repair and repair_cost settings in openttd.cfg, it should make payment for repairing vehicle entering depot, if it was broken,
but I don't see any effects.
Is it from this patch: viewtopic.php?f=33&t=45642 ?

Probably there is interference with improved breakdowns patch.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

FrontierPharmacist wrote:I humbly ask you to reconsider this. The reason is that conditional jump order have opened new interesting possibilities, for example:

1. If you have a route with transfer - for example ship unloading cargo at the dock for trucks to pick it up, you can order the trucks to stay in depot until the ship arrive and then return to depot after cargo is distributed to wait for another ship.
2. In ECS there are some seasonal products (fruits, grain) - with conditional jump you can make truck/train wain in depot until those products are harvested, instead of waiting whole year at the station.
3. In ECS production plants storage is limited. With conditional jump you can order a train to check which industry needs raw material and deliver it there or to wait in depot if none need it at the moment (very useful for distributing vehicles from vehicle factory to stimulate other facilities).

The problem is that all above is pointless if running cost of ACTIVATED (green flag) vehicle waiting in depot is the same as working vehicle. A global modification of running costs in depot could make such strategies valid and add some interesting complexity. It should not be purely GFR dependent as not every GFR maker is aware of it nor wishes to modify his sets.

Anyway, great job with this patch. Keep up the good work!

Best regards!
I'll have to take a look at the existing implementation and the NewGRF spec at a later date, but I will bear this in mind.
SimYouLater wrote:Hey, there. Have you heard about NotRoadTypes? If so, can you keep an eye on it for future addition? Thanks for the great work!
I'm aware of it, I may took a closer look at it at a later date.
kaumi wrote:Would you make chunnel option (as link : viewtopic.php?f=33&t=41775 ) in next version?
This is on the list of things which may be considered for possible future addition.
McZapkie wrote:There is pay_for_repair and repair_cost settings in openttd.cfg, it should make payment for repairing vehicle entering depot, if it was broken,
but I don't see any effects.
Is it from this patch: viewtopic.php?f=33&t=45642 ?

Probably there is interference with improved breakdowns patch.
It is from there, this should be fixed in the next release, thanks for pointing this out.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
3iff
Tycoon
Tycoon
Posts: 1093
Joined: 21 Oct 2005 09:26
Location: Birmingham, England

Re: JGR's Patch Pack

Post by 3iff »

JGR wrote:
3iff wrote:JGR 0.16.0

A bug.

When instructing a vehicle to "go to nearest depot" and STOP, then the vehicle doesn't stop.
When instructing a vehicle to "go to a specific depot" and STOP, then the vehicle stops as expected.

It's a change from earlier versions (and expected behaviour) so I'm assuming it's a bug not a feature.
It seems to happen with all vehicle types.

Hopefully it's not a new setting I've overlooked.
I can't reproduce or see anything obviously wrong with "go to nearest depot" orders.
Have you got a savegame which exhibits the issue?
I don't have one to hand but I'll get one sorted out for you. I'll try a no-newgrf game first to make sure it's not something else. My internet is intermittent so it'll be a week or so.

Thanks.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 9 guests