JGR's Patch Pack
Moderator: OpenTTD Developers
Re: JGR's Patch Pack
When will that be?
Re: JGR's Patch Pack
Maybe tomorrow.Mizari wrote:When will that be?
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
Hi,
I suppose one needs a bit more deep understand of OTTD to get the thing running
I copied my install,
installed your win64 files on top,
and ran it
but saw none of the described GRF's, what did i miss ?
I suppose one needs a bit more deep understand of OTTD to get the thing running
I copied my install,
installed your win64 files on top,
and ran it
but saw none of the described GRF's, what did i miss ?
Re: JGR's Patch Pack
The patchpack will refuse to run if any of the 4 GRFs included in the install are missing, however they won't show up in the GRF list as they're classified as part of the base set (i.e. internal).viking42 wrote:Hi,
I suppose one needs a bit more deep understand of OTTD to get the thing running
I copied my install,
installed your win64 files on top,
and ran it
but saw none of the described GRF's, what did i miss ?
So if it runs OK the GRFs are installed correctly.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
-
- Engineer
- Posts: 2
- Joined: 12 Apr 2011 15:27
Re: JGR's Patch Pack
Hi, thanks for the great patch pack! I was wondering if you had planned to include some sort of copy/paste patch (such as http://www.tt-forums.net/viewtopic.php?f=33&t=45488) or similar functionality?
Re: JGR's Patch Pack
I'm not so keen on the idea TBH. Without wanting to regurgitate the various threads on the subject, it seems a bit unnecessary to me.palaceofhate wrote:Hi, thanks for the great patch pack! I was wondering if you had planned to include some sort of copy/paste patch (such as http://www.tt-forums.net/viewtopic.php?f=33&t=45488) or similar functionality?
On a more objective front though, the patch in that thread is huge and seems to make an excessive number of changes, which would be time-consuming to merge and maintain, so it's unlikely that it'll be included in the near future.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
Which platform/OS are you running on?archy wrote:Latest git master gives me a strange linker error:
http://pastebin.com/raw.php?i=0JscY4bE
In the meantime you should be able to get around that by configuring with:
Code: Select all
./configure --without-libbfd
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
an up-to-date 64bit Arch Linux systemJGR wrote:Which platform/OS are you running on?
With that it works. Thanks.JGR wrote:In the meantime you should be able to get around that by configuring with:Code: Select all
./configure --without-libbfd
Re: JGR's Patch Pack
If you get a chance, it'd be much appreciated if could you see whether the tmp_jgrpp_libbfd_update branch fixes the issue on your system, and what the output of `./configure` is. I've made some tweaks to the configure script.archy wrote:an up-to-date 64bit Arch Linux systemJGR wrote:Which platform/OS are you running on?
With that it works. Thanks.JGR wrote:In the meantime you should be able to get around that by configuring with:Code: Select all
./configure --without-libbfd
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
An old save (it's not important that it works, I just wanted to check in on it because of realising that certain performance problems had to do with one-way roads without end) suddenly crashed when zooming out with some error about water. I guess it might be something that could occur for others, so... Thus attached.
- Attachments
-
- crash.sav
- (6.31 MiB) Downloaded 165 times
Re: JGR's Patch Pack
These should both be fixed in in 0.5.1.Mizari wrote:An old save (it's not important that it works, I just wanted to check in on it because of realising that certain performance problems had to do with one-way roads without end) suddenly crashed when zooming out with some error about water. I guess it might be something that could occur for others, so... Thus attached.
The performance issue was due to inclusion the extra large maps patch, as the pathfinder (YAPF) limited the road vehicle path length to the maximum map size (2048). As this has now gone up to 1M, the excessively long paths were causing the performance regression. I've decreased the road vehicle pathfinder limit back down to 2048.
The crash was because the earlier fix for the crash when looking at aqueduct bridge heads using the enhanced viewports patch was incorrect, but I hadn't noticed as the crash was then only triggered when the tile with the index of the tile type of the aqueduct bridge head tile was a water tile, which it generally isn't.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
- HackaLittleBit
- Director
- Posts: 550
- Joined: 10 Dec 2008 16:08
- Location: tile 0x0000
Re: JGR's Patch Pack
Found you a bug.
It is also in the everest patch.
See attachment for patch.
Reproduce bug.
In arctic climate go above snowline and tree line.
Build random trees.
Result will be cactus.
Question:
Can I use your code to upgrade everest patch?
It is better than mine.
It is also in the everest patch.
See attachment for patch.
Reproduce bug.
In arctic climate go above snowline and tree line.
Build random trees.
Result will be cactus.
Question:
Can I use your code to upgrade everest patch?
It is better than mine.
- Attachments
-
- patch bug planting random trees.diff
- (928 Bytes) Downloaded 178 times
Re: JGR's Patch Pack
Thanks for this fix, I've merged it in (with a minor formatting change), and it'll be in the next release.HackaLittleBit wrote:Found you a bug.
It is also in the everest patch.
See attachment for patch.
Reproduce bug.
In arctic climate go above snowline and tree line.
Build random trees.
Result will be cactus.
Please feel free, (it's all GPL, after all).HackaLittleBit wrote: Question:
Can I use your code to upgrade everest patch?
It is better than mine.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
-
- Route Supervisor
- Posts: 466
- Joined: 15 Jun 2007 09:27
- Skype: madchimiste
- Location: Berlin, Deutschland
Re: JGR's Patch Pack
Hello!
Really nice patch pack! So far, no crash or bugs to report. I have a question though:
I noticed there is a patch to pick and place houses in the scenario editor. I found the house pick window, which has a similar interface as the NewObject window, but I can't manage to place a house in game. I tried in city centres, in suburbs, but I must have missed something. How to use this patch properly?
(I am using version 0.5.1 of the Patchpack, running on Win 7)
I also noticed an error in the first post: the "Vehicle group info" links to the "Upgrade airport" thread.
Really nice patch pack! So far, no crash or bugs to report. I have a question though:
I noticed there is a patch to pick and place houses in the scenario editor. I found the house pick window, which has a similar interface as the NewObject window, but I can't manage to place a house in game. I tried in city centres, in suburbs, but I must have missed something. How to use this patch properly?
(I am using version 0.5.1 of the Patchpack, running on Win 7)
I also noticed an error in the first post: the "Vehicle group info" links to the "Upgrade airport" thread.
Re: JGR's Patch Pack
It seems that the functionality got broken when I fixed a bug in the last release.arikover wrote:Hello!
Really nice patch pack! So far, no crash or bugs to report. I have a question though:
I noticed there is a patch to pick and place houses in the scenario editor. I found the house pick window, which has a similar interface as the NewObject window, but I can't manage to place a house in game. I tried in city centres, in suburbs, but I must have missed something. How to use this patch properly?
(I am using version 0.5.1 of the Patchpack, running on Win 7)
I also noticed an error in the first post: the "Vehicle group info" links to the "Upgrade airport" thread.
I'll probably go through that patch and sort it all out so it works like the object picker window. It should be fixed in the next release.
Thanks for reporting the bug.
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
-
- Route Supervisor
- Posts: 466
- Joined: 15 Jun 2007 09:27
- Skype: madchimiste
- Location: Berlin, Deutschland
Re: JGR's Patch Pack
Well thanks for the quick answer and keep up the good work!
Re: JGR's Patch Pack
This is fixed in v0.5.2 which is available in the first post.arikover wrote:Well thanks for the quick answer and keep up the good work!
Ex TTDPatch Coder
Patch Pack, Github
Patch Pack, Github
Re: JGR's Patch Pack
Are there any instabilities with multiplayer to be expected?
Who is online
Users browsing this forum: No registered users and 20 guests