Question 2: When I compiled Cirdan's patch into the source and makefile/config.lib created rev.cpp, it would seem that the version number was not written. Did I miss doing something?
How did you obtain the OpenTTD source code? When cloning hg/git or checking out from SVN, it will use that version when writing rev.cpp. Thus these methods are recommended over downloading the source .zip files. Also this allow you to pull the last changes instead of downloading a new full copy of the source code later when you want to update.
Lord Aro wrote:
To aid trunk inclusion, you should of course:
a) split the patch up into separate changes (i know you've already done this, but i don't see a recent version published)
b) for minor things such as bug fixes that are (mostly) unrelated to the map features, make (individual) flyspray tasks
I had a quick look in your branch patch from April
and from what I could see, there were some codechanges/fixes that would make sense on their own. I would suggest that you try to look through your patch queue and isolate changes that stands on their own and submit them to FS. This way you can reduce the size of your patch queue. (I saw that your combined patch file is 30k+ lines long which is a lot to review)
If you wish to aid reviewing and have some web space somewhere, you could upload your patch queue as individual numbered patches instead of contained in a single huge file. If you use hg or git locally you can use Bitbucket or Github to host your patch queue.
Note though that this is not a promise for review, only suggestions on what you can do to make reviewing easier. Also note that this message is my personal and not from the whole dev team.
_________________My OpenTTD contributions
(AIs, Game Scripts, patches, OpenTTD Auto Updater, and some sprites)Junctioneer
(a traffic intersection simulator)