Transport Tycoon Forums

NekoMaster wrote:As I'm working on my own GRF set for OpenTTD, NARS Add-on Set, I was wondering if it'd be ok to use sprites from the 2cc Train Set.

Diesel Power wrote:Just spotted the 4th Gen box cars do the same thing. The 5th Gen box cars, the graphics are swapped for all cargoes

NekoMaster wrote:I'd like to thank Transportman and all the artists of 2cc Trains for making this set a possibility. Its always nice to have a variety of locomotives to play with

As I'm working on my own GRF set for OpenTTD, NARS Add-on Set, I was wondering if it'd be ok to use sprites from the 2cc Train Set. I understand giving credit and I believe I need to have my set licensed under the same license as 2cc Set (Which I believe is GPL v2?)

Voyager One wrote:

NekoMaster wrote:As I'm working on my own GRF set for OpenTTD, NARS Add-on Set, I was wondering if it'd be ok to use sprites from the 2cc Train Set.

All my sprites are always freely available to all who simply ask.

NekoMaster wrote:I made sure to save space on my sprite sheets to credit people

Transportman wrote:based on your reports it seems that there are some things mixed up there.

Voyager One wrote:

Transportman wrote:based on your reports it seems that there are some things mixed up there.

Graphics-wise or code-wise?

Transportman wrote:That is the result of the "low" capacities of those vehicles compared to their loading speed. All cargo wagons have the same loading speed of 20, and with capacities around that, you'll get instant load and unload. I might need to tweak those loading speeds a bit.

NeutralHavoc wrote:

Transportman wrote:That is the result of the "low" capacities of those vehicles compared to their loading speed. All cargo wagons have the same loading speed of 20, and with capacities around that, you'll get instant load and unload. I might need to tweak those loading speeds a bit.

Nice, glad to see that you've already found the root of the problem. Thanks!

Kogut wrote:I am not sure what went wrong, but this newgrf is configured to inform AIs that all train engines can pull solely passenger carriages.

https://noai.openttd.org/api/trunk/clas ... 7405eb0f14 is not promised to be always right, but I never encountered trainset that would give so wrong information.

I attached test AI listing what this function gives to AI.

To run it put archive into

Code: Select all

content_download/ai

folder.

Start OpenTTD, start game with 2cc in NML newgrf, use ~ to enable console, type

Code: Select all

start_ai TEST

press enter.

AI will deliberately crash to show log window. Note that all engines are listed as able to handle solely passengers.

For reference: AI log loop.

Code: Select all

{
	local cargo_list=AICargoList();
	local engines = AIEngineList(AIVehicle.VT_RAIL);

	for (local engine = engines.Begin(); !engines.IsEnd(); engine = engines.Next()) {
		if(AIEngine.IsWagon(engine)){
			continue;		
		}
		for (local cargo = cargo_list.Begin(); !cargo_list.IsEnd(); cargo = cargo_list.Next()) {
			local state = "is not able";
			if(AIEngine.CanPullCargo(engine, cargo)){
				state = "is able";
				AILog.Info(AIEngine.GetName(engine) + " " + state + " to pull " + AICargo.GetCargoLabel(cargo));
			}
		}
	}
}

Transportman wrote:I guess the problem is that the ai_special_flag is set to AI_FLAG_PASSENGER for all vehicles (at least, I assume that CanPullCargo looks at that flag). It would indeed be better to set it to AI_FLAG_CARGO for engines that are really meant for cargo.

/* static */ bool ScriptEngine::CanPullCargo(EngineID engine_id, CargoID cargo_id)
{
	if (!IsValidEngine(engine_id)) return false;
	if (GetVehicleType(engine_id) != ScriptVehicle::VT_RAIL) return false;
	if (!ScriptCargo::IsValidCargo(cargo_id)) return false;

	return (::RailVehInfo(engine_id)->ai_passenger_only != 1) || ScriptCargo::HasCargoClass(cargo_id, ScriptCargo::CC_PASSENGERS);
}

Maddog45353 wrote:This still being updated or maintained?

Maddog45353 wrote:This still being updated or maintained?

Cadde wrote:IIRC, 2cc trainset (the non NML version) had variable running costs based on current consist speed. If the vehicle was stopped, running costs were low whereas if the consist went faster than one of it's wagons design speeds (required wagon speed limits to be off), running costs would exponentially increase with overspeeding.
Is there any chance of this happening in the NML version?

Or, can someone better versed in NML explain to me how to set up that particular callback because i looked around and the documentation is unclear at best on that particular subject. I.E, where does the declaration for "running_cost_factor" go when one wants to use a callback? I assume in the "graphics" block.
And how do i access the current vehicle speed from within the callback?

graphics {
	running_cost_factor:			switch_overspeed;
	

	switch (FEAT_TRAINS, SELF, switch_overspeed, (current_SPEED)) { 
		0..160:		return 200;
		161..200: 		return 300;
		201..65000: 	return 800;
		default: 		return 200;
	}