[GS] Think globally, act locally

[HapticTactic]

I have found a bug (I believe):

The time elapsed is reset when you load your saved game. Can you confirm?

[Wahazar]

The time elapsed is reset when you load your saved game. Can you confirm?

Yes, it is a bug, but I have no idea, how to fix it. I have variable for starting year saved:

Code: Select all

function GSToyHelper::Save() {
	local save_table = {};
	save_table.town_data_table <- {};
	if (firsttime_start) {
		save_table.town_data_table <- ::TownDataTable;
	} else {
		foreach (i, town in this.towns)
			{
				save_table.town_data_table[town.id] <- town.SavingTownData();
			}
		save_table.gamestart_year <- this.gamestart_year;
	}
	return save_table;
}

and loaded:

Code: Select all

function GSToyHelper::Load(version, saved_data)
{
	firsttime_start = false;
	foreach (townid, town_data in saved_data.town_data_table) {
		::TownDataTable[townid] <- town_data;
	}
	this.gamestart_year = saved_data.gamestart_year;
}

but it doesn't work, I have to little knowledge of squirrel to found out what is wrong.

[HapticTactic]

Well, that's too bad. My programming skills for OTTD are non-existent.

What is the actual effect of this bug? Does it only mean that the script becomes easier in difficulty every time the time is reset because the global economy index grows?

[Wahazar]

What is the actual effect of this bug? Does it only mean that the script becomes easier in difficulty every time the time is reset because the global economy index grows?

Exactly yes. In case of multiplayer server, there is usually no problem due to lack of save/load procedures. In case of singleplayer, you can just pause game instead of quit.

[HapticTactic]

What is the actual effect of this bug? Does it only mean that the script becomes easier in difficulty every time the time is reset because the global economy index grows?

Exactly yes. In case of multiplayer server, there is usually no problem due to lack of save/load procedures. In case of singleplayer, you can just pause game instead of quit.

Well, I am currently using the script in a multiplayer game that we have saved and loaded numerous times (because the game is long).

[rowdog]

I'm just guessing but do you need to save gamestart_year on the first run? Maybe you can move that line out of the if() like so...

Code: Select all

function GSToyHelper::Save() {
	local save_table = {};
	save_table.town_data_table <- {};
	if (firsttime_start) {
		save_table.town_data_table <- ::TownDataTable;
	} else {
		foreach (i, town in this.towns)
			{
				save_table.town_data_table[town.id] <- town.SavingTownData();
			}
		//save_table.gamestart_year <- this.gamestart_year;
	}
	save_table.gamestart_year <- this.gamestart_year;
	return save_table;
}

[Wahazar]

Version 19 uploaded to bananas.
I removed all game duration stuff and simplified rules, now:

• industry will be generated if amount of served industry (+ bonus from subsidies) is above threshold (settings);
• density of industry generation depend on active subsidies and vary from 2 to 5 if above-mentioned criterion is fulfilled;
• subsidies will be generated if amount of served towns is above threshold (settings);
• town growth cargoes are now compatible with XIS.

Note, that you don't need to hunt for subsidies, you will collect them randomly if you have passenger/mail cargodist network,
because subsidies are generated between already served town and any other town, served or not.

[nihues]

Oops, started and got this error on map generation (latest XIS).

[Wahazar]

Oops, started and got this error on map generation (latest XIS).

Could you show script settings?

[nihues]

Just tried again with Industry setting OFF and works. It occurs when Industry: try to keep industries on map: ON

the rest are default.

[Wahazar]

Fixed version 20 is on bananas. I also simplified city growth rules, below 50 city grow intself, below 500 it demands mail or pass, above this threshold it demand both mail and pass.

[Argus]

The game seems to ignore older versions of the script. When you start a game played with an older version, the script does not load.

[AdmiralEllis]

Playing on a snowy map, I can't get a town above the snow line to grow. It has been at 459 population since the start of the game and I have been keeping it above the passengers and mail threshold all the while. I have tried bringing food to it, but to no avail. I am using AXIS and Improved Town Layouts if that makes a difference. For what it's worth, the script does not seem to recognize the food from AXIS as food--maybe the way cargoes are defined internally needs to be looked at. I am going to continue with this save and try bringing goods once I have that set up.