MogulAI

[Dezmond_snz]

Thank you, guys, very much!
Now i totally killed 'for' loops with such damn itteration.
There are some other implovements:
- better route selection;
- better money managment while building roads;
- upgraded queue detector (work only at trunk yet);
- sending vehicles to depot now more solid
- something else, forgot already...

Updated BaNaNaS and first post.

[Dezmond_snz]

Update. Some changes and fixes improved performance of AI at higher difficulties.

Changelog:
- fix for bridge cost calc;
- imploved queue detector;
- fix bug when AI accidentally sent all vehicles to depots;
- better vehicle replacement;

Updated BaNaNaS and first post.

[Lord Aro]

woo!

are you saying port intentionally or by accident?

Updated BaNaNaS and first port.

[Dezmond_snz]

are you saying port intentionally or by accident?

Updated BaNaNaS and first port.

typo + copypaste

[Zuu]

I've noticed that on bananas your AI has license := custom. However, in your tar archive you have a license.txt file with the GPL 2 license. In none of your .nut files I've found any statement regarding if your AI is covered by the "or at your opinion any later version" statement that OpenTTD and many AIs do not have.

I would recommend you to mark in at least info.nut and main.nut if it is strictly version 2 or version >= 2 of GPL that you use. If you opt for strictly version 2, then you can select GPL2 at bananas instead of custom license.

[Yexo]

I would recommend you to mark in at least info.nut and main.nut if it is strictly version 2 or version >= 2 of GPL that you use. If you opt for strictly version 2, then you can select GPL2 at bananas instead of custom license.

You can select gplv2 on bananas in either case.

If you copy code from an AI that states "gpl v2 only (no later versions)" you can't use "or any later version" at least for the file you copied the code to.
If you copy code from an AI that states "gpl v2 or (at your option) any later version" you can still specify "gpl v2 only" in your AI.

[Brumi]

Thank you for the update, I was testing your AI for a while, there were no problems, except that it doesn't behave properly when the vehicle limit is reached. At least from the AI debug window it seems that the AI is constantly trying to add new vehicles to existing routes. I also see lines referring to the construction of stations.

[Dezmond_snz]

Ok, some work made this evening, so...
Update:
- take RV limit into account;
- fix for closing routes.

New tar available at first post and BaNaNaS.

I also noticed strange thing. Look at screenshot:

Moguls Trans Corp ltd., 2051-06-08.png (66.87 KiB) Viewed 880 times

This is r20296. AI removed all order from this vehicle and sent it to depot while this RV stayed at station. And now it stays here forever. Is that normal behavior or bug?

[Rubidium]

This is r20296. AI removed all order from this vehicle and sent it to depot while this RV stayed at station. And now it stays here forever. Is that normal behavior or bug?

It's probably the "failed" attempt at fixing https://secure.openttd.org/bugs/task/3935 although the deadlock caused by that "fix" has been reverted according to the logs. In any case, adding the savegame to the bug report might be useful.

[Zuu]

Possible workaround:

* Add two go to depot orders
* Use the skip to order command to switch to the other order
* (remove the last order)


This has worked before to make sure road vehicles actually stop what they are doing and go to depot. That said, I haven't studied this bug enough to know if this procedure has any advantage in this situation.

[Dezmond_snz]

This is r20296. AI removed all order from this vehicle and sent it to depot while this RV stayed at station. And now it stays here forever. Is that normal behavior or bug?

It's probably the "failed" attempt at fixing https://secure.openttd.org/bugs/task/3935 although the deadlock caused by that "fix" has been reverted according to the logs. In any case, adding the savegame to the bug report might be useful.

That's easy.

1.sav

(16.17 KiB) Downloaded 150 times

edit:
Updated to r20357 - no changes. It easy to reproduce: while vehicle full-loading at station pause game, remove all orders and append goto-depot (service) order (what require unpause) - vehicle will stay at station until it full-loaded, only after that it will go to depot. However, if set "stop" flag for goto-depot order after that, vehicle leave station immediately.

[Dezmond_snz]

And new version again!

Now with more important changes:
- better behavior when coming close to RVs limit;
- use built-in replace functions;
- fixed bug of calculating starting count of vehicles for route;
- some minor tweaks.

Enjoy. And feedback are welcome.

[ostlandr]

I like! I have added MogulAI to my games, along with NoCab (and Town Cars for the eye candy.)

[LamRis]

Bug report:
openttd r20911

[Dezmond_snz]

Bug report:
openttd r20911

Thank You very much!
Fixed 5900.

[Kogut]

bugbugbug

[Kogut]

In long run MogulAI is collecting RV in depots what is bad afterhitting RV limit.

Code: Select all

function AIAI::DeleteVehiclesInDepots()
	{
	local counter=0;
	local list=AIVehicleList();
	for (local q = list.Begin(); list.HasNext(); q = list.Next()){ //from Chopper 
		if(AIVehicle.IsStoppedInDepot(q)){
			AIVehicle.SellVehicle(q);
			counter++;
		}
	}
	return counter;
	}

[Zuu]

Hint: that code can be shortened as:

Code: Select all

function AIAI::DeleteVehiclesInDepots()
{
   local list = AIVehicleList();
   list.Valuate(AIVehicle.IsStoppedInDepot);
   list.KeepValue(1);
   list.Valuate(AIVehicle.SellVehicle);
   return list.Count();
}

[Kogut]

Hint: that code can be shortened as:

Code: Select all

function AIAI::DeleteVehiclesInDepots()
{
   local list = AIVehicleList();
   list.Valuate(AIVehicle.IsStoppedInDepot);
   list.KeepValue(1);
   list.Valuate(AIVehicle.SellVehicle);
   return list.Count();
}

Thanks!

[Kogut]

Warning! It is not working: