Trans AI .:19.07.23 :.
Moderator: OpenTTD Developers
Re: Trans AI :: 09-08-24 ::
I just experimented with this, and then tested it for 2 minutes, and it worked. I don't know if it can have an impact on other areas of the AI, you know your code better.
- Doorslammer
- Tycoon
- Posts: 1037
- Joined: 16 Oct 2007 11:08
- Location: Perth, Western Australia
- Contact:
Re: Trans AI :: 09-08-24 ::
Oops, a cockup has occured.
- Attachments
-
- Error1.PNG (189.78 KiB) Viewed 503 times
Re: Trans AI :: 09-08-24 ::
A bit more info on that error:Monaro Doorslammer wrote:Oops, a cockup has occured.
The subsidy system has been changed in a few commits +-r17110. Subsidies are no longer station->station, but are town->town, industry->industry or industry->town now. A new set of AI api functions has been introduced to deal with this. The old functions have been changed to work like the old functions as much as possible, but it isn't possible to return a StationID for an awarded subsidy anymore, since multiple stations can be valid.
- Doorslammer
- Tycoon
- Posts: 1037
- Joined: 16 Oct 2007 11:08
- Location: Perth, Western Australia
- Contact:
Re: Trans AI :: 09-08-24 ::
Oops, now in iMAX mode error reporting.
- Attachments
-
- Error1.PNG (32.28 KiB) Viewed 495 times
Re: Trans AI :: 09-08-24 ::
Judging by the debug output that seams to be the same error as you have already reported, and you are still using the same version of the AI.
My OpenTTD contributions (AIs, Game Scripts, patches, OpenTTD Auto Updater, and some sprites)
Junctioneer (a traffic intersection simulator)
Junctioneer (a traffic intersection simulator)
Re: Trans AI :: 09-08-24 ::
Yes, but this time the complete stack trace is readable.Zuu wrote:Judging by the debug output that seams to be the same error as you have already reported, and you are still using the same version of the AI.
Re: Trans AI :: 09-08-24 ::
Its look like that AI crash on calling function. Thats mean the returned "INVALID_STATION" is not known?Yexo wrote:A bit more info on that error:Monaro Doorslammer wrote:Oops, a cockup has occured.
The subsidy system has been changed in a few commits +-r17110. Subsidies are no longer station->station, but are town->town, industry->industry or industry->town now. A new set of AI api functions has been introduced to deal with this. The old functions have been changed to work like the old functions as much as possible, but it isn't possible to return a StationID for an awarded subsidy anymore, since multiple stations can be valid.
What if the returned value of GetSource() and and GetDestination just an InvalidID of Town/Industry or common invalid value (eg. -1) instead of "INVALID_STATION"?
Re: Trans AI :: 09-08-24 ::
Ah, sorry. It's my fault, and a bug in OpenTTD (in compat_0.7.nut to be exact). Will fix this later tonight.fanioz wrote:Its look like that AI crash on calling function. Thats mean the returned "INVALID_STATION" is not known?
Edit: fixed in r17289.
Re: Trans AI :: 09-08-24 ::
Yexo wrote:Ah, sorry. It's my fault, and a bug in OpenTTD (in compat_0.7.nut to be exact). Will fix this later tonight.fanioz wrote:Its look like that AI crash on calling function. Thats mean the returned "INVALID_STATION" is not known?
Edit: fixed in r17289.
Well, thanks
I don't need to change anything from my side.
(Just remember the number 17289)
Re: Trans AI :: 09-08-24 ::
Well it's not exactly fixed:
- Attachments
-
- TransAI #1.png (54.18 KiB) Viewed 503 times
Re: Trans AI :: 09-08-24 ::
Don't know how I managed to make it instantly crash on startup? Maybe because I'm using multiple versions with the same grfs/AI's? I have used the most current nightly to download updates and then used an old build (9th of july, don't know revision) to play with it.
- Attachments
-
- Ridderdoorn Transport, 1950-01-25.png
- (308.29 KiB) Downloaded 62 times
Re: Trans AI :: 09-08-24 ::
bokkie: That screenshot is almost certainly of no use to the AI author. Please enlarge the window in both height and width so that the full error message is shown next time
Re: Trans AI :: 09-08-24 ::
I'm 99% sure it's because the version of OpenTTD is you use is too old for that version of Trans AI.
Re: Trans AI :: 09-08-24 ::
I'm sory. I couldn,t see any wrong there. Perhaps you could describe it a bit.Wold wrote:Well it's not exactly fixed:
bokkie:
Yexo is right. And, yes there are 1 percent of my bad code design.
- cmoiromain
- Chief Executive
- Posts: 655
- Joined: 15 Jan 2007 21:45
- Location: FRANCE
- Contact:
Re: Trans AI :: 09-08-24 ::
One thing I have noticed about this AI is that it loves long bridges. I think that's the problem on he above screenshot. I also came across many situations where instead of simply building some straight track, the AI built a bridge.
Also, it seems reluctant to reusing its tracks, and sometimes builds three times the same path for three different industries.
Also, it seems reluctant to reusing its tracks, and sometimes builds three times the same path for three different industries.
I am little, ugly, and nasty. How do you do?
Re: Trans AI :: 09-08-24 ::
With the previous screenshot I meant that the bridge problem is not fixed.
With the following screenshot I want to show that your AI makes a route ( blocking the supply ). I think it will be a good idea when you transport secondary stuff to add a simple route ( either train or truck ) in order to feed the industry ensuring constant supply.
With the following screenshot I want to show that your AI makes a route ( blocking the supply ). I think it will be a good idea when you transport secondary stuff to add a simple route ( either train or truck ) in order to feed the industry ensuring constant supply.
- Attachments
-
- trans1.png (99.98 KiB) Viewed 494 times
Re: Trans AI :: 09-08-24 ::
I ran into this while I was playing:
The pair of that road station simply didn't exist.Re: Trans AI :: 09-08-24 ::
That's because it couldn't find a path. That's normal when it fails to build a route.Brumi wrote:I ran into this while I was playing:The pair of that road station simply didn't exist.
Re: Trans AI :: 09-08-24 ::
I'm not sure about that. The coal mine was quite nearby and there was no obstruction. Even if the pathfinder fails, it should delete the station.Wold wrote:That's because it couldn't find a path. That's normal when it fails to build a route.
Re: Trans AI :: 09-08-29 ::
Updated, as usual. 2nd post and Bananas...
Long bridge is a feature, but Bridge-Happy is a bug. Agree ?
edit:
Forget to answer this:
bokkie wrote:Don't know how I managed to make it instantly crash on startup? Maybe because I'm using multiple versions with the same grfs/AI's? I have used the most current nightly to download updates and then used an old build (9th of july, don't know revision) to play with it.
Then, this version should fix the 1% left. Just make sure you would need at least 0.7.2 (I don't remember if I've ever added newer API function)Yexo wrote:I'm 99% sure it's because the version of OpenTTD is you use is too old for that version of Trans AI.
Wold wrote:With the previous screenshot I meant that the bridge problem is not fixed.
I've tell him in this version to try build normal track instead, but still let him build bridge if necessary.cmoiromain wrote:One thing I have noticed about this AI is that it loves long bridges. I think that's the problem on he above screenshot. I also came across many situations where instead of simply building some straight track, the AI built a bridge.
Long bridge is a feature, but Bridge-Happy is a bug. Agree ?
re-using track : I've done some experiment in my other thread, and I've a not-published-yet version of Trans that re-use rail track. There is still a problem to avoid crossing on existing track. Of course I'll release it when ready.cmoiromain wrote: Also, it seems reluctant to reusing its tracks, and sometimes builds three times the same path for three different industries.
I left this one, couldn't implement it right now, probably in the trunk version. However the idea is good. ThanksWold wrote: With the following screenshot I want to show that your AI makes a route ( blocking the supply ). I think it will be a good idea when you transport secondary stuff to add a simple route ( either train or truck ) in order to feed the industry ensuring constant supply.
edit:
Forget to answer this:
TestMode said, AI can build route, ExecMode not. The pathfinder failed, it wouldn't delete the road station, because it was a drop off. It will re-used later. But in the next days, AI decide to build rail and success. The road station would only be used again, if AI couldn't build rail service.Brumi wrote:I'm not sure about that. The coal mine was quite nearby and there was no obstruction. Even if the pathfinder fails, it should delete the station.Wold wrote:That's because it couldn't find a path. That's normal when it fails to build a route.
Who is online
Users browsing this forum: No registered users and 7 guests