Crashing with more than one AI

[paullb]

I have noticed with the latest noai nightly r13512, that whenever there is more than one AI running it seems to crash the game.

Based on what I have seen, my best guess that it would happen when both of the AIs try to build at the same time.

Anyone else had this experience?

[glx]

You forgot to give us all details. OS, message if any, how to reproduce...

[paullb]

You forgot to give us all details. OS, message if any, how to reproduce...

Before I wrote out a whole lost of stuff. I was just wondering if any else had experienced it.

I was able to reproduce it in the following way.

1) Run Openttd.exe (obviously)
2) Start Convoy twice in rapid succession (does necessarily have to be rapid, but the crash seems to happen earlier when started togher). Same effect for 1 of my AI (Jinjaba, unpublished, which is operates busses as well) and 1 convoy
3) usually crash happens within 10-60 seconds. (message standard, "this has crashed message" from Windows)

If there are any log files or whatnot that OpenTTD produces let me know and I will post them.
WinXP, r13512-noai (also experienced with another recent nightly, forget the number)
(I can paste the above into bug tracker as well if you want)

[glx]

Please retry with http://devs.openttd.org/~glx/OTTD-MSVC- ... 2-noai.zip, it should produce .log and .dmp on crash.

Edit: I can reproduce it (I get a "map/set iterator not decrementable" error)

[paullb]

Please retry with http://devs.openttd.org/~glx/OTTD-MSVC- ... 2-noai.zip, it should produce .log and .dmp on crash.

Here you go.

[glx]

Ok it's the bug described on http://wiki.openttd.org/index.php/AI:Bugs and Convoy does exactly that.

[GeekToo]

It did never crash on me ( Gentoo Linux), but the line causing trouble is 612 I presume?

Could you try this one?

[glx]

This version works. And I did get the segfault using the previous version on windows and mandriva64.

Edit: looking into Convoy code, line 637 may cause problems too.

[GeekToo]

No, I've seen that line, but the remove is on another list than the iterator

Code: Select all

for (town_it = town_list2.Begin(); town_list2.HasNext(); 
	   	town_it = town_list2.Next()){	
			town_list.RemoveItem(town_it);

[glx]

Oh, you're right.