Solution to the infamous passengers-from-nowhere bug

[Zimmlock]

First, I dont know if you can consider this a bug, but if you run massive amounts of trains and you get a hudge trafficjam some of your trains can disapear from the map, you can find them back in your train list with the message No Position. I consider it a bug/ unwanted behavior.
Second, if you play a map long enough you end up without trees, even if you have set in the scenario editor the maximum amout of forrests and individual trees.

[LocoMH]

My 3 dreams for Locomotion are: bigger maps (everyone has that dream...), passengers with destination (makes no sense to transport passengers from one station to another and unloading all to me) and trains that know when there is a junction between their tracks so they get a green signal. However...I believe this is hard to fix by just using a patch. (...?)

[Jerrythabest]

LSP? I did wonder whether I'd seen a similar approach for something before, but I couldn't think what to search for. Searching for LSP has given me nothing. Could you expand?

LSP = Long Station Patch if I'm correct.
I'm starting to wonder how that works actually, as I've seen that the station data structures in memory have room to store no more than 80 station element locations. At least some things need to be worked around then, I suppose.


But that's rather offtopic. About the Loco Statoin Fixer release, it'll come in about 10 hours from now; it'll be the first thing I do when I come home tonight. Don't want to keep you guys waiting any longer than necessary, but I couldn't do it yesterday

First, I dont know if you can consider this a bug, but if you run massive amounts of trains and you get a hudge trafficjam some of your trains can disapear from the map, you can find them back in your train list with the message No Position. I consider it a bug/ unwanted behavior.
Second, if you play a map long enough you end up without trees, even if you have set in the scenario editor the maximum amout of forrests and individual trees.

I'd consider both to be bugs, though I thought the former was fixed with the .172 patch?

My 3 dreams for Locomotion are: bigger maps (everyone has that dream...), passengers with destination (makes no sense to transport passengers from one station to another and unloading all to me) and trains that know when there is a junction between their tracks so they get a green signal. However...I believe this is hard to fix by just using a patch. (...?)

We are dreaming about the same things I guess Though these things are by design (that is, not bugs), I hope that we'll have a patch capable of changing such behaviour one day. It'll be a difficult one to do, so I don't think that I'm ready for something like that, but if I ever run into the solution to do this I won't hesitate to try

[Jerrythabest]

All right everyone, I've attached Loco Station Fixer v1.1 to the opening post!

Alternatively, you may download it from here.

[Illegal_Alien]

Thats great, but i wont use it as i will wait for more usefull patches.

p.s.: I just reported your post and asked for an anwer of the moderatorteam/orudge. and it seems it helped

[Jerrythabest]

Haha, thank you for that

If there is anything specific you'd like to see patched, feel free to ask can't hurt trying.

[Bit]

First, I dont know if you can consider this a bug, but if you run massive amounts of trains and you get a hudge trafficjam some of your trains can disapear from the map, you can find them back in your train list with the message No Position. I consider it a bug/ unwanted behavior.
Second, if you play a map long enough you end up without trees, even if you have set in the scenario editor the maximum amout of forrests and individual trees.

I've seen these two too and would also call them bugs, so I'd certainly vote for those to be patched, if the solutions are sensible.

Re LSP: I don't find the station limitation a problem, I simply add a second station e.g. "Waterloo [1-4]" and "Waterloo [5-8]" which often helps with train routing, and there are techniques to making platforms longer than 16 tiles. So might I suggest that any 'mods' included be optional as in OTTD?

A quick extra thought, would it be possible to select an ObjData folder (and possibly Saved games folder) before start-up (maybe auto-renaming/copying them) so that it's easy to keep multiple set-ups for different scenarios on one PC?

[Jerrythabest]

Re LSP: I don't find the station limitation a problem, I simply add a second station e.g. "Waterloo [1-4]" and "Waterloo [5-8]" which often helps with train routing, and there are techniques to making platforms longer than 16 tiles. So might I suggest that any 'mods' included be optional as in OTTD?

I'd say any non-bugfixes should be optional since they may modify gameplay more seriously.

A quick extra thought, would it be possible to select an ObjData folder (and possibly Saved games folder) before start-up (maybe auto-renaming/copying them) so that it's easy to keep multiple set-ups for different scenarios on one PC?

I figure that's possible with a little batch file that renames the folders and then launches Loco. It can also re-rename the folders when Loco exits I suppose.

[Zainy521]

Just letting you know, Your patch is incompatible with LSP savegames. Otherwise works fine.

[Dreamcatcher]

Just letting you know, Your patch is incompatible with LSP savegames. Otherwise works fine.

Of course it would be incompatible with the LSP..

|I can only assume that both this and Lsp change various values in the running exe meaning that lsp will not work with this and vice versa.

[Zainy521]

Just letting you know, Your patch is incompatible with LSP savegames. Otherwise works fine.

Of course it would be incompatible with the LSP..

|I can only assume that both this and Lsp change various values in the running exe meaning that lsp will not work with this and vice versa.

It's not incompatible with LSP, LSP works just fine with both running. I just can't load LSP savegames with this patch running.

[Jerrythabest]

That's interesting, I'll have to see what the LSP does to your save files then.

What happens when you try to load an LSP savegame? I suppose the game crashes?


EDIT: aha, funny, I see what the LSP does now. Will do a little check for that in v1.2.

EDIT 2: released Loco Station Fixer v1.2!

[Zainy521]

When playing with LSP, you'll receive an error whenever you place a station that isn't a train station. Error #:0042F38D

[Plastikman]

When playing with LSP, you'll receive an error whenever you place a station that isn't a train station. Error #:0042F38D

what station?
I have placed road and boat docks fine..
i didn't try and airport tho

[Jerrythabest]

When playing with LSP, you'll receive an error whenever you place a station that isn't a train station. Error #:0042F38D

I understand that this is what happened in Loco Station Fixer v1.1, right? It's exactly the address I checked for in v1.2, so if you encounter this error with v1.2 I must have made a mistake somewhere.

[Zimmlock]

More bug
The money bugg, the game simply cant handle it if you over stretch it. After a certain date or in come your income turns negative, but only at this image, the train income stays positive untill december and just befor the end of the year it turns negative. However, my total Cash and company value keeps climbing, i dont get announced bankrupt in 6 month.
If you want to study a overstretched game pm me and you can get my save

[Jerrythabest]

Oh, yes. The money bug!
While the cause of that is simple and straightforward, it's gonna be one hell of a job to get that fixed. The game reserves 4 bytes for each number you see in that window, which gives it a certain range of numbers it can store. If you go beyond that, it wraps around into the negatives. The solution is both trivial and incredibly difficult at the same time: increase the number of bytes the game uses for each number.

The easy part is reserving the extra space, which can simply be borrowed from the space where the game now stores your financial history (similar to how the LSP increases the number of station elements per station by cutting the possible number of stations in half).

However, Locomotion is a 32-bit (=4 bytes) application, which means that it does all its calculations (except for multiplications) in at most 4 bytes. So to make that work with 8 bytes, a simple addition like "trainIncome + incomeOfMyTrain" becomes a mathematical trick that involves multiple steps. While the solution is not that hard to find (as many programmers have had to deal with this in the past), the actual difficult part is that for a patch like this the program code of the solution must fit within space occupied by the original code. And the original ADD operation is usually no more than 2 bytes!


Though, I wonder... you're making so much money because you are moving around vast amounts of cargo. The Loco Station Fixer has the potential to reduce the amount of cargo produced on your map. Just out of curiousity: do you see any (significant) decrease in income in that game after you start using the Loco Station Fixer?

[Zimmlock]

Though, I wonder... you're making so much money because you are moving around vast amounts of cargo. The Loco Station Fixer has the potential to reduce the amount of cargo produced on your map. Just out of curiousity: do you see any (significant) decrease in income in that game after you start using the Loco Station Fixer?

Worst, i dont use the bug fixer because i never ever experienced any station bug, that is, only sometimes when i build a new station at a farm or oilfield it ll produce for verry short time a amount of passengers and mail, but i do not collect them and they ll never show up again.
This is the amount of cargo i have devivered in 283 years in reality i have moved more because a lot of trains have the order to unload. (thats why i have only delivered 942.420 automobiles, i have fixed cargos unload stations at towns, but the autodealers are not fixed so sometimes a dealer is build into the catchment area of a cargo unload station and it accepts automobiles that are registered in this list)

[IANF]

i believe this bug is called "not everyone has a house in the city"
now sit and think about this

[nicholas51]

I have the money bug in all scenarios mainly in aircraft unbelievably even in Boulder Breakers bugs stations are large and have a more awkward for the list put a station on the side of oremine and had no load on the station does not pick up the load at all station was on the side of mine::