Page 1 of 3

Currency fix

Posted: 17 Aug 2004 13:56
by ChrisCF
Reposted here so it doesn't get lost.

* Adds comments for the currencies that weren't previously commented
* Replaces ugly ISO-isms with more familiar symbols
* Uses less foreign-looking exchange rates

Known issues:

* Lack of support for Greek characters means that Drachmae are listed as "Dr." instead of "Δρ." or "₯"
* The various Francs are listed as per French order, with F first
* The different Kronor are all listed as 'kr' - though the difference in value is minimal
* Forint and zloty have Euro introduction dates after 2002, these may need to be accommodated elsewhere

This is the same version as is currently on the SF tracker

Posted: 20 Aug 2004 23:36
by ChrisCF
Bump. Any thoughts?

Posted: 21 Aug 2004 06:13
by dominik81
How about asking people that use those currencies which abbreviation they like better? No one complained about their currecy symbols yet... And I agree that it would make sense to change the exchange rates.

Posted: 21 Aug 2004 14:38
by ChrisCF
For years, nobody complained about my local swimming pool. One day, someone found that the place was more-or-less about to fall down, so they closed it. The moral of the story: Just because nobody has complained, it does not mean that all is well.

I asked around quite a few people to see what they saw used in their countries (some people had to think back a bit). Not one person said they'd seen the ISO codes in general use within their countries, and suggested alternatives. The symbols in the patch are (mostly) the result of that (there are still a few which aren't certain, but it's better to be able to fix some than none). So, any chance of merging it in?

Posted: 21 Aug 2004 19:31
by dominik81
(Follow-up to this thread.)

We're about to make some currency changes, e.g. changing the exchange rates to some nicer, more rounded values. One of those changes will be to use real life abbreviations for currencies instead of ISO 4217 currency codes. An example: The international code for Deutsche Mark is DEM, but DM was used in Germany.

Please confirm the currency symbols used in your country.

List is constantly being updated.

Code: Select all

currency        | old | new

----------------------------
pound sterling  | £   | £    <- confirmed
us dollar       | $   | $    <- confirmed
euro            | €   | €    <- confirmed
franc - french  | FF  | FF
deutsche mark   | DM  | DM   <- confirmed
yen             | ¥   | ¥    <- confirmed
pesetas         | Pt  | Pts
forint          | Ft  | Ft   <- confirmed 
zloty           | zl  | zl   <- confirmed
schilling       | ATS | S.   <- confirmed
franc - belgium | BEF | BEF  <- both BF/FB used, probably better stick with ISO code
krone - denmark | kr  | kr   <- confirmed
markka          | FIM | MK   <- confirmed
drachma         | GRD | Dr.
franc - switss  | CHF | CHF  <- confirmed
gulden          | NLG | fl.  <- NLG prefered
lira            | ITL | L.   <- confirmed 
rouble          | rur | p    <- confirmed
koruna - czech  | Kc  | Kč   <- confirmed (change seperator to " ")
krona - iceland | kr  | Kr   <- confirmed
krone - norway  | kr  | Kr   <- confirmed 

Posted: 21 Aug 2004 22:13
by orudge
I thought ChrisCF had asked people from the various countries about it - at least, that's what I gathered from this quotation:
ChrisCF wrote:I asked around quite a few people to see what they saw used in their countries (some people had to think back a bit). Not one person said they'd seen the ISO codes in general use within their countries, and suggested alternatives.

Posted: 21 Aug 2004 22:52
by ChrisCF
dominik81 wrote:No offence, but you're not living in any of those countries whose currencies you corrected, right?
No offence, but neither do you, right? ;)
That's why I'd rather wanna hear someone who uses (or used to before the Euro) to hear their opinion.
OK, I've started to lose count of how many times I've said this to people, in public or otherwise, but I've already checked most of them. :roll:

From speaking to people, and from my own travels, the following have been confirmed and verified, and therefore are absolutely correct:

Code: Select all

currency        | symbol
----------------------------
sterling        | £
dollar USD      | $
franc FRF       | FF
mark            | DM
yen             | ¥
pesetas         | Pts
forint          | Ft
zloty           | zl
schilling       | S.
krone DKK       | kr
markka          | Mk
drachma         | Δρ. (Dr.) or ₯
guilder         | fl.
lira ITL        | ₤ or L.
krona SEK       | kr
rouble          | Р (R)
koruna CZK      | Kč
The following are confirmed, but not yet verified, so are probably correct:

Code: Select all

currency        | symbol
----------------------------
krona ISK       | kr
krona NOK       | kr
The following are not confirmed, and are possibly incorrect:

Code: Select all

currency        | old | new
----------------------------
franc - belgium | BEF | FB or BF
franc - swiss   | CHF | FS or SF

Posted: 21 Aug 2004 23:00
by mivlad
Rouble should be "p", not "P".

Posted: 21 Aug 2004 23:26
by Darkvater
In Holland we used "fl" a lot, but I'd much rather see NLG, since that was what it was used internationally.

Posted: 21 Aug 2004 23:33
by Korenn
Darkvater wrote:In Holland we used "fl" a lot, but I'd much rather see NLG, since that was what it was used internationally.
I second that.

Posted: 21 Aug 2004 23:54
by ChrisCF
The point of offering different currencies is that people can use their own currencies, and that each currency should be shown the way it would have been shown to people that used it, not on the international market. It kind of defeats the point of even having the different currencies otherwise ...

Posted: 22 Aug 2004 00:09
by dominik81
ChrisCF wrote:
dominik81 wrote:No offence, but you're not living in any of those countries whose currencies you corrected, right?
No offence, but neither do you, right? ;)
No, and that's why I'm not claiming that I know better what other people want. So let's keep this thread running for a while and see what they are suggesting. I'll update the list in my second post to reflect those suggestions.

And just to add to the confusion, here's a list of abbreviations for currencies on pre-Euro german magazine covers:

Code: Select all

currency        | symbol
----------------------------
pesetas         | Pta
schilling       | öS
franc - belgium | bfr
drachma         | DR
franc - switss  | sfr
guilder         | hfl
lira            | Lit
franc -luxemb.  | lfr
franc - french  | F

Posted: 22 Aug 2004 01:02
by ChrisCF
I would not call two votes representative of a whole nation ;)

and it's "fl" not "fL"

Posted: 22 Aug 2004 09:58
by fire87

Code: Select all

currency        | old | new
----------------------------
krone - norway  | kr  | kr
We norwegians use krone, not krona, we're not swedish
8)

Actually we still use the norwegian krone, and we'll not change to Euro at least before 2008 I think.. If we change..

Just an information :wink:

And it is Krone in Iceland too..

Posted: 22 Aug 2004 13:15
by lucaspiller
The currency here in the UK is either known as pounds or pound sterling, not just sterling.

Posted: 22 Aug 2004 14:53
by ChrisCF
"Sterling" is also used, and equally valid. And this notation is only for the table above, not for the game.

Having spoken to some more Dutch folk (including some actual Dutch i18n folk), the preferred term is prefixed "f." or "fl.", with postfixed "G" being slighlty less preferable.

Posted: 24 Aug 2004 13:13
by Hadez
I agree with Kc (or Kč), but " " num. separator is used in Czech republic, not ",". Could you fix it, please?

Posted: 24 Aug 2004 13:56
by Doc Oc
ChrisCF wrote:Having spoken to some more Dutch folk (including some actual Dutch i18n folk), the preferred term is prefixed "f." or "fl.", with postfixed "G" being slighlty less preferable.
True, except I've never seen "G" used anywhere at all. DFL was used in international banking, NLG was used in domestic banking. Price tags always used "f" or "fl".

I don't believe the translation "guilder" is correct either; I believe it's a failed attempt at english pronunciation gone out of control. In dutch the coin is called "gulden" which refers to gold, not to guilds. I'd just leave "gulden" untranslated in the language file.

Posted: 24 Aug 2004 18:47
by SuPr
Hadez wrote:I agree with Kc (or Kč), but " " num. separator is used in Czech republic, not ",". Could you fix it, please?
I submited patch on sf.net :)

Posted: 25 Aug 2004 06:40
by dominik81
SuPr wrote:I submited patch on sf.net :)
Please don't submit patches for those changes mentioned here. I'm collecting all those currency suggestions to make one big currency fix (along with ChrisCFs new exchange rates). So, any more suggestions for the list (in my second post)?