Page 10 of 10

Re: [patch] Realistic Train Shunting

Posted: 23 Nov 2018 15:53
by TrainLover
How probable would it be to get the realistic train shunting patch into a major patch pack, like JGR's?

Re: [patch] Realistic Train Shunting

Posted: 23 Nov 2018 21:58
by kamnet
TrainLover wrote:How probable would it be to get the realistic train shunting patch into a major patch pack, like JGR's?
Here's the answer from JGR himsef:
[b][url=https://www.tt-forums.net/viewtopic.php?p=1210152#p1210152]On July 23, 2018 JGR[/url][/b] wrote:
TrainLover wrote:What would be broken if you added the realistic shunting patch into this PatchPack?
I am keeping an eye on this patch, however it is not finished and not in a state where I would be inclined to consider looking into the feasibility of merging it.

If I were to merge it, I would not do so in a way that broke existing functionality.

Re: [patch] Realistic Train Shunting

Posted: 29 Nov 2018 22:07
by Jim Starluck
kamnet wrote:
TrainLover wrote:How probable would it be to get the realistic train shunting patch into a major patch pack, like JGR's?
Here's the answer from JGR himsef:
[b][url=https://www.tt-forums.net/viewtopic.php?p=1210152#p1210152]On July 23, 2018 JGR[/url][/b] wrote:
TrainLover wrote:What would be broken if you added the realistic shunting patch into this PatchPack?
I am keeping an eye on this patch, however it is not finished and not in a state where I would be inclined to consider looking into the feasibility of merging it.

If I were to merge it, I would not do so in a way that broke existing functionality.
Very good to hear. :D

Re: [patch] Realistic Train Shunting

Posted: 29 Nov 2018 22:21
by Eddi
you realize that post basically says "no"?

Re: [patch] Realistic Train Shunting

Posted: 30 Nov 2018 22:50
by Diesel Power
Eddi wrote:you realize that post basically says "no"?
Really?
I read it as "when it's ready".

Re: [patch] Realistic Train Shunting

Posted: 01 Dec 2018 01:12
by kamnet
Diesel Power wrote:
Eddi wrote:you realize that post basically says "no"?
Really?
I read it as "when it's ready".
And he might, but right now that day is a long way out, and Karn has acknowledged that this patch has a lot of things left to fix.

Re: [patch] Realistic Train Shunting

Posted: 01 Dec 2018 01:53
by wallyweb
kamnet wrote:
Diesel Power wrote:
Eddi wrote:you realize that post basically says "no"?
Really?
I read it as "when it's ready".
And he might, but right now that day is a long way out, and Karn has acknowledged that this patch has a lot of things left to fix.
The shunting works at an acceptable level. It's the known issues that are the challenge.

Re: [patch] Realistic Train Shunting

Posted: 25 Jan 2019 22:51
by kyosuke1989
Nice to see where this patch has evolved :) Thumbs up! Keep up the good work. :) It spices up the game nicely.

Re: [patch] Realistic Train Shunting

Posted: 15 May 2019 18:07
by danielkrs
hi! this patch is so mesmerizing :bow: ! But I have a problem with "critical failur" about the newgrf: 'CZTR RAILS 2.1.0'. Something about invalid ID (sprite 2032). I am uploading two screenshots for better understanding. Can you fix it? or may I go to CZTR forum first? thank you so much!
Image
Image

Re: [patch] Realistic Train Shunting

Posted: 16 May 2019 02:34
by kamnet
danielkrs wrote:hi! this patch is so mesmerizing :bow: ! But I have a problem with "critical failur" about the newgrf: 'CZTR RAILS 2.1.0'. Something about invalid ID (sprite 2032). I am uploading two screenshots for better understanding. Can you fix it? or may I go to CZTR forum first? thank you so much!
What version of OpenTTD did you apply this patch to?

Re: [patch] Realistic Train Shunting

Posted: 16 May 2019 04:18
by stefino_cz
danielkrs wrote:hi! this patch is so mesmerizing :bow: ! But I have a problem with "critical failur" about the newgrf: 'CZTR RAILS 2.1.0'. Something about invalid ID (sprite 2032). I am uploading two screenshots for better understanding. Can you fix it? or may I go to CZTR forum first? thank you so much!
You have to download version 1.9.0 or higher. You have old version which doesn't support more railtypes than 15 (or how many railtypes were in the previous version)

FYI bug

Posted: 16 May 2019 10:23
by SciFurz
Something I saw happening while testing shunting between two stations, the consist doesn't reverse at the end of a line and instead goes backwards from then on. If left alone it'll even become stuck at a station after 3 or so visits, on the order to visit the next.
It might have to do with the Dutch train set that I use by default but that set is too important for playing the game to do without.

I still have to finish details on my own real time patch though, otherwise I'd take a shot at tinkering with this patch and testing more thoroughly.

Re: [patch] Realistic Train Shunting

Posted: 20 May 2019 17:11
by danielkrs
kamnet wrote:
danielkrs wrote:hi! this patch is so mesmerizing :bow: ! But I have a problem with "critical failur" about the newgrf: 'CZTR RAILS 2.1.0'. Something about invalid ID (sprite 2032). I am uploading two screenshots for better understanding. Can you fix it? or may I go to CZTR forum first? thank you so much!
What version of OpenTTD did you apply this patch to?
At first I was download ottd 1.9.1. to my new OS and after that I looked for decouple patch, but I found only openttd_decouple_0.10.4_win32.zip file on this thread with another openttd.exe. I was download all of cztr grfs again and than I took the screenshot with failure info....
In the cztr facebook page somebody wrote that this patch is downloadable with older version of ottd. last changes was made in 2018...
maybe anybody can help how I can "extract" the patch to my openttd 1.9.1. or something?

Thank you

Re: [patch] Realistic Train Shunting

Posted: 21 May 2019 00:34
by kamnet
danielkrs wrote:
kamnet wrote:
danielkrs wrote:hi! this patch is so mesmerizing :bow: ! But I have a problem with "critical failur" about the newgrf: 'CZTR RAILS 2.1.0'. Something about invalid ID (sprite 2032). I am uploading two screenshots for better understanding. Can you fix it? or may I go to CZTR forum first? thank you so much!
What version of OpenTTD did you apply this patch to?
At first I was download ottd 1.9.1. to my new OS and after that I looked for decouple patch, but I found only openttd_decouple_0.10.4_win32.zip file on this thread with another openttd.exe. I was download all of cztr grfs again and than I took the screenshot with failure info....
In the cztr facebook page somebody wrote that this patch is downloadable with older version of ottd. last changes was made in 2018...
maybe anybody can help how I can "extract" the patch to my openttd 1.9.1. or something?

Thank you
A patch is C++ code which must be added to the OpenTTD source code and compiled. It may or may not require changes in order to successfully compile with the current master source code (which will be newer than OpenTTD 1.9.1).

Some thoughts

Posted: 11 Jun 2019 01:00
by SciFurz
Had some thoughts recently about this patch looking at it from the point of automating a sorting yard.
What would be needed is each wagon having a tag for the next hop destination and the ability for the locomotive to read that tag. That way the locomotive can couple a wagon, and depending on the next hop move to a specific waypoint and couple it to wagons with the same tag. Alternatively it's a next hop tag for the cargo. I haven't dug into that side of the code to see what's already available.
The conditional order then needs a list of train stations to choose from and a conditional order could be made that directs the main line coupling locomotive to head for the station tagged on the wagon/cargo.
Then there's also the possibility to sort by empty wagons or possible cargo type of a wagon to pick those up and deliver them to loading stations.

To avoid a train running in reverse because the coupling wasn't done from the side of the next destination (the first problem I ran into when testing the functionality), a way to check for that and reverse the whole train if necessary before the LEAVESTATION order.
To avoid a no power status, a check at decoupling to disable it.