Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Fri May 24, 2019 12:06 am

All times are UTC




Post new topic  Reply to topic  [ 599 posts ]  Go to page Previous 124 25 26 27 2830 Next
Author Message
 Post subject: Re: NotRoadTypes
PostPosted: Sun Apr 07, 2019 7:38 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
Our current thinking is to do away with RoadSubTypes, so all of the API changes have been reverted. There is now a RoadTypeList instead, and the ability to check if a RoadType is road or tram.

This is possible as there are now 63 road types rather than 15 road types. Road and tram types now share the same range, so there is a total of 63 road and tram types rather than 63 road, and 63 tram types. This minor reduction in types simplifies the code massively.

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sun Apr 07, 2019 8:30 pm 
Offline
Engineer
Engineer

Joined: Sat Jun 18, 2016 7:05 pm
Posts: 116
Has this fork been updated now so we have 63 roadtypes? Or is it now just possible?


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sun Apr 07, 2019 11:31 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
Er, it was updated a year ago for 63 road types... now it's changed internally so that road and tram types use up the same set of IDs to simplify things internally, which wasn't possible with only 15 types as that would be too restrictive.

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Mon Apr 08, 2019 10:23 am 
Offline
Traffic Manager
Traffic Manager
User avatar

Joined: Thu Jul 02, 2015 8:05 am
Posts: 186
Location: Czech Republic
I'm sorry for stupid question, but roadtypes are available in the basic game like railtypes? So can I code roadtypes in 1.9 version? Or is it only available in patched game?

I think that it is possible to have roadtypes only in patched game (because NRT is patch) but I'm little bit confused now.

Thanks, stefino

PS: What does the "fork" mean? Some adjustment for game engine?

_________________
Image


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Mon Apr 08, 2019 10:45 am 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Nov 27, 2004 3:05 pm
Posts: 5505
Location: Canada
stefino_cz wrote:
I'm sorry for stupid question, but roadtypes are available in the basic game like railtypes? So can I code roadtypes in 1.9 version? Or is it only available in patched game?

I think that it is possible to have roadtypes only in patched game (because NRT is patch) but I'm little bit confused now.

Thanks, stefino

PS: What does the "fork" mean? Some adjustment for game engine?

NRT is not a patch.
It is a fork.
A fork is a program that is based upon an original program but the fork includes changes that are not compatible with the original.
The hope is that once NRT's new code is seen to be stable, then it will be merged into OpenTTD.

DISCLAIMER: I stand to be corrected.

_________________
wallyweb on tt-forums: Screenshots - Projects - Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016 - January 2018 - December 2018


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Mon Apr 08, 2019 11:02 am 
Offline
Transport Coordinator
Transport Coordinator

Joined: Mon Oct 23, 2006 2:07 am
Posts: 357
Location: Berlin
Hello

stefino_cz wrote:
I'm sorry for stupid question, but roadtypes are available in the basic game like railtypes? So can I code roadtypes in 1.9 version? Or is it only available in patched game?

I think that it is possible to have roadtypes only in patched game (because NRT is patch) but I'm little bit confused now.

PS: What does the "fork" mean? Some adjustment for game engine?

The development of NRT is separated from OpenTTD with the fork. When it's ready it should get included into OpenTTD. So no, currently it is not part of the core.

Tschö, Auge

_________________
my Github account


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Mon Apr 08, 2019 3:42 pm 
Offline
Engineer
Engineer

Joined: Sat Jun 18, 2016 7:05 pm
Posts: 116
peter1138 wrote:
Er, it was updated a year ago for 63 road types...


How did I miss this?! Been having to choose which road grfs to use, not knowing i could use them all!


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sat Apr 13, 2019 7:58 am 
Offline
Engineer
Engineer

Joined: Sat Jun 18, 2016 7:05 pm
Posts: 116
andythenorth wrote:



I get that this is an experimental version and is WIP.
Just tried this and there's a few major bugs in it:

Towns are building haul roads.
The original roads have not been disabled by the grfs.
Non electric tramways display the cantanary from the original tramways.

Are these NRT issues or grf ones that need reporting to the authors?
I'm using:
Unspooled (full roster)
Docklands (chips and ISR)
Country roads (haul enabled)

Thanks


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sat Apr 13, 2019 12:47 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
Thanks for testing and reporting! This is how we get bugs fixed ;)

Actually, this is due to me removing electrified roads/non-electrified trams from the defaults (much earlier than removing roadsubtypes internally), therefore it is using the default flags of the default types. I will fix this by clearing the road type flags for new road/tram types.

I've just pushed with this change, and some deduplication efforts, if you could test please :-)

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sat Apr 13, 2019 1:53 pm 
Offline
Engineer
Engineer

Joined: Sat Jun 18, 2016 7:05 pm
Posts: 116
Will do. Download from the same link?


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sat Apr 13, 2019 2:51 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
Ah, I didn't realize there were precompiled NRT binaries! That one is kinda old already. If you self-built from the PR on github, you can do that again. If you used the precompiled build, then that has just been queued, so will take a little time.

EDIT: Website has been updated, new build at https://www.openttd.org/downloads/opent ... atest.html

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sat Apr 13, 2019 4:42 pm 
Offline
Route Supervisor
Route Supervisor
User avatar

Joined: Mon Dec 19, 2011 7:54 am
Posts: 471
Location: Washington State, USA
Ooh, new binaries! :D

Speaking of bugs, I just downloaded the latest build to test it out and the infinite money glitch is still a thing.

Also sort of related, the modified version of NML for NRT seems to have never been updated to include callbacks for tunnel sprites, or at least it claims not to recognize them. I know NML is a separate thing, but seeing as all existing NRT NewGRFs are made with it, it's worth mentioning that tunnel support is lacking :)

_________________
WSF Ferry Set [WIP] || American Road Replacement Set || NightGFX Base Graphics Set || Wasteland [WIP] || RattRoads (NRT Only) || American Bridge Replacement Set [WIP]


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Sat Apr 13, 2019 9:38 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
Ah, major bug with this version, loading savegames with trams will fail due to an initialization order mess up. Oddly, this order isn't anything I changed, so I'm not entirely sure how it used to work... :p

Fix has been pushed to the repo, but no build at the moment.

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Tue Apr 16, 2019 10:22 am 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
New build 20190416-pr6811-g43aab42a4c is published at https://www.openttd.org/downloads/opent ... atest.html

This fixes loading games with trams and also the money bug, and is otherwise also fully synced up with master.

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Tue Apr 16, 2019 12:01 pm 
Offline
Engineer
Engineer

Joined: Tue Oct 16, 2018 8:31 am
Posts: 58
Not loading previous NRT save files :( Crashing.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Tue Apr 16, 2019 12:30 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
How old is the savegame? NRT is not a patch pack and will only load NRT saves since the last savegame bump in unpatched master.

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Tue Apr 16, 2019 12:49 pm 
Offline
Engineer
Engineer

Joined: Tue Oct 16, 2018 8:31 am
Posts: 58
From last RATT build.
Never mind, it wasn't a long game. :)


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Wed Apr 17, 2019 9:26 am 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
AI docs updated at http://fuzzle.org/~petern/wip-nrt-aidoc ... _8hpp.html

Sorry for the false start with the last doc update. All the stuff to do with road sub types has been removed.

_________________
He's like, some kind of OpenTTD developer.


Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Wed Apr 17, 2019 5:26 pm 
Offline
Engineer
Engineer

Joined: Sat Jun 18, 2016 7:05 pm
Posts: 116
Now trying the latest build and there are still a few bugs.
In the screenshot below is a bugged rough tram line from Unspooled. It was built over a stone paved road but when the road was removed it looked like this.
You may also notice the the vanilla roads are also still available and have not been disabled.

I haven't been able to reproduce this bug outside of the save game with just the minimum grf's needed but i'm still working on it.
Bingo! it happens in the town zone where the roads have pavements but not trees.


Attachments:
The Snow Shifters, 21st Oct 1863.png [161.35 KiB]
Not downloaded yet
Top
   
 Post subject: Re: NotRoadTypes
PostPosted: Wed Apr 17, 2019 9:43 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Mar 30, 2005 9:43 am
Posts: 1644
Sorry, I can't guess what NewGRFs you have loaded and what order they are from a screenshot. Can you post the savegame please.

EDIT: Incorrect ground sprite for paved tram with no road has been fixed.

_________________
He's like, some kind of OpenTTD developer.


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 599 posts ]  Go to page Previous 124 25 26 27 2830 Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000-2019 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2019.
Hosted by Zernebok Hosting.