It doesn't solve the problem. The problem is that in your patchpack, right click always closes window even when it's in a zone where right click has meaning and defined for window. Tested with official 1.8, it doesn't close window when clicked on vehicle in depot or on map area in map view.
Sorry but I cannot confirm this. There is a setting for this and I have it deactivated because I don't like that either. it doesn't do that when it's off. I play with this version myself regularly, that doesn't happen. You need to turn that off in the interface settings.
In your patchpack, tooltip shows on industries and every house which is inconvenient.
Then JGR didn't import that patch in its full form. There was a patch adding a lot more tooltips to the map. I like it since it always shows me the town and population when I'm playing with the town names off (which I often do). I MIGHT look into making interface settings for all types of tooltips, but it's not a priority. But I'll keep it in mind. There's one thing I might soon create a setting for anyway, so I'll add it if I have the time.
Sorry I should have mentioned it first, I checked income with day length 1 in both cases, with identical game settings and newgrfs.
I also checked the same route in official 1.8, it gives 88 per trip. That means income is calculated differently (for times less in this case) in you patchpack than in official version or JGR. Unfortunately, I could not find any information on changed cargo income and how new formulas work on the first page of this thread.
As I said I adjusted cargo income. I can't tell you exactly what I changed since it was over a year ago I think, but it doesn't work as in vanilla, but it works for me. It's different on purpose. THere was a bug in the cargo calculation in vanilla that made very long distances lose money while paying too much for short distances. The cargo income is totally different now but it works fine. If you feel you get way too little money I'd suggest adding a base cost adjustment newgrf that lowers your costs to compensate. But this is not something I'll change or even offer a setting for since the original code was simply a bug.
I don't know if JGR fixed that or fixed it differently, but I found something that works fine for me. So if that bothers you very much then unfortunately my version might not be for you. As I said I'm aware my version works differently and it does so intentionally. I do not consider it unbalanced. I played tons of games with this version and it's still incredibly easy to make money.
Please consider adding build and refit option in some way, I'm sure it will make many players happy.
I'll consider it next time I'm working on the code. For now I won't do that for a while again since I need to work on other stuff for my youtube channel again which I neglected to work on these last few versions.
What I was suggesting actually is that if you change some text in English, replace corresponding texts in other languages to the same English string, it will help people see that something was changed but not translated (yet), and it will help translators to find and translate new things.
The game displays text in English if it can't find a translation for it. Every string I add that doesn't exist in vanilla yet obviously won't find a translation so it displays the English standard by default. The game WOULD pick a translation if one existed. That works the same for all text in the game. There's a ton of translators working on every version of Vanilla to offer translations for new stuff. I don't have those people so most of my features are English only. I don't consider this a major problem since I personally consider English to be a language you should be able to speak nowadays or you miss 90% of what's going on in the world. If someone wants to offer me a translated language file I'll be more than happy to include it.
Sorry I didn't know it was only for a closed group of dedicated players, I was under impression you offered your work for all OTTD folks to play and bring some feedback.
It's not for a closed group. I just need people to understand that this was never meant for ANYBODY but myself. This was not planned or ever maintained as a public patch pack. This is for me and me alone primarily. People asked me to share it so I do, but that doesn't mean I accept demands or feature requests. I accept suggestions and I will implement them if I personally consider them worth it and if they will improve MY fun with the game.
This is a personal version of the game that I share because people asked. That means what OTHER people want in the game is very very very low on my list. I don't have a lot of work at all to work on this, so I usually only work on it when I feel I want something in the game.
That's the basis everybody needs to understand when using my version. I have no issues with someone using it and suggesting stuff but if I don't want something in it then it won't go in it. if I personally don't consider something worth the time and effort (like so far build a refit.. I simply don't need it that much), then it probably won't happen for a while or ever.
That's why I honestly think if people want a patch pack that offers support and maintenance and build for all platforms and all that kinds of stuff, JGR might be the better option. JGR has WAY more time to work on this, probably has some infrastructure in place to test-compile on all platforms and all that kind of Jazz. I don't have that nor will I. I don't have a mac or linux so I don't care if it compiles there. I don't carea if some outdated compiler doesn't support some C++ feature I use either. If it compiles in my Visual Studio then I'm fine. That's the difference. The version I upload is compiled on my home computer. I don't use a compile farm or produce nightly builds or anything like what I'd have in place for any professional project.
And this missunderstanding is exactly why I originally hesitated to make this public AT ALL. Some people will not like what I add to the game because they play differently and will ask me to change it, remove it or make it optional. Not gonna happen, unless I really feel like it. I work on this for me and me alone and it's shared because others wanted me to. But that does NOT mean I'll add stuff to this version because someone ELSE wants it unless it's a friend or someone I want to do a favor for.
Suggestions are always welcome because they might introduce me to features I consider fun and hadn't heard about yet. But keep in mind that if I don't consider it fun, it probably won't be in the game. At least not in this version.
If you can't compiler it on mac.. that's your problem, that's why it's open source. Same for linux. I don't use it, so I don't care. I do NOT approach this like a professional project since I simply don't have the spare time to put that much work into setting all that up and maintaining multiple compiler chains and all that. I don't consider fixing bugs on a platform I don't use fun and I only do that kind of work for stuff I'm paid for. If someone else fixes it and gives me a pull request I'll of course include it, but I won't work on that myself.
This is not meant to sound pissy, I just feel I need to make this perfectly clear since a lot of people don't understand what this is. I do NOT work on matching anybody's code style, I write code the way I can read it best. I do NOT care about other compilers or platforms because I don't use them, I do NOT care about Vanilla compatibility beyond savegame loading which I only do because it's easy to do. I do NOT care about features being super polished or perfect as long as they work and are bug free and fun for me personally. I do NOT care much about translations since I play in English (even though I'm German, there's no German translation either since I simply would never see it, so why double my work in that area).
This is what people need to understand when using my version and I tried making that clear right from the start.