Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Thu Nov 15, 2018 3:47 pm

All times are UTC




Post new topic  Reply to topic  [ 85 posts ]  Go to page Previous 1 2 3 4 5 Next
Author Message
PostPosted: Tue Jun 14, 2016 9:12 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Tue Oct 20, 2015 7:05 pm
Posts: 231
Yes, sorry! I forgot to put it in there but I am running Lt. Joker's patch V 1.4.1


Top
   
PostPosted: Wed Jun 15, 2016 12:11 am 
Offline
President
President
User avatar

Joined: Tue Nov 23, 2010 9:25 pm
Posts: 958
Location: ::1
Posting the question in the patch's own thread might get a better response. Also, posting the save file that's giving you grief might help whoever is trying to help.


Top
   
PostPosted: Wed Jun 15, 2016 5:29 am 
Offline
Traffic Manager
Traffic Manager

Joined: Tue Oct 20, 2015 7:05 pm
Posts: 231
Quote:
Also, posting the save file that's giving you grief might help whoever is trying to help.

I can't get to my computer now so I shall do so later


Top
   
PostPosted: Wed Jun 15, 2016 7:20 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Tue Oct 20, 2015 7:05 pm
Posts: 231
Below I have attached 2 save games, the former is the emergency crash save (29th December 1956) and the later is the last, untouched save I made (18th August 1953)

Please note that you will need Joker's patch to run these save games and I also use a lot of NewGRFs.


Attachments:
File comment: Emergency Crash save (29th December 1956)
crash.sav [412.19 KiB]
Downloaded 38 times
File comment: 18th August 1953
Green & Co., 18th Aug 1953.sav [398.56 KiB]
Downloaded 50 times
Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Thu Jun 16, 2016 10:55 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Tue Oct 20, 2015 7:05 pm
Posts: 231
I have gone back to my last save and played from there onwards (and past the crash date) so I think we should leave it here. Thanks for all your help.


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Fri Jul 08, 2016 4:39 pm 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274
You probably saved a game with a version that had a problematic bug regarding certain signal types. I fixed the bug but that unfortunately meant those problematic savegames cannot be loaded. I had the same issue myself with some savegames. Don't worry, your new savegames will always work.


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Tue Sep 27, 2016 6:58 pm 
Offline
Engineer
Engineer

Joined: Fri Oct 11, 2013 11:20 pm
Posts: 16
Hi, has anyone been succesfull on compiling Jokers patch pack for linux?

Im a complete beginner on compiling !


Thanks!!


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Wed Sep 28, 2016 7:46 am 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Sun Sep 09, 2007 5:03 am
Posts: 4677
Location: home
gabrielbyrnei wrote:
Hi, has anyone been succesfull on compiling Jokers patch pack for linux?
If you want actual help with the process rather than a "yes/no" answer which you seem to ask for currently, post more details.
In particular, post ./configure output, and error messages of the compiler (where the first ones are most interesting, beyond a page or so, it's just repeating the same problem for other files (and since we have around 300 files, that can be a lot of output), or a compiler hopelessly lost but still trying to make sense of the source code.

Edit: It is usually a good idea to first do a compilation with the unpatched source. Once that compiles, apply the patch, and build the patched version.
In that way, it is easier to pinpoint the source of an error.

_________________
Being a OpenTTD developer does not mean I know what I am doing.
Also, other OpenTTD developers may have different opinions.


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Mon Jul 03, 2017 6:52 am 
Offline
Engineer
Engineer

Joined: Mon Jul 03, 2017 6:46 am
Posts: 1
I've fixed compiling the Patch Pack on Linux. I haven't had a chance to play-test it thoroughly, but I also fixed a few crashes along the way.

Attached below is the combined patch. I've sent a pull request as well.

Attachment:
File comment: Linux compile fixes and a few crash fixes.
linux-fixes.patch [6.04 KiB]
Downloaded 42 times


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Tue Sep 12, 2017 8:27 pm 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274
Got the "multiple docks per station" thing finally extracted out of other code. It's a separate branch on my github. I'm pretty sure I got all the bugs dealt with. Seems to work just fine.
So if anyone want to integrate it into their own patchpack or try to turn it into a single patch, it's just 2-3 commits on that branch, so it should be easy enough to figure out.
Sorry I can't provide a patch file since I applied it to MY codebase, not trunk but I think there shouldn't be too many differences,
so maybe someone can apply the changes to trunk and turn it into a patch that can then end up in trunk at some point.

If anybody finds a bug, tell me on github or one of my videos, not here, I check this too irregularly.

@JGR, if you integrate this in your codebase (maybe you already have I don't know), and you find way to improve it, I'd appreciate pull requests so I can integrate those in my version too, thanks :) I also shamelessly stole your integration and improvements to the "cargo based load orders" ;) Thanks for those.


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Wed Sep 13, 2017 11:52 am 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274
River creation improved. No more crazy lakes in the middle of nowhere and wide rivers work properly.


Attachments:
Unnamed, 1st Jan 1950#1.png [311.62 KiB]
Not downloaded yet
Unnamed, 1st Jan 1950.png [366.47 KiB]
Not downloaded yet
Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Sat Sep 16, 2017 8:55 am 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1847
Location: Ipswich
KeldorKatarn wrote:
Got the "multiple docks per station" thing finally extracted out of other code. It's a separate branch on my github. I'm pretty sure I got all the bugs dealt with. Seems to work just fine.
So if anyone want to integrate it into their own patchpack or try to turn it into a single patch, it's just 2-3 commits on that branch, so it should be easy enough to figure out.
Sorry I can't provide a patch file since I applied it to MY codebase, not trunk but I think there shouldn't be too many differences,
so maybe someone can apply the changes to trunk and turn it into a patch that can then end up in trunk at some point.

If anybody finds a bug, tell me on github or one of my videos, not here, I check this too irregularly.

@JGR, if you integrate this in your codebase (maybe you already have I don't know), and you find way to improve it, I'd appreciate pull requests so I can integrate those in my version too, thanks :) I also shamelessly stole your integration and improvements to the "cargo based load orders" ;) Thanks for those.

I don't have any multiple-dock support at the moment, but I'd support adding it to my patchpack.
I'll take a look at the code soon, thanks for your work on this.
Using the cargo based load order code is no problem at all, glad to hear that it came in handy :).

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Sat Sep 16, 2017 5:57 pm 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274
Yeah I don't think i'll use it much in my current series with ECS but for FIRS with all the supplies I think it can be very very useful. You can send trains with supplies to the industries and then take the resources with you on the back trip. Even with CargoDist that usually doesn't work as it's supposed to, Cargodist starts using the industries as distribution hubs for supplies :P
The cargo load orders should fix that :)


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Mon Sep 18, 2017 4:05 am 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274
Public roads creation now supported in the latest version. Check the thread about it for details.

Attachment:
Unnamed, 1st Jan 2040#2.png [421.64 KiB]
Not downloaded yet


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Mon Oct 16, 2017 6:15 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Jan 18, 2014 6:10 pm
Posts: 1083
While trying to compile source copied from github, I got this (linux make):
Code:
/src/pathfinder/npf/aystar.h:69:50: error: invalid use of incomplete type ‘struct std::hash<Trackdir>’
   return std::hash<T>()(x.first) ^ std::hash<U>()(x.second);


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Thu Mar 22, 2018 10:00 pm 
Offline
Engineer
Engineer
User avatar

Joined: Sun Mar 07, 2004 10:34 am
Posts: 26
Skype: daccus
Location: Berlin, DE, EU
Compiling this on my OSX setup fails.
What I did was download as zip, unpack the zip, go to the directory in the terminal, say
./configure
make

The compilation failed, with this in the end:

Code:
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:19: error: 
      no member named 'tuple' in namespace 'std'
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                    ~~~~~^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:25: error:
      'Industry' does not refer to a value
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                               ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/industry.h:39:8: note:
      declared here
struct Industry : IndustryPool::PoolItem<&_industry_pool> {
       ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:34: error:
      expected expression
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                                        ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:48: error:
      expected unqualified-id
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                                                      ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:3: error:
      use of undeclared identifier 'accepting_industries'
                accepting_industries.push_back(std::tuple<Industry*, uin...
                ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:39: error:
      no member named 'tuple' in namespace 'std'
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                               ~~~~~^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:45: error:
      'Industry' does not refer to a value
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                                          ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/industry.h:39:8: note:
      declared here
struct Industry : IndustryPool::PoolItem<&_industry_pool> {
       ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:54: error:
      expected expression
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                                                   ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:56: error:
      unexpected type name 'uint': expected expression
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                                                     ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:66: error:
      expected '(' for function-style cast or type construction
  ...accepting_industries.push_back(std::tuple<Industry*, uint, bool>(ind, ca...
                                                                ~~~~^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:68: warning:
      expression result unused [-Wunused-value]
  ...accepting_industries.push_back(std::tuple<Industry*, uint, bool>(ind, ca...
                                                                      ^~~
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:73: warning:
      expression result unused [-Wunused-value]
  ...uint, bool>(ind, cargo_index, true));
                      ^~~~~~~~~~~
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1103:38: error:
      use of undeclared identifier 'accepting_industries'
        int num_accepting_industries = (int)accepting_industries.size();
                                            ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1109:19: error:
      use of undeclared identifier 'accepting_industries'
                if (std::get<2>(accepting_industries[ind_index])) {
                                ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1110:32: error:
      use of undeclared identifier 'accepting_industries'
                        Industry* ind = std::get<0>(accepting_industries...
                                                    ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1111:35: error:
      use of undeclared identifier 'accepting_industries'
                        uint cargo_index = std::get<1>(accepting_industr...
                                                       ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1115:17: error:
      use of undeclared identifier 'accepting_industries'
                                std::get<2>(accepting_industries[ind_ind...
                                            ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1126:31: error:
      use of undeclared identifier 'accepting_industries'
                ind_index = (++ind_index) % accepting_industries.size();
                                            ^
5 warnings and 16 errors generated.
make[1]: *** [economy.o] Error 1
make: *** [all] Error 1
Tuukkas-Mini:OpenTTD_PatchPack-master_joker tuuktuuk$ 8~


I can't really understand why tuples wouldn't exist... It's a very basic thing. Any help? :)
The whole pile of output can be found here: https://pastebin.com/TtN2Wfbs .
I did the downloading of the zip by going to https://github.com/KeldorKatarn/OpenTTD_PatchPack , then clicking the green [Clone or download] button and then choosing "Download ZIP".
I didn't make any other choices on the site; f.ex. the "branch" menu remains at master_joker.

_________________
Where have my euro notes travelled? *click* http://eurobilltracker.eu/
Hmm..?! From Portugal to Finland?
See it for yourself!


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Fri Mar 23, 2018 2:22 pm 
Offline
Engineer
Engineer

Joined: Wed Mar 07, 2018 5:00 pm
Posts: 53
A crash occured after unpausing a freshly generated game.
Edit: It seems the game crashes if the SPI 1.32 grf is loaded. Any other industry grf (FIRS 1.4.4M, 2.1.5, 3.0.5 aswell as ECS Vectors) works fine, furthermore SPI works in JGRPP 0.23.0 and OpenTTD 1.7.2. The only issue is SPI being loaded in Joker's Patck Pack v1.18.12.


Attachments:
crash.dmp [13.14 MiB]
Downloaded 24 times
crash.sav [138.97 KiB]
Downloaded 17 times
Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Tue Mar 27, 2018 7:20 am 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274
I'll look into it when I get the chance.


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Thu Mar 29, 2018 5:29 pm 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274
Edit: Don't know why this happens, but should be fixed now.


Top
   
 Post subject: Re: Joker's Patch Pack
PostPosted: Tue Apr 03, 2018 8:18 pm 
Offline
Transport Coordinator
Transport Coordinator

Joined: Tue Apr 13, 2010 9:31 pm
Posts: 274


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 85 posts ]  Go to page Previous 1 2 3 4 5 Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 7 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000-2018 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2018.
Hosted by Zernebok Hosting.