Joker's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Translink
Traffic Manager
Traffic Manager
Posts: 231
Joined: 20 Oct 2015 19:05

Re: Unknown Cause of Crash

Post by Translink » 14 Jun 2016 21:12

Yes, sorry! I forgot to put it in there but I am running Lt. Joker's patch V 1.4.1

User avatar
Sylf
President
President
Posts: 958
Joined: 23 Nov 2010 21:25
Location: ::1

Re: Unknown Cause of Crash

Post by Sylf » 15 Jun 2016 00:11

Posting the question in the patch's own thread might get a better response. Also, posting the save file that's giving you grief might help whoever is trying to help.

Translink
Traffic Manager
Traffic Manager
Posts: 231
Joined: 20 Oct 2015 19:05

Re: Unknown Cause of Crash

Post by Translink » 15 Jun 2016 05:29

Also, posting the save file that's giving you grief might help whoever is trying to help.
I can't get to my computer now so I shall do so later

Translink
Traffic Manager
Traffic Manager
Posts: 231
Joined: 20 Oct 2015 19:05

Re: Unknown Cause of Crash

Post by Translink » 15 Jun 2016 19:20

Below I have attached 2 save games, the former is the emergency crash save (29th December 1956) and the later is the last, untouched save I made (18th August 1953)

Please note that you will need Joker's patch to run these save games and I also use a lot of NewGRFs.
Attachments
crash.sav
Emergency Crash save (29th December 1956)
(412.19 KiB) Downloaded 47 times
Green & Co., 18th Aug 1953.sav
18th August 1953
(398.56 KiB) Downloaded 61 times

Translink
Traffic Manager
Traffic Manager
Posts: 231
Joined: 20 Oct 2015 19:05

Re: Joker's Patch Pack

Post by Translink » 16 Jun 2016 22:55

I have gone back to my last save and played from there onwards (and past the crash date) so I think we should leave it here. Thanks for all your help.

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 08 Jul 2016 16:39

You probably saved a game with a version that had a problematic bug regarding certain signal types. I fixed the bug but that unfortunately meant those problematic savegames cannot be loaded. I had the same issue myself with some savegames. Don't worry, your new savegames will always work.

gabrielbyrnei
Engineer
Engineer
Posts: 16
Joined: 11 Oct 2013 23:20

Re: Joker's Patch Pack

Post by gabrielbyrnei » 27 Sep 2016 18:58

Hi, has anyone been succesfull on compiling Jokers patch pack for linux?

Im a complete beginner on compiling !


Thanks!!

Alberth
OpenTTD Developer
OpenTTD Developer
Posts: 4718
Joined: 09 Sep 2007 05:03
Location: home

Re: Joker's Patch Pack

Post by Alberth » 28 Sep 2016 07:46

gabrielbyrnei wrote:Hi, has anyone been succesfull on compiling Jokers patch pack for linux?
If you want actual help with the process rather than a "yes/no" answer which you seem to ask for currently, post more details.
In particular, post ./configure output, and error messages of the compiler (where the first ones are most interesting, beyond a page or so, it's just repeating the same problem for other files (and since we have around 300 files, that can be a lot of output), or a compiler hopelessly lost but still trying to make sense of the source code.

Edit: It is usually a good idea to first do a compilation with the unpatched source. Once that compiles, apply the patch, and build the patched version.
In that way, it is easier to pinpoint the source of an error.
Being a OpenTTD developer does not mean I know what I am doing.
Also, other OpenTTD developers may have different opinions.

TehKittyCat
Engineer
Engineer
Posts: 1
Joined: 03 Jul 2017 06:46

Re: Joker's Patch Pack

Post by TehKittyCat » 03 Jul 2017 06:52

I've fixed compiling the Patch Pack on Linux. I haven't had a chance to play-test it thoroughly, but I also fixed a few crashes along the way.

Attached below is the combined patch. I've sent a pull request as well.
linux-fixes.patch
Linux compile fixes and a few crash fixes.
(6.04 KiB) Downloaded 53 times

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 12 Sep 2017 20:27

Got the "multiple docks per station" thing finally extracted out of other code. It's a separate branch on my github. I'm pretty sure I got all the bugs dealt with. Seems to work just fine.
So if anyone want to integrate it into their own patchpack or try to turn it into a single patch, it's just 2-3 commits on that branch, so it should be easy enough to figure out.
Sorry I can't provide a patch file since I applied it to MY codebase, not trunk but I think there shouldn't be too many differences,
so maybe someone can apply the changes to trunk and turn it into a patch that can then end up in trunk at some point.

If anybody finds a bug, tell me on github or one of my videos, not here, I check this too irregularly.

@JGR, if you integrate this in your codebase (maybe you already have I don't know), and you find way to improve it, I'd appreciate pull requests so I can integrate those in my version too, thanks :) I also shamelessly stole your integration and improvements to the "cargo based load orders" ;) Thanks for those.

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 13 Sep 2017 11:52

River creation improved. No more crazy lakes in the middle of nowhere and wide rivers work properly.
Attachments
Unnamed, 1st Jan 1950#1.png
(311.62 KiB) Not downloaded yet
Unnamed, 1st Jan 1950.png
(366.47 KiB) Not downloaded yet

User avatar
JGR
Tycoon
Tycoon
Posts: 1935
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: Joker's Patch Pack

Post by JGR » 16 Sep 2017 08:55

KeldorKatarn wrote:Got the "multiple docks per station" thing finally extracted out of other code. It's a separate branch on my github. I'm pretty sure I got all the bugs dealt with. Seems to work just fine.
So if anyone want to integrate it into their own patchpack or try to turn it into a single patch, it's just 2-3 commits on that branch, so it should be easy enough to figure out.
Sorry I can't provide a patch file since I applied it to MY codebase, not trunk but I think there shouldn't be too many differences,
so maybe someone can apply the changes to trunk and turn it into a patch that can then end up in trunk at some point.

If anybody finds a bug, tell me on github or one of my videos, not here, I check this too irregularly.

@JGR, if you integrate this in your codebase (maybe you already have I don't know), and you find way to improve it, I'd appreciate pull requests so I can integrate those in my version too, thanks :) I also shamelessly stole your integration and improvements to the "cargo based load orders" ;) Thanks for those.
I don't have any multiple-dock support at the moment, but I'd support adding it to my patchpack.
I'll take a look at the code soon, thanks for your work on this.
Using the cargo based load order code is no problem at all, glad to hear that it came in handy :).
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Dad-Coder since April 2018

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 16 Sep 2017 17:57

Yeah I don't think i'll use it much in my current series with ECS but for FIRS with all the supplies I think it can be very very useful. You can send trains with supplies to the industries and then take the resources with you on the back trip. Even with CargoDist that usually doesn't work as it's supposed to, Cargodist starts using the industries as distribution hubs for supplies :P
The cargo load orders should fix that :)

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 18 Sep 2017 04:05

Public roads creation now supported in the latest version. Check the thread about it for details.
Unnamed, 1st Jan 2040#2.png
(421.64 KiB) Not downloaded yet

McZapkie
Tycoon
Tycoon
Posts: 1175
Joined: 18 Jan 2014 18:10

Re: Joker's Patch Pack

Post by McZapkie » 16 Oct 2017 18:15

While trying to compile source copied from github, I got this (linux make):

Code: Select all

/src/pathfinder/npf/aystar.h:69:50: error: invalid use of incomplete type ‘struct std::hash<Trackdir>’
   return std::hash<T>()(x.first) ^ std::hash<U>()(x.second);

Dakkus
Engineer
Engineer
Posts: 26
Joined: 07 Mar 2004 10:34
Skype: daccus
Location: Berlin, DE, EU
Contact:

Re: Joker's Patch Pack

Post by Dakkus » 22 Mar 2018 22:00

Compiling this on my OSX setup fails.
What I did was download as zip, unpack the zip, go to the directory in the terminal, say
./configure
make

The compilation failed, with this in the end:

Code: Select all

/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:19: error: 
      no member named 'tuple' in namespace 'std'
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                    ~~~~~^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:25: error: 
      'Industry' does not refer to a value
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                               ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/industry.h:39:8: note: 
      declared here
struct Industry : IndustryPool::PoolItem<&_industry_pool> {
       ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:34: error: 
      expected expression
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                                        ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1081:48: error: 
      expected unqualified-id
        std::vector<std::tuple<Industry*, uint, bool> > accepting_industries;
                                                      ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:3: error: 
      use of undeclared identifier 'accepting_industries'
                accepting_industries.push_back(std::tuple<Industry*, uin...
                ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:39: error: 
      no member named 'tuple' in namespace 'std'
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                               ~~~~~^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:45: error: 
      'Industry' does not refer to a value
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                                          ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/industry.h:39:8: note: 
      declared here
struct Industry : IndustryPool::PoolItem<&_industry_pool> {
       ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:54: error: 
      expected expression
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                                                   ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:56: error: 
      unexpected type name 'uint': expected expression
                accepting_industries.push_back(std::tuple<Industry*, uin...
                                                                     ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:66: error: 
      expected '(' for function-style cast or type construction
  ...accepting_industries.push_back(std::tuple<Industry*, uint, bool>(ind, ca...
                                                                ~~~~^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:68: warning: 
      expression result unused [-Wunused-value]
  ...accepting_industries.push_back(std::tuple<Industry*, uint, bool>(ind, ca...
                                                                      ^~~
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1100:73: warning: 
      expression result unused [-Wunused-value]
  ...uint, bool>(ind, cargo_index, true));
                      ^~~~~~~~~~~
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1103:38: error: 
      use of undeclared identifier 'accepting_industries'
        int num_accepting_industries = (int)accepting_industries.size();
                                            ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1109:19: error: 
      use of undeclared identifier 'accepting_industries'
                if (std::get<2>(accepting_industries[ind_index])) {
                                ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1110:32: error: 
      use of undeclared identifier 'accepting_industries'
                        Industry* ind = std::get<0>(accepting_industries...
                                                    ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1111:35: error: 
      use of undeclared identifier 'accepting_industries'
                        uint cargo_index = std::get<1>(accepting_industr...
                                                       ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1115:17: error: 
      use of undeclared identifier 'accepting_industries'
                                std::get<2>(accepting_industries[ind_ind...
                                            ^
/Users/tuuktuuk/Downloads/ottd/OpenTTD_PatchPack-master_joker/src/economy.cpp:1126:31: error: 
      use of undeclared identifier 'accepting_industries'
                ind_index = (++ind_index) % accepting_industries.size();
                                            ^
5 warnings and 16 errors generated.
make[1]: *** [economy.o] Error 1
make: *** [all] Error 1
Tuukkas-Mini:OpenTTD_PatchPack-master_joker tuuktuuk$ 8~
I can't really understand why tuples wouldn't exist... It's a very basic thing. Any help? :)
The whole pile of output can be found here: https://pastebin.com/TtN2Wfbs .
I did the downloading of the zip by going to https://github.com/KeldorKatarn/OpenTTD_PatchPack , then clicking the green [Clone or download] button and then choosing "Download ZIP".
I didn't make any other choices on the site; f.ex. the "branch" menu remains at master_joker.
Where have my euro notes travelled? *click* http://eurobilltracker.eu/
Hmm..?! From Portugal to Finland?
See it for yourself!

vrn
Engineer
Engineer
Posts: 62
Joined: 07 Mar 2018 17:00

Re: Joker's Patch Pack

Post by vrn » 23 Mar 2018 14:22

A crash occured after unpausing a freshly generated game.
Edit: It seems the game crashes if the SPI 1.32 grf is loaded. Any other industry grf (FIRS 1.4.4M, 2.1.5, 3.0.5 aswell as ECS Vectors) works fine, furthermore SPI works in JGRPP 0.23.0 and OpenTTD 1.7.2. The only issue is SPI being loaded in Joker's Patck Pack v1.18.12.
Attachments
crash.dmp
(13.14 MiB) Downloaded 37 times
crash.sav
(138.97 KiB) Downloaded 29 times

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 27 Mar 2018 07:20

I'll look into it when I get the chance.

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 29 Mar 2018 17:29

Edit: Don't know why this happens, but should be fixed now.

KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: Joker's Patch Pack

Post by KeldorKatarn » 03 Apr 2018 20:18


Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 5 guests