JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
JGR
Tycoon
Tycoon
Posts: 2120
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Diesel Power wrote:
08 Aug 2020 22:34
Found a bug with the "load/unload by cargo type" menu. if you are using a GRF with a large amount of cargos, the list goes off the bottom of the screen and you can't select the ones at the bottom. See screen shot, there is one more cargo off the bottom. (ignore the the undefined strings, this is a bug with another GRF).
dasy2k1 wrote:
18 Aug 2020 18:06
Timetable based separation suggestion

posting this here because the original patch thread seems to be dead.
i would love it if there was a setting in the timetable based separation that basically ignores the wait time if the load is 100%.
These are implemented now, they'll be in the next release.
Ex TTDPatch Coder
Patch Pack, Github
Dad-Coder since April 2018

Avatar by MoonsongWolf

Diesel Power
Traffic Manager
Traffic Manager
Posts: 220
Joined: 18 Jun 2016 19:05

Re: JGR's Patch Pack

Post by Diesel Power »

Good work 👍🏻
I'm getting a lot of lag with 35.1. Haven't noticed it this bad with previous releases. Every few minutes the game freezes for a few seconds and seems to get worse the longer I play. I've tried to reduce the calculation times in cargo dist but it hasn't made any difference. Any other ideas?

User avatar
JGR
Tycoon
Tycoon
Posts: 2120
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Diesel Power wrote:
21 Aug 2020 22:53
Good work 👍🏻
I'm getting a lot of lag with 35.1. Haven't noticed it this bad with previous releases. Every few minutes the game freezes for a few seconds and seems to get worse the longer I play. I've tried to reduce the calculation times in cargo dist but it hasn't made any difference. Any other ideas?
If you can post a savegame I can take a look.
Ex TTDPatch Coder
Patch Pack, Github
Dad-Coder since April 2018

Avatar by MoonsongWolf

Diesel Power
Traffic Manager
Traffic Manager
Posts: 220
Joined: 18 Jun 2016 19:05

Re: JGR's Patch Pack

Post by Diesel Power »

Here you go...
Attachments
Steel.sav
(1.85 MiB) Downloaded 14 times

User avatar
JGR
Tycoon
Tycoon
Posts: 2120
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Diesel Power wrote:
24 Aug 2020 05:05
Here you go...
The problem is caused by the large number of refit orders, especially refit to any available cargo.
This interacts poorly with cargodist, in that it needs to estimate the link capacity for all 64 cargoes.
In particular this involves querying the GRF for the refitted capacity for each cargo for each vehicle at each refit order.
Refreshing the link capacities and checking for stale links generates a large number of such operations, and as GRF operations are very slow, this creates a noticeable pause.

I can probably optimise this a bit, but in general using both cargodist and refit to any available cargo is problematic.
Ex TTDPatch Coder
Patch Pack, Github
Dad-Coder since April 2018

Avatar by MoonsongWolf

User avatar
piratescooby
Transport Coordinator
Transport Coordinator
Posts: 349
Joined: 21 Nov 2014 12:39
Location: The Granite City.

Re: JGR's Patch Pack

Post by piratescooby »

I'm not sure if it is my computer or the latest nightly 804/821 that has the lag , I'm referring to the previous post , when I run a game on 1.10.3 it is ok , your latest and nightly has a lag .

User avatar
JGR
Tycoon
Tycoon
Posts: 2120
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Diesel Power wrote:
24 Aug 2020 05:05
Here you go...
I've reduced the size of the performance impact, it should no longer be problematic.
This will be in the next release.
piratescooby wrote:
24 Aug 2020 18:55
I'm not sure if it is my computer or the latest nightly 804/821 that has the lag , I'm referring to the previous post , when I run a game on 1.10.3 it is ok , your latest and nightly has a lag .
If you've got a save which shows the issue I can take a look
Ex TTDPatch Coder
Patch Pack, Github
Dad-Coder since April 2018

Avatar by MoonsongWolf

Diesel Power
Traffic Manager
Traffic Manager
Posts: 220
Joined: 18 Jun 2016 19:05

Re: JGR's Patch Pack

Post by Diesel Power »

Is there any other way to do it? If a train is picking up multiple cargos at each station of differing amounts, I can't see any other way of doing it

User avatar
JGR
Tycoon
Tycoon
Posts: 2120
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Diesel Power wrote:
25 Aug 2020 18:42
Is there any other way to do it? If a train is picking up multiple cargos at each station of differing amounts, I can't see any other way of doing it
I don't see another way at the moment. I'll see if there are improvements which can be made.
In the meantime the next release shouldn't be too far away.
Ex TTDPatch Coder
Patch Pack, Github
Dad-Coder since April 2018

Avatar by MoonsongWolf

Diesel Power
Traffic Manager
Traffic Manager
Posts: 220
Joined: 18 Jun 2016 19:05

Re: JGR's Patch Pack

Post by Diesel Power »

Sweet.
Quick question...
If I pick up a unit of cargo from it's station of origin, take it for a ride, then drop it back at it's station of origin, does the cargo payment decay timer reset?

Sky_Turner
Engineer
Engineer
Posts: 1
Joined: 30 Aug 2020 18:44
Location: Yekaterinburg, Russia

Re: JGR's Patch Pack

Post by Sky_Turner »

Author-avtor, add pliz this beutiful patchpack to ur pachpak
viewtopic.php?f=33&t=73976
sowwy fo mah bad english, i m commie
Last edited by Sky_Turner on 03 Sep 2020 22:50, edited 1 time in total.
Image
Image

root@earth: $ /you > /dev/null

Eddi
Tycoon
Tycoon
Posts: 7479
Joined: 17 Jan 2007 00:14

Re: JGR's Patch Pack

Post by Eddi »

Diesel Power wrote:
27 Aug 2020 21:06
Sweet.
Quick question...
If I pick up a unit of cargo from it's station of origin, take it for a ride, then drop it back at it's station of origin, does the cargo payment decay timer reset?
no.
You might not exactly be interested in Ferion, but if you are, have fun :)

User avatar
Lordmwa
President
President
Posts: 898
Joined: 20 May 2006 19:30
Location: West Sussex, England

Re: JGR's Patch Pack

Post by Lordmwa »

I am having a strange situation with the cargodist, All was well and running nicely and then I added 2 new lines and all the passengers are just for any destination, the link graph shows the routes in white and trains are running but it does not seem to change, I have tried changing various settings and even deleting the trains and starting again. Any suggestions?

Thanks!
Attachments
Nelson & Co., 11th Feb 1902.sav
(1.19 MiB) Downloaded 10 times
The TT forums trivia tournament! Come along and join in the fun
http://www.funtrivia.com/private/main.cfm?tid=90722

User avatar
JGR
Tycoon
Tycoon
Posts: 2120
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Lordmwa wrote:
03 Sep 2020 08:51
I am having a strange situation with the cargodist, All was well and running nicely and then I added 2 new lines and all the passengers are just for any destination, the link graph shows the routes in white and trains are running but it does not seem to change, I have tried changing various settings and even deleting the trains and starting again. Any suggestions?

Thanks!
This should be fixed in the next release.
For now I'd suggest turning on "Do not scale the linkgraph days by the day length factor" and reducing "Take N days for recalculation of distribution graph".

As a one-off you could open the console and run "merge_link_graph_jobs_asap", then run it again after waiting at least a day. This will update the graph immediately.
Ex TTDPatch Coder
Patch Pack, Github
Dad-Coder since April 2018

Avatar by MoonsongWolf

User avatar
Lordmwa
President
President
Posts: 898
Joined: 20 May 2006 19:30
Location: West Sussex, England

Re: JGR's Patch Pack

Post by Lordmwa »

:bow:

Thanks!
The TT forums trivia tournament! Come along and join in the fun
http://www.funtrivia.com/private/main.cfm?tid=90722

User avatar
fridaemon
Engineer
Engineer
Posts: 69
Joined: 27 Oct 2019 21:06
Contact:

Re: JGR's Patch Pack

Post by fridaemon »

Maybe I'm blind but I can't find download link for the latest 0.36 version . Can you give it to me? :)
------------------------------------------------------------------------
Image
IN 1.0 EDIT YOU CAN EXCEPT:
Beach Objects * Shopping Centres * Shops
Underground Passenger Entrances * Garage Entrances

ino
Engineer
Engineer
Posts: 125
Joined: 09 Apr 2017 14:58

Re: JGR's Patch Pack

Post by ino »


SomeIndianGuy
Engineer
Engineer
Posts: 43
Joined: 19 Nov 2018 19:26
Location: Somewhere in Eastern India

Re: JGR's Patch Pack

Post by SomeIndianGuy »

Hello JGR,
Here attached is a crash report regarding the most recent version of your patchpack :
Crash report.zip
(9.22 MiB) Downloaded 7 times
Nothing to put here!

User avatar
JGR
Tycoon
Tycoon
Posts: 2120
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

SomeIndianGuy wrote:
12 Sep 2020 09:16
Hello JGR,
Here attached is a crash report regarding the most recent version of your patchpack :Crash report.zip
Thanks for reporting this, I will investigate.
For now I would suggest increasing the size of the sprite_cache_size_px value in your openttd.cfg file.
Ex TTDPatch Coder
Patch Pack, Github
Dad-Coder since April 2018

Avatar by MoonsongWolf

SomeIndianGuy
Engineer
Engineer
Posts: 43
Joined: 19 Nov 2018 19:26
Location: Somewhere in Eastern India

Re: JGR's Patch Pack

Post by SomeIndianGuy »

JGR wrote:
12 Sep 2020 10:38
SomeIndianGuy wrote:
12 Sep 2020 09:16
Hello JGR,
Here attached is a crash report regarding the most recent version of your patchpack :Crash report.zip
Thanks for reporting this, I will investigate.
For now I would suggest increasing the size of the sprite_cache_size_px value in your openttd.cfg file.
What is the max value for the given config variable?
I have kept it at 256 for now. It seemed to crash when the value was 128.
Nothing to put here!

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 4 guests