A fix for this has already been implemented, it'll be in the next release.3iff wrote:Further to the industry mouseover issue, it's still not 100% (maybe due to changes in trunk?).
If the setting is 'right-click', right clicking on an industry does nothing, right clicking on an option shows the tooltip.
Setting it to 'hover X msecs' will show the industry info window but also shows tooltips over every other option (which is intensely annoying).
As neither setting gives a satisfactory display, I've reverted to 29.0 as it shows industry info windows and no tooltips.
Could you post a savegame? I'll look into it.Rhodax wrote:I've just been trying this pack and noticed a problem with auto scheduling and seperation. If I turn it on for planes/buses or set it to automatically on in settings then quite often the vehicle does not empty at its destination and collect money. Often it takes the people back to their original airport and it costs money when/if it unloads.
Been playing with the original today and haven't seen that happen at all.
Thanks for reporting this, it will be fixed by the next release.Quinch wrote:Heya! Just throwing a crash report this way! First time happening, didn't see anything too weird leading up to it except occasional pausing, but that might be normal.
In the meantime turning disasters off should prevent further crashes.
Thanks for reporting this, it is fixed and will be in the next release.Valle wrote:I found a solution that fixed the issue for me. Bit 19 in row 91 of src/rev.cpp is not defined at the moment:Valle wrote:I tried to compile the latest version on macOS Sierra 10.12.6 after ./configure --without-liblzo2 (as it refuses to use it for whatever reason) and ran into the following issue while compiling rev.cpp.
The same issue occurred on another copy with ./configure --enable-static --without-liblzo2
Does anyone have an idea what the root of the above issue is and how it can be fixed?
Code: Select all
[SRC] Compiling progress.cpp [SRC] Compiling rail.cpp [SRC] Compiling rail_cmd.cpp [SRC] Compiling rail_gui.cpp [SRC] Compiling rev.cpp /Users/Val/Downloads/OpenTTD-patches-jgrpp/src/rev.cpp:91:72: error: expected expression ..._openttd_newgrf_version = 1 << 28 | 10 << 24 | 0 << 20 | << 19 | 28004; ^ 1 error generated. make: *** [rev.o] Error 1 make: *** [all] Error 1According to row 84 and 87-89, Bit 19 is defined as follows:
Code: Select all
const uint32 _openttd_newgrf_version = 1 << 28 | 10 << 24 | 0 << 20 | !!ISSTABLETAG!! << 19 | 28004;It looks like this bit must be defined in order for Mac users to compile the patchpack successfully. After I replaced !!ISSTABLETAG!! with 1, changing Line 91 as follows, it worked (JGRpp v0.29.3).
Code: Select all
84: * 19 1 if it is a release, 0 if it is not. 87: * The 19th bit is there so the development/betas/alpha, etc. leading to a 88: * final release will always have a lower version number than the released 89: * version, thus making comparisons on specific revisions easy.
Code: Select all
const uint32 _openttd_newgrf_version = 1 << 28 | 10 << 24 | 0 << 20 | 1 << 19 | 28004;
This looks like it is probably related to this: https://github.com/OpenTTD/OpenTTD/pull/7382 which is already fixed upstream.romazoon wrote:Hi JGR
I noticed since a couple versions that the company ratings are a bit wonky, their is a 5% rating not attributed sometimes to times, and randomly it seems
The implementation of TBTR which I have is loosely based on https://github.com/flitzpiepe/OpenTTD_T ... d82a6a59aa partly updated to match KeldorKatarn's fork (JokerPP) (971ba4928a5c7c7916fea55d91a3b6dd5bba140c), with a few dozen changes/fixes on top.HapticTactic wrote:Hi guys, hi JGR!
I enjoy playing JGRPP so much. So first, let me thank you, JGR, for allowing me to finally enjoy OTTD the way I always wanted - with challenge and depth. So thanks!
I have a question about ffpp's "Template based train replacement" patch you are using in your pack. Would it be possible for you to update it to the latest version with your next or future JGRPP updates? There is at least one crucial feature in the latest version of "ffpp's TBTR" that I would, personally, love to see in the game. It allows for creating template clones from trains that contain obsolete vehicles. The version you are using currently in JGRPP does not allow this. It would be an extremely useful feature for us who love to play with the templates feature.
Thank you for your time and effort!
The commit in KeldorKatarn's branch is now gone as he periodically rebased it.
I don't know what version this may correspond to in terms of the forum thread.
Enabling creating templates with obsolete vehicles seems doesn't seem like a big change. If there is a commit where it's implemented and it is compatible I could cherry pick it, otherwise I can look into the possibility of implementing it directly in due course.