JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

vrn
Engineer
Engineer
Posts: 66
Joined: 07 Mar 2018 17:00

Re: JGR's Patch Pack

Post by vrn »

You can get base sounds and music via in-game content download. If problems should arise in the future, feel free to use the wiki, in many cases the answer is already there. 8)
SimYouLater
Chief Executive
Chief Executive
Posts: 675
Joined: 03 Apr 2016 20:19

Re: JGR's Patch Pack

Post by SimYouLater »

ringostorm wrote:How do you install this? I have windows 7 and when I download and extract the files its just the base game with no sound. I cant find a installation guide anywhere.
It's kind of weird. Click "Check Online Content" in the main menu. Then search for OpenSFX, download and you're good.

Or put the contents of this RAR in your baseset folder for TTD graphics!
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.
User avatar
kamnet
Moderator
Moderator
Posts: 8548
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: JGR's Patch Pack

Post by kamnet »

ringostorm wrote:How do you install this? I have windows 7 and when I download and extract the files its just the base game with no sound. I cant find a installation guide anywhere.
If you have a standard OpenTTD installation, then it should have detected everything from it, as it uses the same shared file system. But if you have things isolated or modified how you installed it, clearly this won't work. None the less, adding sound is as simple as downloading OpenSFX and OpenMSX from within the in-game content download system.
eshield
Engineer
Engineer
Posts: 32
Joined: 24 Feb 2009 12:41
Contact:

Re: JGR's Patch Pack

Post by eshield »

ringostorm wrote:How do you install this? I have windows 7 and when I download and extract the files its just the base game with no sound. I cant find a installation guide anywhere.
Sounds, Music and etc can be downloaded via "Check Online Content". There is a search box where you can find everything you need.
Ask, and it shall be given you.
Seek, and ye shall find.
Knock, and it shall open unto you.
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

Are there any plans for next release? I'm asking because I would like to schedule my server version change from 0.23.0 to new one.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

McZapkie wrote:Are there any plans for next release? I'm asking because I would like to schedule my server version change from 0.23.0 to new one.
There are a couple of things which have been added/improved since the last release (0.24.1), but nothing major which would prevent upgrading the server to that release.
I don't have any concrete plans for when the next release will be, it depends on how development work progresses and whether any significant bugs in the most recent release are found.
Ex TTDPatch Coder
Patch Pack, Github
ecolortest
Engineer
Engineer
Posts: 19
Joined: 12 Oct 2016 07:46

Re: JGR's Patch Pack

Post by ecolortest »

JGR wrote:
ecolortest wrote:Crash in wine

ERROR>fixme:dbghelp:MiniDumpWriteDump NIY MiniDumpWithDataSegs
ERROR>err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr 0x5f4d6f

so how to fix it?

My device is mac book pro earlly 2011 13-inch
Version macos High sierra Version 10.13.4
Processor 2.3 GHz Intel Core i5
Memory 8gb 1600 mhz ddr3
grphics Intel hd Graphics 3000 512 MB
Can you post the crash.log file?
Redirect Left wrote:another suggestion i realised would be quite handy playing today;
As you know, if you click a train, it will give a quick GUI overview of where it calls, with little numbers over all its stops.

Is it possible, that when you click on a station, it gives a similar overview, but for all trains that call there - this would quickly help me identify where this station has direct links to, and spot any missing useful links for passengers to get to and from there.
Isn't this more or less what the cargo dest link graph overlay does?
The departure boards can also be quite useful here.
My todo list is currently very long, so developing this sort of feature is not likely to occur soon.
If you/someone else can develop a reasonable quality patch to implement it that may be a more pragmatic way to go.
Here the crash log:
[+] Spoiler
*** OpenTTD Crash Report ***

Crash at: Tue May 29 02:09:24 2018
In game date: 0-01-00 (0)

Crash reason:
Exception: C0000005
Location: 004DC21E
Message: <none>

OpenTTD version:
Version: - Joker's Patch Pack v1.24.4 (0)
NewGRF ver: 19006d63
Bits: 32
Endian: little
Dedicated: no
Build date: Apr 28 2018 16:03:20

Registers:
EAX: 00000E1F EBX: 0000387C ECX: 00000000 EDX: 00000002
ESI: 000002D3 EDI: 00000002 EBP: 0032E88C ESP: 0032E878
EIP: 004DC21E EFLAGS: 00010297

Bytes at instruction pointer:
8A 43 10 0F B6 D0 3B D7 0F 84 C9 00 00 00 83 FF 02 75 24 85 D2 75 20 39

Stack trace:
00219C88 0000000C 4000004D 00000000 0000003F 00000000 0049F18F 00000000
00000002 00000015 0032E938 00000002 00000000 00000000 00000000 00000000
00000002 00000002 00000015 00000002 0000000C 00000000 00219C68 00000000
0000000B 00130BA0 00000017 00000000 4000004D 0000000A 0049F440 0000000C
0000000B 00000001 00000000 00000000 00000017 00000000 00000002 00219CB8
00000001 00000004 0032E970 00000015 00000002 0032FB28 0086F2D8 00000000
0032F170 0050FBCA 00000002 0032E970 00000000 00000001 00000000 00000000
00203F70 0020F190 0020F190 0032F194 00000000 00000000 4D8A81EE 69737369
6720676E 68706172 00736369 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000

Operating system:
Name: Windows
Release: 5.1.2600 (Service Pack 3)
Compiler: MSVC 1912

Configuration:
Blitter: 32bpp-anim
Graphics set: none (4294967295)
Language: Z:\Users\okansp\Downloads\OpenTTD_LetsPlayEdition_32bit\lang\english_US.lng
Music driver: none
Music set: none (4294967295)
Network: no
Sound driver: none
Sound set: none (4294967295)
Video driver: win32

Fonts:
Small: sprite
Medium: sprite
Large: sprite
Mono: sprite

AI Configuration (local: 0):

Libraries:
FreeType: 2.6.0
ICU i18n: 55.1
ICU lx: 55.1
LZMA: 5.2.1
LZO: 2.09
PNG: 1.6.18
Zlib: 1.2.8

Module information:
Z:\Users\okansp\Downloads\OpenTTD_LetsPlayEdition_32bit\openttd.exe handle: 00400000 size: 13819392 crc: B40E105F date: 2018-04-28 07:07:46
C:\windows\system32\ntdll.dll handle: 7BC10000 size: 2468 crc: FB718EBA date: 2018-04-28 23:35:38
C:\windows\system32\KERNEL32.dll handle: 40AE0000 size: 1677836 crc: 5C7A04F3 date: 2018-04-28 23:35:32
C:\windows\system32\winmm.dll handle: 42850000 size: 475744 crc: ECB2054F date: 2018-04-28 23:35:32
C:\windows\system32\user32.dll handle: 42950000 size: 227780 crc: 941BABED date: 2018-04-28 23:35:35
C:\windows\system32\gdi32.dll handle: 42D40000 size: 16152 crc: 661CC3ED date: 2018-04-28 23:35:34
C:\windows\system32\advapi32.dll handle: 43010000 size: 2488 crc: 72E51CA9 date: 2018-04-28 23:35:36
C:\windows\system32\version.dll handle: 43100000 size: 2484 crc: 9EE4EBDF date: 2018-04-28 23:35:34
C:\windows\system32\ole32.dll handle: 43120000 size: 19576 crc: FFCF05CB date: 2018-04-28 23:35:37
C:\windows\system32\rpcrt4.dll handle: 434A0000 size: 2472 crc: 6810D2D7 date: 2018-04-28 23:35:36
C:\windows\system32\msacm32.dll handle: 435E0000 size: 22744 crc: 56ED9DAA date: 2018-04-28 23:35:34
C:\windows\system32\ws2_32.dll handle: 43630000 size: 2476 crc: 1318FF5D date: 2018-04-28 23:35:35
C:\windows\system32\imm32.dll handle: 436A0000 size: 2468 crc: BE40FCE4 date: 2018-04-28 23:35:33
C:\windows\system32\shell32.dll handle: 436E0000 size: 1416672 crc: 984DAC8F date: 2018-04-28 23:35:36
C:\windows\system32\shlwapi.dll handle: 43AC0000 size: 19932 crc: 83F20744 date: 2018-04-28 23:35:35
C:\windows\system32\comctl32.dll handle: 43BB0000 size: 178076 crc: 4455CF90 date: 2018-04-28 23:35:34
C:\windows\system32\winemac.drv handle: 44000000 size: 1032 crc: 2FE56CE0 date: 2018-04-28 23:35:37
C:\windows\system32\uxtheme.dll handle: 44290000 size: 2448 crc: 9443403E date: 2018-04-28 23:35:38
C:\windows\system32\iphlpapi.dll handle: 45740000 size: 2480 crc: A6A82B86 date: 2018-04-28 23:35:33
C:\windows\system32\psapi.dll handle: 456C0000 size: 2500 crc: AA22BDD2 date: 2018-04-28 23:35:37

---- gamelog start ----
---- gamelog end ----

Command Log:
Showing most recent 0 of 0 commands

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] ??? 0x004DC21E

*** End of additional info ***
eshield
Engineer
Engineer
Posts: 32
Joined: 24 Feb 2009 12:41
Contact:

Re: JGR's Patch Pack

Post by eshield »

ecolortest wrote:OpenTTD version:
Version: - Joker's Patch Pack v1.24.4 (0)
NewGRF ver: 19006d63
Bits: 32
Endian: little
Dedicated: no
Build date: Apr 28 2018 16:03:20
Joker's PP is not JGR PP. Why post here?
Ask, and it shall be given you.
Seek, and ye shall find.
Knock, and it shall open unto you.
User avatar
Hyronymus
Tycoon
Tycoon
Posts: 13233
Joined: 03 Dec 2002 10:36
Location: The Netherlands
Contact:

Re: JGR's Patch Pack

Post by Hyronymus »

eshield wrote:Joker's PP is not JGR PP. Why post here?
Because people make mistakes :roll: ? The proper thread is Joker's Patch Pack.
ecolortest
Engineer
Engineer
Posts: 19
Joined: 12 Oct 2016 07:46

Re: JGR's Patch Pack

Post by ecolortest »

Hyronymus wrote:
eshield wrote:Joker's PP is not JGR PP. Why post here?
Because people make mistakes :roll: ? The proper thread is Joker's Patch Pack.
are Joker's PP and JGR PP is differt, i sorry if differnt
mak
Traffic Manager
Traffic Manager
Posts: 205
Joined: 30 Sep 2015 13:16

Re: JGR's Patch Pack

Post by mak »

ecolortest wrote:
Hyronymus wrote:
eshield wrote:Joker's PP is not JGR PP. Why post here?
Because people make mistakes :roll: ? The proper thread is Joker's Patch Pack.
are Joker's PP and JGR PP is differt, i sorry if differnt
Simple answer: Yes but do not worry you are not the only one to make the mistake.
Use the link and hopefully your question will be answered. :)
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

I found a small bug with loading trough option.
I enabled this option for one client, set this order on MP server, and when joined using another client with such option switched off, I found that train is sitting very long on the short station.
See train #1 in attached save.

EDIT: some other issues appears related with trough order. Train 9 have "full load" order, he loaded something, proceed to the end of the stock, and being stuck. There is 10 tonnes reserved to load (see second save).
Attachments
stuckload.sav
(772.68 KiB) Downloaded 28 times
stalledload.sav
(677.9 KiB) Downloaded 22 times
User avatar
HackaLittleBit
Director
Director
Posts: 550
Joined: 10 Dec 2008 16:08
Location: tile 0x0000

Re: JGR's Patch Pack

Post by HackaLittleBit »

Would it help to raise the production level of Humenne Coal Mine? (cheat)
Next to Humenne Heights station
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

McZapkie wrote:I found a small bug with loading trough option.
I enabled this option for one client, set this order on MP server, and when joined using another client with such option switched off, I found that train is sitting very long on the short station.
See train #1 in attached save.

EDIT: some other issues appears related with trough order. Train 9 have "full load" order, he loaded something, proceed to the end of the stock, and being stuck. There is 10 tonnes reserved to load (see second save).
There are several bugs with through load which have come to my attention in the last day or so.
This looks to be due to a bug in the handling of full load orders, and doesn't seem to be because of the client setting, which only affects the GUI.
These bugs should be fixed now, so I will do another release soonish.
Ex TTDPatch Coder
Patch Pack, Github
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

JGR wrote: This looks to be due to a bug in the handling of full load orders, and doesn't seem to be because of the client setting, which only affects the GUI.
Yes, you are right, from more observation I can deduct, that it is issue related to station refit+full load+load trough.
If train is refitted in a depot earlier, it can load without problems.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
eshield
Engineer
Engineer
Posts: 32
Joined: 24 Feb 2009 12:41
Contact:

Re: JGR's Patch Pack

Post by eshield »

JGR
Seems like I've found yet another bug.

Steps to reproduce:
1. Have a station A which accepts, for example, Coal.
2. Coal is nicely delivered there by your vehicles.
3. Build a Coal Mine within station A catchment area.
4. Voilà! Your vehicles going to be red very soon.

The following screenshot shows what happens if delivered goods are already produced near to the station:
Untitled.png
(302.14 KiB) Not downloaded yet
Ask, and it shall be given you.
Seek, and ye shall find.
Knock, and it shall open unto you.
Eddi
Tycoon
Tycoon
Posts: 8258
Joined: 17 Jan 2007 00:14

Re: JGR's Patch Pack

Post by Eddi »

that is not a bug, you need "unload and leave empty" orders
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5656
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: JGR's Patch Pack

Post by andythenorth »

eshield wrote:Seems like I've found yet another bug.
As far as I can tell, that's not a bug, but standard game mechanic.

The vehicles are loading cargo which has no destination so they get no payment so they lose money.

Don't use 'unload and take cargo'. Use 'no loading'.

I might have misunderstood the screenshot though :)
nihues
Engineer
Engineer
Posts: 85
Joined: 13 Jan 2015 10:26

Re: JGR's Patch Pack

Post by nihues »

eshield wrote:JGR
Seems like I've found yet another bug.

Steps to reproduce:
1. Have a station A which accepts, for example, Coal.
2. Coal is nicely delivered there by your vehicles.
3. Build a Coal Mine within station A catchment area.
4. Voilà! Your vehicles going to be red very soon
Not a bug... put second order to unload and leave empty....

You need a second (different) station to load the new coal industry and unload on that station, otherwise it will be a mess to handle...
eshield
Engineer
Engineer
Posts: 32
Joined: 24 Feb 2009 12:41
Contact:

Re: JGR's Patch Pack

Post by eshield »

Eddi wrote:that is not a bug, you need "unload and leave empty" orders
Nope, that does not help at all.
nihues wrote:You need a second (different) station to load the new coal industry and unload on that station, otherwise it will be a mess to handle...
I believe this is not that hard to check if cargo is accepted or not on unload.
andythenorth wrote:Don't use 'unload and take cargo'. Use 'no loading'.
Thanks. "No loading" works really well! But, this "feature" kinda is not that obvious for user.
Last edited by eshield on 05 Jun 2018 20:32, edited 1 time in total.
Ask, and it shall be given you.
Seek, and ye shall find.
Knock, and it shall open unto you.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 12 guests