JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Valle wrote:I had to escalate this problem to a friend from outside of the OpenTTD community, who provided me with the following solution.

Problem: OSX Mavericks and newer ships with several versions of the standard library libc++

Solution: entering the following code into the terminal window in which OpenTTD is compiled afterwards.

Code: Select all

export LDFLAGS="-stdlib=libstdc++ -lstdc++"
I have attached the Mac OS X build of your patchpack I generated after that.
That is a bit odd. Have you tried compiling with clang for both the compile and link steps? There's some clang-specific stuff in the configure script so it ought to work.
I'm a little hesitant to add that to the configure scripts at the moment as I don't want to accidentally break any other combinations of toolchains/platforms which may not be affected at present, especially when I can't test anything Apple-related.
Valle wrote:Interestingly, there is a problem with the year display, which also exists with my friend's bundle.
If I'm in the year 1945, OpenTTD displays the year 21395. This problem persists in later years, with the year count rising accordingly.
That is a bit baffling. Interestingly 21395 is 11 times 1945 which suggests some sort of scaling issue somewhere. Do you get the same issue on OpenTTD trunk? Are you using an increased day length?
Valle wrote: My build (attached below) doesn't display the version/build correctly in the main menu, just calling the version "norev000". I wasn't able to test it properly yet.
archy wrote:Wow, awesome selection of patches!

Also great to see someone do a patch pack "the proper way", with git branches. Hopefully this means it won't bitrot quite as fast as previous patch packs.

PS: I'm trying to build version 0.2.1 directly from https://github.com/JGRennison/OpenTTD-patches/releases but it prints this warning at the start:

Code: Select all

WARNING: there is no means to determine the version.
WARNING: please use a subversion, mercurial, or git checkout of OpenTTD.
WARNING: you can only join game servers that have been compiled without
WARNING:   version detection.
WARNING: there is a great chance you desync.
WARNING: USE WITH CAUTION!
Is this to be expected? Is there some way the configure script can be told the correct version number?
The OpenTTD build system runs the script `findversion.sh` which tries to work out what the version string should be.
If there's a file named ".ottdrev" it uses that, otherwise it looks to see if you're in an SVN, Mercurial or Git repository and looks at the current revision/branch/status etc. to get a version string.
I'm guessing that you downloaded a zip rather than `git clone`ing the repository, as this would not include the version info.
The zip files on Github are auto-generated, and I'm not sure how I could feasibly manually add version info to them (at least not in a way that isn't overly awkward). I'll have to think about how to modify the version detection script and/or add version info to tagged versions to do something else to work out the version.
The diffs in the first post have the version info added by the script I use to generate the diff.

Edit: This ought to be fixed as of v0.3.0.
Last edited by JGR on 31 Aug 2015 11:43, edited 1 time in total.
Ex TTDPatch Coder
Patch Pack, Github
archy
Engineer
Engineer
Posts: 42
Joined: 03 Aug 2012 20:55

Re: JGR's Patch Pack

Post by archy »

Thanks for the explanation. I'll do a git clone instead, then.

I'm wondering if I should build the latest release tag (`git checkout jgrpp-0.2.1`) or the head of the jgrpp branch.

Is the jgrpp branch considered always stable, or does it contain work-in-progress stuff in between releases?
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

archy wrote:Thanks for the explanation. I'll do a git clone instead, then.

I'm wondering if I should build the latest release tag (`git checkout jgrpp-0.2.1`) or the head of the jgrpp branch.

Is the jgrpp branch considered always stable, or does it contain work-in-progress stuff in between releases?
I try to keep it stable, but I can't make full guarantees, at present at least there are no known bugs (only unknown ones).

Edit: 0.3.0 is out now, so you can use that.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
romazoon
Tycoon
Tycoon
Posts: 1291
Joined: 20 Jun 2010 23:16

Re: JGR's Patch Pack

Post by romazoon »

nice patch pack, thanks for sharing :)

though we encounter a bug in multiplayer:

each time someone tries to open a competitor' vehicle's order, the client who did it crashes.



*** OpenTTD Crash Report ***

Crash at: Mon Aug 31 14:00:52 2015
In game date: 1995-08-03 (35)

Crash reason:
Exception: C0000005
Location: 0000000000651520
Message: <none>

OpenTTD version:
Version: jgrpp-0.3.0 (0)
NewGRF ver: 16006afd
Bits: 64
Endian: little
Dedicated: no
Build date: Aug 31 2015 11:51:09

Registers:
RAX: 0000000005776850 RBX: 0000000000B7E880 RCX: 0000000000000000 RDX: 0000000040000001
RSI: 0000000006FB0140 RDI: 000000000C100F20 RBP: 0000000005D6A9E0 RSP: 000000000022D688
R8: 000000000A6FFF40 R9: FFFFFFFFFFFFF0E0 R10: E4666368564D3030 R11: 8101010101010100
R12: 0000000000B718FD R13: 0000000000000077 R14: 0000000000000001 R15: 000000000887ED40
RIP: 0000000000651520 EFLAGS: 00010246

Bytes at instruction pointer:
89 51 60 C3 66 66 66 2E 0F 1F 84 00 00 00 00 00 48 8D 05 19 9D 49 00 89

Stack trace:
00537B79 00000000 00B7E880 00000000 0065706A 00000000 00000000 00000000
FC17FCEB 000007FE 00B7E880 00000000 00000006 00000000 000000EF 00000000
05D6A9E0 00000000 00000006 00000000 0065A770 00000000 00000000 00000000
00000000 00000000 00000001 00000000 00000001 00000000 00000020 00000000
00000001 00000000 00000000 00000000 00000001 00000000 00000000 00000000
000000EF 0000006A 00000000 00000000 00000201 00000000 008300EF 00000000
001004E6 00000000 00000001 00000000 00000000 00000000 00000201 00000000
00000000 00000000 001004E6 00000000 0063B799 00000000 00000000 00000000
00000000 00000000 00000070 00000000 FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF
76C59B43 00000000 76C59BEF 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 76C572CB 00000000 00000000 00000000
0063B260 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000001 00000000 00B74580 00000000 00000000 00000000
00000201 00000000 00000000 00000000 76C59BD1 00000000 0022D8F8 00000000
00000000 00000000 00000000 00000000 00000004 00000000 0063B260 00000000
000003FF 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000083 00000000 00000048 00000000 00000001 00000000 00000000 00000000
00000000 00000000 00000030 00000000 FFFFFFFF FFFFFFFF FFFFFFFF FFFFFFFF
76C59B43 00000000 00000000 00000000 00B74580 00000000 00000001 00000000
00000001 00000000 00000000 00000000 76C598DA 00000000 0022D9D0 00000000
0063B260 00000000 76C5991C 00000000 01AE66C0 00000000 00000001 00000000
008300EF 00000000 01AE66E8 00000000 00000001 00000000 76C58FD0 00000000
76C5991C 00000000 76C596F0 00000000 0B7778C3 00000000 0B7778B4 00000000
0B7778C3 00000000 76C5991C 00000000 0063A415 00000000 0022D9D0 00000000

Operating system:
Name: Windows
Release: 6.1.7601 (Service Pack 1)
Compiler: GCC 4.9.2 "4.9.2"

Configuration:
Blitter: 32bpp-optimized
Graphics set: OpenGFX (5580)
Language: C:\Users\andylu\Desktop\Spiel\Diverse Patched version\JGR's pack\lang\french.lng
Music driver: win32
Music set: Modern Motion (1)
Network: client
Sound driver: win32
Sound set: NoSound (2)
Video driver: win32

Fonts:
Small: Arial
Medium: Arial
Large: Arial
Mono: sprite

AI Configuration (local: 255):
0: Human
1: Human
2: Human
3: Human
4: Human

Libraries:
FreeType: 2.6.0
LZMA: 5.2.1
LZO: 2.09
PNG: 1.5.23
Zlib: 1.2.8

Module information:
C:\Users\andylu\Desktop\Spiel\Diverse Patched version\JGR's pack\openttd.exe handle: 0000000000400000 size: 14932915 crc: 6AF621A8 date: 2015-08-31 09:53:10
C:\Windows\SYSTEM32\ntdll.dll handle: 0000000076d40000 size: 1730496 crc: CBF68D17 date: 2015-07-15 18:12:09
C:\Windows\system32\kernel32.dll handle: 0000000076b20000 size: 1163264 crc: 161DB41D date: 2015-07-15 18:10:48
C:\Windows\system32\KERNELBASE.dll handle: 000007fefbac0000 size: 424960 crc: D82FE040 date: 2015-07-15 18:10:48
C:\Windows\system32\ADVAPI32.dll handle: 000007fefda30000 size: 879104 crc: 5E972699 date: 2015-05-25 18:18:54
C:\Windows\system32\msvcrt.dll handle: 000007fefd210000 size: 634880 crc: 9D1B448A date: 2011-12-16 08:46:06
C:\Windows\SYSTEM32\sechost.dll handle: 000007fefbc30000 size: 113664 crc: 98A6ADF4 date: 2015-05-25 18:19:09
C:\Windows\system32\RPCRT4.dll handle: 000007fefd860000 size: 1216512 crc: 646551CD date: 2015-07-15 18:10:56
C:\Windows\system32\GDI32.dll handle: 000007fefc0f0000 size: 404992 crc: 66195D86 date: 2015-06-17 17:47:05
C:\Windows\system32\USER32.dll handle: 0000000076c40000 size: 1008128 crc: 70FF7D7F date: 2010-11-20 13:27:28
C:\Windows\system32\LPK.dll handle: 000007fefd7b0000 size: 41984 crc: B3F642CD date: 2015-07-30 18:06:42
C:\Windows\system32\USP10.dll handle: 000007fefd6e0000 size: 801280 crc: DCB1924F date: 2014-04-25 02:34:59
C:\Windows\system32\IMM32.dll handle: 000007fefc0c0000 size: 167424 crc: 41B2805A date: 2009-07-14 01:41:09
C:\Windows\system32\MSCTF.dll handle: 000007fefc160000 size: 1067520 crc: 362B3A40 date: 2015-01-17 02:48:38
C:\Windows\system32\SHELL32.dll handle: 000007fefc480000 size: 14177280 crc: 155A393E date: 2015-07-10 17:51:25
C:\Windows\system32\SHLWAPI.dll handle: 000007fefbba0000 size: 448512 crc: 086DF743 date: 2010-11-20 13:27:26
C:\Windows\system32\WINMM.dll handle: 000007fef6280000 size: 217600 crc: 7BC1529F date: 2009-07-14 01:41:56
C:\Windows\system32\WS2_32.dll handle: 000007fefdcf0000 size: 297984 crc: 0F68689B date: 2010-11-20 13:27:30
C:\Windows\system32\NSI.dll handle: 000007fefbc20000 size: 13824 crc: 53B46F6C date: 2009-07-14 01:41:53
C:\Windows\system32\nvinitx.dll handle: 000007fefb720000 size: 166568 crc: 71468437 date: 2014-07-02 20:48:32
C:\Program Files\NVIDIA Corporation\CoProcManager\detoured.dll handle: 000000000f000000 size: 13088 crc: A1486341 date: 2014-07-02 20:48:32
C:\Program Files\NVIDIA Corporation\CoProcManager\nvd3d9wrapx.dll handle: 000007fef7160000 size: 191264 crc: 635CE895 date: 2014-07-02 20:48:32
C:\Windows\system32\SETUPAPI.dll handle: 000007fefdb10000 size: 1900544 crc: A364BD6A date: 2010-11-20 13:27:26
C:\Windows\system32\CFGMGR32.dll handle: 000007fefbb50000 size: 207872 crc: 1984C339 date: 2010-11-20 13:25:52
C:\Windows\system32\OLEAUT32.dll handle: 000007fefd600000 size: 861696 crc: 2B84F0E4 date: 2014-11-26 03:53:59
C:\Windows\system32\ole32.dll handle: 000007fefbeb0000 size: 2087424 crc: 5DA42F8C date: 2015-07-04 18:07:11
C:\Windows\system32\DEVOBJ.dll handle: 000007fefb920000 size: 93184 crc: A7541AE2 date: 2009-07-14 01:40:28
C:\Program Files\NVIDIA Corporation\CoProcManager\nvdxgiwrapx.dll handle: 000007fef70e0000 size: 130488 crc: 40E98CF0 date: 2014-07-02 20:48:32
C:\Program Files (x86)\AVG\AVG2015\avghooka.dll handle: 000007fef61e0000 size: 592816 crc: 04B3A36E date: 2015-07-31 12:54:40
C:\Windows\system32\CRYPTBASE.dll handle: 000007fefb610000 size: 44032 crc: AC1D5D3A date: 2015-07-15 18:10:43
C:\Windows\system32\mswsock.dll handle: 000007fefaf50000 size: 327168 crc: 2C87855E date: 2013-09-08 02:27:14
C:\Windows\System32\wshtcpip.dll handle: 000007fefa920000 size: 13312 crc: 5D1E2C55 date: 2009-07-14 01:41:58
C:\Windows\system32\MMDevAPI.DLL handle: 000007fefa500000 size: 284160 crc: CDF2EF81 date: 2009-07-14 01:41:26
C:\Windows\system32\PROPSYS.dll handle: 000007fefa3d0000 size: 1212416 crc: B83FA3BE date: 2010-11-20 13:27:24
C:\Windows\system32\wdmaud.drv handle: 000007fef2400000 size: 217088 crc: 12829973 date: 2010-11-20 13:24:22
C:\Windows\system32\ksuser.dll handle: 0000000073580000 size: 5120 crc: AA2071D9 date: 2009-07-14 01:41:13
C:\Windows\system32\AVRT.dll handle: 000007fefa5f0000 size: 18432 crc: 5CE53CB7 date: 2009-07-14 01:40:05
C:\Windows\system32\AUDIOSES.DLL handle: 000007fef6140000 size: 296448 crc: E010A4A9 date: 2015-02-03 03:30:55
C:\Windows\system32\msacm32.drv handle: 000007fef7080000 size: 25600 crc: 2B579A05 date: 2009-07-14 01:38:50
C:\Windows\system32\MSACM32.dll handle: 000007fef23e0000 size: 83456 crc: 3D67538B date: 2009-07-14 01:41:27
C:\Windows\system32\midimap.dll handle: 000007fef4950000 size: 20480 crc: CB902A13 date: 2009-07-14 01:41:23
C:\Windows\system32\CLBCatQ.DLL handle: 000007fefd7c0000 size: 607744 crc: 939E35C9 date: 2009-07-14 01:40:15
C:\Windows\System32\wship6.dll handle: 000007fefaf40000 size: 13824 crc: E3FBF123 date: 2009-07-14 01:41:58
C:\Windows\system32\DNSAPI.dll handle: 000007fefadd0000 size: 357888 crc: 194CAF1C date: 2011-10-19 02:49:31
C:\Program Files\Common Files\Microsoft Shared\Windows Live\WLIDNSP.DLL handle: 000007fef5400000 size: 171392 crc: BE3AE755 date: 2011-03-29 04:11:06
C:\Windows\system32\PSAPI.DLL handle: 0000000076f10000 size: 9216 crc: 84B5E9BA date: 2009-07-14 01:41:53
C:\Windows\system32\IPHLPAPI.DLL handle: 000007fef87e0000 size: 145920 crc: 000D9F17 date: 2010-11-20 13:26:40
C:\Windows\system32\WINNSI.DLL handle: 000007fef87d0000 size: 26112 crc: 744B2434 date: 2009-07-14 01:41:56
C:\Windows\System32\fwpuclnt.dll handle: 000007fef8690000 size: 324096 crc: 5D5E70C7 date: 2013-10-12 02:29:08
C:\Windows\system32\rasadhlp.dll handle: 000007fef53f0000 size: 16384 crc: C5FD1616 date: 2009-07-14 01:41:53

---- gamelog start ----
Tick 0: new game started
Revision text changed to 1.1.5, savegame version 160, not modified, _openttd_newgrf_version = 0x11585cf6
New game mode: 1 landscape: 0
Added NewGRF: GRF ID 72777473, checksum 431E58F4ACA83A2B4E25EEC5FD2E1EEF, filename: uk_town_set-2.1\ukts_2.1.grf (md5sum matches)
Added NewGRF: GRF ID 45530500, checksum FA231F55E8CC472EA98271F7C2AA9EFF, filename: japanese_stations-2.0a\jpstationsw.grf (md5sum matches)
Added NewGRF: GRF ID 554B524C, checksum 934F973D33A42EB858B80031F904F057, filename: uk_roads_with_signs-0.2\ukroadswsigns.grf (md5sum matches)
Added NewGRF: GRF ID 46727806, checksum 09E95562B1894A4D55D5532C6A889621, filename: opengfx_trees-0.2.2\opengfx+trees.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum 0BF8636EFEEF4F0617CAE47D77FF4C43, filename: av8_aviators_aircraft_set-1.81\pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 4D420000, checksum 0D730B1D72F292ED8621E90B84C657A7, filename: bobs_random_vehicles_-0.8.2\brbvv0.8.2w.grf (md5sum matches)
Added NewGRF: GRF ID 52455400, checksum 1600687C50C5AB1E72EDD487CAD50E2A, filename: ae_cityw.GRF (md5sum matches)
Added NewGRF: GRF ID 52455200, checksum 0E5A9C5ACD2BCAF7FA0658C3F905A660, filename: rural_stations-1\ae_ruraw.grf (md5sum matches)
Added NewGRF: GRF ID 52455300, checksum 37C0B839B13C4B18051580C81EEDF427, filename: suburban_stations-1\ae_subuw.grf (md5sum matches)
Added NewGRF: GRF ID 686D6301, checksum ECFF8464F08FD6772E7A133C46FA43F2, filename: more_british_town_names-1.0\morebritishtownnames_1.grf (md5sum matches)
Added NewGRF: GRF ID 44442411, checksum BE3D8201BDE0ABB92F8D9696D93524CC, filename: tai_uk_houses-0.3\tai_uk.grf (md5sum matches)
Added NewGRF: GRF ID 4D42000A, checksum BC3A0E791C74C1A04A3B90C3B2FA83A6, filename: bats-0.4\batsv0.4w.grf (md5sum matches)
Added NewGRF: GRF ID 045C030C, checksum F42CF9EBF107CEEF90A58BAE812A0A9D, filename: narvw-2.00\narvsw.grf (md5sum matches)
Added NewGRF: GRF ID 44441000, checksum 5CA2EF8EABD9B28B7D9970B2989A5519, filename: ukrs2__the_uk_railway_set-0.82\proj1000.grf (md5sum matches)
Added NewGRF: GRF ID 44441001, checksum 47C32136806D45FB7CDD6D82E67D9E77, filename: ukrs2_uk_railway_addon_set-1.1\pj1kadd.grf (md5sum matches)
Added NewGRF: GRF ID 44442303, checksum BCDA97D28B89282C930154DD67C470A4, filename: pb_trax.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum EFB21CFA6828362FDA9B2D629B5EEEB4, filename: industrial_stations_renewal-0.8.1\indstatr.grf (md5sum matches)
Tick 24291: GRF config changed
Removed NewGRF: GRF ID 045C030C, filename: narvw-2.00\narvsw.grf (md5sum matches)
Added NewGRF: GRF ID 52571201, checksum C1C7D8C53EB7E74EEE2F0EF29638B466, filename: egrvts.1.0\egrvts.grf (md5sum matches)
Tick 24268: game loaded
Revision text changed to jgrpp-0.3.0, savegame version 194, not modified, _openttd_newgrf_version = 0x16006afd
---- gamelog end ----

*** End of OpenTTD Crash Report ***
Attachments
crash.png
(138.35 KiB) Not downloaded yet
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

romazoon wrote:nice patch pack, thanks for sharing :)

though we encounter a bug in multiplayer:

each time someone tries to open a competitor' vehicle's order, the client who did it crashes.
Thanks for the bug report, this should be fixed in v0.3.1.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Valle
Transport Coordinator
Transport Coordinator
Posts: 284
Joined: 15 May 2007 11:35
Location: Germany

Re: JGR's Patch Pack

Post by Valle »

What do the rejectiions of S2013PP savegames look like as of v0.3.1? With my last savegame from S2013PP v2.0.103, I get the following crash. Possible issue regarding that: the NewGRF list of the savegame was modified several times while it was played. To my untrained eye, the cause of the crash could be the ticks per day value, though.

Code: Select all

Assertion failed at line 40 of /Users/Val/Downloads/OTTD-jgrpp031/src/date.cpp: fract < DAY_TICKS
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Valle wrote:What do the rejectiions of S2013PP savegames look like as of v0.3.1? With my last savegame from S2013PP v2.0.103, I get the following crash. Possible issue regarding that: the NewGRF list of the savegame was modified several times while it was played. To my untrained eye, the cause of the crash could be the ticks per day value, though.

Code: Select all

Assertion failed at line 40 of /Users/Val/Downloads/OTTD-jgrpp031/src/date.cpp: fract < DAY_TICKS
It's a day length related issue, it should be fixed in v0.3.2.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Mizari
Traffic Manager
Traffic Manager
Posts: 136
Joined: 22 Apr 2012 14:21

Re: JGR's Patch Pack

Post by Mizari »

Clicking a particular train's schedule to open the list, I get this crash:
Attachments
crash.png
crash.png (499.96 KiB) Viewed 22478 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Mizari wrote:Clicking a particular train's schedule to open the list, I get this crash:
This most likely means that you're using an old version of the data/language files.
Can you check that the everything in the bundle you downloaded or that was output from your build has been kept together, that you're not running the executable separately from the rest of the data files, and that you haven't partly copied them into another installation.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Mizari
Traffic Manager
Traffic Manager
Posts: 136
Joined: 22 Apr 2012 14:21

Re: JGR's Patch Pack

Post by Mizari »

The language files are just those which came with the patch. This was a save-game from Spring Patch Pack, however (although I do not remember it having any weird orders). I sold the train in question and made a new one with the same schedule and there was no issue.

http://www.tt-forums.net/viewtopic.php?f=33&t=42845

Would it be possible to include this small patch? It produces these lovely yearly mini-map screenshots.
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Mizari wrote:The language files are just those which came with the patch. This was a save-game from Spring Patch Pack, however (although I do not remember it having any weird orders). I sold the train in question and made a new one with the same schedule and there was no issue.

http://www.tt-forums.net/viewtopic.php?f=33&t=42845

Would it be possible to include this small patch? It produces these lovely yearly mini-map screenshots.
If possible could you post the SpringPP savegame?

There's already a minimap screenshot patch included in the patchpack, there's a new button in the minimap window.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Mizari
Traffic Manager
Traffic Manager
Posts: 136
Joined: 22 Apr 2012 14:21

Re: JGR's Patch Pack

Post by Mizari »

JGR wrote:
Mizari wrote: There's already a minimap screenshot patch included in the patchpack, there's a new button in the minimap window.
But that one makes very large isometric ones. This one made small, top-view ones. And it saved one at the beginning of each year (it was in the Hard patch pack). Makes for very memorable maps accumulating.

//

The offending train is train number 88.
Attachments
Boyeworld Government Railways, 10th Jan 1924.sav
(4.11 MiB) Downloaded 172 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Mizari wrote:
JGR wrote:
Mizari wrote: There's already a minimap screenshot patch included in the patchpack, there's a new button in the minimap window.
But that one makes very large isometric ones. This one made small, top-view ones. And it saved one at the beginning of each year (it was in the Hard patch pack). Makes for very memorable maps accumulating.

//

The offending train is train number 88.
The train has a "wait for cargo" order as added in SpringPP, and it's not handled sensibly as I thought it would have been.
I'll do an update to fix that soon. Edit: the bug in importing SpringPP games has been fixed in v0.4.0.

I'll have a look at that minimap patch.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Valle
Transport Coordinator
Transport Coordinator
Posts: 284
Joined: 15 May 2007 11:35
Location: Germany

Re: JGR's Patch Pack

Post by Valle »

Compiling fails with the current version (Github-zip) on my Mac. This should be the relevant part of the log.

Code: Select all

[SRC] Compiling pbs.cpp
/Users/Val/Downloads/OpenTTD-patches-jgrpp-2/src/pbs.cpp:472:124: error: use of
      undeclared identifier 'nullptr'
  ...trackdir, &IsSafeWaitingPositionTraceRestrictPreviousSignalCallback, nul...
                                                                          ^
1 error generated.
make[1]: *** [pbs.o] Error 1
make: *** [all] Error 1
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Valle wrote:Compiling fails with the current version (Github-zip) on my Mac. This should be the relevant part of the log.

Code: Select all

[SRC] Compiling pbs.cpp
/Users/Val/Downloads/OpenTTD-patches-jgrpp-2/src/pbs.cpp:472:124: error: use of
      undeclared identifier 'nullptr'
  ...trackdir, &IsSafeWaitingPositionTraceRestrictPreviousSignalCallback, nul...
                                                                          ^
1 error generated.
make[1]: *** [pbs.o] Error 1
make: *** [all] Error 1
Oops, I let another C++11ism slip in. If you replace nullptr by NULL it should compile. I'll do another update soon.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Tintinfan
Engineer
Engineer
Posts: 105
Joined: 29 Sep 2010 11:36

Re: JGR's Patch Pack

Post by Tintinfan »

Greetings JGR,


Firstly might I say what a wonderful job you've done with this patchpack. Myself and a few others have been having a great time with it on network games. Today I opted to update the server to 0.4.0 - however I can't quite seem to get the clients posted here for windows to align with what I compile on linux from git.

With the git pull and reset to revision 713f9fabc53a9062a2e162b0f7d3f1a62aaf616d (I believe that is the version in the source listed as the 0.4.0 release on github) there is no version mismatch; but during connecting windows clients are booted for a "revision mismatch". With a straight git pull the version of the server is listed as jgr-0.4.0-3-. Lastly I have tired with 776c93ca55086a2f28eaa7a822c3284a9ae306c8 which yielded a version mismatch similar to a straight git pull.

I'm probably doing something wrong here, but I can't see what!


Thank you in advance,

- Tin.
Regards,

Tinny/Tintinfan. :)
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Tintinfan wrote:Greetings JGR,


Firstly might I say what a wonderful job you've done with this patchpack. Myself and a few others have been having a great time with it on network games. Today I opted to update the server to 0.4.0 - however I can't quite seem to get the clients posted here for windows to align with what I compile on linux from git.

With the git pull and reset to revision 713f9fabc53a9062a2e162b0f7d3f1a62aaf616d (I believe that is the version in the source listed as the 0.4.0 release on github) there is no version mismatch; but during connecting windows clients are booted for a "revision mismatch". With a straight git pull the version of the server is listed as jgr-0.4.0-3-. Lastly I have tired with 776c93ca55086a2f28eaa7a822c3284a9ae306c8 which yielded a version mismatch similar to a straight git pull.

I'm probably doing something wrong here, but I can't see what!


Thank you in advance,

- Tin.
It seems that the windows builds had partially out of date version info, so the NewGRF version numbers did not match. I've made a change to the makefile which should prevent that in future and I'll do a 0.4.1 release shortly.
Many thanks for your comments, and the bug report :)
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Valle
Transport Coordinator
Transport Coordinator
Posts: 284
Joined: 15 May 2007 11:35
Location: Germany

Re: JGR's Patch Pack

Post by Valle »

Thank you for all your hard work. Version 0.4.1 compiles successfully (although with multiple warnings) but there is still an issue with the S2013PP savegames.
I truly admire the fact that you try to make your patchpack able to read them.

This particular save game does not feature any huge airports and I don't remember sending any aircraft to fishing grounds or oil rigs either.
Attachments
Bildschirmfoto 2015-09-06 um 17.09.49.png
Bildschirmfoto 2015-09-06 um 17.09.49.png (52.98 KiB) Viewed 22478 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2560
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Valle wrote:Thank you for all your hard work. Version 0.4.1 compiles successfully (although with multiple warnings) but there is still an issue with the S2013PP savegames.
I truly admire the fact that you try to make your patchpack able to read them.

This particular save game does not feature any huge airports and I don't remember sending any aircraft to fishing grounds or oil rigs either.
Can you post the SpringPP savegame? The only other thing I can think of off the top of my head is NewGRF airports.
Mizari wrote:But that one makes very large isometric ones. This one made small, top-view ones. And it saved one at the beginning of each year (it was in the Hard patch pack). Makes for very memorable maps accumulating.
Were you using the daily/monthly/yearly scripts patch for that?
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Valle
Transport Coordinator
Transport Coordinator
Posts: 284
Joined: 15 May 2007 11:35
Location: Germany

Re: JGR's Patch Pack

Post by Valle »

There you go. Please note that the upload to Dropbox's server is not complete yet and could take a while. This game has 41 MB and had its NewGRF list modified in-game.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: Ahrefs [Bot] and 15 guests