JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Snail wrote: 18 Apr 2021 16:50 Hey JGR,

I just tried to compile your latest version (0.41.0) on my system, which is OS X 10.12 . I could compile versions up to 0.40.5 with no problems, thanks to your previous fix.

Now, at around 60%, I come across the following error:

Code: Select all

[ 63%] Building CXX object CMakeFiles/openttd.dir/src/network/network_udp.cpp.o
/roba/OpenTTD-patches-jgrpp-0.41.0/src/network/network_udp.cpp:733:18: error: expected ';' after
      expression
        std::scoped_lock lock(_udp_client.mutex, _udp_server.mutex, _udp_master.mutex);
                        ^
                        ;
/roba/OpenTTD-patches-jgrpp-0.41.0/src/network/network_udp.cpp:733:7: error: no member named
      'scoped_lock' in namespace 'std'; did you mean 'adopt_lock'?
        std::scoped_lock lock(_udp_client.mutex, _udp_server.mutex, _udp_master.mutex);
        ~~~~~^~~~~~~~~~~
             adopt_lock
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__mutex_base:79:25: note: 
      'adopt_lock' declared here
constexpr adopt_lock_t  adopt_lock  = adopt_lock_t();
                        ^
/roba/OpenTTD-patches-jgrpp-0.41.0/src/network/network_udp.cpp:733:2: warning: expression result
      unused [-Wunused-value]
        std::scoped_lock lock(_udp_client.mutex, _udp_server.mutex, _udp_master.mutex);
        ^~~~~~~~~~~~~~~~
1 warning and 2 errors generated.
make[2]: *** [CMakeFiles/openttd.dir/src/network/network_udp.cpp.o] Error 1
make[1]: *** [CMakeFiles/openttd.dir/all] Error 2
make: *** [all] Error 2
Your Mac OS bin works fine with my system, so my question is more of a curiosity. Would this be an easy error to fix? If so, it'd be great if it could get fixed, since I would still welcome the opportunity of compiling your patchpack myself.

Thanks in advance!
This is from some upstream improvements to networking. I've added a workaround which should enable you to compile it.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Snail
Tycoon
Tycoon
Posts: 1283
Joined: 28 Apr 2003 18:52
Contact:

Re: JGR's Patch Pack

Post by Snail »

JGR wrote: 18 Apr 2021 20:53 This is from some upstream improvements to networking. I've added a workaround which should enable you to compile it.
Wow, thank you! Is it already in the source code on your GitHub?
The French Narrow Gauge Train Set is now released! Get it here
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Snail wrote: 18 Apr 2021 21:33
JGR wrote: 18 Apr 2021 20:53 This is from some upstream improvements to networking. I've added a workaround which should enable you to compile it.
Wow, thank you! Is it already in the source code on your GitHub?
Yes, I've already pushed it there.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Snail
Tycoon
Tycoon
Posts: 1283
Joined: 28 Apr 2003 18:52
Contact:

Re: JGR's Patch Pack

Post by Snail »

JGR wrote: 18 Apr 2021 22:02
Snail wrote: 18 Apr 2021 21:33
JGR wrote: 18 Apr 2021 20:53 This is from some upstream improvements to networking. I've added a workaround which should enable you to compile it.
Wow, thank you! Is it already in the source code on your GitHub?
Yes, I've already pushed it there.
Tried it, successfully compiled it, the game works just great.

Thank you so much! You're the best! :bow:
The French Narrow Gauge Train Set is now released! Get it here
User avatar
kamnet
Moderator
Moderator
Posts: 8548
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: JGR's Patch Pack

Post by kamnet »

EDIT: I may have figured it out - I was playing with OpenTTD 1.11.1 earlier and I had hardware acceleration and vsync enabled. Disabled those, re-launched, loaded fine. Leaving it here for JGR to double-check.
------------------------------------------------------------------
Just tried launching 0.41.0 and I'm hit with this error:

Error! Assertion failed at line 996 of /home/jgr/openttd/jgrpp/src/video/win32_v.cpp: _screen.dst_ptr != nullptr

Crash report below:
[+] Spoiler
*** OpenTTD Crash Report ***

Crash at: Mon Apr 19 04:27:57 2021
In game date: 2051-05-09 (27, 0) (DL: 1)
Game loaded at: 2051-05-09 (27, 0), Mon Apr 19 04:26:55 2021

Crash reason:
Exception: E1212012
Location: 00007FF878B14B59
Message: Assertion failed at line 996 of /home/jgr/openttd/jgrpp/src/video/win32_v.cpp: _screen.dst_ptr != nullptr

OpenTTD version:
Version: jgrpp-0.41.0 (0)
NewGRF ver: 1c006d64
Bits: 64
Endian: little
Dedicated: no
Build date: Apr 14 2021 21:22:06
Defines: NDEBUG WITH_BITMATH_BUILTINS WITH_OVERFLOW_BUILTINS WITH_DEMANGLE WITH_BFD0 WITH_DBGHELP TTD_ENDIAN=TTD_LITTLE_ENDIAN WITH_PNG WITH_ZLIB WITH_LIBLZMA WITH_LZO WITH_ZSTD WITH_OPENGL WITH_PERSONAL_DIR WITH_SSE WITH_ASSERT UNICODE _UNICODE WITH_UNISCRIBE _SQ64

Stack trace:
00000003 00000000 00000016 00000000 7A8F46B8 00007FF8 00000002 00000000
E1212012 00000000 00000000 00000000 78B14B59 00007FF8 00000000 00000000
0BF4AB90 00000000 004F0002 00000000 0000004F 00000001 00000002 00000000
00000044 00000000 00000000 00000000 00000000 00000000 001524C0 00000000
05200000 00000000 00150000 00000000 00150324 00000000 0BF4AB80 00000000
00000210 00000000 00150CC0 00000000 00000003 00000000 02000002 00000000
7CBD29A0 000028BC 7B396491 00007FF8 00000000 00000000 7A88ADFB 00007FF8
00000016 00000000 00000002 00000000 00000016 00000000 7A8F46B8 00007FF8
0000001A 00000000 03000003 00007FF8 07FA0101 00000000 7B39B800 00007FF8
00F38800 00000000 073A6A80 00000000 073A6AA8 00000000 0506CFA0 00000000
7A8BA6B0 00007FF8 7A88F1FB 00007FF8 00000001 00000000 00000000 00000000
61D6C618 167727DE 7B39FAA0 00007FF8 0BF41750 00000000 7B396491 00007FF8
05200000 00000000 00000000 00000000 0BF40F70 00000000 00000084 00000000
00000084 00000000 00000084 00000000 05200324 00000000 00000027 00000000
05200101 00000000 0506CA00 00000000 00000102 00000000 7B39B3C7 00007FF8
0BF40F80 00000000 20BE0027 00000000 0000037F 00000001 02000002 00000000
00000102 00000000 00000000 00000000 00000210 00000002 02000002 00000000
00000001 00000000 2D00002D 00000000 00000000 00000000 0BF40F70 00000000
00000208 00000000 00000002 00000000 00000084 00000000 052EB340 00000000
0520A6B4 00000000 00000102 00000000 00000000 00000000 7B395BA1 00007FF8
05200000 00000000 05200000 00000000 00000000 00000000 00000102 00000000
0BF4AB90 00000002 84000084 00007FF8 08604EF0 00000000 9E0020BE 00000000
00000000 00000000 02000002 00000000 085B3350 00000000 9E0020BE 00000000
00150000 00000000 763AE1F5 00007FF8 00000000 00000000 00000010 00000000

Registers:
RAX: 0000000000000000 RBX: 0000000000000016 RCX: 0000000000000022 RDX: 00007FF8764FB8D9
RSI: 00007FF87A8F46B8 RDI: 0000000000000000 RBP: 0000000000C84BE0 RSP: 000000000506C870
R8: 00000000FFFFFFFE R9: 000000000000004D R10: 0000000000000000 R11: 0000000000000000
R12: 0000000000000910 R13: 0000000000000000 R14: 00000000004D9620 R15: 0000000000000001
RIP: 00007FF878B14B59 EFLAGS: 00000202

Bytes at instruction pointer:
0F 1F 44 00 00 48 8B 8C 24 C0 00 00 00 48 33 CC E8 72 95 05 00 48 81 C4

Operating system:
Name: Windows
Release: 10.0.19042 ()
Compiler: GCC 9.3.0 "9.3-win32 20200320"

Configuration:
Blitter: 32bpp-anim
Graphics set: OpenGFX (7761)
Language: C:\Users\kyxti\Google Drive\OpenTTD\OpenTTD Patch Packs\1. JGR Patch Pack\openttd-jgrpp-0.41.0-windows-win64\lang\english_US.lng
Music driver: dmusic
Music set: OpenMSX (7761)
Network: no
Sound driver: win32
Sound set: OpenSFX (7758)
Video driver: win32-opengl
Pathfinder: YAPF YAPF NPF

Fonts:
Small: Arial Bold
Medium: Arial Bold
Large: Arial Bold
Mono: sprite

Map size: 0x10000 (256 x 256)

AI Configuration (local: 0) (current: 0):
0: Human

Libraries:
LZMA: 5.2.1
ZSTD: 1.4.8
LZO: 2.09
PNG: 1.5.23
Zlib: 1.2.8

Module information:
C:\Users\kyxti\Google Drive\OpenTTD\OpenTTD Patch Packs\1. JGR Patch Pack\openttd-jgrpp-0.41.0-windows-win64\openttd.exe handle: 0000000000400000 size: 56415746 crc: B988769F date: 2021-04-14 20:22:11
C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007ff87b370000 size: 2024728 crc: 4399D735 date: 2021-04-13 23:31:40
C:\WINDOWS\System32\KERNEL32.DLL handle: 00007ff87a7a0000 size: 764976 crc: 3A191151 date: 2021-04-13 23:31:20
C:\WINDOWS\System32\KERNELBASE.dll handle: 00007ff878ae0000 size: 2919288 crc: EAF99E19 date: 2021-04-13 23:31:42
C:\WINDOWS\SYSTEM32\apphelp.dll handle: 00007ff876360000 size: 570880 crc: EC8E5911 date: 2021-04-13 23:31:36
C:\WINDOWS\System32\ADVAPI32.dll handle: 00007ff87ae90000 size: 689024 crc: 355A9B19 date: 2021-02-14 03:33:42
C:\WINDOWS\System32\msvcrt.dll handle: 00007ff87a860000 size: 637360 crc: 072737D9 date: 2021-02-14 03:34:49
C:\WINDOWS\System32\sechost.dll handle: 00007ff8793e0000 size: 625496 crc: E09B47D4 date: 2021-04-13 23:31:42
C:\WINDOWS\System32\RPCRT4.dll handle: 00007ff87b120000 size: 1220520 crc: BB501898 date: 2021-04-13 23:31:42
C:\WINDOWS\System32\GDI32.dll handle: 00007ff879480000 size: 161680 crc: 2A141BAA date: 2021-02-14 03:34:15
C:\WINDOWS\System32\win32u.dll handle: 00007ff879020000 size: 132760 crc: 167E1EAD date: 2021-04-13 23:31:30
C:\WINDOWS\System32\gdi32full.dll handle: 00007ff878f10000 size: 1075880 crc: 6C19849E date: 2021-04-13 23:31:46
C:\WINDOWS\System32\msvcp_win.dll handle: 00007ff879330000 size: 634760 crc: E6732639 date: 2021-02-14 03:34:47
C:\WINDOWS\System32\ucrtbase.dll handle: 00007ff879050000 size: 1044888 crc: D3CA62A3 date: 2021-02-14 03:34:47
C:\WINDOWS\System32\USER32.dll handle: 00007ff87a990000 size: 1702416 crc: 73C75F75 date: 2021-04-13 23:31:30
C:\WINDOWS\System32\IMM32.dll handle: 00007ff87ac50000 size: 185448 crc: 36F61BF6 date: 2021-02-14 03:34:53
C:\WINDOWS\System32\ole32.dll handle: 00007ff87a670000 size: 1212232 crc: 0FD6B05F date: 2021-02-14 03:34:43
C:\WINDOWS\System32\combase.dll handle: 00007ff87a280000 size: 3506992 crc: C1B1E60F date: 2021-04-13 23:31:38
C:\WINDOWS\System32\SHELL32.dll handle: 00007ff879920000 size: 7637008 crc: 57C77621 date: 2021-04-13 23:31:49
C:\WINDOWS\System32\WS2_32.dll handle: 00007ff87a920000 size: 427200 crc: 6E37A637 date: 2021-02-14 03:34:52
C:\WINDOWS\SYSTEM32\OPENGL32.dll handle: 00007ff85a370000 size: 1064448 crc: A63281AE date: 2021-04-13 23:32:09
C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007ff86d6e0000 size: 147200 crc: 18D40339 date: 2021-02-14 03:33:37
C:\WINDOWS\SYSTEM32\USP10.dll handle: 00007ff873b90000 size: 79360 crc: 9A7F7CC2 date: 2021-02-14 03:34:53
C:\WINDOWS\SYSTEM32\GLU32.dll handle: 00007ff864480000 size: 164352 crc: DA0CBD61 date: 2021-02-27 02:57:51
C:\WINDOWS\SYSTEM32\CRYPTSP.dll handle: 00007ff878780000 size: 83744 crc: DDF7045E date: 2021-02-14 03:34:47
C:\WINDOWS\system32\rsaenh.dll handle: 00007ff877b80000 size: 207608 crc: 4A244345 date: 2021-02-14 03:34:48
C:\WINDOWS\System32\bcrypt.dll handle: 00007ff878ab0000 size: 146240 crc: 50F3C5E2 date: 2021-02-14 03:34:47
C:\WINDOWS\SYSTEM32\CRYPTBASE.dll handle: 00007ff8783b0000 size: 34152 crc: CC386121 date: 2021-02-14 03:34:50
C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007ff8792b0000 size: 523200 crc: 1A4DFB8D date: 2021-02-14 03:34:52
C:\WINDOWS\SYSTEM32\windows.storage.dll handle: 00007ff876bb0000 size: 7968600 crc: A4E92974 date: 2021-04-13 23:31:29
C:\WINDOWS\SYSTEM32\Wldp.dll handle: 00007ff878450000 size: 173016 crc: C5218D0B date: 2021-02-14 03:34:47
C:\WINDOWS\System32\SHCORE.dll handle: 00007ff87ad50000 size: 704008 crc: 0812F61E date: 2021-02-14 03:34:27
C:\WINDOWS\System32\shlwapi.dll handle: 00007ff87a220000 size: 342440 crc: 5693748E date: 2021-02-14 03:35:12
C:\WINDOWS\system32\uxtheme.dll handle: 00007ff8764f0000 size: 627712 crc: A05B5F55 date: 2021-02-14 03:35:04
C:\WINDOWS\System32\MSCTF.dll handle: 00007ff87ab30000 size: 1128008 crc: 3E23452A date: 2021-04-13 23:31:43
C:\WINDOWS\System32\OLEAUT32.dll handle: 00007ff87afa0000 size: 831024 crc: 8304FB12 date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\kernel.appcore.dll handle: 00007ff8769b0000 size: 60464 crc: 7039ACC9 date: 2021-02-14 03:34:22
C:\WINDOWS\System32\clbcatq.dll handle: 00007ff87b070000 size: 672976 crc: AD4CB4A3 date: 2021-02-14 03:34:43
C:\WINDOWS\SYSTEM32\nvoglv64.DLL handle: 0000000069af0000 size: 31523384 crc: 1A74915F date: 2016-11-14 12:30:58
C:\WINDOWS\System32\SETUPAPI.dll handle: 00007ff8794b0000 size: 4650576 crc: F65AC9E1 date: 2021-02-27 02:57:29
C:\WINDOWS\System32\cfgmgr32.dll handle: 00007ff8791b0000 size: 305272 crc: DE2280BE date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\WTSAPI32.dll handle: 00007ff873300000 size: 67192 crc: 7604358D date: 2021-02-14 03:33:46
C:\WINDOWS\SYSTEM32\VERSION.dll handle: 00007ff86d660000 size: 31496 crc: 546E295F date: 2021-02-14 03:35:12
C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 00007ff8777b0000 size: 191656 crc: B2A51DA2 date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\powrprof.dll handle: 00007ff878060000 size: 295464 crc: 74230007 date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\UMPDC.dll handle: 00007ff877ed0000 size: 64552 crc: B19D9CE1 date: 2021-02-14 03:33:37
C:\WINDOWS\SYSTEM32\WINSTA.dll handle: 00007ff877820000 size: 351200 crc: D09048B8 date: 2021-02-14 03:33:46
C:\WINDOWS\system32\dwmapi.dll handle: 00007ff8768a0000 size: 168408 crc: BE283206 date: 2021-02-14 03:34:43
C:\WINDOWS\SYSTEM32\textinputframework.dll handle: 00007ff8683c0000 size: 1016456 crc: 1AA07241 date: 2021-04-13 23:31:27
C:\WINDOWS\SYSTEM32\CoreMessaging.dll handle: 00007ff8760f0000 size: 986464 crc: EDF107E3 date: 2021-02-14 03:34:43
C:\WINDOWS\SYSTEM32\CoreUIComponents.dll handle: 00007ff875d90000 size: 3537520 crc: 78335519 date: 2021-02-14 03:34:13
C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007ff8756c0000 size: 1394016 crc: BD196440 date: 2021-04-13 23:31:38
C:\WINDOWS\SYSTEM32\dxgi.dll handle: 00007ff8773b0000 size: 979792 crc: 3FEC10DC date: 2021-04-13 23:31:27
C:\WINDOWS\SYSTEM32\d3d11.dll handle: 00007ff874a30000 size: 2503504 crc: D4639E70 date: 2021-02-14 03:34:14
C:\WINDOWS\SYSTEM32\nvwgf2umx.dll handle: 00007ff865640000 size: 18634216 crc: 44801F1C date: 2016-11-14 12:30:58
C:\WINDOWS\System32\PSAPI.DLL handle: 00007ff87a5e0000 size: 19144 crc: 6E06CEEB date: 2021-02-14 03:34:42
C:\WINDOWS\SYSTEM32\dxcore.dll handle: 00007ff8650f0000 size: 219016 crc: 72966353 date: 2021-02-14 03:33:59
C:\WINDOWS\system32\mswsock.dll handle: 00007ff878230000 size: 418416 crc: 7609CC3B date: 2021-02-14 03:34:47
C:\WINDOWS\SYSTEM32\winmmbase.dll handle: 00007ff855540000 size: 144592 crc: B331D5DD date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007ff8728d0000 size: 529424 crc: DFC9B2A0 date: 2021-02-14 03:33:36
C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 00007ff878860000 size: 165832 crc: 9AB2CB9F date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007ff868ac0000 size: 259584 crc: DB966BEF date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007ff873bb0000 size: 23264 crc: A73C3DE9 date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007ff873090000 size: 30480 crc: D6790ED2 date: 2021-02-14 03:33:36
C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007ff872960000 size: 1566600 crc: 9603B6F2 date: 2021-04-13 23:31:15
C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007ff873b60000 size: 30208 crc: 414EBD44 date: 2021-02-14 03:33:36
C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007ff860a60000 size: 112080 crc: 7C3515A4 date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007ff873b50000 size: 26624 crc: C81948B1 date: 2021-02-14 03:33:36
C:\WINDOWS\System32\dmusic.dll handle: 00007ff8602d0000 size: 136192 crc: BDA2573A date: 2019-12-07 09:09:37
C:\WINDOWS\System32\DSOUND.dll handle: 00007ff85d6c0000 size: 615424 crc: 1C78A884 date: 2019-12-07 09:08:07
C:\WINDOWS\System32\WINTRUST.dll handle: 00007ff879150000 size: 382720 crc: 255FF0BB date: 2021-02-14 03:34:22
C:\WINDOWS\System32\CRYPT32.dll handle: 00007ff878db0000 size: 1425440 crc: 71673E8A date: 2021-02-27 02:57:23
C:\WINDOWS\System32\MSASN1.dll handle: 00007ff878820000 size: 64072 crc: FDFACF86 date: 2021-02-14 03:34:47
C:\WINDOWS\System32\dmsynth.dll handle: 00007ff860230000 size: 126464 crc: 2A50C1AD date: 2019-12-07 09:09:37
C:\WINDOWS\SYSTEM32\resourcepolicyclient.dll handle: 00007ff8765d0000 size: 71784 crc: 38C47F6A date: 2021-02-14 03:33:56
C:\Windows\System32\Windows.UI.dll handle: 00007ff8684c0000 size: 1317544 crc: C59FEC4F date: 2021-02-14 03:34:33
C:\Windows\System32\InputHost.dll handle: 00007ff8681b0000 size: 1378064 crc: FEEFA38C date: 2021-04-13 23:31:28
C:\Windows\System32\WindowManagementAPI.dll handle: 00007ff868310000 size: 643072 crc: 4D2F7971 date: 2021-02-14 03:34:21
C:\WINDOWS\SYSTEM32\twinapi.appcore.dll handle: 00007ff871570000 size: 2100112 crc: 607D6B93 date: 2021-02-14 03:33:57
C:\Windows\System32\PROPSYS.dll handle: 00007ff874670000 size: 1009232 crc: A53AC761 date: 2021-03-16 19:34:17
C:\WINDOWS\SYSTEM32\TextShaping.dll handle: 00007ff865000000 size: 707016 crc: 49A4E545 date: 2021-03-16 19:34:16

---- gamelog start ----
Tick 62675: game loaded
Conversion from OTTD savegame without gamelog: version 4, 1
Revision text changed to jgrpp-0.41.0, savegame version 290, not modified, _openttd_newgrf_version = 0x1c006d64
New game mode: 0 landscape: 1
---- gamelog end ----

Recent news messages (0 of 0):

Command Log:
Showing most recent 0 of 0 commands

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE 0x00007FF878B14B59 RaiseException + 105
[01] msvcrt 0x00007FF87A88ADFB raise + 539
[02] msvcrt 0x00007FF87A88F1FB abort + 27
[03] openttd 0x0000000000618996 error(char const*, ...) + 118 (/home/jgr/openttd/jgrpp/src/openttd.cpp:171)
[04] openttd 0x000000000053231F VideoDriver_Win32Base::LockVideoBuffer() + 111 (/home/jgr/openttd/jgrpp/src/video/win32_v.cpp:996)
[05] openttd 0x000000000053680D VideoDriver::Tick() + 973 (/home/jgr/openttd/jgrpp/src/video/video_driver.cpp:175)
[06] openttd 0x0000000000531BD8 VideoDriver_Win32Base::MainLoop() + 40 (/home/jgr/openttd/jgrpp/src/video/win32_v.cpp:873)
[07] openttd 0x000000000061B973 openttd_main(int, char**) + 6595 (/home/jgr/openttd/jgrpp/src/openttd.cpp:998)
[08] openttd 0x00000000004E0656 WinMain + 342 (/home/jgr/openttd/jgrpp/src/os/windows/win32.cpp:441)
[09] openttd 0x00000000004013B4 __tmainCRTStartup + 564 (./build/x86_64-w64-mingw32-x86_64-w64-mingw32-crt/./mingw-w64-crt/crt/crtexe.c:339)
[10] openttd 0x00000000004014DB WinMainCRTStartup + 27 (./build/x86_64-w64-mingw32-x86_64-w64-mingw32-crt/./mingw-w64-crt/crt/crtexe.c:195)
[11] KERNEL32 0x00007FF87A7B7034 BaseThreadInitThunk + 20
[12] ntdll 0x00007FF87B3C2651 RtlUserThreadStart + 33

*** End of additional info ***
Attachments
crash-20210419T042800Z.sav
(154.07 KiB) Downloaded 64 times
Nrgte
Engineer
Engineer
Posts: 3
Joined: 19 Apr 2021 10:46

Re: JGR's Patch Pack

Post by Nrgte »

Hello everyone, I'm trying to compile the Patch Pack from source. Which generally works, however when I launch the game, load a save and zoom out on the map it lags a lot. It generally seems that my compiled version runs a lot slower. Map generation is slower too. I'm building on Windows with Visual Studio Community 2019.

I've tested the same with vanilla OpenTTD and the same issue occurs there too, so it's probably an issue with some settings. Has anyone experienced this and knows a solution?

I've tried changing the configuration from Debug to Release, but that made no difference.
User avatar
mxnp
Engineer
Engineer
Posts: 17
Joined: 08 Mar 2021 14:48

Re: JGR's Patch Pack

Post by mxnp »

Hey JGR,
I've noticed that in v0.41.0 house IDs have been increased. I wonder if a similar increase could also be done to the current maximum of 64 road types?
Thanks!
Auge
Director
Director
Posts: 633
Joined: 23 Oct 2006 02:07
Location: Berlin

Re: JGR's Patch Pack

Post by Auge »

Hello
mxnp wrote: 20 Apr 2021 12:36 I've noticed that in v0.41.0 house IDs have been increased. I wonder if a similar increase could also be done to the current maximum of 64 road types?
Holy s***! What the heck wants one with more than 64 road types? I am a bit overwhelmed with testing my own set in development with currently only 10 types. ;-))

Tschö, Auge
User avatar
Snail
Tycoon
Tycoon
Posts: 1283
Joined: 28 Apr 2003 18:52
Contact:

Re: JGR's Patch Pack

Post by Snail »

Auge wrote: 20 Apr 2021 13:59 Hello
mxnp wrote: 20 Apr 2021 12:36 I've noticed that in v0.41.0 house IDs have been increased. I wonder if a similar increase could also be done to the current maximum of 64 road types?
Holy s***! What the heck wants one with more than 64 road types? I am a bit overwhelmed with testing my own set in development with currently only 10 types. ;-))

Tschö, Auge
"640Kb will be enough for everyone" :p
I'm starting to think that 64 rail types might not be enough :lol: but I wouldn't dare to ask our OTTD developers to increase that limit.
The French Narrow Gauge Train Set is now released! Get it here
User avatar
mxnp
Engineer
Engineer
Posts: 17
Joined: 08 Mar 2021 14:48

Re: JGR's Patch Pack

Post by mxnp »

Auge wrote: 20 Apr 2021 13:59 Holy s***! What the heck wants one with more than 64 road types? I am a bit overwhelmed with testing my own set in development with currently only 10 types. ;-))
Snail wrote: 20 Apr 2021 14:27 "640Kb will be enough for everyone" :p
I'm starting to think that 64 rail types might not be enough :lol: but I wouldn't dare to ask our OTTD developers to increase that limit.
HAHA I was scared to ask this question. I promise I'm not going insane with all your GRF releases, yet!
Unfortunately you start running out when using the latest U&RaTT with GarryG's AuzRoads—maybe I'll just make my own personal set in the future.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

mxnp wrote: 20 Apr 2021 12:36 Hey JGR,
I've noticed that in v0.41.0 house IDs have been increased. I wonder if a similar increase could also be done to the current maximum of 64 road types?
Thanks!
I'm not going to be doing that.
64 types is already too many from a UI point of view.
Having more and more types to compensate for the lack of composability of road/tram properties isn't a good approach.

Most sets with large number of types have minuscule differences between most of them.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

kamnet wrote: 19 Apr 2021 04:34 EDIT: I may have figured it out - I was playing with OpenTTD 1.11.1 earlier and I had hardware acceleration and vsync enabled. Disabled those, re-launched, loaded fine. Leaving it here for JGR to double-check.
------------------------------------------------------------------
Just tried launching 0.41.0 and I'm hit with this error:

Error! Assertion failed at line 996 of /home/jgr/openttd/jgrpp/src/video/win32_v.cpp: _screen.dst_ptr != nullptr

Crash report below:
[+] Spoiler
*** OpenTTD Crash Report ***

Crash at: Mon Apr 19 04:27:57 2021
In game date: 2051-05-09 (27, 0) (DL: 1)
Game loaded at: 2051-05-09 (27, 0), Mon Apr 19 04:26:55 2021

Crash reason:
Exception: E1212012
Location: 00007FF878B14B59
Message: Assertion failed at line 996 of /home/jgr/openttd/jgrpp/src/video/win32_v.cpp: _screen.dst_ptr != nullptr

OpenTTD version:
Version: jgrpp-0.41.0 (0)
NewGRF ver: 1c006d64
Bits: 64
Endian: little
Dedicated: no
Build date: Apr 14 2021 21:22:06
Defines: NDEBUG WITH_BITMATH_BUILTINS WITH_OVERFLOW_BUILTINS WITH_DEMANGLE WITH_BFD0 WITH_DBGHELP TTD_ENDIAN=TTD_LITTLE_ENDIAN WITH_PNG WITH_ZLIB WITH_LIBLZMA WITH_LZO WITH_ZSTD WITH_OPENGL WITH_PERSONAL_DIR WITH_SSE WITH_ASSERT UNICODE _UNICODE WITH_UNISCRIBE _SQ64

Stack trace:
00000003 00000000 00000016 00000000 7A8F46B8 00007FF8 00000002 00000000
E1212012 00000000 00000000 00000000 78B14B59 00007FF8 00000000 00000000
0BF4AB90 00000000 004F0002 00000000 0000004F 00000001 00000002 00000000
00000044 00000000 00000000 00000000 00000000 00000000 001524C0 00000000
05200000 00000000 00150000 00000000 00150324 00000000 0BF4AB80 00000000
00000210 00000000 00150CC0 00000000 00000003 00000000 02000002 00000000
7CBD29A0 000028BC 7B396491 00007FF8 00000000 00000000 7A88ADFB 00007FF8
00000016 00000000 00000002 00000000 00000016 00000000 7A8F46B8 00007FF8
0000001A 00000000 03000003 00007FF8 07FA0101 00000000 7B39B800 00007FF8
00F38800 00000000 073A6A80 00000000 073A6AA8 00000000 0506CFA0 00000000
7A8BA6B0 00007FF8 7A88F1FB 00007FF8 00000001 00000000 00000000 00000000
61D6C618 167727DE 7B39FAA0 00007FF8 0BF41750 00000000 7B396491 00007FF8
05200000 00000000 00000000 00000000 0BF40F70 00000000 00000084 00000000
00000084 00000000 00000084 00000000 05200324 00000000 00000027 00000000
05200101 00000000 0506CA00 00000000 00000102 00000000 7B39B3C7 00007FF8
0BF40F80 00000000 20BE0027 00000000 0000037F 00000001 02000002 00000000
00000102 00000000 00000000 00000000 00000210 00000002 02000002 00000000
00000001 00000000 2D00002D 00000000 00000000 00000000 0BF40F70 00000000
00000208 00000000 00000002 00000000 00000084 00000000 052EB340 00000000
0520A6B4 00000000 00000102 00000000 00000000 00000000 7B395BA1 00007FF8
05200000 00000000 05200000 00000000 00000000 00000000 00000102 00000000
0BF4AB90 00000002 84000084 00007FF8 08604EF0 00000000 9E0020BE 00000000
00000000 00000000 02000002 00000000 085B3350 00000000 9E0020BE 00000000
00150000 00000000 763AE1F5 00007FF8 00000000 00000000 00000010 00000000

Registers:
RAX: 0000000000000000 RBX: 0000000000000016 RCX: 0000000000000022 RDX: 00007FF8764FB8D9
RSI: 00007FF87A8F46B8 RDI: 0000000000000000 RBP: 0000000000C84BE0 RSP: 000000000506C870
R8: 00000000FFFFFFFE R9: 000000000000004D R10: 0000000000000000 R11: 0000000000000000
R12: 0000000000000910 R13: 0000000000000000 R14: 00000000004D9620 R15: 0000000000000001
RIP: 00007FF878B14B59 EFLAGS: 00000202

Bytes at instruction pointer:
0F 1F 44 00 00 48 8B 8C 24 C0 00 00 00 48 33 CC E8 72 95 05 00 48 81 C4

Operating system:
Name: Windows
Release: 10.0.19042 ()
Compiler: GCC 9.3.0 "9.3-win32 20200320"

Configuration:
Blitter: 32bpp-anim
Graphics set: OpenGFX (7761)
Language: C:\Users\kyxti\Google Drive\OpenTTD\OpenTTD Patch Packs\1. JGR Patch Pack\openttd-jgrpp-0.41.0-windows-win64\lang\english_US.lng
Music driver: dmusic
Music set: OpenMSX (7761)
Network: no
Sound driver: win32
Sound set: OpenSFX (7758)
Video driver: win32-opengl
Pathfinder: YAPF YAPF NPF

Fonts:
Small: Arial Bold
Medium: Arial Bold
Large: Arial Bold
Mono: sprite

Map size: 0x10000 (256 x 256)

AI Configuration (local: 0) (current: 0):
0: Human

Libraries:
LZMA: 5.2.1
ZSTD: 1.4.8
LZO: 2.09
PNG: 1.5.23
Zlib: 1.2.8

Module information:
C:\Users\kyxti\Google Drive\OpenTTD\OpenTTD Patch Packs\1. JGR Patch Pack\openttd-jgrpp-0.41.0-windows-win64\openttd.exe handle: 0000000000400000 size: 56415746 crc: B988769F date: 2021-04-14 20:22:11
C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007ff87b370000 size: 2024728 crc: 4399D735 date: 2021-04-13 23:31:40
C:\WINDOWS\System32\KERNEL32.DLL handle: 00007ff87a7a0000 size: 764976 crc: 3A191151 date: 2021-04-13 23:31:20
C:\WINDOWS\System32\KERNELBASE.dll handle: 00007ff878ae0000 size: 2919288 crc: EAF99E19 date: 2021-04-13 23:31:42
C:\WINDOWS\SYSTEM32\apphelp.dll handle: 00007ff876360000 size: 570880 crc: EC8E5911 date: 2021-04-13 23:31:36
C:\WINDOWS\System32\ADVAPI32.dll handle: 00007ff87ae90000 size: 689024 crc: 355A9B19 date: 2021-02-14 03:33:42
C:\WINDOWS\System32\msvcrt.dll handle: 00007ff87a860000 size: 637360 crc: 072737D9 date: 2021-02-14 03:34:49
C:\WINDOWS\System32\sechost.dll handle: 00007ff8793e0000 size: 625496 crc: E09B47D4 date: 2021-04-13 23:31:42
C:\WINDOWS\System32\RPCRT4.dll handle: 00007ff87b120000 size: 1220520 crc: BB501898 date: 2021-04-13 23:31:42
C:\WINDOWS\System32\GDI32.dll handle: 00007ff879480000 size: 161680 crc: 2A141BAA date: 2021-02-14 03:34:15
C:\WINDOWS\System32\win32u.dll handle: 00007ff879020000 size: 132760 crc: 167E1EAD date: 2021-04-13 23:31:30
C:\WINDOWS\System32\gdi32full.dll handle: 00007ff878f10000 size: 1075880 crc: 6C19849E date: 2021-04-13 23:31:46
C:\WINDOWS\System32\msvcp_win.dll handle: 00007ff879330000 size: 634760 crc: E6732639 date: 2021-02-14 03:34:47
C:\WINDOWS\System32\ucrtbase.dll handle: 00007ff879050000 size: 1044888 crc: D3CA62A3 date: 2021-02-14 03:34:47
C:\WINDOWS\System32\USER32.dll handle: 00007ff87a990000 size: 1702416 crc: 73C75F75 date: 2021-04-13 23:31:30
C:\WINDOWS\System32\IMM32.dll handle: 00007ff87ac50000 size: 185448 crc: 36F61BF6 date: 2021-02-14 03:34:53
C:\WINDOWS\System32\ole32.dll handle: 00007ff87a670000 size: 1212232 crc: 0FD6B05F date: 2021-02-14 03:34:43
C:\WINDOWS\System32\combase.dll handle: 00007ff87a280000 size: 3506992 crc: C1B1E60F date: 2021-04-13 23:31:38
C:\WINDOWS\System32\SHELL32.dll handle: 00007ff879920000 size: 7637008 crc: 57C77621 date: 2021-04-13 23:31:49
C:\WINDOWS\System32\WS2_32.dll handle: 00007ff87a920000 size: 427200 crc: 6E37A637 date: 2021-02-14 03:34:52
C:\WINDOWS\SYSTEM32\OPENGL32.dll handle: 00007ff85a370000 size: 1064448 crc: A63281AE date: 2021-04-13 23:32:09
C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007ff86d6e0000 size: 147200 crc: 18D40339 date: 2021-02-14 03:33:37
C:\WINDOWS\SYSTEM32\USP10.dll handle: 00007ff873b90000 size: 79360 crc: 9A7F7CC2 date: 2021-02-14 03:34:53
C:\WINDOWS\SYSTEM32\GLU32.dll handle: 00007ff864480000 size: 164352 crc: DA0CBD61 date: 2021-02-27 02:57:51
C:\WINDOWS\SYSTEM32\CRYPTSP.dll handle: 00007ff878780000 size: 83744 crc: DDF7045E date: 2021-02-14 03:34:47
C:\WINDOWS\system32\rsaenh.dll handle: 00007ff877b80000 size: 207608 crc: 4A244345 date: 2021-02-14 03:34:48
C:\WINDOWS\System32\bcrypt.dll handle: 00007ff878ab0000 size: 146240 crc: 50F3C5E2 date: 2021-02-14 03:34:47
C:\WINDOWS\SYSTEM32\CRYPTBASE.dll handle: 00007ff8783b0000 size: 34152 crc: CC386121 date: 2021-02-14 03:34:50
C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007ff8792b0000 size: 523200 crc: 1A4DFB8D date: 2021-02-14 03:34:52
C:\WINDOWS\SYSTEM32\windows.storage.dll handle: 00007ff876bb0000 size: 7968600 crc: A4E92974 date: 2021-04-13 23:31:29
C:\WINDOWS\SYSTEM32\Wldp.dll handle: 00007ff878450000 size: 173016 crc: C5218D0B date: 2021-02-14 03:34:47
C:\WINDOWS\System32\SHCORE.dll handle: 00007ff87ad50000 size: 704008 crc: 0812F61E date: 2021-02-14 03:34:27
C:\WINDOWS\System32\shlwapi.dll handle: 00007ff87a220000 size: 342440 crc: 5693748E date: 2021-02-14 03:35:12
C:\WINDOWS\system32\uxtheme.dll handle: 00007ff8764f0000 size: 627712 crc: A05B5F55 date: 2021-02-14 03:35:04
C:\WINDOWS\System32\MSCTF.dll handle: 00007ff87ab30000 size: 1128008 crc: 3E23452A date: 2021-04-13 23:31:43
C:\WINDOWS\System32\OLEAUT32.dll handle: 00007ff87afa0000 size: 831024 crc: 8304FB12 date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\kernel.appcore.dll handle: 00007ff8769b0000 size: 60464 crc: 7039ACC9 date: 2021-02-14 03:34:22
C:\WINDOWS\System32\clbcatq.dll handle: 00007ff87b070000 size: 672976 crc: AD4CB4A3 date: 2021-02-14 03:34:43
C:\WINDOWS\SYSTEM32\nvoglv64.DLL handle: 0000000069af0000 size: 31523384 crc: 1A74915F date: 2016-11-14 12:30:58
C:\WINDOWS\System32\SETUPAPI.dll handle: 00007ff8794b0000 size: 4650576 crc: F65AC9E1 date: 2021-02-27 02:57:29
C:\WINDOWS\System32\cfgmgr32.dll handle: 00007ff8791b0000 size: 305272 crc: DE2280BE date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\WTSAPI32.dll handle: 00007ff873300000 size: 67192 crc: 7604358D date: 2021-02-14 03:33:46
C:\WINDOWS\SYSTEM32\VERSION.dll handle: 00007ff86d660000 size: 31496 crc: 546E295F date: 2021-02-14 03:35:12
C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 00007ff8777b0000 size: 191656 crc: B2A51DA2 date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\powrprof.dll handle: 00007ff878060000 size: 295464 crc: 74230007 date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\UMPDC.dll handle: 00007ff877ed0000 size: 64552 crc: B19D9CE1 date: 2021-02-14 03:33:37
C:\WINDOWS\SYSTEM32\WINSTA.dll handle: 00007ff877820000 size: 351200 crc: D09048B8 date: 2021-02-14 03:33:46
C:\WINDOWS\system32\dwmapi.dll handle: 00007ff8768a0000 size: 168408 crc: BE283206 date: 2021-02-14 03:34:43
C:\WINDOWS\SYSTEM32\textinputframework.dll handle: 00007ff8683c0000 size: 1016456 crc: 1AA07241 date: 2021-04-13 23:31:27
C:\WINDOWS\SYSTEM32\CoreMessaging.dll handle: 00007ff8760f0000 size: 986464 crc: EDF107E3 date: 2021-02-14 03:34:43
C:\WINDOWS\SYSTEM32\CoreUIComponents.dll handle: 00007ff875d90000 size: 3537520 crc: 78335519 date: 2021-02-14 03:34:13
C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007ff8756c0000 size: 1394016 crc: BD196440 date: 2021-04-13 23:31:38
C:\WINDOWS\SYSTEM32\dxgi.dll handle: 00007ff8773b0000 size: 979792 crc: 3FEC10DC date: 2021-04-13 23:31:27
C:\WINDOWS\SYSTEM32\d3d11.dll handle: 00007ff874a30000 size: 2503504 crc: D4639E70 date: 2021-02-14 03:34:14
C:\WINDOWS\SYSTEM32\nvwgf2umx.dll handle: 00007ff865640000 size: 18634216 crc: 44801F1C date: 2016-11-14 12:30:58
C:\WINDOWS\System32\PSAPI.DLL handle: 00007ff87a5e0000 size: 19144 crc: 6E06CEEB date: 2021-02-14 03:34:42
C:\WINDOWS\SYSTEM32\dxcore.dll handle: 00007ff8650f0000 size: 219016 crc: 72966353 date: 2021-02-14 03:33:59
C:\WINDOWS\system32\mswsock.dll handle: 00007ff878230000 size: 418416 crc: 7609CC3B date: 2021-02-14 03:34:47
C:\WINDOWS\SYSTEM32\winmmbase.dll handle: 00007ff855540000 size: 144592 crc: B331D5DD date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007ff8728d0000 size: 529424 crc: DFC9B2A0 date: 2021-02-14 03:33:36
C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 00007ff878860000 size: 165832 crc: 9AB2CB9F date: 2021-02-14 03:34:48
C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007ff868ac0000 size: 259584 crc: DB966BEF date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007ff873bb0000 size: 23264 crc: A73C3DE9 date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007ff873090000 size: 30480 crc: D6790ED2 date: 2021-02-14 03:33:36
C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007ff872960000 size: 1566600 crc: 9603B6F2 date: 2021-04-13 23:31:15
C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007ff873b60000 size: 30208 crc: 414EBD44 date: 2021-02-14 03:33:36
C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007ff860a60000 size: 112080 crc: 7C3515A4 date: 2019-12-07 09:08:07
C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007ff873b50000 size: 26624 crc: C81948B1 date: 2021-02-14 03:33:36
C:\WINDOWS\System32\dmusic.dll handle: 00007ff8602d0000 size: 136192 crc: BDA2573A date: 2019-12-07 09:09:37
C:\WINDOWS\System32\DSOUND.dll handle: 00007ff85d6c0000 size: 615424 crc: 1C78A884 date: 2019-12-07 09:08:07
C:\WINDOWS\System32\WINTRUST.dll handle: 00007ff879150000 size: 382720 crc: 255FF0BB date: 2021-02-14 03:34:22
C:\WINDOWS\System32\CRYPT32.dll handle: 00007ff878db0000 size: 1425440 crc: 71673E8A date: 2021-02-27 02:57:23
C:\WINDOWS\System32\MSASN1.dll handle: 00007ff878820000 size: 64072 crc: FDFACF86 date: 2021-02-14 03:34:47
C:\WINDOWS\System32\dmsynth.dll handle: 00007ff860230000 size: 126464 crc: 2A50C1AD date: 2019-12-07 09:09:37
C:\WINDOWS\SYSTEM32\resourcepolicyclient.dll handle: 00007ff8765d0000 size: 71784 crc: 38C47F6A date: 2021-02-14 03:33:56
C:\Windows\System32\Windows.UI.dll handle: 00007ff8684c0000 size: 1317544 crc: C59FEC4F date: 2021-02-14 03:34:33
C:\Windows\System32\InputHost.dll handle: 00007ff8681b0000 size: 1378064 crc: FEEFA38C date: 2021-04-13 23:31:28
C:\Windows\System32\WindowManagementAPI.dll handle: 00007ff868310000 size: 643072 crc: 4D2F7971 date: 2021-02-14 03:34:21
C:\WINDOWS\SYSTEM32\twinapi.appcore.dll handle: 00007ff871570000 size: 2100112 crc: 607D6B93 date: 2021-02-14 03:33:57
C:\Windows\System32\PROPSYS.dll handle: 00007ff874670000 size: 1009232 crc: A53AC761 date: 2021-03-16 19:34:17
C:\WINDOWS\SYSTEM32\TextShaping.dll handle: 00007ff865000000 size: 707016 crc: 49A4E545 date: 2021-03-16 19:34:16

---- gamelog start ----
Tick 62675: game loaded
Conversion from OTTD savegame without gamelog: version 4, 1
Revision text changed to jgrpp-0.41.0, savegame version 290, not modified, _openttd_newgrf_version = 0x1c006d64
New game mode: 0 landscape: 1
---- gamelog end ----

Recent news messages (0 of 0):

Command Log:
Showing most recent 0 of 0 commands

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE 0x00007FF878B14B59 RaiseException + 105
[01] msvcrt 0x00007FF87A88ADFB raise + 539
[02] msvcrt 0x00007FF87A88F1FB abort + 27
[03] openttd 0x0000000000618996 error(char const*, ...) + 118 (/home/jgr/openttd/jgrpp/src/openttd.cpp:171)
[04] openttd 0x000000000053231F VideoDriver_Win32Base::LockVideoBuffer() + 111 (/home/jgr/openttd/jgrpp/src/video/win32_v.cpp:996)
[05] openttd 0x000000000053680D VideoDriver::Tick() + 973 (/home/jgr/openttd/jgrpp/src/video/video_driver.cpp:175)
[06] openttd 0x0000000000531BD8 VideoDriver_Win32Base::MainLoop() + 40 (/home/jgr/openttd/jgrpp/src/video/win32_v.cpp:873)
[07] openttd 0x000000000061B973 openttd_main(int, char**) + 6595 (/home/jgr/openttd/jgrpp/src/openttd.cpp:998)
[08] openttd 0x00000000004E0656 WinMain + 342 (/home/jgr/openttd/jgrpp/src/os/windows/win32.cpp:441)
[09] openttd 0x00000000004013B4 __tmainCRTStartup + 564 (./build/x86_64-w64-mingw32-x86_64-w64-mingw32-crt/./mingw-w64-crt/crt/crtexe.c:339)
[10] openttd 0x00000000004014DB WinMainCRTStartup + 27 (./build/x86_64-w64-mingw32-x86_64-w64-mingw32-crt/./mingw-w64-crt/crt/crtexe.c:195)
[11] KERNEL32 0x00007FF87A7B7034 BaseThreadInitThunk + 20
[12] ntdll 0x00007FF87B3C2651 RtlUserThreadStart + 33

*** End of additional info ***
Upstream are looking into this. There's not a great deal that I can do other than disabling OpenGL again.
Nrgte wrote: 19 Apr 2021 10:55 Hello everyone, I'm trying to compile the Patch Pack from source. Which generally works, however when I launch the game, load a save and zoom out on the map it lags a lot. It generally seems that my compiled version runs a lot slower. Map generation is slower too. I'm building on Windows with Visual Studio Community 2019.

I've tested the same with vanilla OpenTTD and the same issue occurs there too, so it's probably an issue with some settings. Has anyone experienced this and knows a solution?

I've tried changing the configuration from Debug to Release, but that made no difference.
I've not used Visual Studio in quite a few years now, so I can't really help there unfortunately.
Are you going via CMake?
Ex TTDPatch Coder
Patch Pack, Github
Nrgte
Engineer
Engineer
Posts: 3
Joined: 19 Apr 2021 10:46

Re: JGR's Patch Pack

Post by Nrgte »

JGR wrote: 20 Apr 2021 17:12 I've not used Visual Studio in quite a few years now, so I can't really help there unfortunately.
Are you going via CMake?
Yes, I basically did everything that was listed in the compiling.md doc. Using CMake with vcpkg and then make the exectuble with Visual Studio. According to the documenation this seems to be the default way of building OpenTTD on Windows. The build process works flawlessly, it's just that the built executable is lagging horribly when I zoom out and the map generation takes a lot longer than your pre-built executable as well as the pre-built executable of vanilla OpenTTD.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

Nrgte wrote: 20 Apr 2021 20:46
JGR wrote: 20 Apr 2021 17:12 I've not used Visual Studio in quite a few years now, so I can't really help there unfortunately.
Are you going via CMake?
Yes, I basically did everything that was listed in the compiling.md doc. Using CMake with vcpkg and then make the exectuble with Visual Studio. According to the documenation this seems to be the default way of building OpenTTD on Windows. The build process works flawlessly, it's just that the built executable is lagging horribly when I zoom out and the map generation takes a lot longer than your pre-built executable as well as the pre-built executable of vanilla OpenTTD.
Just a thought. It's been a year or two since I compiled. It seems to me that there was an option to compile a debug version which adds a lot of overhead to the binary. Might this be your problem? How big is your product compared to vanilla or jgrpp?
perverted monkey
Traffic Manager
Traffic Manager
Posts: 161
Joined: 02 Mar 2009 02:07

Re: JGR's Patch Pack

Post by perverted monkey »

JGR wrote: 20 Apr 2021 17:08 ... the lack of composability of road/tram properties isn't a good approach.
Do you have something else in mind?
User avatar
mxnp
Engineer
Engineer
Posts: 17
Joined: 08 Mar 2021 14:48

Re: JGR's Patch Pack

Post by mxnp »

JGR wrote: 20 Apr 2021 17:08 I'm not going to be doing that.
64 types is already too many from a UI point of view.
Having more and more types to compensate for the lack of composability of road/tram properties isn't a good approach.

Most sets with large number of types have minuscule differences between most of them.
Yep that's reasonable, as you said, with the current limit the UI already fills the whole screen, and it's probably more the fault of the design approach with road sets, than the actual game. (A little bit annoying that trams and roads share the same limit, but the limit is reasonable.)
I'm going to have to refrain from posting when I'm still half-awake...
User avatar
kamnet
Moderator
Moderator
Posts: 8548
Joined: 28 Sep 2009 17:15
Location: Eastern KY
Contact:

Re: JGR's Patch Pack

Post by kamnet »

JGR wrote: 20 Apr 2021 17:08
mxnp wrote: 20 Apr 2021 12:36 Hey JGR,
I've noticed that in v0.41.0 house IDs have been increased. I wonder if a similar increase could also be done to the current maximum of 64 road types?
Thanks!
I'm not going to be doing that.
64 types is already too many from a UI point of view.
Having more and more types to compensate for the lack of composability of road/tram properties isn't a good approach.

Most sets with large number of types have minuscule differences between most of them.
I'll definitely agree with this, as much as I LOVE cramming as much stuff in as possible, there is no reason to play with more than one, maybe two road sets. Most of them have so much stuff that overlaps already. If anything, we need developers to focus on more carefully curating their sets rather than throwing a bunch of sets together.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

kamnet wrote: 21 Apr 2021 11:03
JGR wrote: 20 Apr 2021 17:08
mxnp wrote: 20 Apr 2021 12:36 Hey JGR,
I've noticed that in v0.41.0 house IDs have been increased. I wonder if a similar increase could also be done to the current maximum of 64 road types?
Thanks!
I'm not going to be doing that.
64 types is already too many from a UI point of view.
Having more and more types to compensate for the lack of composability of road/tram properties isn't a good approach.

Most sets with large number of types have minuscule differences between most of them.
I'll definitely agree with this, as much as I LOVE cramming as much stuff in as possible, there is no reason to play with more than one, maybe two road sets. Most of them have so much stuff that overlaps already. If anything, we need developers to focus on more carefully curating their sets rather than throwing a bunch of sets together.
K.I.S.S. is always appropriate. 8)
michael blunck
Tycoon
Tycoon
Posts: 5948
Joined: 27 Apr 2005 07:09
Contact:

Re: JGR's Patch Pack

Post by michael blunck »

When trying to save an older game (started in trunk 1.8.) in 0.41.0, I'm getting the error message:
Game save failed (undefined string)
This file may be from a different game.
Has anything been changed in this respect since
JGR wrote: Savegames from trunk up to the last savegame version which has been merged should be loadable in this patchpack.
?

regards
Michael
Image
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

Not sure how deceleration in advanced braking model works, but maybe it would be interesting to take tractive effort of all vehicles into account?
So newgrf maker can easily simulate all these brake-less wagons just by putting TE 0 (usually it is default 0.3 and not used).
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 18 guests