since your great patch had meanwhile developed into a common replacement for trunk, are you thinking about to not only add existing patches but also about adding some of those often requested features which had/will never made/make it into trunk?
I´m not talking about "large" features like "real" push-pull operation for trains or multiple cargo for ships, but about "smaller" ones like
- allow to built stations on different adjoining levels (see pic)
- disallow to built stations for certain track types (via CB13/var42, resp CB var10 or 18)
stations_flat-land-required.png
Both features won´t need any changes in nfo/grf specs/docs.
regards
Michael
Are you thinking of Peter1138 here?
If not, I'm not especially familiar with the NewGRF interface. It's not a part of the code that I tend to look at or use much, so I'm probably not the right person to ask for these.
If not, I'm not especially familiar with the NewGRF interface. It's not a part of the code that I tend to look at or use much, so I'm probably not the right person to ask for these.
Ah, sorry. Of course I meant Jonathan.
Well, first item seems not a newgrf interface problem. I think that´s rather an original TTD limitation. And the second one seems to have been already contemplated, since I found this line in newgrf_station.cpp:
case 0x42: return 0; // Rail type (XXX Get current type from GUI?)
In fact, this seems to be the way with implementing that particular feature, since the railtype is already known here, when going to build a station tile.
Anyway, I´ll ask cirdan, maybe it´s a more fitting feature for his OTTD fork.
I am currently reviewing your changes on TBTR. It looks like you made some nide additions.
May I draw (some of) them into the next official release of the tbtr project?
Thanks also for working on those crucial multiplayer issues, I was not aware of them.
I am currently reviewing your changes on TBTR. It looks like you made some nide additions.
May I draw (some of) them into the next official release of the tbtr project?
Thanks also for working on those crucial multiplayer issues, I was not aware of them.
Best,
Thomas
By all means, please feel free to merge any of my changes.
No problem, and thank you for your work in developing it.
I'd quite like a little toggle, to draw the destination of a train above it (or its assigned ID / name). So trains run around with a little tag above them stating where it's going. next destination or termination point. I think that'd aid in locating misrouted trains or thinking of better routes on the fly as I spot them on their travels / timetabling adjustments.
Might be a bit of a CPU drain though, I guess. Seems a neat thing to have at least.
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
Redirect Left wrote:I'd quite like a little toggle, to draw the destination of a train above it (or its assigned ID / name). So trains run around with a little tag above them stating where it's going. next destination or termination point. I think that'd aid in locating misrouted trains or thinking of better routes on the fly as I spot them on their travels / timetabling adjustments.
Might be a bit of a CPU drain though, I guess. Seems a neat thing to have at least.
I can see the attraction of that sort of thing, but it seems like one of those areas where doing it well and seamlessly would take quite a bit of thought and development time.
I'll add it to the list, but there may be a large delay before I can get round to looking at those sorts of things.
Compiling strgen/strgen_base.cpp
In file included from ~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:17:0:
~/OpenTTD-patches-jgrpp/src/strgen/strgen.h:120:33: error: ‘LanguagePackHeader’ does not name a type
virtual void WriteHeader(const LanguagePackHeader *header) = 0;
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen.h:120:53: error: ISO C++ forbids declaration of ‘header’ with no type [-fpermissive]
virtual void WriteHeader(const LanguagePackHeader *header) = 0;
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen.h:149:8: error: ‘LanguagePackHeader’ does not name a type
extern LanguagePackHeader _lang;
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:31:1: error: ‘LanguagePackHeader’ does not name a type
LanguagePackHeader _lang; ///< Header information about a language.
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp: In constructor ‘StringData::StringData(size_t)’:
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:90:70: error: ‘TAB_SIZE’ was not declared in this scope
StringData::StringData(size_t tabs) : tabs(tabs), max_strings(tabs * TAB_SIZE)
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:92:18: error: ‘CallocT’ was not declared in this scope
this->strings = CallocT<LangString *>(max_strings);
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:92:37: error: expected primary-expression before ‘*’ token
this->strings = CallocT<LangString *>(max_strings);
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:92:38: error: expected primary-expression before ‘>’ token
this->strings = CallocT<LangString *>(max_strings);
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:93:35: error: expected primary-expression before ‘>’ token
this->hash_heads = CallocT<uint16>(max_strings);
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp: In member function ‘uint StringData::CountInUse(uint) const’:
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:216:11: error: ‘TAB_SIZE’ was not declared in this scope
for (i = TAB_SIZE; --i >= 0;) if (this->strings[(tab * TAB_SIZE) + i] != NULL) break;
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp: At global scope:
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:238:28: error: expected template-name before ‘<’ token
struct Buffer : SmallVector<byte, 256> {
^
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:238:28: error: expected ‘{’ before ‘<’ token
~/OpenTTD-patches-jgrpp/src/strgen/strgen_base.cpp:238:28: error: expected unqualified-id before ‘<’ token
Any idea, what goes wrong? I got this error on ubuntu 14.04, at another computer with ubuntu 16 everthing is OK, maybe outdated compiler?
Thanks for the bug report.
It'd be helpful if you could upload the crash.log file as well.
Also, your savegame uses a number of GRFs not available on bananas, it'd be useful if you could also upload those.
McZapkie wrote:I'm trying to compile files from github, but got followng errors:
JGR wrote:Thanks for the bug report.
It'd be helpful if you could upload the crash.log file as well.
Also, your savegame uses a number of GRFs not available on bananas, it'd be useful if you could also upload those.
And this bug also occurs when company is autocleaned.
The bug is due to an error in the code to handle accounting of infrastructure totals when a bridge/tunnel with signals is removed due to removal of the company.
This has been fixed and will be in the next release.
Thanks for bringing it to my attention.
Your Patchpack is awesome! It is a lot better then vanilla OpenTTD (128x zoom is the bomb).
However, I recently downloaded v0.17.0 (coming from v0.16.1) and have the following issues:
The 32bit version upon loading states "Out of memory, Allocating 1.5GiB of spritecache faild, reduced to 768MiB etc etc" (this does not happen on the 64bit version, O/S is win7 64bit.)
Both 64bit and 32bit upon loading a game state "Too many NEWGRF's are loaded" (similar to vanilla openttd) and some grf's aren't loaded. This is game-breaking and does not happen with the v0.16.1 version.
I really enjoy the max 255grf, I hope you can fix this.
Your Patchpack is awesome! It is a lot better then vanilla OpenTTD (128x zoom is the bomb).
However, I recently downloaded v0.17.0 (coming from v0.16.1) and have the following issues:
The 32bit version upon loading states "Out of memory, Allocating 1.5GiB of spritecache faild, reduced to 768MiB etc etc" (this does not happen on the 64bit version, O/S is win7 64bit.)
Both 64bit and 32bit upon loading a game state "Too many NEWGRF's are loaded" (similar to vanilla openttd) and some grf's aren't loaded. This is game-breaking and does not happen with the v0.16.1 version.
I really enjoy the max 255grf, I hope you can fix this.
Edit: This should be fixed in 0.17.1
Last edited by JGR on 14 Feb 2017 01:05, edited 1 time in total.
Version 0.17.0, crash as soon as I build a bus stop (not immediate, but a few seconds later)...
Edit:
And if I build a train station instead, I get an "Assertion failed at line 2897 of/home/jgr/openttd/cross-win32/src/window.cpp:HasModalProgress()||IsLocalCompany()
Swedish Windows XP.
Edit2:
And if I build a dock, I get another crash...
AndersI wrote:Version 0.17.0, crash as soon as I build a bus stop (not immediate, but a few seconds later)...
Edit:
And if I build a train station instead, I get an "Assertion failed at line 2897 of/home/jgr/openttd/cross-win32/src/window.cpp:HasModalProgress()||IsLocalCompany()
Swedish Windows XP.
Edit2:
And if I build a dock, I get another crash...
Thanks for letting me know about this, looks like a silly error on my part.
There's a divide by 0 error in the case where the total estimated cost of all scheduled cargo-dest link graph operations is 0 or 1, which is a case that I hadn't thought of.
Edit: Have you got a crash log or some other information for the assertion failure case.
.
