JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
HackaLittleBit
Director
Director
Posts: 550
Joined: 10 Dec 2008 16:08
Location: tile 0x0000

Re: JGR's Patch Pack

Post by HackaLittleBit »

1.png
1.png (105 KiB) Viewed 4662 times
Bug.
in foto 1 I build dock connected to Wronboroug docks
Everyting ok so far.

Image
foto 2 I build a wall around the dock.
Ships still try to reach it.

In Cirdans branch it works flawless.
If first dock not reachable ships go automatic to next reachable dock.

I think this patch comes from KeldorKatarn
Attachments
2.png
2.png (133.21 KiB) Viewed 757 times
wjhunt78
Engineer
Engineer
Posts: 5
Joined: 24 Nov 2013 13:15

Re: JGR's Patch Pack

Post by wjhunt78 »

ino wrote:Could you also tell me what mode is the departure board in? D only? A and D? Things work much differently internally between modes.
It is in D only, I don't know about the other mode yet, but I can check that for you of course.

A fix would be nice, but I'm still very happy with your work anyway. I cannot imagine playing without 24h clock and departure boards anymore!
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

HackaLittleBit wrote:1.png
Bug.
in foto 1 I build dock connected to Wronboroug docks
Everyting ok so far.

foto 2 I build a wall around the dock.
Ships still try to reach it.

In Cirdans branch it works flawless.
If first dock not reachable ships go automatic to next reachable dock.

I think this patch comes from KeldorKatarn
I've ported Cirdan's pathfinding implementation which fixes this issue. It'll be in the next release.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
HackaLittleBit
Director
Director
Posts: 550
Joined: 10 Dec 2008 16:08
Location: tile 0x0000

Re: JGR's Patch Pack

Post by HackaLittleBit »

JGR wrote:I've ported Cirdan's pathfinding implementation which fixes this issue. It'll be in the next release.
Nice.
Now a long desired wish is coming closer!
I am writing patch in Cirdan's branch to make ships choose empty slot.
Very experimental.
This is a preliminary result so far.
All credit goes to Cirdan.
Image
Attachments
docking.png
docking.png (149.24 KiB) Viewed 757 times
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

That would be an ace patch to have in when ready, i've long thought the ships all zerg rushing the same port has looked ridiculous.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: JGR's Patch Pack

Post by TrueSatan »

Uh do I hear something like patch in cridan's branch ???
Sounds like I get something to compile anytime soon hehe.

Looks great so far, always wondered about the ships driving over each other
and if this will be ever fixed.

Hope to see a patch soon for cirdan's branch.
Should be easy to apply to jgr's tracerestriction branch as well.

Cheers
nart1s
Engineer
Engineer
Posts: 1
Joined: 14 Feb 2018 12:34

Re: JGR's Patch Pack

Post by nart1s »

Does anyone know if a MacOS version was indeed compiled in mid January?
I’ve just spent a few hours trying to compile it myself (my first time doing anything like this), and it’s all been a bit of disaster.

If anyone is kind enough, and has the free time, to compile for MacOS it would be tremendously appreciated.
:)
username_taken
Engineer
Engineer
Posts: 4
Joined: 16 Jan 2018 09:36

Re: JGR's Patch Pack

Post by username_taken »

nart1s wrote:Does anyone know if a MacOS version was indeed compiled in mid January?
I’ve just spent a few hours trying to compile it myself (my first time doing anything like this), and it’s all been a bit of disaster.

If anyone is kind enough, and has the free time, to compile for MacOS it would be tremendously appreciated.
:)
I didn't hear anything more from the person who offered to compile it, so I don't think so. If there are any MacOS players out there, it would be awesome if you could share your compiled version of this game.

nart1s: If you manage to compile it, don't be shy to share it here. I might give it another go myself
p4nzer
Engineer
Engineer
Posts: 31
Joined: 27 Jun 2017 21:43

Re: JGR's Patch Pack

Post by p4nzer »

Is there a reason the "ticks per minute" setting is limited to 255? Could it be increased? I'm trying to have 1:1 days:minutes at a daylength factor of 7, if it helps.
Chico008
Traffic Manager
Traffic Manager
Posts: 143
Joined: 05 Mar 2008 10:56
Location: France

Re: JGR's Patch Pack

Post by Chico008 »

JGR wrote:
Chico008 wrote:Hi

Don't know if it has been asked yet, but i have a problem compiling

i'm using the r27935 from svn, then apply the diff file
configure and make or OK, but when i launch a dedicated server, i can't connect using the client provided on first page

There is a version mismatch
dedicated server got version : jgrpp-0.22.1-M-
win32/64 clients are : jgrpp-0.22.1

How can i compile to get the same versions on the dedicated serveur ?
This suggests that the patched source is not identical to that of the release, probably because one or more source files have have been manually edited in some way.
In general patching the version detection script is not a good solution as the whole point of the modification check is to avoid the multi-player desync issues which can occur when a modified build is incorrectly labelled as an unmodified release build, and is subsequently used with unmodified release builds.
I Know, but i had to because in don't have the tools to compile again the windows client.

But, we're are using the server very fine, several games, with grf, big maps, etc, never got desynch
nurabsal
Engineer
Engineer
Posts: 19
Joined: 03 Dec 2017 17:02

Re: JGR's Patch Pack

Post by nurabsal »

Could snow in temperate patch be added into your patchpack with next version working with variable snowline? Im doing some eyecandy worldbuilding and would really like to have such thingbut im unable to patch and compile it myself. Maybe also others would also appreciate.

viewtopic.php?t=24574&start=40
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

p4nzer wrote:Is there a reason the "ticks per minute" setting is limited to 255? Could it be increased? I'm trying to have 1:1 days:minutes at a daylength factor of 7, if it helps.
I've increased the limit, so this should be possible in the next release.
nurabsal wrote:Could snow in temperate patch be added into your patchpack with next version working with variable snowline? Im doing some eyecandy worldbuilding and would really like to have such thingbut im unable to patch and compile it myself. Maybe also others would also appreciate.

viewtopic.php?t=24574&start=40
I'll have a look into the possibility.
Ex TTDPatch Coder
Patch Pack, Github
NetMax
Engineer
Engineer
Posts: 19
Joined: 06 Nov 2010 17:20

Re: JGR's Patch Pack

Post by NetMax »

For increasing the number of ticks per day (to increase factory outputs), what is the status of this patch and its compatibility with 1.7.2 on W7 pro?

If positive, can you point me to where I can D/L the patch and where directions are posted. TIA
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

NetMax wrote:For increasing the number of ticks per day (to increase factory outputs), what is the status of this patch and its compatibility with 1.7.2 on W7 pro?

If positive, can you point me to where I can D/L the patch and where directions are posted. TIA
Increasing the day length (ticks per day) does not increase per-day factory outputs.

This patch pack can load 1.7.2 savegames, and should work fine on windows 7.

See the first post of this thread for various types of download links.
Ex TTDPatch Coder
Patch Pack, Github
NetMax
Engineer
Engineer
Posts: 19
Joined: 06 Nov 2010 17:20

Re: JGR's Patch Pack

Post by NetMax »

Thanks for setting me straight. What I read about 'ticks-industry output' must have been conjecture then - that didn't work as expected. Explains why I can't find that patch.
stb
Engineer
Engineer
Posts: 40
Joined: 20 Sep 2013 20:26

Re: JGR's Patch Pack

Post by stb »

Hi there,

Found a small bug related to Zoning:
Sometimes "Station catchment (window open)" highlights less area then "Station catchment".
In the below picture, SW side of station coverage is not complete (I use 4 tiles for all station types):
Image
Attachments
ottd.png
ottd.png (618.63 KiB) Viewed 757 times
User avatar
Gwyd
Chief Executive
Chief Executive
Posts: 721
Joined: 17 Apr 2017 16:52
Location: Western Ile-de-France Region

Re: JGR's Patch Pack

Post by Gwyd »

Notice how it goes 5 tiles the other way
stb
Engineer
Engineer
Posts: 40
Joined: 20 Sep 2013 20:26

Re: JGR's Patch Pack

Post by stb »

Gwyd wrote:Notice how it goes 5 tiles the other way
There's a joint truck station.
SkullKrixzz
Engineer
Engineer
Posts: 29
Joined: 31 Oct 2014 18:24
Location: London, Ontario

Re: JGR's Patch Pack

Post by SkullKrixzz »

Not sure if it has been asked here already, and im sorry if so but i have a question on if Mr. JGR has/would consider adding "yellow signals patch" to the pack? i like this pack, it is my favourite and it helps me build the realistic networks that i like to build, there are some things lacking but not the fault of hte pack, more so game limitations/ it hasnt been made into a patch of its own yet... anyways i feel this would be a good additions if it "makes the cut"....like will be posted belowto the thread for it.

viewtopic.php?t=74451
cpeosphoros
Engineer
Engineer
Posts: 7
Joined: 05 Mar 2018 16:31

Re: JGR's Patch Pack

Post by cpeosphoros »

Hi there, is it better to post issues here or open then on the GitHUb repo?

Thanks
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 54 guests