JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Valle wrote:There you go. Please note that the upload to Dropbox's server is not complete yet and could take a while. This game has 41 MB and had its NewGRF list modified in-game.
Aircraft 89 is on its way to an oil rig, it seems it's not caught by the load code as it's a FIRS oil rig instead of an ordinary one.
I'll have to see if I can modify the test to check for that.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Valle
Transport Coordinator
Transport Coordinator
Posts: 284
Joined: 15 May 2007 11:35
Location: Germany

Re: JGR's Patch Pack

Post by Valle »

JGR wrote:
Valle wrote:There you go. Please note that the upload to Dropbox's server is not complete yet and could take a while. This game has 41 MB and had its NewGRF list modified in-game.
Aircraft 89 is on its way to an oil rig, it seems it's not caught by the load code as it's a FIRS oil rig instead of an ordinary one.
I'll have to see if I can modify the test to check for that.
:shock:

Thank you.
User avatar
Mizari
Traffic Manager
Traffic Manager
Posts: 136
Joined: 22 Apr 2012 14:21

Re: JGR's Patch Pack

Post by Mizari »

JGR wrote:
Mizari wrote:But that one makes very large isometric ones. This one made small, top-view ones. And it saved one at the beginning of each year (it was in the Hard patch pack). Makes for very memorable maps accumulating.
Were you using the daily/monthly/yearly scripts patch for that?
Well, it was by default in HardPP, so whatever that was, it was automatic (and I don't recall if there was a setting somewhere to toggle it on or off, but there might have been) I didn't compile that myself.
Frdm920
Engineer
Engineer
Posts: 3
Joined: 07 Sep 2015 13:17

Re: JGR's Patch Pack

Post by Frdm920 »

Hey JGR,

My copy of your Patch Pack seems to have suddenly developed a tendency to crash when demolishing/building landscape objects in the scenario editor (I'm not sure if it occurs in game as well, but I have confirmed it's not limited to any one scenario) any ideas? Dump, Log, PNG and Save attached.

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Mon Sep 07 13:15:54 2015
In game date: 1970-01-01 (0)

Crash reason:
 Exception: C0000005
 Location:  00000000008660BB
 Message:   <none>

OpenTTD version:
 Version:    jgrpp-0.4.1 (0)
 NewGRF ver: 16006b02
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Sep  6 2015 10:57:55

Registers:
 RAX: 0000000000AE0278 RBX: 000000002C41F400 RCX: 0000000000000078 RDX: 000000002C41F400
 RSI: 0000000000AD42B0 RDI: 0000000000000000 RBP: 0000000000AD3B50 RSP: 000000000022D600
 R8:  000000000022D640 R9:  0000000000AD42B0 R10: 000000000000001E R11: 0000108801360117
 R12: 0000000000050008 R13: 00000000FFFFFFF5 R14: 0000000000000001 R15: 000000002C2F0F80
 RIP: 00000000008660BB EFLAGS: 00010206

 Bytes at instruction pointer:
 48 8B 01 C7 44 24 54 10 00 00 00 4C 89 44 24 38 48 89 54 24 20 41 B8 06

Stack trace:
 FFFFFFF5 00000000 2C2F0F80 00000000 00000000 00000000 004AD3C7 00000000
 2C2F0F80 00000000 00000005 00000000 009388A0 00000000 008019D6 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 0051D3ED 00000000
 2C2F0F80 00000000 2C2F0F80 00000000 00000001 00000000 00000005 00000000
 2BF76F30 00000000 0077674D 00000000 2BF76C30 00000000 006579E5 00000000
 00000000 00000000 FF95FCEB 000007FE 00000000 00000000 00B80880 00050008
 00B80880 00000000 00000008 00000000 00000126 00000000 0065B770 00000000
 00000000 00000000 00000001 00000000 00000000 00000000 00000001 00000000
 00000020 00000000 00000000 00000000 00000000 00000000 00000001 00000000
 00000000 00000000 00000126 0000012D 00000000 00000000 00000201 00000000
 02430126 00000000 000E05B8 00000000 00000001 00000000 00000000 00000000
 00000201 00000000 00000000 00000000 000E05B8 00000000 0063C799 00000000
 00000000 00000000 00000000 00000000 00000070 00000000 FFFFFFFF FFFFFFFF
 FFFFFFFF FFFFFFFF 77659B43 00000000 77659BEF 00000000 00000000 00000000
 00000000 00000000 00000000 00000000 00000000 00000000 776572CB 00000000
 00000000 00000000 0063C260 00000000 00000000 00000000 00000000 00000000
 00000000 00000000 00000001 00000000 00000000 00000000 00B76580 00000000
 00000000 00000000 00000201 00000000 00000000 00000000 77659BD1 00000000
 0022D8F8 00000000 00000000 00000000 00000000 00000000 00000004 00000000
 0063C260 00000000 000003FF 00000000 00000001 00000000 00000000 00000000
 00000000 00000000 00000243 00000000 00000048 00000000 00000001 00000000
 00000000 00000000 00000000 00000000 00000030 00000000 FFFFFFFF FFFFFFFF
 FFFFFFFF FFFFFFFF 77659B43 00000000 00000000 00000000 00B76580 00000000
 00000001 00000000 00000001 00000000 00000000 00000000 776598DA 00000000

Operating system:
 Name:     Windows
 Release:  6.1.7601 (Service Pack 1)
 Compiler: GCC 4.9.2 "4.9.2"

Configuration:
 Blitter:      32bpp-optimized
 Graphics set: OpenGFX (5203)
 Language:     C:\Users\[name]\Desktop\jgrpp\english.lng
 Music driver: win32
 Music set:    OpenMSX (96)
 Network:      no
 Sound driver: win32
 Sound set:    OpenSFX (87)
 Video driver: win32

Fonts:
 Small:  Tahoma
 Medium: Tahoma
 Large:  Times New Roman
 Mono:   sprite

AI Configuration (local: 16):
  0: Human
 GS: Renewed City Growth (v5)

Libraries:
 FreeType:   2.6.0
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
C:\Users\[name]\Desktop\jgrpp\openttd.exe handle: 0000000000400000 size: 14941341 crc: EFB1B8A2 date: 2015-09-06 02:57:58
 C:\Windows\SYSTEM32\ntdll.dll handle: 0000000077740000 size: 1730496 crc: CBF68D17 date: 2015-07-15 18:12:09
 C:\Windows\system32\kernel32.dll handle: 0000000077520000 size: 1163264 crc: 161DB41D date: 2015-07-15 18:10:48
 C:\Windows\system32\KERNELBASE.dll handle: 000007fefd840000 size: 424960 crc: D82FE040 date: 2015-07-15 18:10:48
 C:\Windows\system32\ADVAPI32.dll handle: 000007feff790000 size: 879104 crc: 5E972699 date: 2015-05-25 18:18:54
 C:\Windows\system32\msvcrt.dll handle: 000007fefd8d0000 size: 634880 crc: 9D1B448A date: 2011-12-16 08:46:06
 C:\Windows\SYSTEM32\sechost.dll handle: 000007fefdd90000 size: 113664 crc: 98A6ADF4 date: 2015-05-25 18:19:09
 C:\Windows\system32\RPCRT4.dll handle: 000007fefdc50000 size: 1216512 crc: 646551CD date: 2015-07-15 18:10:56
 C:\Windows\system32\GDI32.dll handle: 000007fefeb50000 size: 404992 crc: 66195D86 date: 2015-06-17 17:47:05
 C:\Windows\system32\USER32.dll handle: 0000000077640000 size: 1008128 crc: 70FF7D7F date: 2010-11-21 03:24:09
 C:\Windows\system32\LPK.dll handle: 000007fefeb40000 size: 41984 crc: B3F642CD date: 2015-07-30 18:06:42
 C:\Windows\system32\USP10.dll handle: 000007feff870000 size: 801280 crc: DCB1924F date: 2014-04-25 02:34:59
 C:\Windows\system32\IMM32.dll handle: 000007feff580000 size: 167424 crc: 41B2805A date: 2009-07-14 01:41:09
 C:\Windows\system32\MSCTF.dll handle: 000007feff940000 size: 1067520 crc: 362B3A40 date: 2015-01-17 02:48:38
 C:\Windows\system32\SHELL32.dll handle: 000007fefddb0000 size: 14177280 crc: 155A393E date: 2015-07-10 17:51:25
 C:\Windows\system32\SHLWAPI.dll handle: 000007feff3e0000 size: 448512 crc: 086DF743 date: 2010-11-21 03:24:22
 C:\Windows\system32\WINMM.dll handle: 000007fefb100000 size: 217600 crc: 7BC1529F date: 2009-07-14 01:41:56
 C:\Windows\system32\WS2_32.dll handle: 000007feff5b0000 size: 297984 crc: 0F68689B date: 2010-11-21 03:24:28
 C:\Windows\system32\NSI.dll handle: 000007fefdd80000 size: 13824 crc: 53B46F6C date: 2009-07-14 01:41:53
 C:\Windows\system32\ole32.dll handle: 000007feff1d0000 size: 2087424 crc: 5DA42F8C date: 2015-07-04 18:07:11
 C:\Windows\system32\uxtheme.dll handle: 000007fefb9c0000 size: 332288 crc: B0A13DF9 date: 2009-07-14 01:41:56
 C:\Windows\system32\dwmapi.dll handle: 000007fefaea0000 size: 82432 crc: A459F360 date: 2009-07-14 01:40:34
 C:\Windows\system32\CRYPTBASE.dll handle: 000007fefd390000 size: 44032 crc: AC1D5D3A date: 2015-07-15 18:10:43
 C:\Windows\system32\CLBCatQ.DLL handle: 000007fefdb50000 size: 607744 crc: 939E35C9 date: 2009-07-14 01:40:15
 C:\Windows\system32\OLEAUT32.dll handle: 000007feff0f0000 size: 861696 crc: 2B84F0E4 date: 2014-11-26 03:53:59
 C:\Windows\system32\mswsock.dll handle: 000007fefcc90000 size: 327168 crc: 2C87855E date: 2013-09-08 02:27:14
 C:\Windows\System32\wshtcpip.dll handle: 000007fefc690000 size: 13312 crc: 5D1E2C55 date: 2009-07-14 01:41:58
 C:\Windows\system32\MMDevAPI.DLL handle: 000007fefc190000 size: 284160 crc: CDF2EF81 date: 2009-07-14 01:41:26
 C:\Windows\system32\PROPSYS.dll handle: 000007fefc060000 size: 1212416 crc: B83FA3BE date: 2010-11-21 03:23:55
 C:\Windows\system32\wdmaud.drv handle: 000007fefb0c0000 size: 217088 crc: 12829973 date: 2010-11-21 03:24:32
 C:\Windows\system32\ksuser.dll handle: 00000000750e0000 size: 5120 crc: AA2071D9 date: 2009-07-14 01:41:13
 C:\Windows\system32\AVRT.dll handle: 000007fefc1e0000 size: 18432 crc: 5CE53CB7 date: 2009-07-14 01:40:05
 C:\Windows\system32\SETUPAPI.dll handle: 000007fefd970000 size: 1900544 crc: A364BD6A date: 2010-11-21 03:24:28
 C:\Windows\system32\CFGMGR32.dll handle: 000007fefd6f0000 size: 207872 crc: 1984C339 date: 2010-11-21 03:24:00
 C:\Windows\system32\DEVOBJ.dll handle: 000007fefd560000 size: 93184 crc: A7541AE2 date: 2009-07-14 01:40:28
 C:\Windows\system32\AUDIOSES.DLL handle: 000007fefaf10000 size: 296448 crc: E010A4A9 date: 2015-02-03 03:30:55
 C:\Windows\system32\msacm32.drv handle: 000007fefae90000 size: 25600 crc: 2B579A05 date: 2009-07-14 01:38:50
 C:\Windows\system32\MSACM32.dll handle: 000007fefae70000 size: 83456 crc: 3D67538B date: 2009-07-14 01:41:27
 C:\Windows\system32\midimap.dll handle: 000007fefae60000 size: 20480 crc: CB902A13 date: 2009-07-14 01:41:23
 C:\Windows\system32\psapi.dll handle: 0000000077900000 size: 9216 crc: 84B5E9BA date: 2009-07-14 01:41:53

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.3.2, savegame version 194, not modified, _openttd_newgrf_version = 0x16006afd
New game mode: 2 landscape: 0
Added NewGRF: GRF ID F1250005, checksum 955C122CEFCC91F1EDAB646F7DF7D141, filename: firs_industry_replacement_set-1.4.4\firs.grf (md5sum matches)
Added NewGRF: GRF ID 56430001, checksum 2AD089EE6B73F25D79F286AD43765914, filename: total_town_replacement_set-3.14\ttrs3w.grf (md5sum matches)
Added NewGRF: GRF ID 4D560000, checksum A420B01EE556C4C8EC7E8A59E4CC05DB, filename: ALL ROAD VEHICLES\Ikarus_Set-6beta\TESTFILEw.GRF (md5sum matches)
Added NewGRF: GRF ID 41501202, checksum B13DD8FB0D7C34CACAC2FE68BD137BB9, filename: heqs_heavy_equipment_set-1.5.2\heqs.grf (md5sum matches)
Added NewGRF: GRF ID 58534453, checksum 27B31AFC05CE6AE50287F5567F660538, filename: dutchstat.grf (md5sum matches)
Added NewGRF: GRF ID 504A0110, checksum E8244C5278CB2408A818854DC11F8940, filename: ALL STATION SET\Dutch_Station_Addition_Set-0.8\dstatadd_v0_8.grf (md5sum matches)
Added NewGRF: GRF ID 4A430001, checksum 4CF50E2A770F6672A77A8842A3129ECA, filename: british_stations_set-0.0.4final\dstatsw.grf (md5sum matches)
Added NewGRF: GRF ID 4D480201, checksum 9E914C31E5FC7FC3F686D009BD55F331, filename: alexandra_palace-1.0.0\alexandrapalace.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 54430201, checksum C837D48D657129DD915830D60D68E09F, filename: cs_stationset_v0.1-1\csstationsw.grf (md5sum matches)
Added NewGRF: GRF ID 54430202, checksum 081B62FD686AF2161866A0CF6EA043AC, filename: cs_platforms_set-1\csplatformsw.grf (md5sum matches)
Added NewGRF: GRF ID 54632301, checksum 2A21D6582AA90BFF0395969C13892D58, filename: stat-cs_extras-win-ottd.grf (md5sum matches)
Added NewGRF: GRF ID 45530500, checksum 3A943F4E8E345F903F2CEF090A12346C, filename: Japan Themed Newgrf\jpstations\jpstations\jpstations.grf (md5sum matches)
Added NewGRF: GRF ID 9787EA81, checksum 344D22B14325AA88CA1D7B1272C1A7AC, filename: Canadian Themed Newgrf\Canadian_Stations-1.6.0\CanStn.grf (md5sum matches)
Added NewGRF: GRF ID 54570200, checksum 3DEB9B30A6254AE8606A5A9A99A9A696, filename: ALL STATION SET\gare diverses\usstatsw (2).grf (md5sum matches)
Added NewGRF: GRF ID 43485053, checksum 68B7DC640138E4F4B712F3CFB88167D6, filename: chips_station_set-1.4.0\chips.grf (md5sum matches)
Added NewGRF: GRF ID 504A0013, checksum E2FB4F9E66207F8016B7303323FDD00C, filename: isrdwestyle_objects-1.0\isrdwe_objects_v1_0.grf (md5sum matches)
Added NewGRF: GRF ID 44573452, checksum 48CF5FC0DEB895136F337A7E563FC66D, filename: ALL STATION SET\gare diverses\dwe_stat_r.grf (md5sum matches)
Added NewGRF: GRF ID 44578619, checksum B30A5E35634A59D2BDD9C2389CEDBF2C, filename: dwestationtiles__fences-v1.2\fences.grf (md5sum matches)
Added NewGRF: GRF ID 52455400, checksum 1600687C50C5AB1E72EDD487CAD50E2A, filename: ae_cityw.GRF (md5sum matches)
Added NewGRF: GRF ID 0100403A, checksum 7AF20043B3FBF794969A9292DEE937C4, filename: city_objects-b06\co06.grf (md5sum matches)
Added NewGRF: GRF ID 6D620C00, checksum 79F501FF2571BBC7E0713E3E86F513FB, filename: marico.grf (md5sum matches)
Added NewGRF: GRF ID 504A0107, checksum 29830A0BDE9BBE9578C44C4D22D76B7C, filename: beach_v1_0.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0501, checksum 32533DE8356B7D38137770523929DFA3, filename: dutch_road_furniture-0.6.0\dutchroadfurniture.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0502, checksum 55AE61673CBCDE4A7231DEA85973278C, filename: dutch_road_furn._uk_signs_addon-1.0.0\dutchroadfurnitureuksignsaddon.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 536506BDDDBD8644815FC2E7E6A80D7A, filename: fish_2-2.0.2\fish.grf (md5sum matches)
Added NewGRF: GRF ID 4D430207, checksum 1D297AAD8A7F19F49ED60997CADCEF9E, filename: polroad-19\polroad.grf (md5sum matches)
Added NewGRF: GRF ID 1560B248, checksum 76BE5A3BA8C66817C14CFA05177D20D9, filename: redfish-0.4\redfish.grf (md5sum matches)
Added NewGRF: GRF ID 9787EAFE, checksum 88D9C3894ADC2C068CF7EF1FD42BFB84, filename: road_hog-alpha15\road-hog.grf (md5sum matches)
Added NewGRF: GRF ID 24252C2C, checksum 4B9D9B1DF2B0C34FABC9AAC8554F9427, filename: hungarian_truck_set-3l\hts.grf (md5sum matches)
Added NewGRF: GRF ID 504A4641, checksum 457DE3A141B99D6BE258981C993B6761, filename: fake_airport_objects-0.1\fakeairportobjects_v0_1.grf (md5sum matches)
Added NewGRF: GRF ID 304FE908, checksum 1096139243746879AEF44B7C339C77E3, filename: city_hqs-b\chq.grf (md5sum matches)
Added NewGRF: GRF ID 444E0800, checksum 334F8C4697455569073434DB107F864A, filename: vast_objects-0.3.0\vastobjects.grf (md5sum matches)
Added NewGRF: GRF ID 444E0C00, checksum B5D2AB5FC93A09E1FAB5F0DB82307ECF, filename: vast_fences-0.2.0\vastfences.grf (md5sum matches)
Added NewGRF: GRF ID 444E0400, checksum 735D3D74D5DCADBF1FD6EF7A9C5A3519, filename: vast_station_tiles-0.2.0\vast.grf (md5sum matches)
Added NewGRF: GRF ID 58534D00, checksum 6F4C28B41F5127046DED0320D0BE533B, filename: modern_set.grf (md5sum matches)
Added NewGRF: GRF ID 6D620601, checksum 537A2B9E5F0644BC360248B2B802D086, filename: newstats.grf (md5sum matches)
Added NewGRF: GRF ID 7D244C0E, checksum BC419F2B1EA283EA0D663BB849318209, filename: ALL ROAD VEHICLES\huntram_1.1b.grf (md5sum matches)
Added NewGRF: GRF ID 53441101, checksum 3E2397532428AB013862B22EDBB396E5, filename: ALL NEW OBJECTS\INFRA Green P1\infra_green1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53441119, checksum 4201D77058BC82C4F2DC0294AFBA6DC3, filename: ALL NEW OBJECTS\INFRA Green P2\infra_green1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID 53441129, checksum 9CF044DD9054F863295D5AA8A1671999, filename: ALL NEW OBJECTS\INFRA Green P3\infra_green1x1_p3.grf (md5sum matches)
Added NewGRF: GRF ID 53541101, checksum AAE3DC77FAC504FB07D9F8752F49ECA4, filename: ALL NEW OBJECTS\INFRA Streets P1-OpenTTD\infra_streets1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53541119, checksum 40AC1CC9C1E328BE359094B7754054DB, filename: ALL NEW OBJECTS\INFRA Streets P2-OpenTTD\infra_streets1x1_p2.grf (md5sum matches)
Added NewGRF: GRF ID 53541129, checksum 249C8A47E845E9D0270FFAFE5E2EB4C1, filename: ALL NEW OBJECTS\INFRA Streets P3-OpenTTD\infra_streets1x1_p3.grf (md5sum matches)
Added NewGRF: GRF ID 52453C00, checksum C5B4EC240B33E2DB8D1EA64C97898B5E, filename: packttdistas\stolentreesw_162.grf (md5sum matches)
Added NewGRF: GRF ID 554A0000, checksum F7410A673ED67FA693AD063C4FEB1863, filename: polish_buildings_set-1.4.0\plbuildingset140w.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum B21E7D6ADD69B1C07643939764FB4878, filename: swedish_houses-1.1.2\swehouses.grf (md5sum matches)
Added NewGRF: GRF ID 4D656F9D, checksum A4D9273D4C56BD2432E8994B95652D65, filename: ecs_houses-1.1.219jun2011\ecshouse.grf (md5sum matches)
Added NewGRF: GRF ID 44442303, checksum 90300B85C4DE1DD192691827B054522D, filename: uk_railway_set_tracks-2.0\pb_trax.grf (md5sum matches)
Added NewGRF: GRF ID 167B2E54, checksum 7EB5E4CBFFFF6E43043AC0CDD44B2C55, filename: city_tram_track-b06\ctt06.grf (md5sum matches)
Added NewGRF: GRF ID 524B0301, checksum BB7BBE4FF23B349D17ED0A682503680C, filename: lightrailtramtracks-0.2\tramtrkw.grf (md5sum matches)
Added NewGRF: GRF ID 44441000, checksum DA36131A815D2D5FC158C7A27D67B5AF, filename: ukrs2__the_uk_railway_set-1.05\proj1000.grf (md5sum matches)
Added NewGRF: GRF ID 44441001, checksum 83915879F68DD174C953868C0629A4C9, filename: ukrs2_uk_railway_addon_set-gobi\pj1kadd.grf (md5sum matches)
Added NewGRF: GRF ID 57415332, checksum A3D1F4C7D1D1F9A39F0F5E5B0FE11853, filename: WAS.grf (md5sum matches)
Added NewGRF: GRF ID 53421194, checksum A4C2739CC2290D24A62B14506577D1A8, filename: TDUK.grf (md5sum matches)
Added NewGRF: GRF ID 44442411, checksum E6A38D0DC67DE54DD2928447BB72F924, filename: tai_uk_houses-gamma1\tai_uk.grf (md5sum matches)
Added NewGRF: GRF ID 504E0001, checksum E7781323D2B0086E2E76342DAA036054, filename: ALL WAYPOINTS\ukwaypointsw.grf (md5sum matches)
Tick 1280: game loaded
Revision text changed to jgrpp-0.4.1, savegame version 194, not modified, _openttd_newgrf_version = 0x16006b02
---- gamelog end ----

*** End of OpenTTD Crash Report ***
Attachments
crash.png
(1014.37 KiB) Not downloaded yet
crash.sav
(3.3 MiB) Downloaded 294 times
crash.dmp
(4.69 MiB) Downloaded 288 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Frdm920 wrote:Hey JGR,

My copy of your Patch Pack seems to have suddenly developed a tendency to crash when demolishing/building landscape objects in the scenario editor (I'm not sure if it occurs in game as well, but I have confirmed it's not limited to any one scenario) any ideas? Dump, Log, PNG and Save attached.
Thanks for the bug report.
Are there any particular steps or GRFs which seem to trigger this? I haven't been able to reproduce it at my end.
I'm having some trouble extracting useful info from the crash log so this may take some time.
Ex TTDPatch Coder
Patch Pack, Github
Frdm920
Engineer
Engineer
Posts: 3
Joined: 07 Sep 2015 13:17

Re: JGR's Patch Pack

Post by Frdm920 »

JGR wrote:
Frdm920 wrote:Hey JGR,

My copy of your Patch Pack seems to have suddenly developed a tendency to crash when demolishing/building landscape objects in the scenario editor (I'm not sure if it occurs in game as well, but I have confirmed it's not limited to any one scenario) any ideas? Dump, Log, PNG and Save attached.
Thanks for the bug report.
Are there any particular steps or GRFs which seem to trigger this? I haven't been able to reproduce it at my end.
I'm having some trouble extracting useful info from the crash log so this may take some time.
As I said mainly when demolishing/building things in the scenario editor, placing industries/roads/towns or anything like that does not appear to cause it, just the landscape objects although I think it most frequently occurs with the Fake Airport Objects grf. I tested in trunk and there was no issues, also the problem only started occuring yesterday and I haven't had the issue before then with any other patchpacks or the earlier revisions of your pack (or in fact with this revision up until yesterday) so I have to admit I'm quite confused.

I can confirm though that it is not related to changing the grfs of an existing scenario/game as even creating a new scenario has the same issues.

Edit: It happened again when levelling terrain, so another crash log and dump attached (didn't get the save sorry). Also not 100% sure but does seem to be limited to a certain set of grfs which I've attached a list of as well.

If it helps apparently C0000005 is an access violation.
Attachments
crash.txt
(18.77 KiB) Downloaded 259 times
crash.dmp
(4.69 MiB) Downloaded 241 times
grfs for scenarios where crash occured.txt
(10.39 KiB) Downloaded 264 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Frdm920 wrote:
JGR wrote:
Frdm920 wrote:Hey JGR,

My copy of your Patch Pack seems to have suddenly developed a tendency to crash when demolishing/building landscape objects in the scenario editor (I'm not sure if it occurs in game as well, but I have confirmed it's not limited to any one scenario) any ideas? Dump, Log, PNG and Save attached.
Thanks for the bug report.
Are there any particular steps or GRFs which seem to trigger this? I haven't been able to reproduce it at my end.
I'm having some trouble extracting useful info from the crash log so this may take some time.
As I said mainly when demolishing/building things in the scenario editor, placing industries/roads/towns or anything like that does not appear to cause it, just the landscape objects although I think it most frequently occurs with the Fake Airport Objects grf. I tested in trunk and there was no issues, also the problem only started occuring yesterday and I haven't had the issue before then with any other patchpacks or the earlier revisions of your pack (or in fact with this revision up until yesterday) so I have to admit I'm quite confused.

I can confirm though that it is not related to changing the grfs of an existing scenario/game as even creating a new scenario has the same issues.

Edit: It happened again when levelling terrain, so another crash log and dump attached (didn't get the save sorry). Also not 100% sure but does seem to be limited to a certain set of grfs which I've attached a list of as well.

If it helps apparently C0000005 is an access violation.
The crash log seems to point to the code to animate the cursor, but that may be a false positive. It might be that some GRF set or other part of the code is doing something fishy with the cursor sprites.

I've been doing a bit of hacking on the crash logger and so if you could try with the binary attached I'd be most appreciative. It should produce a nicer and more useful crashlog. (The source is on github).
Edit: snipped, this is in v0.5.0 now.
Last edited by JGR on 14 Sep 2015 01:18, edited 1 time in total.
Ex TTDPatch Coder
Patch Pack, Github
Frdm920
Engineer
Engineer
Posts: 3
Joined: 07 Sep 2015 13:17

Re: JGR's Patch Pack

Post by Frdm920 »

Ok done with the binary, log attached.
Attachments
crashwithbinary.txt
(20.38 KiB) Downloaded 255 times
crash.dmp
(6.89 MiB) Downloaded 247 times
crash.png
(498.59 KiB) Not downloaded yet
User avatar
Mizari
Traffic Manager
Traffic Manager
Posts: 136
Joined: 22 Apr 2012 14:21

Re: JGR's Patch Pack

Post by Mizari »

I can confirm that I too experienced a lot of crashes when playing in the scenario editor, though I did not test it any further.
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

I can consistently reproduce it by opening the main landscaping menu, then the house-building window, and then, without closing it, clicking on the object button of the main landscaping menu.
This seems to crash on all platforms and without any GRFs, so this should be fixable later on today.

Edit:
This is now fixed. The bug is currently in trunk, and was introduced in r27346.
The chain of events is as follows:
SELGW = ScenarioEditorLandscapeGenerationWindow
Crash is triggered by the following:
1. SELGW has a OnPlaceObject active (e.g. raise/lower land).
2. SELGW button is clicked to open BuildObjectWindow
3. BuildObjectWindow constructor calls ResetObjectToPlace
4. SELGW::OnPlaceObjectAbort is called
5. DeleteWindowById(WC_BUILD_OBJECT, 0) is called
6. BuildObjectWindow is freed whilst its constructor is executing
7. Crash occurs later on in the BuildObjectWindow constructor.
AddressSanitizer was quite handy in debugging this.

Edit 2: Seems a bug has been filed for this already.
Ex TTDPatch Coder
Patch Pack, Github
sunshare
Transport Coordinator
Transport Coordinator
Posts: 279
Joined: 10 Oct 2014 00:43

Re: JGR's Patch Pack

Post by sunshare »

Hello, could add these patch?

Extra large maps and Huge airports, which they are the Springpack

Waypoints Air: http://www.tt-forums.net/viewtopic.php?t=72165
nihues
Engineer
Engineer
Posts: 85
Joined: 13 Jan 2015 10:26

Re: JGR's Patch Pack

Post by nihues »

Hello, I might have found another bug.

Your 0.4.1 patch is crashing when using conditional orders, tried with ships only, just add a conditional order, then it crashes to desktop. Code and save below.

And, you can use some new patches from BTPro Client http://openttd.btpro.nl/forum/30-btpro- ... ient-1-5-1

I really like from BTPRO:
- Industry Tooltips patch - by MJP;
- Station Tooltips patch - by ST2 (based on previous Industry Tooltips patch);
- New line in Town GUI - By Xi - (GR: number of days town takes to build a new building: next: number of days till next building is built; RH: number of days till town rebuilt an existent building; flag: are new building being funded?; Fund: remaining months of Fund New Buildings campaign);
- Potential town population (including unfinished buildings) in town window caption bar - by Novapolis team
- Option for depots and road stations to automatically choose direction (Thanks to Novapolis team)
- Local authority detail for all companies in town authority window (Thanks to Novapolis team)
- Added 2 new lines in Town GUI (Thanks to Novapolis team):
* Houses: Building: Houses under construction; RTM: Rebuilt this Month; DTM: Demolished this Month;
* House skip (HS); Cycle skip (CS); House removal (HR); Values appear like: Total (Last_Month) (wiki.novapolis.net/index.php/Advanced_town_growth);
- Added Show houses count in towns list, towns can be sorted by it too (Thanks to CityMania team);
- Added Zoning patch - originally here www.tt-forums.net/viewtopic.php?f=33&t=33701 upgraded by Citymania team - our thanks to both and m1 for the merge;
- new CB window (in town window) with auto schedule for regular advertisement, powerfunding, etc (Thanks to CityMania team and m1 for the merge);
- Added new set of hotkeys (thanks to Novapolis team); (read below)
* Not all hotkeys have a default value, but can be set in the hotkeys.cfg file.

But I miss most of yout patches from BTPro too... a mix of both would be very nice!



Code: Select all

*** OpenTTD Crash Report ***

Crash at: Thu Sep 10 17:03:50 2015
In game date: 1902-01-09 (17)

Crash reason:
 Signal:  Segmentation fault (11)
 Message: <none>

OpenTTD version:
 Version:    jgrpp-0.4.1 (1)
 NewGRF ver: 16006b02
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Sep  8 2015 21:53:53

Stacktrace:
 [00] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZNK12CrashLogUnix13LogStacktraceEPcPKc+0x37) [0x76bdc7]
 [01] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZNK8CrashLog12FillCrashLogEPcPKc+0xeb) [0x64c7cb]
 [02] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZNK8CrashLog12MakeCrashLogEv+0x7f) [0x64ca3f]
 [03] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd() [0x76bcd5]
 [04] /lib/x86_64-linux-gnu/libc.so.6(+0x36d40) [0x7f8131d17d40]
 [05] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZN14NWidgetStacked17SetDisplayedPlaneEi+0) [0x8ea190]
 [06] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZN12OrdersWindow17UpdateButtonStateEv+0x864) [0x767434]
 [07] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZN12OrdersWindow7OnClickE5Pointii+0x410) [0x768b80]
 [08] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_Z17HandleMouseEventsv+0x1162) [0x8f35e2]
 [09] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZN15VideoDriver_SDL9PollEventEv+0xf6) [0x8d0926]
 [10] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_ZN15VideoDriver_SDL8MainLoopEv+0x80) [0x8d0bb0]
 [11] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd(_Z12openttd_mainiPPc+0x1422) [0x759ba2]
 [12] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f8131d02ec5]
 [13] /home/nihues/Dropbox/Openttd JGRPP 0.4.1/openttd() [0x5a1dbe]

Operating system:
 Name:     Linux
 Release:  3.13.0-37-generic
 Version:  #64-Ubuntu SMP Mon Sep 22 21:28:38 UTC 2014
 Machine:  x86_64
 Compiler: GCC 4.8.4 "4.8.4"

Configuration:
 Blitter:      32bpp-anim
 Graphics set: OpenGFX (5580)
 Language:     /home/nihues/Dropbox/Openttd JGRPP 0.4.1/lang/english_US.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: sdl
 Sound set:    NoSound (2)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  Century Schoolbook L
 Mono:   sprite

AI Configuration (local: 0):
  0: Human
 GS: Neighbours are important (v16)

Libraries:
 FontConfig: 2.11.0
 FreeType:   2.5.2
 ICU i18n:   52.1
 ICU lx:     52.1
 LZMA:       5.1.0alpha
 LZO:        2.06
 PNG:        1.2.50
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.4.1, savegame version 194, maybe modified, _openttd_newgrf_version = 0x16006b02
New game mode: 1 landscape: 1
Added NewGRF: GRF ID 79210502, checksum FAFE655EC51D907391C38B116B199307, filename: brazilian_town_names-2.0/braziliantownnames.grf (md5sum matches)
Added NewGRF: GRF ID 4D4703C1, checksum 22BBE4FFF6EAC6BCCC71B6403F876D19, filename: basemod_presets-1.4.2/basecosts-presets.grf (md5sum matches)
Added NewGRF: GRF ID 44440A80, checksum A930B079A5B8985E94EA823604CC276B, filename: av9.8-0.83/av9point8.grf (md5sum matches)
Added NewGRF: GRF ID 44441000, checksum DA36131A815D2D5FC158C7A27D67B5AF, filename: ukrs2__the_uk_railway_set-1.05/proj1000.grf (md5sum matches)
Added NewGRF: GRF ID 44441001, checksum 83915879F68DD174C953868C0629A4C9, filename: ukrs2_uk_railway_addon_set-gobi/pj1kadd.grf (md5sum matches)
Added NewGRF: GRF ID 1560B248, checksum 76BE5A3BA8C66817C14CFA05177D20D9, filename: redfish-0.4/redfish.grf (md5sum matches)
Added NewGRF: GRF ID 52571203, checksum 7CE88A25DDB058C1BE577B88D049B274, filename: egrvts2-188/egrvts2.grf (md5sum matches)
Added NewGRF: GRF ID 304FE908, checksum 1096139243746879AEF44B7C339C77E3, filename: city_hqs-b/chq.grf (md5sum matches)
Added NewGRF: GRF ID 52455400, checksum 1600687C50C5AB1E72EDD487CAD50E2A, filename: coded_by_aegir._artwork_by_aegir-1/ae_cityw.grf (md5sum matches)
Added NewGRF: GRF ID 54430201, checksum C837D48D657129DD915830D60D68E09F, filename: cs_stationset_v0.1-1/csstationsw.grf (md5sum matches)
Added NewGRF: GRF ID 54430202, checksum 081B62FD686AF2161866A0CF6EA043AC, filename: cs_platforms_set-1/csplatformsw.grf (md5sum matches)
Added NewGRF: GRF ID 58534453, checksum 2E100BCA91DB8371CD9D57DBEC3AB0C8, filename: dutch_stations_set-1.0.0alpha/dutchstatw.grf (md5sum matches)
Added NewGRF: GRF ID 504A0110, checksum E8244C5278CB2408A818854DC11F8940, filename: dutch_station_addition_set-0.8/dstatadd_v0_8.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2/indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 45530500, checksum 3A943F4E8E345F903F2CEF090A12346C, filename: japanese_stations-3.5/jpstations.grf (md5sum matches)
Added NewGRF: GRF ID 52455200, checksum 0E5A9C5ACD2BCAF7FA0658C3F905A660, filename: rural_stations-1/ae_ruraw.grf (md5sum matches)
Added NewGRF: GRF ID 4D50006A, checksum 3A797B1A7E3968A91CB45199BCF52520, filename: ore_unloader_station-0.1/iorestat.grf (md5sum matches)
Added NewGRF: GRF ID 49464E4F, checksum 9EE9117BD4511BD6879429ECF8DC9335, filename: sno__supercheeses_newobjects-0.3.1/sno-supercheesesnewobjects.grf (md5sum matches)
Added NewGRF: GRF ID 54570200, checksum 3DEB9B30A6254AE8606A5A9A99A9A696, filename: us_stations_set-0.86/usstatsw.grf (md5sum matches)
Added NewGRF: GRF ID 504A0013, checksum E2FB4F9E66207F8016B7303323FDD00C, filename: isrdwestyle_objects-1.0/isrdwe_objects_v1_0.grf (md5sum matches)
Added NewGRF: GRF ID F1250005, checksum 955C122CEFCC91F1EDAB646F7DF7D141, filename: firs_industry_replacement_set-1.4.4/firs.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum 136D889FDAEAA3491F8320248A04425C, filename: opengfx_landscape-1.1.2/ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 46727806, checksum BBE029FCDD7A16F85876D417FF318D23, filename: opengfx_trees-0.8.0/opengfx+trees.grf (md5sum matches)
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2/ogfx-airports.grf (md5sum matches)
Added NewGRF: GRF ID 415A0301, checksum 8667797182D6F6C670D7BE5D677ACB45, filename: american_road_replacement_set-2.0.0/americanroads.grf (md5sum matches)
Added NewGRF: GRF ID 44442303, checksum 90300B85C4DE1DD192691827B054522D, filename: uk_railway_set_tracks-2.0/pb_trax.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0901, checksum 4619642A3BF1A535AEDBDA426FF63EBB, filename: friss-0.5.2/friss-stations.grf (md5sum matches)
Added NewGRF: GRF ID 44440502, checksum 9B2267C916691C45A2C85BE1FF54F7C3, filename: combined_american_signal_set.1.1/ussigzw.grf (md5sum matches)
Added NewGRF: GRF ID 415A0501, checksum 37F4A01391FE088BD22740A89E22F78B, filename: total_bridge_renewal_set_arrs-1.0.0/total_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 48530101, checksum EC17E22A38C037D156BD22A96F4A8523, filename: reduced_passenger_payment.1.0/reducedpassengerpayment.grf (md5sum matches)
Added NewGRF: GRF ID 43414361, checksum 4FF21D837F0C19EF91DB383B62FB3151, filename: NACityw.grf (md5sum matches)
Added NewGRF: GRF ID 52453400, checksum 87E88EFA687F91CE44548E54DA55059F, filename: japanese_buildings-3.0/jpbuild.grf (md5sum matches)
Added NewGRF: GRF ID 554A0000, checksum F7410A673ED67FA693AD063C4FEB1863, filename: polish_buildings_set-1.4.0/plbuildingset140w.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum B21E7D6ADD69B1C07643939764FB4878, filename: swedish_houses-1.1.2/swehouses.grf (md5sum matches)
---- gamelog end ----

*** End of OpenTTD Crash Report ***
Attachments
Jones & Co., Jan 1st, 1902.sav
(990.57 KiB) Downloaded 243 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

nihues wrote:Hello, I might have found another bug.

Your 0.4.1 patch is crashing when using conditional orders, tried with ships only, just add a conditional order, then it crashes to desktop. Code and save below.
Thanks for the bug report. It seems that the more conditional orders patch added the new widgets to the train orders window but forgot to add them to the non-train orders window, a fix is on github/will be in the next release.
nihues wrote: And, you can use some new patches from BTPro Client http://openttd.btpro.nl/forum/30-btpro- ... ient-1-5-1

I really like from BTPRO:
- Industry Tooltips patch - by MJP;
- Station Tooltips patch - by ST2 (based on previous Industry Tooltips patch);
- New line in Town GUI - By Xi - (GR: number of days town takes to build a new building: next: number of days till next building is built; RH: number of days till town rebuilt an existent building; flag: are new building being funded?; Fund: remaining months of Fund New Buildings campaign);
- Potential town population (including unfinished buildings) in town window caption bar - by Novapolis team
- Option for depots and road stations to automatically choose direction (Thanks to Novapolis team)
- Local authority detail for all companies in town authority window (Thanks to Novapolis team)
- Added 2 new lines in Town GUI (Thanks to Novapolis team):
* Houses: Building: Houses under construction; RTM: Rebuilt this Month; DTM: Demolished this Month;
* House skip (HS); Cycle skip (CS); House removal (HR); Values appear like: Total (Last_Month) (wiki.novapolis.net/index.php/Advanced_town_growth);
- Added Show houses count in towns list, towns can be sorted by it too (Thanks to CityMania team);
- Added Zoning patch - originally here http://www.tt-forums.net/viewtopic.php?f=33&t=33701 upgraded by Citymania team - our thanks to both and m1 for the merge;
- new CB window (in town window) with auto schedule for regular advertisement, powerfunding, etc (Thanks to CityMania team and m1 for the merge);
- Added new set of hotkeys (thanks to Novapolis team); (read below)
* Not all hotkeys have a default value, but can be set in the hotkeys.cfg file.

But I miss most of yout patches from BTPro too... a mix of both would be very nice!
The zoning patch is already included, albeit without any upgrades which you've added. Industry tooltips is included as part of the enhanced viewports patch.
I will have a look at the others, this is the first I've heard of BTPro.

Edit: Are these patches individually available anywhere? It's not very practical to review features when they're all squashed into a single diff.
sunshare wrote:Hello, could add these patch?

Extra large maps and Huge airports, which they are the Springpack

Waypoints Air: http://www.tt-forums.net/viewtopic.php?t=72165
I will have a look but can't make any guarantees about future additions.

Edit: Large maps should be doable, it's one I've been pondering already. The other two would be likely to need a fair bit of time to update, clean up, remove bugs, etc. so don't hold your breath.
Last edited by JGR on 11 Sep 2015 02:00, edited 2 times in total.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: JGR's Patch Pack

Post by ISA »

I also have earlier made a suggestion.
Also a suggestion. There were a patch where on the 'Map' window in one view all the different rail types were presented in different color.
I am not sure that You saw it as there was no answer. In some reason I cant find the patch what was certainly there some time back. In short: If You open mini map window the railroads (unelectrified, electrified, maglev and so on) are marked in different colors in one of those options what minimap offers
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

ISA wrote:I also have earlier made a suggestion.
Also a suggestion. There were a patch where on the 'Map' window in one view all the different rail types were presented in different color.
I am not sure that You saw it as there was no answer. In some reason I cant find the patch what was certainly there some time back. In short: If You open mini map window the railroads (unelectrified, electrified, maglev and so on) are marked in different colors in one of those options what minimap offers
Sorry, I must have missed it.
That said, I just tried it and rail types already seem to already be in different colours in the transport routes mode of the minimap (at least using NuTracks). I'm not sure when/where that was implemented, I'll have to have a look.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
ISA
Tycoon
Tycoon
Posts: 3384
Joined: 17 Oct 2005 20:56
Location: Estonia

Re: JGR's Patch Pack

Post by ISA »

Oh, I see. So its .grf related feature... I myself using Japan tracks. Maybe it was in the graphics section where I saw that. I were looking thru the development part. My mistake.
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Mizari wrote:Well, it was by default in HardPP, so whatever that was, it was automatic (and I don't recall if there was a setting somewhere to toggle it on or off, but there might have been) I didn't compile that myself.
I had a look in the most recent version of HardPP and couldn't find anything automatic or any default behaviour to do it yearly.
I went ahead and merged the daily/monthly/yearly scripts patch and the minimap patches anyway. You can add a script to run it yearly. You might find a script already in your HardPP installation folder in which case you can copy and use that.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Mizari
Traffic Manager
Traffic Manager
Posts: 136
Joined: 22 Apr 2012 14:21

Re: JGR's Patch Pack

Post by Mizari »

ISA wrote:Oh, I see. So its .grf related feature... I myself using Japan tracks. Maybe it was in the graphics section where I saw that. I were looking thru the development part. My mistake.
I think this is a feature of XUSSR Railway Set? It has different colours for different types of electrification and such.
Mushu
Engineer
Engineer
Posts: 2
Joined: 12 Sep 2015 15:45

Re: JGR's Patch Pack

Post by Mushu »

JGR wrote:
Valle wrote:Interestingly, there is a problem with the year display, which also exists with my friend's bundle.
If I'm in the year 1945, OpenTTD displays the year 21395. This problem persists in later years, with the year count rising accordingly.
That is a bit baffling. Interestingly 21395 is 11 times 1945 which suggests some sort of scaling issue somewhere. Do you get the same issue on OpenTTD trunk? Are you using an increased day length?
I have the same problem, and yes daylenth of 6 => year multiplied by 6, changed the daylenth to 8 (ingame) and bam the year is now multiplied by 8.
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Mushu wrote:
JGR wrote:
Valle wrote:Interestingly, there is a problem with the year display, which also exists with my friend's bundle.
If I'm in the year 1945, OpenTTD displays the year 21395. This problem persists in later years, with the year count rising accordingly.
That is a bit baffling. Interestingly 21395 is 11 times 1945 which suggests some sort of scaling issue somewhere. Do you get the same issue on OpenTTD trunk? Are you using an increased day length?
Edit: This has been fixed already, and will be in the next release.
Ex TTDPatch Coder
Patch Pack, Github
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 46 guests