JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

Redirect Left wrote: it'd be nice to able to press 'Go To' when route plotting, but then have it stay in that mode when we select a station, and not have to go back and press 'Go To' again for the next station, and so on and so forth.

It'd also be pretty neat to be able to have an option which then routes the train back from its current point, through all the stations already chosen. So if i was going from A to F, via B C D & E. Usually i'd have to sleect A to F seperate, then again E to B. Would be amazing if we could just click say "end route" and then it automatically routes its way back through the identical route chosen on the return.

Are either of these viable, do you think?
If you make sure that non-stop is not selected, then your train should stop at all stations between A and B. For the return trip, just do Go To A (without Non-Stop) and your train should do the same on the return trip.
Also, in the Settings window under Company, make sure that "New orders are 'non-stop' by default" is set to off.
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

wallyweb wrote:
Redirect Left wrote: it'd be nice to able to press 'Go To' when route plotting, but then have it stay in that mode when we select a station, and not have to go back and press 'Go To' again for the next station, and so on and so forth.

It'd also be pretty neat to be able to have an option which then routes the train back from its current point, through all the stations already chosen. So if i was going from A to F, via B C D & E. Usually i'd have to sleect A to F seperate, then again E to B. Would be amazing if we could just click say "end route" and then it automatically routes its way back through the identical route chosen on the return.

Are either of these viable, do you think?
If you make sure that non-stop is not selected, then your train should stop at all stations between A and B. For the return trip, just do Go To A (without Non-Stop) and your train should do the same on the return trip.
Also, in the Settings window under Company, make sure that "New orders are 'non-stop' by default" is set to off.
The issue is, I default to non stop, as most of my stuff is long distance and seperate trains for local stopping services. So when i am doing local stoppers, it's a bit of effort. I do use non-stop orders for long distance trains so they won't decide to stop everywhere and be a nuisance to other traffic,
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

Redirect Left wrote:The issue is, I default to non stop, as most of my stuff is long distance and seperate trains for local stopping services. So when i am doing local stoppers, it's a bit of effort. I do use non-stop orders for long distance trains so they won't decide to stop everywhere and be a nuisance to other traffic,
Assuming that your long distance trains have fewer orders, set non-stop to off and then set the long distance trains to non-stop in the orders window.
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

wallyweb wrote:
Redirect Left wrote:The issue is, I default to non stop, as most of my stuff is long distance and seperate trains for local stopping services. So when i am doing local stoppers, it's a bit of effort. I do use non-stop orders for long distance trains so they won't decide to stop everywhere and be a nuisance to other traffic,
Assuming that your long distance trains have fewer orders, set non-stop to off and then set the long distance trains to non-stop in the orders window.

I guess that is one solution, but I reckon ideally it'd be nice to have some sub function to automatically route the train back, I think actual orders instead of the implied ones OpenTTD generates look neater, and also if you don't route some stations, the pathfinder may find a quicker or ideal route that avoids that station, which would be solved by specifically routing through it, either manually or automatically.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: JGR's Patch Pack

Post by wallyweb »

Redirect Left wrote:I guess that is one solution, but I reckon ideally it'd be nice to have some sub function to automatically route the train back, I think actual orders instead of the implied ones OpenTTD generates look neater, and also if you don't route some stations, the pathfinder may find a quicker or ideal route that avoids that station, which would be solved by specifically routing through it, either manually or automatically.
Heh. I think I see what you are on to.
Go to F (return) such that (return) causes the train to work the stops inserted by OTTD in reverse and (return) suppresses a default non-stop setting for that train.
You'd still need a Go to A order, if only to get a new train from the depot to A.
Eddi
Tycoon
Tycoon
Posts: 8267
Joined: 17 Jan 2007 00:14

Re: JGR's Patch Pack

Post by Eddi »

Redirect Left wrote:]it'd be nice to able to press 'Go To' when route plotting, but then have it stay in that mode when we select a station, and not have to go back and press 'Go To' again for the next station, and so on and so forth.
you know the "G" hotkey?
It'd also be pretty neat to be able to have an option which then routes the train back from its current point, through all the stations already chosen. So if i was going from A to F, via B C D & E. Usually i'd have to sleect A to F seperate, then again E to B. Would be amazing if we could just click say "end route" and then it automatically routes its way back through the identical route chosen on the return.
that would be something to work into a complete redesign of the order GUI, which is desperately needed, but nobody really attempted so far.

it is currently overloaded with features, and some of them are hidden behind hotkeys and modifier keys (like CTRL) or sensitive of what you click on, which is difficult to communicate to users. simply adding that button you ask for would make that worse.
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

Eddi wrote:
Redirect Left wrote:]it'd be nice to able to press 'Go To' when route plotting, but then have it stay in that mode when we select a station, and not have to go back and press 'Go To' again for the next station, and so on and so forth.
you know the "G" hotkey?
Nope. That makes things simpler. I guess that is also part of the GUI issue, it doesn't really make these alternatives obviously known.

Another interesting issue I have, is accidentally pressing the window behind the 'go to' button (although now I know G this will not be an issue as much).
I am not sure if this only happens at certain resolutions, but the 'buy vehicle' button is unfortunately placed directly behind the 'go to' button, so a slight misclick means you get an unfortunate buy and need to fix that. Any gui updates, either in this patch or in general, may be worth changing that.
Image
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
User avatar
Gwyd
Chief Executive
Chief Executive
Posts: 721
Joined: 17 Apr 2017 16:52
Location: Western Ile-de-France Region

Re: JGR's Patch Pack

Post by Gwyd »

Also in the options is "fast creation of vehicle orders" or something like that, which means Go To is automatically pressed down when you open an (empty?) vehicle's orders window. It also continues to hold down the button for you as you click round your route. Hope this has helped
mak
Traffic Manager
Traffic Manager
Posts: 205
Joined: 30 Sep 2015 13:16

Re: JGR's Patch Pack

Post by mak »

Gwyd wrote:Also in the options is "fast creation of vehicle orders" or something like that, which means Go To is automatically pressed down when you open an (empty?) vehicle's orders window. It also continues to hold down the button for you as you click round your route. Hope this has helped
What he said, :)

It is a sub edit in 'Construction'
lugo
Engineer
Engineer
Posts: 100
Joined: 12 Oct 2010 13:55

Re: JGR's Patch Pack

Post by lugo »

lugo wrote: Well, using jgrpp-0.28.0 and having a freight train selected, i can only cycle through "near end", "middle" and "far end".
I overlooked the appropriate setting: "Interface -> Show advanced loading mode features". :roll: :lol:
User avatar
Redirect Left
Tycoon
Tycoon
Posts: 7249
Joined: 22 Jan 2005 19:31
Location: Wakefield, West Yorkshire

Re: JGR's Patch Pack

Post by Redirect Left »

I thikn all this suggests that we really need to have some sort of introductory thing in game you can start that shows you all the short cuts and how to do X and Y things.
Image
Need some good tested AI? - Unofficial AI Tester, list of good stuff & thread is here.
MichalSoldat
Engineer
Engineer
Posts: 10
Joined: 21 Oct 2018 21:47

Re: JGR's Patch Pack

Post by MichalSoldat »

Would be possible to add to patch pack something like "rush hours"
So the town would generate different amout of passangers in specific hours. So far u can modify the amout only by increasing towns note by regular handling. Would it be possible to reverse that? So we can simulate morning and after work rush.
User avatar
JGR
Tycoon
Tycoon
Posts: 2559
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

madrito wrote:
JGR wrote:... I'm open to suggestions ...
suggestion is that there should be some version with prog.singnals variant somehow "better".grf or otherwise and not necessarily permanently
This is implemented, the programmable signals graphics can now be overridden by a NewGRF. See here for details.
Redirect Left wrote:I thikn all this suggests that we really need to have some sort of introductory thing in game you can start that shows you all the short cuts and how to do X and Y things.
As much as that would be nice, someone (else) would have to volunteer to do it.
MichalSoldat wrote:Would be possible to add to patch pack something like "rush hours"
So the town would generate different amout of passangers in specific hours. So far u can modify the amout only by increasing towns note by regular handling. Would it be possible to reverse that? So we can simulate morning and after work rush.
I don't see how it would fit in the gameplay model, really. If someone implements it and it turns out to work well I can look into the feasibility of including it though.
Ex TTDPatch Coder
Patch Pack, Github
ino
Traffic Manager
Traffic Manager
Posts: 152
Joined: 09 Apr 2017 14:58

Re: JGR's Patch Pack

Post by ino »

I actually did consider the "ruch hour" feature before, because it would really make full timetabling elmore meaningful. It should not be that hard to implement (just change the current "town cargo generation factor" according to time), but I have not look in depth yet.

I end up thinking that it would require big changes because currently wall clock setting is not saved -- it is purely client setting. So you cannot rely on that for "ruch hour". If wall clock setting were to be changed to be saved in save game then I might consider implementing it.

Ideally, I want rush hour and quiet hour (e.g. night), so that frieght train would run during quiet hour, etc.
stb
Engineer
Engineer
Posts: 40
Joined: 20 Sep 2013 20:26

Re: JGR's Patch Pack

Post by stb »

Hi there,
The last version has some bug: cloning a vehichle sometimes doesn't create new one's window
User avatar
Gwyd
Chief Executive
Chief Executive
Posts: 721
Joined: 17 Apr 2017 16:52
Location: Western Ile-de-France Region

Re: JGR's Patch Pack

Post by Gwyd »

I think the problem with rush hours is that stations (especially ones in a typical commuter context) usually have a backlog. Having extra passengers being added periodically wouldn't make a huge difference to game play, and I would just have to run extra trains at all times.
MichalSoldat
Engineer
Engineer
Posts: 10
Joined: 21 Oct 2018 21:47

Re: JGR's Patch Pack

Post by MichalSoldat »

Gwyd wrote:I think the problem with rush hours is that stations (especially ones in a typical commuter context) usually have a backlog. Having extra passengers being added periodically wouldn't make a huge difference to game play, and I would just have to run extra trains at all times.
The idea would be to set passanger multipler by yourself in lets say 24 time periods. 0-1, 1-2 etc. And of course u need to make timetable witch has the same frequency as "rush hours" so it makes sense.
User avatar
Gwyd
Chief Executive
Chief Executive
Posts: 721
Joined: 17 Apr 2017 16:52
Location: Western Ile-de-France Region

Re: JGR's Patch Pack

Post by Gwyd »

Yes but what I'm saying is that if I have ten thousand people constantly waiting at my station, extra demand at certain hours won't change how I run services.
ino
Traffic Manager
Traffic Manager
Posts: 152
Joined: 09 Apr 2017 14:58

Re: JGR's Patch Pack

Post by ino »

Gwyd wrote:I think the problem with rush hours is that stations (especially ones in a typical commuter context) usually have a backlog. Having extra passengers being added periodically wouldn't make a huge difference to game play, and I would just have to run extra trains at all times.
Not everyone have backlog at their stations :-)

I used to think that, as many big train stations constantly have thousands of people waiting. But when I looked closely, most of them are not backlog -- they are just connecting. With train length 4 (8 cars), commuter train holds 700-900 persons, and at hub station where a lot of lines, with various services, operate from, you can easily get into thousands of people just waiting for connection in the station.

For me with extra demand, I am thinking 4-20 times the normal demand, with quiet hour have less than 10% of normal demand.
madrito
Engineer
Engineer
Posts: 37
Joined: 05 Jul 2018 15:38

Re: JGR's Patch Pack

Post by madrito »

JGR wrote:
madrito wrote:
JGR wrote:... I'm open to suggestions ...
suggestion is that there should be some version with prog.singnals variant somehow "better".grf or otherwise and not necessarily permanently
This is implemented, the programmable signals graphics can now be overridden by a NewGRF. See here for details.

...
Yes, elegantly
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 20 guests