JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
AndersI
Tycoon
Tycoon
Posts: 1732
Joined: 19 Apr 2004 20:09
Location: Sweden
Contact:

Re: JGR's Patch Pack

Post by AndersI »

JGR wrote: There's a divide by 0 error in the case where the total estimated cost of all scheduled cargo-dest link graph operations is 0 or 1, which is a case that I hadn't thought of.

Edit: Have you got a crash log or some other information for the assertion failure case.
It looks like 0.17.1 fixed all of my problems, at least it hasn't crashed yet (more than an hour of playing).

Thank you!
User avatar
GlitchDetector
Engineer
Engineer
Posts: 14
Joined: 18 Sep 2009 19:47

Scrolling Bug Fix

Post by GlitchDetector »

I'm having issues with scrolling in the game. (This seems to be an issue in the core game.)
For a while I've been playing using the custom BTPro client for vanilla, which includes a fix for the scrolling issues.

In their client's thread they have this listed under patches:
- Enabled DpiAwareness (VS100 project file), to avoid scrolling glitches (mostly on Windows 10);

I'm no tech person, so I don't know exactly what and how this change is. But if you could look into possibly doing something like this with this pack, it would be amazing!

Playing in Fullscreen or downscaling my monitor to 1080p isn't always ideal. (which are the current fixes for the scrolling)
LocArny
Transport Coordinator
Transport Coordinator
Posts: 378
Joined: 17 Oct 2005 12:40
Location: Bennekom, Netherlands

Re: JGR's Patch Pack

Post by LocArny »

JGR wrote:
LocArny wrote:1/ I switched over from the Spring Patchpack recently, this pack allows very long vehicle names. I regularly change my vehicle names from "Road Vehicle 4" to the name of the origin or destination but currently this often does not fit in the text box. Is it possible to increase the number of characters allowed in the text boxes?
I've increased the limit. This'll be in the next release.
Hi JGR, you've kindly increased the vehicle name limit, would you be able to do the same for Vehicle Groups? Thanks a lot!
User avatar
Hyronymus
Tycoon
Tycoon
Posts: 13233
Joined: 03 Dec 2002 10:36
Location: The Netherlands
Contact:

Re: JGR's Patch Pack

Post by Hyronymus »

I ran into a crash using patchpack 16, see attached files and log.
[+] Spoiler

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Sat Feb 18 19:19:42 2017
In game date: 1899-03-15 (54, 0)

Crash reason:
 Exception: E1212012
 Location:  00007FF8304E7788
 Message:   Assertion failed at line 2602 of /home/jgr/openttd/cross-win64/src/window.cpp: HasModalProgress() || IsLocalCompany()

Within context:
     0: RunVehicleDayProc: veh: 6270: (Schip 58)

OpenTTD version:
 Version:    jgrpp-0.16.0 (0)
 NewGRF ver: 17006c20
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Nov 26 2016 22:59:39
 Configure:  ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
 FFFF0000 00007FF8 00000016 00000000 00000000 00000000 00000001 00000000
 E1212012 00000000 00000000 00000000 304E7788 00007FF8 00000000 00007FF8
 00000003 3900F778 02C04740 00000000 00012010 00000000 000704D0 00000000
 00000000 00000000 FFFFFFFF 00007FF8 00000003 3900F778 332A3A65 00007FF8
 00000003 3900F778 CE403DDE 00000000 02AD96A8 00000000 33656457 00007FF8
 02AD96A0 00000000 30525973 00007FF8 0000000C 00000000 00000000 00000000
 5B60F7B1 0000BC47 79929A54 00004204 00000016 00000000 3329AD70 00007FF8
 00000001 00000000 CE403DDE 00007FF8 0000000D 00000000 00000314 00000000
 00000006 00000000 33647187 00007FF8 00000003 00000000 0000000D 00000000
 00000000 00000000 00000000 00000000 00000102 00000000 000B002C 00000000
 0000000D 00000000 3329F19E 00007FF8 00000001 00000000 CE403DDE 00007FF8
 02AD9D20 00000000 0000000D 00000000 02AD9800 00000000 30BE422C 00007FF8
 000B002C 00000000 00000001 00000000 00000001 00000000 30BEE52E 00007FF8
 00000000 00000000 30BF35AC 00007FF8 00000000 00000000 036C1240 00000000
 00000000 00000000 00000000 00000000 000D0454 00000000 30BFE3AE 00007FF8
 02AD9800 00000000 000B002C 00000000 00000001 00000000 00000001 00000000
 00000001 00007FF8 00000012 00000000 000704D0 00000000 0000000F 00000000
 00000000 00000000 00000000 00000000 255D4FAA 00000258 00000265 00000000
 02C8CDC0 00000000 30C56CA0 00007FF8 02C8CE24 00000000 30BD0000 00007FF8
 00000012 00000000 30BFE223 00007FF8 000B002C 00000000 00000001 00000000
 00000008 00000000 30BD78AD 00007FF8 02C8CE24 00000000 00000000 00000000
 00000178 00000000 02AD9999 00000000 02C8CDC0 00000000 00000000 00000000
 00000075 00000000 30C5AE97 00007FF8 00010003 00000000 00000000 00000000
 02C8CDC0 00000000 00000075 00000000 02AD9BD0 00000000 00000000 00007FF8

Registers:
 RAX: 000000000065F090 RBX: 0000000000000016 RCX: 00007FF833685FE0 RDX: 0000000002C00308
 RSI: 0000000000000000 RDI: 0000000000000001 RBP: 000000000000000D RSP: 0000000002AD95F0
 R8:  0000000000000001 R9:  0000000000000001 R10: 00000025FFFFBEF7 R11: 0000000000000000
 R12: 0000000000000910 R13: 0000000000000000 R14: 00007FF8333048E0 R15: 000000000053F880
 RIP: 00007FF8304E7788 EFLAGS: 00000206

 Bytes at instruction pointer:
 48 8B 8C 24 C0 00 00 00 48 33 CC E8 98 1A 06 00 48 81 C4 D8 00 00 00 C3

Operating system:
 Name:     Windows
 Release:  6.2.9200 ()
 Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
 Blitter:      32bpp-sse2-anim
 Graphics set: OpenGFX (5580)
 Language:     C:\Program Files\OpenTTD\lang\dutch.lng
 Music driver: win32
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: win32
 Sound set:    OpenSFX (87)
 Video driver: win32

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 16):
  0: Human
  1: AdmiralAI (v25)
  3: NoNoCAB (v3)
  4: Terron (v209)
 GS: Neighbours are important (v16)

Libraries:
 FreeType:   2.6.0
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
 C:\Program Files\OpenTTD\openttd.exe handle: 0000000000400000 size: 37757289 crc: C5F3B5F5 date: 2017-01-03 16:50:58
 C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007ff8335e0000 size: 1886344 crc: 32D0F0CC date: 2017-01-03 15:44:52
 C:\WINDOWS\System32\KERNEL32.DLL handle: 00007ff8333a0000 size: 699880 crc: BDA99C07 date: 2016-07-16 11:42:16
 C:\WINDOWS\System32\KERNELBASE.dll handle: 00007ff8304d0000 size: 2213760 crc: B80E8694 date: 2017-01-03 15:44:52
 C:\WINDOWS\System32\ADVAPI32.dll handle: 00007ff832e20000 size: 652352 crc: 4CF4BA4F date: 2016-07-16 11:42:21
 C:\WINDOWS\System32\msvcrt.dll handle: 00007ff833270000 size: 634824 crc: 1B98629E date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\sechost.dll handle: 00007ff830ea0000 size: 357984 crc: 923D1945 date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\RPCRT4.dll handle: 00007ff832f70000 size: 1176664 crc: D96EF587 date: 2017-01-03 15:44:52
 C:\WINDOWS\System32\GDI32.dll handle: 00007ff832850000 size: 206096 crc: E055C431 date: 2017-01-03 15:44:44
 C:\WINDOWS\System32\gdi32full.dll handle: 00007ff830810000 size: 1572768 crc: 696AF957 date: 2017-01-03 15:44:49
 C:\WINDOWS\System32\USER32.dll handle: 00007ff830bd0000 size: 1461200 crc: AF0289A1 date: 2017-01-03 15:44:44
 C:\WINDOWS\System32\win32u.dll handle: 00007ff8306f0000 size: 114192 crc: CE8A4673 date: 2017-01-03 15:44:44
 C:\WINDOWS\System32\IMM32.dll handle: 00007ff833240000 size: 175672 crc: EE969F35 date: 2016-07-16 11:42:23
 C:\WINDOWS\System32\SHELL32.dll handle: 00007ff831330000 size: 22224480 crc: 92967A74 date: 2016-12-21 07:42:45
 C:\WINDOWS\System32\cfgmgr32.dll handle: 00007ff82fba0000 size: 259848 crc: 53FDC18A date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\windows.storage.dll handle: 00007ff82fdf0000 size: 7219672 crc: 1FF4C0EE date: 2017-01-03 15:44:43
 C:\WINDOWS\System32\combase.dll handle: 00007ff830f60000 size: 2913144 crc: 04C21DC6 date: 2017-01-03 15:44:43
 C:\WINDOWS\System32\ucrtbase.dll handle: 00007ff830710000 size: 998920 crc: 1F92A209 date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007ff82fb30000 size: 431296 crc: 1EDD065B date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\powrprof.dll handle: 00007ff82fa80000 size: 301680 crc: EF88CF02 date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\shlwapi.dll handle: 00007ff830b70000 size: 333640 crc: 1B9E909B date: 2016-07-16 11:42:42
 C:\WINDOWS\System32\kernel.appcore.dll handle: 00007ff82fa70000 size: 48608 crc: A62D0607 date: 2016-07-16 11:42:06
 C:\WINDOWS\System32\shcore.dll handle: 00007ff82fbf0000 size: 681312 crc: 257B507D date: 2016-07-16 11:42:11
 C:\WINDOWS\System32\profapi.dll handle: 00007ff82fa40000 size: 69264 crc: 2C09169E date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\WS2_32.dll handle: 00007ff833330000 size: 424640 crc: 9F18231B date: 2017-01-03 15:44:52
 C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007ff82d400000 size: 124552 crc: A0E15932 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\WINMMBASE.dll handle: 00007ff82d3a0000 size: 164264 crc: AB86A028 date: 2016-07-16 11:42:22
 C:\WINDOWS\system32\uxtheme.dll handle: 00007ff82e0d0000 size: 587264 crc: 04A28A4B date: 2016-07-16 11:42:40
 C:\WINDOWS\System32\MSCTF.dll handle: 00007ff830d40000 size: 1418312 crc: 95BA362A date: 2017-01-03 15:44:49
 C:\WINDOWS\System32\OLEAUT32.dll handle: 00007ff833520000 size: 773720 crc: 627FBC3E date: 2017-01-03 15:44:43
 C:\WINDOWS\System32\msvcp_win.dll handle: 00007ff82fd50000 size: 633216 crc: D4E5ABC2 date: 2016-07-16 11:42:27
 C:\WINDOWS\system32\mswsock.dll handle: 00007ff82f370000 size: 357216 crc: 137D8928 date: 2016-07-16 11:42:27
 C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007ff82b650000 size: 443744 crc: D67CB824 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 00007ff82e660000 size: 151904 crc: 96DE9A73 date: 2016-07-16 11:42:27
 C:\WINDOWS\SYSTEM32\PROPSYS.dll handle: 00007ff82cd70000 size: 1599608 crc: 3FCD1704 date: 2016-07-16 11:42:06
 C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007ff82b2c0000 size: 233472 crc: 6000BF55 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007ff82e030000 size: 23816 crc: F880EE68 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007ff82c1a0000 size: 32592 crc: 8416D0D7 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007ff8119c0000 size: 590960 crc: 0C3D6D58 date: 2016-12-14 05:41:32
 C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007ff82c390000 size: 1267512 crc: C9CD261A date: 2017-01-03 15:44:43
 C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007ff82d470000 size: 29184 crc: 021361A5 date: 2016-07-16 11:42:21
 C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007ff82b9b0000 size: 105392 crc: B73361AF date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007ff82b9a0000 size: 25088 crc: BBB5876C date: 2016-07-16 11:42:21
 C:\WINDOWS\System32\clbcatq.dll handle: 00007ff832ed0000 size: 631176 crc: 17C82B8C date: 2016-07-16 11:42:17
 C:\WINDOWS\system32\dwmapi.dll handle: 00007ff82d150000 size: 128864 crc: B64DB65F date: 2017-01-03 15:44:41
 C:\WINDOWS\System32\psapi.dll handle: 00007ff832840000 size: 18656 crc: 3E63416E date: 2016-07-16 11:42:15

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.16.0, savegame version 195, not modified, _openttd_newgrf_version = 0x17006c20
New game mode: 1 landscape: 1
Added NewGRF: GRF ID 47471801, checksum 275D86707382D35A2F09AB29C116A665, filename: auzlandscapeobjects-12\auz_landscape_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47470801, checksum 83C613817E5B62EE7F8106110E5AB790, filename: auzslopeawaregroundtiles-1\auzslopeawaregroundtiles.grf (md5sum matches)
Added NewGRF: GRF ID 47470705, checksum D9144A59A210360F1A48350F04C6595D, filename: auz_lineside_objects-27\auz_lineside_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47470901, checksum CDEF5B917AB130B36B4D0186F9C006F1, filename: auz_roadside_objects-25\auz_roadside_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47471502, checksum 098B574E41A47B41F8B2218DCAF634D0, filename: auzwaterobjects-7\auz_water_objects.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21\pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 504A0107, checksum 92B822D319E71F920908801AD5751D26, filename: beach_objects-1.2\beach_v1_2.grf (md5sum matches)
Added NewGRF: GRF ID 4D4C0100, checksum 1E2A243600434194FB100E72E507D5EF, filename: dutch_catenary-1\dutchcatenary.grf (md5sum matches)
Added NewGRF: GRF ID 444C4F53, checksum 39F25FC87E91F7C4E45D9CC11F0FB52B, filename: dutch_landmark_objects_set-0.2\dlos.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0801, checksum 1294D2CF01E4FB615759526A65E7E8FF, filename: dutch_rail_furniture-0.1.2\dutchrailfurniture.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0501, checksum 60082E7DF1D3976274AB86843C3E07B2, filename: dutch_road_furniture-0.7.1\dutchroadfurniture.grf (md5sum matches)
Added NewGRF: GRF ID 58534453, checksum 2E100BCA91DB8371CD9D57DBEC3AB0C8, filename: dutch_stations_set-1.0.0alpha\dutchstatw.grf (md5sum matches)
Added NewGRF: GRF ID 504A0112, checksum B5A3C1AF5C32C0430C374C66963C3320, filename: dutch_station_addition_part_2-0.3\dstatadd_part2_v0_3.grf (md5sum matches)
Added NewGRF: GRF ID 504A0110, checksum E8244C5278CB2408A818854DC11F8940, filename: dutch_station_addition_set-0.8\dstatadd_v0_8.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0601, checksum E167E84751FD2E61967944010AF5C56D, filename: dutch_trainset_2-2.1.0\dutchtrains.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0102, checksum CE6B0C978C025F3477CC9A91AE9109FE, filename: dutch_tram_set-2.0.2\dutchtramset.grf (md5sum matches)
Added NewGRF: GRF ID 52571201, checksum C1C7D8C53EB7E74EEE2F0EF29638B466, filename: egrvts.1.0\egrvts.grf (md5sum matches)
Added NewGRF: GRF ID F1250006, checksum 05978AF75D1A1ACC8D8FBEE2BC5061C9, filename: firs_2-2.1.5\firs.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 504A0013, checksum E2FB4F9E66207F8016B7303323FDD00C, filename: isrdwestyle_objects-1.0\isrdwe_objects_v1_0.grf (md5sum matches)
Added NewGRF: GRF ID 44544E32, checksum EA20E21253A5795785E6DD2C8D1A5A1D, filename: dutch_town_names-2\dtnames.grf (md5sum matches)
Added NewGRF: GRF ID 4D50006A, checksum 3A797B1A7E3968A91CB45199BCF52520, filename: ore_unloader_station-0.1\iorestat.grf (md5sum matches)
Added NewGRF: GRF ID 4B460301, checksum 9E3EF9AB972B459F5BA33850A1F6520F, filename: rock_replacement_for_transmitter-1\transrock.grf (md5sum matches)
Added NewGRF: GRF ID 52455200, checksum 0E5A9C5ACD2BCAF7FA0658C3F905A660, filename: rural_stations-1\ae_ruraw.grf (md5sum matches)
Added NewGRF: GRF ID 4A4D0101, checksum AFE4E75999A3FF92D4B01DBEE9A803E9, filename: sailing_ships-0.62\ss.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 0DA3A80B986BC3C17C20CA4CE9CA26AA, filename: fish_2-2.0.3\fish.grf (md5sum matches)
Added NewGRF: GRF ID 4D4D9910, checksum 3CD3F4D0D98DDC0DB08E9AD74B88A9E2, filename: the_lighthouse_set-1.2\the_lighthouse_set_v1.2.grf (md5sum matches)
Added NewGRF: GRF ID 56430001, checksum 6E97AF35CB8B30720928F7C499D9CE3C, filename: ttrs3w-pre1930patch.grf (md5sum matches)
Added NewGRF: GRF ID 504A5457, checksum D795341420C564012E262FAB630018C5, filename: town_walls_objects-0.1\townwalls_v0_1.grf (md5sum matches)
Added NewGRF: GRF ID 444E0800, checksum 334F8C4697455569073434DB107F864A, filename: vast_objects-0.3.0\vastobjects.grf (md5sum matches)
Added NewGRF: GRF ID 444E0C00, checksum B5D2AB5FC93A09E1FAB5F0DB82307ECF, filename: vast_fences-0.2.0\vastfences.grf (md5sum matches)
Tick 1280: GRF config changed
Removed NewGRF: GRF ID 52571201, filename: egrvts.1.0\egrvts.grf (md5sum matches)
Added NewGRF: GRF ID 4D470305, checksum 2E96B9AB2BEA686BFF94961AD433A701, filename: basecosts-5.0\basecosts.grf (md5sum matches)
Added NewGRF: GRF ID 52571203, checksum 7CE88A25DDB058C1BE577B88D049B274, filename: egrvts2-188\egrvts2.grf (md5sum matches)
Tick 1280: GRF config changed
GRF parameter changed: GRF ID 52571203, filename: egrvts2-188\egrvts2.grf (md5sum matches)
Tick 11381: GRF config changed
GRF parameter changed: GRF ID 4A430002, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Tick 46032: GRF config changed
GRF parameter changed: GRF ID 4D470305, filename: basecosts-5.0\basecosts.grf (md5sum matches)
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x00007FF8304E7788 RaiseException + 104
[01] msvcrt               0x00007FF83329AD70 raise + 512
[02] msvcrt               0x00007FF83329F19E abort + 46
[03] openttd              0x000000000053049F error(char const*, ...) + 95 (/home/jgr/openttd/cross-win64/src/openttd.cpp:130)
[04] openttd              0x0000000000681328 HandleKeypress(unsigned int, unsigned int) + 568 (/home/jgr/openttd/cross-win64/src/window.cpp:2602)
[05] openttd              0x000000000065E8BB HandleCharMsg (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:488)
[06] openttd              0x000000000065F93E WndProcGdi (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:820)
[07] USER32               0x00007FF830BE1C24 CallWindowProcW + 1268
[08] USER32               0x00007FF830BE156C DispatchMessageW + 444
[09] USER32               0x00007FF830BFE4A6 DialogBoxIndirectParamAorW + 1078
[10] USER32               0x00007FF830BFE223 DialogBoxIndirectParamAorW + 435
[11] USER32               0x00007FF830C5AE5B SoftModalMessageBox + 8843
[12] USER32               0x00007FF830C588E8 MessageBoxW + 840
[13] USER32               0x00007FF830C58565 MessageBoxTimeoutW + 213
[14] USER32               0x00007FF830C585EE MessageBoxW + 78
[15] openttd              0x0000000000530492 error(char const*, ...) + 82 (/home/jgr/openttd/cross-win64/src/openttd.cpp:126)
[16] openttd              0x0000000000681328 HandleKeypress(unsigned int, unsigned int) + 568 (/home/jgr/openttd/cross-win64/src/window.cpp:2602)
[17] openttd              0x000000000065E8BB HandleCharMsg (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:488)
[18] openttd              0x000000000065F93E WndProcGdi (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:820)
[19] USER32               0x00007FF830BE1C24 CallWindowProcW + 1268
[20] USER32               0x00007FF830BE156C DispatchMessageW + 444
[21] USER32               0x00007FF830BFE4A6 DialogBoxIndirectParamAorW + 1078
[22] USER32               0x00007FF830BFE223 DialogBoxIndirectParamAorW + 435
[23] USER32               0x00007FF830C5AE5B SoftModalMessageBox + 8843
[24] USER32               0x00007FF830C588E8 MessageBoxW + 840
[25] USER32               0x00007FF830C58565 MessageBoxTimeoutW + 213
[26] USER32               0x00007FF830C585EE MessageBoxW + 78
[27] openttd              0x0000000000530492 error(char const*, ...) + 82 (/home/jgr/openttd/cross-win64/src/openttd.cpp:126)
[28] openttd              0x0000000000681328 HandleKeypress(unsigned int, unsigned int) + 568 (/home/jgr/openttd/cross-win64/src/window.cpp:2602)
[29] openttd              0x000000000065E8BB HandleCharMsg (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:488)
[30] openttd              0x000000000065F93E WndProcGdi (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:820)
[31] USER32               0x00007FF830BE1C24 CallWindowProcW + 1268
[32] USER32               0x00007FF830BE156C DispatchMessageW + 444
[33] USER32               0x00007FF830BFE4A6 DialogBoxIndirectParamAorW + 1078
[34] USER32               0x00007FF830BFE223 DialogBoxIndirectParamAorW + 435
[35] USER32               0x00007FF830C5AE5B SoftModalMessageBox + 8843
[36] USER32               0x00007FF830C588E8 MessageBoxW + 840
[37] USER32               0x00007FF830C58565 MessageBoxTimeoutW + 213
[38] USER32               0x00007FF830C585EE MessageBoxW + 78
[39] openttd              0x0000000000530492 error(char const*, ...) + 82 (/home/jgr/openttd/cross-win64/src/openttd.cpp:126)
[40] openttd              0x0000000000681328 HandleKeypress(unsigned int, unsigned int) + 568 (/home/jgr/openttd/cross-win64/src/window.cpp:2602)
[41] openttd              0x000000000065E8BB HandleCharMsg (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:488)
[42] openttd              0x000000000065F93E WndProcGdi (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:820)
[43] USER32               0x00007FF830BE1C24 CallWindowProcW + 1268
[44] USER32               0x00007FF830BE156C DispatchMessageW + 444
[45] USER32               0x00007FF830BFE4A6 DialogBoxIndirectParamAorW + 1078
[46] USER32               0x00007FF830BFE223 DialogBoxIndirectParamAorW + 435
[47] USER32               0x00007FF830C5AE5B SoftModalMessageBox + 8843
[48] USER32               0x00007FF830C588E8 MessageBoxW + 840
[49] USER32               0x00007FF830C58565 MessageBoxTimeoutW + 213
[50] USER32               0x00007FF830C585EE MessageBoxW + 78
[51] openttd              0x0000000000530492 error(char const*, ...) + 82 (/home/jgr/openttd/cross-win64/src/openttd.cpp:126)
[52] openttd              0x0000000000681328 HandleKeypress(unsigned int, unsigned int) + 568 (/home/jgr/openttd/cross-win64/src/window.cpp:2602)
[53] openttd              0x000000000065FA1F WndProcGdi (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:840)
[54] USER32               0x00007FF830BE1C24 CallWindowProcW + 1268
[55] USER32               0x00007FF830BE156C DispatchMessageW + 444
[56] USER32               0x00007FF830BFE4A6 DialogBoxIndirectParamAorW + 1078
[57] USER32               0x00007FF830BFE223 DialogBoxIndirectParamAorW + 435
[58] USER32               0x00007FF830C5AE5B SoftModalMessageBox + 8843
[59] USER32               0x00007FF830C588E8 MessageBoxW + 840
[60] USER32               0x00007FF830C58565 MessageBoxTimeoutW + 213
[61] USER32               0x00007FF830C585EE MessageBoxW + 78
[62] openttd              0x0000000000530492 error(char const*, ...) + 82 (/home/jgr/openttd/cross-win64/src/openttd.cpp:126)
[63] openttd              0x0000000000536747 OrderList::DebugCheckSanity() const + 503 (/home/jgr/openttd/cross-win64/src/order_cmd.cpp:721)

*** End of additional info ***
Attachments
crash.png
(418.89 KiB) Not downloaded yet
crash.dmp
(6.91 MiB) Downloaded 40 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: Scrolling Bug Fix

Post by JGR »

GlitchDetector wrote:I'm having issues with scrolling in the game. (This seems to be an issue in the core game.)
For a while I've been playing using the custom BTPro client for vanilla, which includes a fix for the scrolling issues.

In their client's thread they have this listed under patches:
- Enabled DpiAwareness (VS100 project file), to avoid scrolling glitches (mostly on Windows 10);

I'm no tech person, so I don't know exactly what and how this change is. But if you could look into possibly doing something like this with this pack, it would be amazing!

Playing in Fullscreen or downscaling my monitor to 1080p isn't always ideal. (which are the current fixes for the scrolling)
I don't have any Windows 10 machines which I can test on at present, but I can look into this.
LocArny wrote:Hi JGR, you've kindly increased the vehicle name limit, would you be able to do the same for Vehicle Groups? Thanks a lot!
That's done now, it'll be in the next release.
Hyronymus wrote:I ran into a crash using patchpack 16, see attached files and log.
This is an interesting crash log, I'll look into this.
Edit: Could you post a savegame as well please?
Ex TTDPatch Coder
Patch Pack, Github
BW89
Engineer
Engineer
Posts: 105
Joined: 10 May 2015 11:42

Re: JGR's Patch Pack

Post by BW89 »

Crash, when i work with Train Timetables (Version 17.1).
[+] Spoiler
*** OpenTTD Crash Report ***

Crash at: Sun Feb 19 12:13:15 2017
In game date: 1871-06-27 (3, 0)

Crash reason:
Exception: E1212012
Location: 00007FFFDA3E7788
Message: Disconnecting road vehicle.

Within context:
0: CallVehicleTicks: veh: 213: (Straßenfahrzeug 62)

OpenTTD version:
Version: jgrpp-0.17.1 (0)
NewGRF ver: 17006c5f
Bits: 64
Endian: little
Dedicated: no
Build date: Feb 14 2017 01:04:35
Configure: ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
FFFF0000 00007FFF 00000016 00000000 00000000 00000000 00000001 00000000
E1212012 00000000 00000000 00000000 DA3E7788 00007FFF 00000000 00007FFF
80000000 571A4D70 2933E270 00000000 00012010 00000000 00160820 00000000
00000000 00000000 FFFFFFFF 00007FFF 80000000 571A4D70 DB873A65 00007FFF
80000000 571A4D70 AE349AE1 00000000 02AECAE8 00000000 DDDE6457 00007FFF
02AECAE0 00000000 DA425973 00007FFF 0000000C 00000000 00000000 00000000
9A92550D 00005359 D6018AE6 0000D08E 00000016 00000000 DB86AD70 00007FFF
00000001 00000000 AE349AE1 00007FFF 00B7F570 00000000 00000314 00000000
00000006 00000000 DDDD7187 00007FFF 00000003 00000000 00B7F570 00000000
011D1E40 00000000 0006726C 00000000 00000000 00000000 00000005 00000000
000000FF 00000000 DB86F19E 00007FFF 00000001 00000000 AE349AE1 00000000
02AED160 00000000 00B7F570 00000000 02AECC40 00000000 DB9542FF 00007FFF
02AECC40 00000000 00000000 00000000 00000001 00000000 00000001 00000000
00000000 00000000 DB9635AC 00007FFF 00000000 00000000 03678C60 00000000
00000000 00000000 00000000 00000000 000807C4 00000000 DB96E3AE 00007FFF
001906DC 00000000 00000001 00000000 00000001 00000000 00000001 00000000
00000001 00007FFF 00000012 00000000 002F07E4 00000000 00000202 00000000
00000000 00000000 00040028 00000000 3D7D0D88 0000041B 00000264 00000000
2927CD90 00000000 DB9C6CA0 00007FFF 2927CDF4 00000000 DB940000 00007FFF
00000012 00000000 DB96E223 00007FFF 001906DC 00000000 00000001 00000000
00000000 00000000 DB9478AD 00007FFF 2927CDF4 00000000 00000000 00000000
00000092 00000000 02AECDD9 00000000 2927CD90 00000000 00000000 00000000
0000001B 00000000 DB9CAE97 00007FFF 00010003 00000000 00000000 00000000
2927CD90 00000000 0000001B 00000000 02AED010 00000000 00000000 00000000

Registers:
RAX: 0000000000070000 RBX: 0000000000000016 RCX: 00000000036BB520 RDX: 0000000003678C60
RSI: 0000000000000000 RDI: 0000000000000001 RBP: 0000000000000080 RSP: 0000000002AECA30
R8: 0000000000000000 R9: 0000000000000001 R10: 0000000000000001 R11: 0000000000000000
R12: 0000000000000910 R13: 0000000000000000 R14: 00007FFFDB8D48E0 R15: 000000000053FED0
RIP: 00007FFFDA3E7788 EFLAGS: 00000206

Bytes at instruction pointer:
48 8B 8C 24 C0 00 00 00 48 33 CC E8 98 1A 06 00 48 81 C4 D8 00 00 00 C3

Operating system:
Name: Windows
Release: 6.2.9200 ()
Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
Blitter: 32bpp-sse2-anim
Graphics set: OpenGFX (5580)
Language: C:\Program Files\OpenTTD\lang\german.lng
Music driver: win32
Music set: OpenMSX (96)
Network: no
Sound driver: win32
Sound set: original_dos (0)
Video driver: win32

Fonts:
Small: sprite
Medium: sprite
Large: sprite
Mono: sprite

AI Configuration (local: 0) (current: 16):
0: Human
GS: City Controller (v7)

Libraries:
FreeType: 2.6.0
LZMA: 5.2.1
LZO: 2.09
PNG: 1.5.23
Zlib: 1.2.8

Module information:
C:\Program Files\OpenTTD\openttd.exe handle: 0000000000400000 size: 37817374 crc: E547F30F date: 2017-02-14 01:05:22
C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007fffddd70000 size: 1886344 crc: 32D0F0CC date: 2016-11-11 10:13:03
C:\WINDOWS\System32\KERNEL32.DLL handle: 00007fffdc340000 size: 699880 crc: BDA99C07 date: 2016-07-16 11:42:16
C:\WINDOWS\System32\KERNELBASE.dll handle: 00007fffda3d0000 size: 2213760 crc: B80E8694 date: 2016-11-11 10:13:54
C:\WINDOWS\System32\ADVAPI32.dll handle: 00007fffdc050000 size: 652352 crc: 4CF4BA4F date: 2016-07-16 11:42:21
C:\WINDOWS\System32\msvcrt.dll handle: 00007fffdb840000 size: 634824 crc: 1B98629E date: 2016-07-16 11:42:27
C:\WINDOWS\System32\sechost.dll handle: 00007fffdbbb0000 size: 357984 crc: 923D1945 date: 2016-07-16 11:42:27
C:\WINDOWS\System32\RPCRT4.dll handle: 00007fffdc100000 size: 1176664 crc: D96EF587 date: 2016-09-24 12:55:31
C:\WINDOWS\System32\GDI32.dll handle: 00007fffddd20000 size: 206096 crc: E055C431 date: 2016-09-15 17:16:45
C:\WINDOWS\System32\gdi32full.dll handle: 00007fffdb170000 size: 1572768 crc: 696AF957 date: 2016-12-09 10:10:40
C:\WINDOWS\System32\USER32.dll handle: 00007fffdb940000 size: 1461200 crc: AF0289A1 date: 2016-12-09 10:10:58
C:\WINDOWS\System32\win32u.dll handle: 00007fffdb150000 size: 114192 crc: CE8A4673 date: 2016-09-24 12:55:17
C:\WINDOWS\System32\IMM32.dll handle: 00007fffdbab0000 size: 175672 crc: EE969F35 date: 2016-07-16 11:42:23
C:\WINDOWS\System32\SHELL32.dll handle: 00007fffdc810000 size: 22224480 crc: 92967A74 date: 2016-12-21 07:42:45
C:\WINDOWS\System32\cfgmgr32.dll handle: 00007fffda380000 size: 259848 crc: 53FDC18A date: 2016-07-16 11:42:27
C:\WINDOWS\System32\windows.storage.dll handle: 00007fffdaa70000 size: 7219672 crc: 1FF4C0EE date: 2016-11-11 10:01:16
C:\WINDOWS\System32\combase.dll handle: 00007fffdb430000 size: 2913144 crc: 04C21DC6 date: 2016-12-09 10:18:21
C:\WINDOWS\System32\ucrtbase.dll handle: 00007fffda5f0000 size: 998920 crc: 1F92A209 date: 2016-07-16 11:42:27
C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007fffda310000 size: 431296 crc: 1EDD065B date: 2016-07-16 11:42:27
C:\WINDOWS\System32\powrprof.dll handle: 00007fffda1f0000 size: 301680 crc: EF88CF02 date: 2016-07-16 11:42:27
C:\WINDOWS\System32\shlwapi.dll handle: 00007fffdb8e0000 size: 333640 crc: 1B9E909B date: 2016-07-16 11:42:42
C:\WINDOWS\System32\kernel.appcore.dll handle: 00007fffda250000 size: 48608 crc: A62D0607 date: 2016-07-16 11:42:06
C:\WINDOWS\System32\shcore.dll handle: 00007fffda260000 size: 681312 crc: 257B507D date: 2016-07-16 11:42:11
C:\WINDOWS\System32\profapi.dll handle: 00007fffda1d0000 size: 69264 crc: 2C09169E date: 2016-07-16 11:42:27
C:\WINDOWS\System32\WS2_32.dll handle: 00007fffdbb40000 size: 424640 crc: 9F18231B date: 2016-09-15 17:29:45
C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007fffd7b90000 size: 124552 crc: A0E15932 date: 2016-07-16 11:42:22
C:\WINDOWS\SYSTEM32\WINMMBASE.dll handle: 00007fffd7a90000 size: 164264 crc: AB86A028 date: 2016-07-16 11:42:22
C:\WINDOWS\system32\uxtheme.dll handle: 00007fffd8850000 size: 587264 crc: 04A28A4B date: 2016-07-16 11:42:40
C:\WINDOWS\System32\MSCTF.dll handle: 00007fffdc3f0000 size: 1418312 crc: 95BA362A date: 2016-11-11 09:54:14
C:\WINDOWS\System32\OLEAUT32.dll handle: 00007fffdb370000 size: 773720 crc: 627FBC3E date: 2016-11-02 11:13:43
C:\WINDOWS\System32\msvcp_win.dll handle: 00007fffda9d0000 size: 633216 crc: D4E5ABC2 date: 2016-07-16 11:42:27
C:\WINDOWS\System32\ole32.dll handle: 00007fffdb700000 size: 1274712 crc: E26EFDAD date: 2016-12-09 10:14:50
C:\WINDOWS\System32\clbcatq.dll handle: 00007fffdc770000 size: 631176 crc: 17C82B8C date: 2016-07-16 11:42:17
C:\WINDOWS\system32\mswsock.dll handle: 00007fffd9b00000 size: 357216 crc: 137D8928 date: 2016-07-16 11:42:27
C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007fffd63a0000 size: 443744 crc: D67CB824 date: 2016-07-16 11:42:22
C:\WINDOWS\SYSTEM32\PROPSYS.dll handle: 00007fffd7c10000 size: 1599608 crc: 3FCD1704 date: 2016-07-16 11:42:06
C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 00007fffd8d80000 size: 151904 crc: 96DE9A73 date: 2016-07-16 11:42:27
C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007fffce8f0000 size: 233472 crc: 6000BF55 date: 2016-07-16 11:42:22
C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007fffd2620000 size: 23816 crc: F880EE68 date: 2016-07-16 11:42:22
C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007fffd62f0000 size: 32592 crc: 8416D0D7 date: 2016-07-16 11:42:22
C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007fffc6ce0000 size: 590960 crc: 0C3D6D58 date: 2016-12-14 05:41:32
C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007fffd66c0000 size: 1267512 crc: C9CD261A date: 2016-12-09 10:18:15
C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007fffce8e0000 size: 29184 crc: 021361A5 date: 2016-07-16 11:42:21
C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007fffce8c0000 size: 105392 crc: B73361AF date: 2016-07-16 11:42:22
C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007fffce8b0000 size: 25088 crc: BBB5876C date: 2016-07-16 11:42:21
C:\WINDOWS\system32\dwmapi.dll handle: 00007fffd79a0000 size: 128864 crc: B64DB65F date: 2016-09-15 17:07:28
C:\WINDOWS\SYSTEM32\ntmarta.dll handle: 00007fffd9580000 size: 189608 crc: AB873A8B date: 2016-07-16 11:42:27
C:\WINDOWS\System32\coml2.dll handle: 00007fffdb300000 size: 435552 crc: 16445D5C date: 2016-07-16 11:42:09
C:\WINDOWS\system32\mssprxy.dll handle: 00007fffc5840000 size: 123904 crc: 7A386C86 date: 2016-09-15 16:42:48
C:\WINDOWS\SYSTEM32\LINKINFO.dll handle: 00007fffd1090000 size: 44032 crc: 34B16C79 date: 2016-07-16 11:42:32
C:\WINDOWS\SYSTEM32\ntshrui.dll handle: 00007fffc5ce0000 size: 842240 crc: 5D11A400 date: 2016-11-11 09:03:12
C:\WINDOWS\SYSTEM32\SspiCli.dll handle: 00007fffd9ed0000 size: 172528 crc: F0427C58 date: 2016-12-09 10:27:38
C:\WINDOWS\SYSTEM32\srvcli.dll handle: 00007fffd2310000 size: 112632 crc: 4B223A7A date: 2016-07-16 11:42:27
C:\WINDOWS\SYSTEM32\cscapi.dll handle: 00007fffc9280000 size: 52736 crc: CB4CC347 date: 2016-07-16 11:42:14
C:\WINDOWS\SYSTEM32\mciseq.dll handle: 00007fffd8080000 size: 29696 crc: 2A683EDA date: 2016-07-16 11:42:21
C:\WINDOWS\System32\psapi.dll handle: 00007fffddd60000 size: 18656 crc: 3E63416E date: 2016-07-16 11:42:15

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.17.1, savegame version 195, not modified, _openttd_newgrf_version = 0x17006c5f
New game mode: 1 landscape: 0
Added NewGRF: GRF ID 4A430101, checksum 436D10C2A56A7AC353C0B3C17326EAFD, filename: frsetw.grf (md5sum matches)
Added NewGRF: GRF ID 4A430201, checksum 72F61883FA6F118139551D9CA31E4C8D, filename: ng_frails.grf (md5sum matches)
Added NewGRF: GRF ID F1250006, checksum 05978AF75D1A1ACC8D8FBEE2BC5061C9, filename: firs_2-2.1.5\firs.grf (md5sum matches)
Added NewGRF: GRF ID 444A5401, checksum B9E9E16F258B32DC91E8BABEF037AFA7, filename: nutracks-r247\nutracks.grf (md5sum matches)
Added NewGRF: GRF ID 41501202, checksum B13DD8FB0D7C34CACAC2FE68BD137BB9, filename: heqs_heavy_equipment_set-1.5.2\heqs.grf (md5sum matches)
Added NewGRF: GRF ID 44441000, checksum DA36131A815D2D5FC158C7A27D67B5AF, filename: ukrs2__the_uk_railway_set-1.05\proj1000.grf (md5sum matches)
Added NewGRF: GRF ID 44441001, checksum 83915879F68DD174C953868C0629A4C9, filename: ukrs2_uk_railway_addon_set-gobi\pj1kadd.grf (md5sum matches)
Added NewGRF: GRF ID 4A430002, checksum 93EAC5F5396584B92D4C5F0AAAF3F6C5, filename: industrial_stations_renewal-1.0.2\indstatr.grf (md5sum matches)
Added NewGRF: GRF ID 52571203, checksum 7CE88A25DDB058C1BE577B88D049B274, filename: egrvts2-188\egrvts2.grf (md5sum matches)
Added NewGRF: GRF ID 54430202, checksum 081B62FD686AF2161866A0CF6EA043AC, filename: cs_platforms_set-1\csplatformsw.grf (md5sum matches)
Added NewGRF: GRF ID 504A0110, checksum E8244C5278CB2408A818854DC11F8940, filename: dutch_station_addition_set-0.8\dstatadd_v0_8.grf (md5sum matches)
Added NewGRF: GRF ID 504A0112, checksum B5A3C1AF5C32C0430C374C66963C3320, filename: dutch_station_addition_part_2-0.3\dstatadd_part2_v0_3.grf (md5sum matches)
Added NewGRF: GRF ID 47470603, checksum 4415AD19D4186AABBF6B8F8ED78760CB, filename: AuzTrains.grf (md5sum matches)
Added NewGRF: GRF ID 544D0101, checksum 9DABDC5F1D8500167D9E4D33966F549D, filename: 2ccts.grf (md5sum matches)
Added NewGRF: GRF ID 4A595001, checksum F53F72870EE9BB4F8A2DDF4C4F180173, filename: 2ccBusSet.grf (md5sum matches)
Added NewGRF: GRF ID 4A520103, checksum 0C510428BA638E3C91D85847A662D1D2, filename: earlyrail.grf (md5sum matches)
Added NewGRF: GRF ID 6A720102, checksum 443F036390FA16C7A110778DD09FB5A3, filename: ERSw.GRF (md5sum matches)
Added NewGRF: GRF ID FBFB0010, checksum 3BDB68BAE8FF4AB735F6C7565765BCB2, filename: trams-2cc.grf (md5sum matches)
Added NewGRF: GRF ID 4D560000, checksum A420B01EE556C4C8EC7E8A59E4CC05DB, filename: ikarus_set-6beta\testfilew.grf (md5sum matches)
Added NewGRF: GRF ID 4D430207, checksum 43F75A35741AFA497AD596270695B005, filename: polroad-36\polroad.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0102, checksum 5A27E9460F3FBAE54131FF1A921E1801, filename: dutchtramset.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0601, checksum E167E84751FD2E61967944010AF5C56D, filename: dutch_trainset_2-2.1.0\dutchtrains.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21\pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 4D430211, checksum 94FC6702295E1B0794947FACBCB914D6, filename: 600mm_narrow_gauge_railways-1.6\ng600mm.grf (md5sum matches)
Added NewGRF: GRF ID 4E4D0927, checksum A372DB9795CAF47B772E5918E8C44584, filename: nars_addon_set__indev-r0045\nars_addon_set.grf (md5sum matches)
Added NewGRF: GRF ID 57415332, checksum 9EC5F59156624E279872835B83DBA3A4, filename: WAS_2.grf (md5sum matches)
Added NewGRF: GRF ID 4A4D0101, checksum AFE4E75999A3FF92D4B01DBEE9A803E9, filename: sailing_ships-0.62\ss.grf (md5sum matches)
Added NewGRF: GRF ID 6D620601, checksum 537A2B9E5F0644BC360248B2B802D086, filename: newstats.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 0DA3A80B986BC3C17C20CA4CE9CA26AA, filename: fish.grf (md5sum matches)
Added NewGRF: GRF ID 43485053, checksum 3FFDBE665AF574189F8A6B08C94F3A71, filename: chips_station_set-1.6.1\chips.grf (md5sum matches)
Added NewGRF: GRF ID 44440302, checksum 439275017478C2E5E7AA25F5E191903D, filename: nars2w.grf (md5sum matches)
Added NewGRF: GRF ID 45530500, checksum D9BE5AFA481FC3E0A96E6EB72B455612, filename: japanese_stations-3.6\jpstations.grf (md5sum matches)
Added NewGRF: GRF ID 43415463, checksum 422B1603DC1CEDA4E59E715E12EAD332, filename: canstnw.grf (md5sum matches)
Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2\ogfx-airports.grf (md5sum matches)
Added NewGRF: GRF ID 52571208, checksum DC83DAB2933FACCB91678D4F75ABCCC6, filename: generic_cars-0.4\cars.grf (md5sum matches)
Added NewGRF: GRF ID 49464556, checksum F1F4F773E4A978A242EC74AEACCBAAC0, filename: eyecandy_road_vehicles-1.1\eyecandyroadvehicles.grf (md5sum matches)
Added NewGRF: GRF ID 47471801, checksum 288073EA78BCBAD65CEC76A418F138AA, filename: auzlandscapeobjects-2\auz_landscape_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47470705, checksum 27CCF263A98145B4D681E15430390817, filename: auz_lineside_objects-21\auz_lineside_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47471501, checksum 3E9737226FE315A9634F2DAA744F3E8D, filename: auzwaterobjects-2\auz_water_objects.grf (md5sum matches)
Added NewGRF: GRF ID 47470901, checksum 84E5B5D60F270B8D3374AD17C359ECF9, filename: auz_roadside_objects-18\auz_roadside_objects.grf (md5sum matches)
Added NewGRF: GRF ID 554A0000, checksum F7410A673ED67FA693AD063C4FEB1863, filename: polish_buildings_set-1.4.0\plbuildingset140w.grf (md5sum matches)
Added NewGRF: GRF ID 74677462, checksum 1D2A4E03D9F30922788C166254C27619, filename: total_bridge_renewal_set-1.2\total_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 53441101, checksum 7D8CFEEC75DA8705DF8E858287E3DC39, filename: infra_green_p1-1.0\infra_green1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID 53541101, checksum ECB758CAF23442BC55A0976A3EEEF1DB, filename: infra_streets_p1-1.0\infra_streets1x1_p1.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0501, checksum 60082E7DF1D3976274AB86843C3E07B2, filename: dutch_road_furniture-0.7.1\dutchroadfurniture.grf (md5sum matches)
Added NewGRF: GRF ID 0100403A, checksum 26B8CB3E29FA6DAD15DFE2F08F0BF1ED, filename: city_objects-b08.1\co08.1.grf (md5sum matches)
Added NewGRF: GRF ID 444E0800, checksum 334F8C4697455569073434DB107F864A, filename: vast_objects-0.3.0\vastobjects.grf (md5sum matches)
Added NewGRF: GRF ID 444E0C00, checksum B5D2AB5FC93A09E1FAB5F0DB82307ECF, filename: vast_fences-0.2.0\vastfences.grf (md5sum matches)
Added NewGRF: GRF ID 4F472B34, checksum 136D889FDAEAA3491F8320248A04425C, filename: opengfx_landscape-1.1.2\ogfx-landscape.grf (md5sum matches)
Added NewGRF: GRF ID 56430001, checksum 2AD089EE6B73F25D79F286AD43765914, filename: total_town_replacement_set-3.14\ttrs3w.grf (md5sum matches)
Added NewGRF: GRF ID 504A5457, checksum D795341420C564012E262FAB630018C5, filename: town_walls_objects-0.1\townwalls_v0_1.grf (md5sum matches)
Added NewGRF: GRF ID 504A0107, checksum 92B822D319E71F920908801AD5751D26, filename: beach_objects-1.2\beach_v1_2.grf (md5sum matches)
Added NewGRF: GRF ID 504A0013, checksum E2FB4F9E66207F8016B7303323FDD00C, filename: isrdwestyle_objects-1.0\isrdwe_objects_v1_0.grf (md5sum matches)
Added NewGRF: GRF ID 44442411, checksum E6A38D0DC67DE54DD2928447BB72F924, filename: tai_uk_houses-gamma1\tai_uk.grf (md5sum matches)
Added NewGRF: GRF ID 4D4D9910, checksum 3CD3F4D0D98DDC0DB08E9AD74B88A9E2, filename: the_lighthouse_set-1.2\the_lighthouse_set_v1.2.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum B21E7D6ADD69B1C07643939764FB4878, filename: swedish_houses-1.1.2\swehouses.grf (md5sum matches)
Added NewGRF: GRF ID 72777473, checksum EBEAB33B398DE7F2921F853C496F6F91, filename: uk_town_set-2.2\ukts_2.2.grf (md5sum matches)
Added NewGRF: GRF ID 52453C00, checksum C5B4EC240B33E2DB8D1EA64C97898B5E, filename: stolentreesw_162.grf (md5sum matches)
Added NewGRF: GRF ID 6D620C00, checksum CAF2CB97F2D3967B86C0DC53575EF368, filename: marico.grf (md5sum matches)
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE 0x00007FFFDA3E7788 RaiseException + 104
[01] msvcrt 0x00007FFFDB86AD70 raise + 512
[02] msvcrt 0x00007FFFDB86F19E abort + 46
[03] openttd 0x0000000000530A2F error(char const*, ...) + 95 (/home/jgr/openttd/cross-win64/src/openttd.cpp:130)
[04] openttd 0x0000000000571CAB IndividualRoadVehicleController(RoadVehicle*, RoadVehicle const*) + 3547 (/home/jgr/openttd/cross-win64/src/roadveh_cmd.cpp:1212)
[05] openttd 0x0000000000572A4B RoadVehController (/home/jgr/openttd/cross-win64/src/roadveh_cmd.cpp:1596)
[06] openttd 0x0000000000655952 CallVehicleTicks() + 418 (/home/jgr/openttd/cross-win64/src/vehicle.cpp:1027)
[07] openttd 0x000000000053460B StateGameLoop() + 363 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1560)
[08] openttd 0x00000000005347F8 GameLoop() + 280 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1657)
[09] openttd 0x00000000006610B9 VideoDriver_Win32::MainLoop() + 457 (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:1277)
[10] openttd 0x00000000005323E5 openttd_main(int, char**) + 5461 (/home/jgr/openttd/cross-win64/src/openttd.cpp:917)
[11] openttd 0x000000000054138F WinMain + 239 (/home/jgr/openttd/cross-win64/src/os/windows/win32.cpp:466)
[12] openttd 0x00000000004013ED __tmainCRTStartup + 573 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:332)
[13] openttd 0x00000000004014FB WinMainCRTStartup + 27 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:184)
[14] KERNEL32 0x00007FFFDC348364 BaseThreadInitThunk + 20
[15] ntdll 0x00007FFFDDDD70D1 RtlUserThreadStart + 33

*** End of additional info ***
Attachments
crash.sav
sav
(1.35 MiB) Downloaded 45 times
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

BW89 wrote:Crash, when i work with Train Timetables (Version 17.1).
Thanks for the crash report, this particular issue has already been reported and fixed a couple of days ago though. The fix will be in the next release.

The issue occurs when removal of a tram effective end of line at a tile edge occurs whilst an articulated tram is mid-way through performing a U-turn. This is probably caused by random road reconstruction.
Ex TTDPatch Coder
Patch Pack, Github
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

JGR wrote: The issue occurs when removal of a tram effective end of line at a tile edge occurs whilst an articulated tram is mid-way through performing a U-turn. This is probably caused by random road reconstruction.
Confirmed, I switched random reconstruction off and didn't got any crash server yet with articulated trams.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
User avatar
Hyronymus
Tycoon
Tycoon
Posts: 13233
Joined: 03 Dec 2002 10:36
Location: The Netherlands
Contact:

Re: Scrolling Bug Fix

Post by Hyronymus »

JGR wrote:
Hyronymus wrote:I ran into a crash using patchpack 16, see attached files and log.
This is an interesting crash log, I'll look into this.
Edit: Could you post a savegame as well please?
Would the crash.sav do by chance? Further information in advance: the crash was not critical to me but DictatorAI didn't make the cut.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: Scrolling Bug Fix

Post by JGR »

Hyronymus wrote:Would the crash.sav do by chance? Further information in advance: the crash was not critical to me but DictatorAI didn't make the cut.
The crash.sav should be fine, thanks.
Ex TTDPatch Coder
Patch Pack, Github
Amak
Engineer
Engineer
Posts: 36
Joined: 13 Feb 2017 14:48

Re: JGR's Patch Pack

Post by Amak »

Hi JGR,

Great work on 17.1, haven't had an issue yet.

Just curious, are you following NotRoadTypes? Would it be possible to add that at some stage?

Cheers
User avatar
Hyronymus
Tycoon
Tycoon
Posts: 13233
Joined: 03 Dec 2002 10:36
Location: The Netherlands
Contact:

Re: Scrolling Bug Fix

Post by Hyronymus »

JGR wrote:
Hyronymus wrote:Would the crash.sav do by chance? Further information in advance: the crash was not critical to me but DictatorAI didn't make the cut.
The crash.sav should be fine, thanks.
There you go :), happy bug hunting!
Attachments
crash.sav
(8 MiB) Downloaded 43 times
SimYouLater
Chief Executive
Chief Executive
Posts: 675
Joined: 03 Apr 2016 20:19

Re: JGR's Patch Pack

Post by SimYouLater »

Amak wrote:Hi JGR,

Great work on 17.1, haven't had an issue yet.

Just curious, are you following NotRoadTypes? Would it be possible to add that at some stage?

Cheers
Already asked this. The answer was "maybe".
JGR wrote:
SimYouLater wrote:Hey, there. Have you heard about NotRoadTypes? If so, can you keep an eye on it for future addition? Thanks for the great work!
I'm aware of it, I may took a closer look at it at a later date.
Licenses for my work...
You automatically have my permission to re-license graphics or code by me if needed for use in any project that is not GPL v2, on the condition that if you release any derivatives of my graphics they're automatically considered as ALSO GPL v2 (code may remain unreleased, but please do provide it) and carry this provision in GPL v2 uses.
Please ask someone in-the-know to be sure that the graphics are done by me. Especially TTD-Scale, long story.
Kruemelchen
Transport Coordinator
Transport Coordinator
Posts: 287
Joined: 18 Feb 2017 17:47

Re: JGR's Patch Pack

Post by Kruemelchen »

SimYouLater wrote:Already asked this. The answer was "maybe".
NotRoadTypes is also on my whishlist.
I tried a resent development snapshot and it worked pretty well (and without bugs so far) for me, so I guess it's realistic to add it to this patch pack some day when it's considered 'stable', as a lot of people would request it I guess?
On the other hand, as long as there is no support by the big RV NewGRFs, it's unlikely for it to be an useful patch to add at that state I guess.

Nevermind, I came here to tout my gratitude for this patch pack! :) You are doing an awesome job, JGR!!


But also I have a minor request. I first played the Spring Patch Pack, and got pretty used to the 'Trip History' feature, as it allowed me to optimise the trip, see delays and so on. I still miss it in your patch pack, so maybe you could look into that some day, if it's not too much hassle.
KeldorKatarn
Transport Coordinator
Transport Coordinator
Posts: 274
Joined: 13 Apr 2010 21:31

Re: JGR's Patch Pack

Post by KeldorKatarn »

Where is NewRoadTypes being discussed at the moment? There doesn't seem to be an active thread in the development section.
User avatar
supermop
Tycoon
Tycoon
Posts: 1104
Joined: 21 Feb 2010 00:15
Location: Fitzroy North - 96

Re: JGR's Patch Pack

Post by supermop »

KeldorKatarn wrote:Where is NewRoadTypes being discussed at the moment? There doesn't seem to be an active thread in the development section.
Just a few topics below this one: viewtopic.php?f=33&t=75637
Kruemelchen wrote:On the other hand, as long as there is no support by the big RV NewGRFs, it's unlikely for it to be an useful patch to add at that state I guess.
Depends on if you consider Road Hog to be a 'big' RV New GRF. I certainly do, as it provides trucks, trams (passengers and freight), buses, and heavy trucks from the 1860s through to the 2000s, and has up to date cargo support and sprites. I'd consider it to be 'bigger' both in vehicle selection and game-play balance than most other RV sets.

Coding support for NRT in a grf is surprisingly easy - even I, who hasn't managed to code a grf in 7 years, was able to put together a roadtype set last week. An unmodified RV set will still work with NRT, and it should be simple enough to modify any of the GPL sets to take advantage of powered roads or unpowered tramway.
User avatar
einsteinyh
Engineer
Engineer
Posts: 46
Joined: 15 Feb 2016 01:22
Location: Bogotá

Re: JGR's Patch Pack

Post by einsteinyh »

Hi, Could anybody help me please? :oops:
I have updated to 0.17.1 and I really like that custom bridgeheads is now enabled. :mrgreen:
However, I haven't been able to build any of them and I've searched in forums, in tt-wiki and openttd wiki without finding a way to do it.
Can anybody tell me how to build a bridge with custom bridgeheads? :roll:
Thanks
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

I'm not averse to the concept of merging NotRoadTypes at some point in the future, I'm not planning on looking into doing that imminently though, it still seems to be under active development.
As far as I can tell it should not cause any significant problems though.
Kruemelchen wrote:But also I have a minor request. I first played the Spring Patch Pack, and got pretty used to the 'Trip History' feature, as it allowed me to optimise the trip, see delays and so on. I still miss it in your patch pack, so maybe you could look into that some day, if it's not too much hassle.
I did consider this for inclusion when I was first putting together the patch-pack. I was not keen on it due to a number of significant usability issues in the UI, and to a lesser extent how the patch was implemented.
Having just dug up/recompiled my old copy of SpringPP though, they seem to have done a much better job with the UI than the standalone patch posted in the trip history thread which I tested previously, so I'll take another look at this in due course.
einsteinyh wrote:Hi, Could anybody help me please? :oops:
I have updated to 0.17.1 and I really like that custom bridgeheads is now enabled. :mrgreen:
However, I haven't been able to build any of them and I've searched in forums, in tt-wiki and openttd wiki without finding a way to do it.
Can anybody tell me how to build a bridge with custom bridgeheads? :roll:
Thanks
Custom bridge heads is only implemented for road/tram bridges at the moment.
There is a setting for it in the "Limitations" section, but it defaults to enabled.
As long as the bridge head is flat (i.e. the bridge ends on a slope), you should be able to add/remove road/tram pieces so long as there is at least one exit off of the bridge.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: Scrolling Bug Fix

Post by JGR »

Hyronymus wrote:Would the crash.sav do by chance? Further information in advance: the crash was not critical to me but DictatorAI didn't make the cut.
It would seem that the most probable cause of the crash is bugs in the infrastructure sharing patch in the handling of vehicle orders which refer to stations/depots/etc. owned by another company which is being deleted.
I would suspect that ship 58 of your company had orders to go the now deleted dock which was previously owned by that AI.

That particular issues and some others should be removed in v0.17.2
Ex TTDPatch Coder
Patch Pack, Github
User avatar
andythenorth
Tycoon
Tycoon
Posts: 5656
Joined: 31 Mar 2007 14:23
Location: Lost in Music

Re: JGR's Patch Pack

Post by andythenorth »

JGR wrote:I'm not averse to the concept of merging NotRoadTypes at some point in the future, I'm not planning on looking into doing that imminently though, it still seems to be under active development.
If you're using git remotes for the patchpack, you could add it from https://github.com/andythenorth/NotRoad ... tram-types ...if you're not then this doesn't help :)

NRT is 'mostly' done and has been tested. The major 'todo' items are scenario editor and gamescript (nogo) support, and obviously any bugs ;)

That said, I know nothing about custom bridgeheads, but from your previous comment, NRT might well conflict with custom bridgeheads as the road/tram bridge code has changed.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 9 guests