JGR's Patch Pack

[Leanden]

Should be on SD card at Android/data/org.openttd.jgrpp/files

Cant find this folder on Storage Device or Internal Storage.

Also text isnt showing up in the server window or the GRF list...

[Wahazar]

Add a setting to scale town growth rate by proportion of town cargo transported

How exactly this option works? Which cargo is accounted to growth rate?

[Gliptal]

It seems like I can't build any water related items on this build (0.21.0). i.e. I get a "can't build on water" when I try to build docks or shipyards. Vanilla works fine. All GRFs are disabled (not that that should change anything). I can provide more info if you can point me in the right direction.

[Leanden]

It seems like I can't build any water related items on this build. i.e. I get a "can't build on water" when I try to build docks or shipyards. Vanilla works fine. All GRFs are disabled (not that that should change anything). I can provide more info if you can point me in the right direction.

Can you be more specific than "this build"

[Gliptal]

It seems like I can't build any water related items on this build. i.e. I get a "can't build on water" when I try to build docks or shipyards. Vanilla works fine. All GRFs are disabled (not that that should change anything). I can provide more info if you can point me in the right direction.

Can you be more specific than "this build"

Yep sorry. It's 0.21.0 (based on trunk r27912) for Windows 64bit, downloaded directly from the OP.

[Wahazar]

It is weird. Didn't tested win64, but win32 and linux works fine both in singleplayer and multiplayer mode.

[Gliptal]

Same issue with the 32bit build.

To be clear, I downloaded the .zip, extracted it, and ran the .exe and let it download the opengraphics package. Previously I copied over the unzipped files on a copy of the vanilla OpenTTD installation. In both cases the water issues are there.

Is there a console somewhere that may help in troubleshooting the issue? By maybe enabling a stacktrace with the details on what condtion is triggerig the error.

[JGR]

Add a setting to scale town growth rate by proportion of town cargo transported

How exactly this option works? Which cargo is accounted to growth rate?

The scales an adjustable fraction of the town growth speed by the proportion of town cargo (passenger and mail) transported last month (same as shown in the town window).

It seems like I can't build any water related items on this build (0.21.0). i.e. I get a "can't build on water" when I try to build docks or shipyards. Vanilla works fine. All GRFs are disabled (not that that should change anything). I can provide more info if you can point me in the right direction.

I'm guessing that you've changed the "enable removing sea and rivers setting" to disabled.
It seems that it also prevents building docks and ship depots, which is indeed incorrect, I'll see that that is fixed.
In the meantime you can change the setting to enabled.

Edit: Fixed, will be in the next release.

[Gliptal]

That was it! Thanks.

[bayferd]

Reporting problem on latest android version of JGR patchpack
after i click check online content, NewGRF settings or AI/gamescript settings, the app force closes.
this applies both on main menu and in-game

[pelya]

Reproduced, I'll try to fix it tomorrow.

[Wahazar]

The scales an adjustable fraction of the town growth speed by the proportion of town cargo (passenger and mail) transported last month (same as shown in the town window).

Thanks for explanations, I wasn't sure that it counts only pas/mail or all cargo (including good, food etc). The latter case would be interesting, all these buggy town growth scripts occupying script slot would be somewhat obsolete.

[pelya]

Reporting problem on latest android version of JGR patchpack
after i click check online content, NewGRF settings or AI/gamescript settings, the app force closes.
this applies both on main menu and in-game

This should be fixed.

[bayferd]

Reporting problem on latest android version of JGR patchpack
after i click check online content, NewGRF settings or AI/gamescript settings, the app force closes.
this applies both on main menu and in-game

This should be fixed.

It's working now.
Thanks.

[Armin79]

Hi!

I'm using this great patch pack since about one year already and already spend many many hours to build my railway networks
in a Hokkaido Island scenario. The network already grown quite big and complex, but until a day ago everything worked fine,
but yesterday, suddenly after placing two trains more I constantly have the problem that "updating the cargo distribution" takes very much time..

Before I actually almost never saw this message, but now I see that message about every 3 minutes, the game stops and it takes about two minutes until the update is finished and the game continues to run.
Did my amount of cars/trains reach some "magic" limit? Did I encounter some bug?

I have attached two savegames. One where the cargo distribution still is working normally (ABSuper, 8. Jul 2136.sav) and another one, where I encounter the cargo update problem (ABSuper, 6. Okt 2136.sav) - in this savegame the update is still running, so the problem can be seen immediatelly.
I would be glad for any help

edit: ah yes, the JGR patchpack version I use is the current one .. 0.21.0, and I'm using a Windows 10 Laptop with 12GB RAM and and an i5 processor

[JGR]

Hi!

I'm using this great patch pack since about one year already and already spend many many hours to build my railway networks
in a Hokkaido Island scenario. The network already grown quite big and complex, but until a day ago everything worked fine,
but yesterday, suddenly after placing two trains more I constantly have the problem that "updating the cargo distribution" takes very much time..

Before I actually almost never saw this message, but now I see that message about every 3 minutes, the game stops and it takes about two minutes until the update is finished and the game continues to run.
Did my amount of cars/trains reach some "magic" limit? Did I encounter some bug?

I have attached two savegames. One where the cargo distribution still is working normally (ABSuper, 8. Jul 2136.sav) and another one, where I encounter the cargo update problem (ABSuper, 6. Okt 2136.sav) - in this savegame the update is still running, so the problem can be seen immediatelly.
I would be glad for any help

edit: ah yes, the JGR patchpack version I use is the current one .. 0.21.0, and I'm using a Windows 10 Laptop with 12GB RAM and and an i5 processor

Hi, thanks for reporting this.
This is a numeric overflow bug in the cost estimation/scheduling for cargodest link graph update jobs.
It's fixed now and will be in the next release.

[Armin79]

okay great, thanks for your efforts! I'm looking forward to the new version

And btw I also would have another question:
I'm usually using the automatic timetable for vehicle separation. But from time to time it happens,
that, because of the automated vehicle separation, the trains are blocking the whole station,
so that no train can go further anymore.

I understand that's because of the automated timetable, where the vehicles stopping at a station to wait a specific
amount of time to have a gap to the other vehicles, but in some cases this algorithm seem to make some vehicles
wait in the same station and blocking all platforms for many many minutes.
I don't want to always build more and more platforms or manually switch automated timetable off and on again
to solve that problem. Is this a problem already known and is there some workaround can be done?

[Marcus98]

Hello

I've recently downloaded the JGR patch (64-bits version) and the game frequently crashes (especially when trying to play a scenario). The settings are also reset. I've read the known-bugs file but I don't really understand why this problem is happening. (I'm not a computer programmer expert haha)

Below is the crash report file I've managed to find.

[+] Spoiler

*** OpenTTD Crash Report ***

Crash at: Thu Oct 05 14:04:08 2017
In game date: 0-01-01 (0, 0)

Crash reason:
Exception: E1212012
Location: 000007FEFDDAAC3D
Message: Assertion failed at line 2802 of /home/jgr/openttd/cross-win64/src/window.cpp: w

OpenTTD version:
Version: jgrpp-0.21.0 (0)
NewGRF ver: 18006d08
Bits: 64
Endian: little
Dedicated: no
Build date: Sep 5 2017 18:17:00
Configure: ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
00000016 00000000 00000000 00000000 00000008 00000000 7707C296 00000000
E1212012 00000000 00000000 00000000 FDDAAC3D 000007FE 00000000 000007FE
28000000 03A84B1D 770D11D6 00000000 00012010 00000000 00000130 000007FE
00040428 00000000 00000024 00000000 00000000 00000000 FFFFFFFF 000007FE
00012010 00000000 7777FBDA 00000000 00012010 00000000 750963A5 00000000
0022CEE8 00000000 00000024 00000000 00000000 00000000 FE4F0957 000007FE
00000001 00000000 FE511B15 000007FE 00000016 00000000 750963A5 00000000
FE565180 000007FE 01DD7AD1 00000000 00000003 00000000 777777BA 00000000
FE566180 000007FE 00000314 00000000 7706F0C4 00000000 7707BD10 00000000
03C80001 00000000 01DD7AD1 00000000 7707C69C 00000000 FE51559A 000007FE
00000001 00000000 0022D540 00000000 01DEE200 00000000 7707C69C 00000000
00000000 00000000 7778F5E5 00000000 00000000 00000000 00000000 00000000
777C93AC 00000000 12000012 00000000 0022CFE8 00000000 00000030 00000003
7706F5BA 00000000 12000012 00000000 03B80AE8 00000000 0022D018 00000000
00000000 00000000 03B4A1A0 00000000 00000020 00000000 00000000 00000000
00000000 00000000 777636A8 00000000 77785810 00000000 7708764C 00000000
00040428 00000000 03B4A1A0 00000000 00000001 00000000 00000001 00000000
00000001 00000000 690A0AAE 00000000 00000000 00000000 00000000 00000000
00000001 00000000 00000010 00000000 059E3BB0 00000000 036F0000 00000000
059E3BA0 00000000 77791885 00000000 036F0000 00000000 059E3B01 00000000
00000000 00000000 059E3BB0 00000000 00040428 00000000 770D32C4 00000000
00000001 00000000 00040428 00000000 770D32C4 00000000 0022D420 00000000
00000000 00000000 01DD6162 00000000 00010003 00000000 00000001 00000000
00000001 00000000 770D2825 00000000 059E3BB0 00000000 059E3BB0 00000000

Registers:
RAX: 00000000772FB085 RBX: 0000000000000016 RCX: 000000000022C810 RDX: 0000000000000000
RSI: 0000000000000000 RDI: 0000000000000008 RBP: 0000000000D12FC0 RSP: 000000000022CE20
R8: 0000000000000000 R9: 0000000000000000 R10: 0000000000000000 R11: 0000000000000286
R12: 000007FEFE561130 R13: 0000000000544570 R14: 0000000000000001 R15: 0000000000000314
RIP: 000007FEFDDAAC3D EFLAGS: 00000202

Bytes at instruction pointer:
48 81 C4 C8 00 00 00 C3 90 90 90 90 90 90 90 90 90 90 90 48 83 EC 48 83

Operating system:
Name: Windows
Release: 6.1.7600 ()
Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
Blitter: 32bpp-anim
Graphics set: none (4294967295)
Language: C:\Users\user\Desktop\OpenTTD\lang\english_US.lng
Music driver: none
Music set: none (4294967295)
Network: no
Sound driver: none
Sound set: none (4294967295)
Video driver: win32

Fonts:
Small: Arial
Medium: Arial
Large: Arial
Mono: sprite

AI Configuration (local: 0) (current: 0):

Libraries:
FreeType: 2.6.0
LZMA: 5.2.1
LZO: 2.09
PNG: 1.5.23
Zlib: 1.2.8

Module information:
C:\Users\user\Desktop\OpenTTD\openttd.exe handle: 0000000000400000 size: 39075315 crc: 4052E7D2 date: 2017-09-05 17:17:57
C:\Windows\SYSTEM32\ntdll.dll handle: 0000000077740000 size: 1739160 crc: CE0F1695 date: 2011-11-17 07:14:10
C:\Windows\system32\kernel32.dll handle: 0000000077620000 size: 1161216 crc: 1D73718F date: 2013-01-04 05:30:34
C:\Windows\system32\KERNELBASE.dll handle: 000007fefdda0000 size: 424960 crc: 5D8671C0 date: 2013-01-04 05:30:34
C:\Windows\system32\ADVAPI32.dll handle: 000007fefe3f0000 size: 877056 crc: FA615A20 date: 2009-07-14 01:40:01
C:\Windows\system32\msvcrt.dll handle: 000007fefe4d0000 size: 634368 crc: 20CD7C2F date: 2011-12-16 08:42:13
C:\Windows\SYSTEM32\sechost.dll handle: 000007fefe730000 size: 113664 crc: 978CFAE5 date: 2009-07-14 01:41:53
C:\Windows\system32\RPCRT4.dll handle: 000007fefe2c0000 size: 1221632 crc: D5B6358C date: 2009-07-14 01:41:53
C:\Windows\system32\GDI32.dll handle: 000007fefe750000 size: 404480 crc: 0F1BAE69 date: 2009-07-14 01:40:56
C:\Windows\system32\USER32.dll handle: 0000000077060000 size: 1008640 crc: 95FA0345 date: 2009-07-14 01:41:56
C:\Windows\system32\LPK.dll handle: 000007fefe950000 size: 41984 crc: 350AF03B date: 2009-07-14 01:41:19
C:\Windows\system32\USP10.dll handle: 000007fefe570000 size: 801280 crc: 1585445D date: 2012-11-22 10:32:45
C:\Windows\system32\IMM32.dll handle: 000007fefe920000 size: 167424 crc: 41B2805A date: 2009-07-14 01:41:09
C:\Windows\system32\MSCTF.dll handle: 000007fefe7c0000 size: 1067008 crc: 798DDDA0 date: 2009-07-14 01:41:28
C:\Windows\system32\SHELL32.dll handle: 000007fefecc0000 size: 14165504 crc: 753CCABB date: 2012-06-09 05:30:56
C:\Windows\system32\SHLWAPI.dll handle: 000007fefe960000 size: 449536 crc: 0BFDF102 date: 2009-07-14 01:41:54
C:\Windows\system32\WINMM.dll handle: 000007fefbc50000 size: 217600 crc: 7BC1529F date: 2009-07-14 01:41:56
C:\Windows\system32\WS2_32.dll handle: 000007fefe6e0000 size: 296448 crc: B9553AFD date: 2009-07-14 01:41:58
C:\Windows\system32\NSI.dll handle: 000007fefe9e0000 size: 13824 crc: 53B46F6C date: 2009-07-14 01:41:53
C:\Windows\system32\ole32.dll handle: 000007fefea90000 size: 2085376 crc: 4764DDC2 date: 2010-06-29 05:39:12
C:\Windows\system32\uxtheme.dll handle: 000007fefc2e0000 size: 332288 crc: B0A13DF9 date: 2009-07-14 01:41:56
C:\Windows\system32\dwmapi.dll handle: 000007fefbf00000 size: 82432 crc: A459F360 date: 2009-07-14 01:40:34
C:\Windows\system32\CRYPTBASE.dll handle: 000007fefdae0000 size: 44032 crc: F547C16E date: 2009-07-14 01:40:24
C:\Windows\system32\CLBCatQ.DLL handle: 000007fefe640000 size: 607744 crc: 939E35C9 date: 2009-07-14 01:40:15
C:\Windows\system32\OLEAUT32.dll handle: 000007fefdf80000 size: 861184 crc: 2C569B03 date: 2011-08-27 05:40:28
C:\Windows\system32\mswsock.dll handle: 000007fefd420000 size: 320000 crc: EA387916 date: 2009-07-14 01:41:34
C:\Windows\System32\wshtcpip.dll handle: 000007fefcda0000 size: 13312 crc: 5D1E2C55 date: 2009-07-14 01:41:58
C:\Windows\system32\psapi.dll handle: 0000000077900000 size: 9216 crc: 84B5E9BA date: 2009-07-14 01:41:53

---- gamelog start ----
---- gamelog end ----

Command Log:
Showing most recent 0 of 0 commands

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE 0x000007FEFDDAAC3D RaiseException + 61
[01] msvcrt 0x000007FEFE511B15 raise + 565
[02] msvcrt 0x000007FEFE51559A abort + 46
[03] openttd 0x0000000000534DEF error(char const*, ...) + 95 (/home/jgr/openttd/cross-win64/src/openttd.cpp:130)
[04] openttd 0x0000000000692E5B ScrollMainViewport (/home/jgr/openttd/cross-win64/src/window.cpp:2802)
[05] openttd 0x0000000000538CF9 GameLoop() + 361 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1623)
[06] openttd 0x000000000066DB19 VideoDriver_Win32::MainLoop() + 457 (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:1277)
[07] openttd 0x0000000000459450 HandleBootstrap() + 496 (/home/jgr/openttd/cross-win64/src/bootstrap_gui.cpp:249)
[08] openttd 0x00000000005364C8 openttd_main(int, char**) + 4728 (/home/jgr/openttd/cross-win64/src/openttd.cpp:851)
[09] openttd 0x0000000000545A2F WinMain + 239 (/home/jgr/openttd/cross-win64/src/os/windows/win32.cpp:469)
[10] openttd 0x00000000004013ED __tmainCRTStartup + 573 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:332)
[11] openttd 0x00000000004014FB WinMainCRTStartup + 27 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:184)
[12] kernel32 0x000000007763F34D BaseThreadInitThunk + 13
[13] ntdll 0x0000000077772CA1 RtlUserThreadStart + 33

*** End of additional info ***

I'm looking forward to your help. Thanks in advance!

[Mardok]

Hi,

I'm also using the patch. It works fine. No crashes for now.
Excellent work. Have only question.
Earlier I was using Terminus Patch, is it possible to add airports from Terminus patch.

[Leanden]

"In game date: 0-01-01 (0, 0)"

Are you starting the game in year 0?

Im not sure how well it would cope with that.