JGR's Patch Pack

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

nihues
Engineer
Engineer
Posts: 85
Joined: 13 Jan 2015 10:26

Re: JGR's Patch Pack

Post by nihues »

Botond P wrote:Hi, is there any way I can get this wonderful patch pack working on linux without compiling? (for example a .deb would be great, I'm running Ubuntu 16.04)
Better compiling yourself...

Get the softwares to compile:

Code: Select all

sudo apt-get update
sudo apt-get install build-essential pkg-config libsdl1.2-dev subversion patch zlib1g-dev liblzo2-dev liblzma-dev libfontconfig-dev libicu-dev
Then get the GIT repository, you can use git software, it will download only modified files, or the clone button from here https://github.com/JGRennison/OpenTTD-p ... tree/jgrpp

unzip, then on the directory extracted execute on terminal:

Code: Select all

./configure
make bundle -j4
it will create a bundle directory with the base game, just open openttd from there, the game should open.

Usually I copy the LANG directory and the openttd file to my working game directory (with all the saves and grfs), without the new lang folder, the game crashes...

Here the latest greatest version :)
https://www.dropbox.com/s/mciqtf0h52y99 ... 1.zip?dl=0

OR install wine and get the windows version compiled from OP.
User avatar
Botond P
Engineer
Engineer
Posts: 13
Joined: 05 Jun 2016 17:38
Location: HU

Re: JGR's Patch Pack

Post by Botond P »

Thanks a lot! I'll try.
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

Seems that cargo waiting conditional jump works opposite as described: if 'is not' is defined, it will jump if there is any cargo at the next station, but would not, if there is no cargo waiting.
BTW, it would by much more convenient, if default descriptor is 'is not', because commonly you need to skip station without cargo.
Therefore, it is easy to fix, just switch strings in pull-down menu and both problems are solved.

Another issue: specific cargo loading/unloading is not displaying choosen cargo (still plain buttons, not 'pressed').
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
mrjack2
Engineer
Engineer
Posts: 74
Joined: 21 Jan 2016 23:04

Re: JGR's Patch Pack

Post by mrjack2 »

New Game.sav
(306.41 KiB) Downloaded 71 times
Trying to load my saved game, the game crashes. This is after I bought out some companies I was switching between using Crtl-C -- the autosaves from before I did this open fine.

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Fri Jan 20 01:33:29 2017
In game date: 1843-08-31 (60, 4)

Crash reason:
 Exception: E1212012
 Location:  00007FF98CD07788
 Message:   Assertion failed at line 113 of /home/jgr/openttd/cross-win64/src/core/pool_type.hpp: index < this->first_unused
	index: 2, first_unused: 1, name: Company

OpenTTD version:
 Version:    jgrpp-0.16.1 (0)
 NewGRF ver: 17006c47
 Bits:       64
 Endian:     little
 Dedicated:  no
 Build date: Jan  5 2017 22:58:48
 Configure:  ./configure --host=x86_64-w64-mingw32 --prefix=/home/jgr/mingw64/ CFLAGS=-I/home/jgr/mingw64/include LDFLAGS=-L/home/jgr/mingw64/lib --without-sdl --without-icu --with-lzo2=/home/jgr/mingw64/lib/liblzo2.a

Stack trace:
 00000000 00000000 00000016 00000000 00000000 00000000 00000001 00000000
 E1212012 00000000 00000000 00000000 8CD07788 00007FF9 00000000 00007FF9
 F457D800 00000049 7A743590 00007FF9 00012010 00000000 00AC061A 00000000
 00000000 00000000 FFFFFFFF 00007FF9 02ADC5B9 00000000 8DFC3A65 00007FF9
 00000001 00000000 00000000 00000000 00000000 00000000 8FC86457 00007FF9
 02ADC2B0 00000000 8CD45973 00007FF9 0000000C 00000000 00000000 00000000
 7B3CC93B 0000811B 6E58700A 0000DBBA 00000016 00000000 8DFBAD70 00007FF9
 00000001 00000000 127D15F6 00007FF9 00B4C630 00000000 02ADD13F 00000000
 BBB19800 00000048 8FC77187 00007FF9 00000003 00000000 02ADD13F 00000000
 270DFD60 00000000 270E5260 00000000 270E5260 00000000 00000001 00000000
 00B4C630 00000000 8DFBF19E 00007FF9 00000001 00000000 127D15F6 00000000
 02ADC940 00000000 02ADD13F 00000000 02ADC3A8 00000000 00000030 00000003
 8D112424 00007FF9 00000000 00000000 00000001 00000000 FFFFE468 00000021
 00000000 00000000 030208A0 00000000 00000082 00000000 50000050 00000000
 00000023 00000000 8FCB5E80 00007FF9 8FCB5FE0 00007FF9 00000023 00000000
 00AC061A 00000000 00000001 00000000 00000000 00000000 00100000 00000000
 001406F4 00000000 00000001 00000000 00140690 00000000 8FC4CFB6 00007FF9
 00100000 00000000 00010003 00000000 00000000 00000000 00140680 00000000
 00140690 00000000 8D526CA0 00007FF9 001406F4 00000000 8D4A0000 00007FF9
 00000012 00000000 8D4CE223 00007FF9 00AC061A 00000000 00000001 00000000
 00000000 00000000 8D4A78AD 00007FF9 8D526CA0 00007FF9 02ADC7E0 00000000
 0000015B 00000000 02ADC5A9 00000000 00140690 00000000 00000000 00000000
 0000009A 00000000 8D52AE97 00007FF9 00010003 00000000 00000000 00000000
 00140690 00000000 0000009A 00000000 02ADC7E0 00000000 00000000 00000000

Registers:
 RAX: 0000000000000025 RBX: 0000000000000016 RCX: 0000000000000000 RDX: 000000000010030C
 RSI: 0000000000000000 RDI: 0000000000000001 RBP: 000000000000FFFE RSP: 0000000002ADC200
 R8:  0000000000000000 R9:  FFFFFFAB00000001 R10: 0000004EFFFFE495 R11: 0000000000000000
 R12: 0000000000000910 R13: 0000000000000000 R14: 00007FF98E0248E0 R15: 000000000053F990
 RIP: 00007FF98CD07788 EFLAGS: 00000206

 Bytes at instruction pointer:
 48 8B 8C 24 C0 00 00 00 48 33 CC E8 98 1A 06 00 48 81 C4 D8 00 00 00 C3

Operating system:
 Name:     Windows
 Release:  6.2.9200 ()
 Compiler: GCC 5.3.1 "5.3.1 20160211"

Configuration:
 Blitter:      32bpp-sse2-anim
 Graphics set: OpenGFX (5580)
 Language:     C:\Program Files\openttd-custom-jgrpp-0.16.1-MINGW-win64\lang\english_AU.lng
 Music driver: win32
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: win32
 Sound set:    OpenSFX (87)
 Video driver: win32

Fonts:
 Small:  sprite
 Medium: sprite
 Large:  sprite
 Mono:   sprite

AI Configuration (local: 0) (current: 2):
  0: Human
 GS: Villages Is Villages (v9)

Libraries:
 FreeType:   2.6.0
 LZMA:       5.2.1
 LZO:        2.09
 PNG:        1.5.23
 Zlib:       1.2.8

Module information:
 C:\Program Files\openttd-custom-jgrpp-0.16.1-MINGW-win64\openttd.exe handle: 0000000000400000 size: 37772395 crc: 830614C3 date: 2017-01-20 01:33:03
 C:\WINDOWS\SYSTEM32\ntdll.dll handle: 00007ff98fc10000 size: 1886344 crc: 32D0F0CC date: 2016-11-11 10:13:03
 C:\WINDOWS\System32\KERNEL32.DLL handle: 00007ff98f7b0000 size: 699880 crc: BDA99C07 date: 2016-07-16 11:42:16
 C:\Program Files (x86)\AVG\Av\avghooka.dll handle: 00007ff97a740000 size: 351768 crc: 7F122770 date: 2017-01-09 01:04:50
 C:\WINDOWS\System32\KERNELBASE.dll handle: 00007ff98ccf0000 size: 2213760 crc: B80E8694 date: 2016-11-11 10:13:54
 C:\WINDOWS\system32\apphelp.dll handle: 00007ff98a620000 size: 481280 crc: 19914941 date: 2016-07-16 11:42:16
 C:\WINDOWS\System32\ADVAPI32.dll handle: 00007ff98f930000 size: 652352 crc: 4CF4BA4F date: 2016-07-16 11:42:21
 C:\WINDOWS\System32\msvcrt.dll handle: 00007ff98df90000 size: 634824 crc: 1B98629E date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\sechost.dll handle: 00007ff98f9e0000 size: 357984 crc: 923D1945 date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\RPCRT4.dll handle: 00007ff98fae0000 size: 1176664 crc: D96EF587 date: 2016-09-22 18:57:37
 C:\WINDOWS\System32\GDI32.dll handle: 00007ff98f8f0000 size: 206096 crc: E055C431 date: 2016-09-15 17:16:45
 C:\WINDOWS\System32\gdi32full.dll handle: 00007ff98c100000 size: 1572768 crc: 696AF957 date: 2016-12-09 10:10:40
 C:\WINDOWS\System32\USER32.dll handle: 00007ff98d4a0000 size: 1461200 crc: AF0289A1 date: 2016-12-09 10:10:58
 C:\WINDOWS\System32\win32u.dll handle: 00007ff98d110000 size: 114192 crc: CE8A4673 date: 2016-09-22 18:57:14
 C:\WINDOWS\System32\IMM32.dll handle: 00007ff98f860000 size: 175672 crc: EE969F35 date: 2016-07-16 11:42:23
 C:\WINDOWS\System32\SHELL32.dll handle: 00007ff98e2a0000 size: 22224480 crc: 92967A74 date: 2016-12-21 07:42:45
 C:\WINDOWS\System32\cfgmgr32.dll handle: 00007ff98cf10000 size: 259848 crc: 53FDC18A date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\windows.storage.dll handle: 00007ff98c460000 size: 7219672 crc: 1FF4C0EE date: 2016-11-11 10:01:16
 C:\WINDOWS\System32\combase.dll handle: 00007ff98d1d0000 size: 2913144 crc: 04C21DC6 date: 2016-12-09 10:18:21
 C:\WINDOWS\System32\ucrtbase.dll handle: 00007ff98cbf0000 size: 998920 crc: 1F92A209 date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\bcryptPrimitives.dll handle: 00007ff98d130000 size: 431296 crc: 1EDD065B date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\powrprof.dll handle: 00007ff98c090000 size: 301680 crc: EF88CF02 date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\shlwapi.dll handle: 00007ff98dce0000 size: 333640 crc: 1B9E909B date: 2016-07-16 11:42:42
 C:\WINDOWS\System32\kernel.appcore.dll handle: 00007ff98c070000 size: 48608 crc: A62D0607 date: 2016-07-16 11:42:06
 C:\WINDOWS\System32\shcore.dll handle: 00007ff98cb40000 size: 681312 crc: 257B507D date: 2016-07-16 11:42:11
 C:\WINDOWS\System32\profapi.dll handle: 00007ff98c0e0000 size: 69264 crc: 2C09169E date: 2016-07-16 11:42:27
 C:\WINDOWS\System32\WS2_32.dll handle: 00007ff98df10000 size: 424640 crc: 9F18231B date: 2016-09-15 17:29:45
 C:\WINDOWS\SYSTEM32\WINMM.dll handle: 00007ff989ca0000 size: 124552 crc: A0E15932 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\WINMMBASE.dll handle: 00007ff989a50000 size: 164264 crc: AB86A028 date: 2016-07-16 11:42:22
 C:\WINDOWS\system32\uxtheme.dll handle: 00007ff98a860000 size: 587264 crc: 04A28A4B date: 2016-07-16 11:42:40
 C:\WINDOWS\System32\MSCTF.dll handle: 00007ff98ddb0000 size: 1418312 crc: 95BA362A date: 2016-11-11 09:54:14
 C:\WINDOWS\System32\OLEAUT32.dll handle: 00007ff98e1e0000 size: 773720 crc: 627FBC3E date: 2016-11-02 11:13:43
 C:\WINDOWS\System32\msvcp_win.dll handle: 00007ff98d070000 size: 633216 crc: D4E5ABC2 date: 2016-07-16 11:42:27
 C:\WINDOWS\system32\dwmapi.dll handle: 00007ff988a70000 size: 128864 crc: B64DB65F date: 2016-09-15 17:07:28
 C:\WINDOWS\system32\mswsock.dll handle: 00007ff98b940000 size: 357216 crc: 137D8928 date: 2016-07-16 11:42:27
 C:\WINDOWS\SYSTEM32\MMDevAPI.DLL handle: 00007ff988260000 size: 443744 crc: D67CB824 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\DEVOBJ.dll handle: 00007ff98ac00000 size: 151904 crc: 96DE9A73 date: 2016-07-16 11:42:27
 C:\WINDOWS\SYSTEM32\PROPSYS.dll handle: 00007ff988310000 size: 1599608 crc: 3FCD1704 date: 2016-07-16 11:42:06
 C:\WINDOWS\SYSTEM32\wdmaud.drv handle: 00007ff96ed10000 size: 233472 crc: 6000BF55 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\ksuser.dll handle: 00007ff989f50000 size: 23816 crc: F880EE68 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\AVRT.dll handle: 00007ff988c20000 size: 32592 crc: 8416D0D7 date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\AUDIOSES.DLL handle: 00007ff976480000 size: 590960 crc: 0C3D6D58 date: 2016-12-14 05:41:32
 C:\WINDOWS\SYSTEM32\wintypes.dll handle: 00007ff9894c0000 size: 1267512 crc: C9CD261A date: 2016-12-09 10:18:15
 C:\WINDOWS\SYSTEM32\msacm32.drv handle: 00007ff988940000 size: 29184 crc: 021361A5 date: 2016-07-16 11:42:21
 C:\WINDOWS\SYSTEM32\MSACM32.dll handle: 00007ff987420000 size: 105392 crc: B73361AF date: 2016-07-16 11:42:22
 C:\WINDOWS\SYSTEM32\midimap.dll handle: 00007ff987410000 size: 25088 crc: BBB5876C date: 2016-07-16 11:42:21
 C:\WINDOWS\System32\clbcatq.dll handle: 00007ff98fa40000 size: 631176 crc: 17C82B8C date: 2016-07-16 11:42:17
 C:\Program Files\Acer\Acer Power Management\SysHook.dll handle: 00007ff95e440000 size: 2220584 crc: 1707A8A1 date: 2013-07-05 05:19:14
 C:\WINDOWS\System32\COMDLG32.dll handle: 00007ff98db80000 size: 991232 crc: F8F731E5 date: 2016-11-11 09:07:35
 C:\WINDOWS\System32\ole32.dll handle: 00007ff98d610000 size: 1274712 crc: E26EFDAD date: 2016-12-09 10:14:50
 C:\WINDOWS\SYSTEM32\MSIMG32.dll handle: 00007ff989f00000 size: 8192 crc: 65C0D294 date: 2016-07-16 11:42:23
 C:\WINDOWS\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_5.82.14393.447_none_0d5aa7fbb6d35646\COMCTL32.dll handle: 00007ff96c160000 size: 684384 crc: 901C7918 date: 2016-11-02 10:59:52
 C:\WINDOWS\SYSTEM32\WINSPOOL.DRV handle: 00007ff987b10000 size: 525312 crc: 93452E76 date: 2016-07-16 11:42:39
 C:\WINDOWS\WinSxS\amd64_microsoft.windows.gdiplus_6595b64144ccf1df_1.1.14393.321_none_72fe05dd211a5fae\gdiplus.dll handle: 00007ff97bcd0000 size: 1656832 crc: 377EC0C5 date: 2016-10-05 09:18:08
 C:\WINDOWS\SYSTEM32\OLEACC.dll handle: 00007ff97a020000 size: 391168 crc: 093500FF date: 2016-07-16 11:42:43
 C:\WINDOWS\SYSTEM32\bcrypt.dll handle: 00007ff98bfb0000 size: 168424 crc: 191C0E0B date: 2016-12-09 10:19:21
 C:\WINDOWS\System32\psapi.dll handle: 00007ff98e030000 size: 18656 crc: 3E63416E date: 2016-07-16 11:42:15

---- gamelog start ----
Tick 0: new game started
Revision text changed to jgrpp-0.15.1, savegame version 195, not modified, _openttd_newgrf_version = 0x17006c0d
New game mode: 1 landscape: 2
Added NewGRF: GRF ID F1250006, checksum 05978AF75D1A1ACC8D8FBEE2BC5061C9, filename: firs_2-2.1.5\firs.grf (md5sum matches)
Added NewGRF: GRF ID 544D0101, checksum 390EA6B640721D3A80200F2A1474B183, filename: 2cc_trainsinnml-2.0alpha1\2ccts.grf (md5sum matches)
Added NewGRF: GRF ID 444A5401, checksum B9E9E16F258B32DC91E8BABEF037AFA7, filename: nutracks-r247\nutracks.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0010, checksum 2A0082F909643FFB6624BD510EBDDA4D, filename: 2cc_trams-0.1.0beta2\trams-2cc.grf (md5sum matches)
Added NewGRF: GRF ID 444E0700, checksum 48B3F9E4FD0DF2A72B5F44D3C8A2F4A0, filename: universal_rail_type-2.0.1\universalrailtype.grf (md5sum matches)
Added NewGRF: GRF ID 414E0201, checksum 536506BDDDBD8644815FC2E7E6A80D7A, filename: fish_2-2.0.2\fish.grf (md5sum matches)
Added NewGRF: GRF ID 454E0101, checksum C1EEEABF84A08839E2AF8607029FC762, filename: modern_maglev_trains-1.1\mmt.grf (md5sum matches)
Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21\pb_av8w.grf (md5sum matches)
Added NewGRF: GRF ID 444A5901, checksum 23CEC795D97265752C21EA8F02564A61, filename: vacuum_tube_train-0.22\vactrain.grf (md5sum matches)
Added NewGRF: GRF ID 56430001, checksum 2AD089EE6B73F25D79F286AD43765914, filename: total_town_replacement_set-3.14\ttrs3w.grf (md5sum matches)
Added NewGRF: GRF ID 41533031, checksum B21E7D6ADD69B1C07643939764FB4878, filename: swedish_houses-1.1.2\swehouses.grf (md5sum matches)
Added NewGRF: GRF ID 72777473, checksum EBEAB33B398DE7F2921F853C496F6F91, filename: uk_town_set-2.2\ukts_2.2.grf (md5sum matches)
Added NewGRF: GRF ID 4D470B02, checksum D3B86F8678699114EC3BC5EBFD52BC51, filename: early_houses.2.0beta_r707\earlyhouses.grf (md5sum matches)
Added NewGRF: GRF ID 4E4C4853, checksum 1787E1E0E308EB5C4E1A8EFC4A059D71, filename: dutch_terraced_houses-0.3b\nlhs.grf (md5sum matches)
Added NewGRF: GRF ID 74677462, checksum 1D2A4E03D9F30922788C166254C27619, filename: total_bridge_renewal_set-1.2\total_bridges.grf (md5sum matches)
Added NewGRF: GRF ID 52571203, checksum 7CE88A25DDB058C1BE577B88D049B274, filename: egrvts2-188\egrvts2.grf (md5sum matches)
Added NewGRF: GRF ID 4D420100, checksum 1A5D28D0719FCDB928F59AEFDBE07B7C, filename: bobs_british_buses-0.2.1\bbbw.grf (md5sum matches)
Added NewGRF: GRF ID 41501202, checksum B13DD8FB0D7C34CACAC2FE68BD137BB9, filename: heqs_heavy_equipment_set-1.5.2\heqs.grf (md5sum matches)
Added NewGRF: GRF ID 58534453, checksum 2E100BCA91DB8371CD9D57DBEC3AB0C8, filename: dutch_stations_set-1.0.0alpha\dutchstatw.grf (md5sum matches)
Added NewGRF: GRF ID 52455200, checksum 0E5A9C5ACD2BCAF7FA0658C3F905A660, filename: rural_stations-1\ae_ruraw.grf (md5sum matches)
Added NewGRF: GRF ID 4A4D0101, checksum AFE4E75999A3FF92D4B01DBEE9A803E9, filename: sailing_ships-0.62\ss.grf (md5sum matches)
Added NewGRF: GRF ID FBFB0301, checksum D961A46B2CC37A04CD4FCBEDD2311A53, filename: foobars_tram_tracks-1.0.1\foobarstramtracks.grf (md5sum matches)
Tick 11858: game loaded
Revision text changed to jgrpp-0.16.1, savegame version 195, not modified, _openttd_newgrf_version = 0x17006c47
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x00007FF98CD07788 RaiseException + 104
[01] msvcrt               0x00007FF98DFBAD70 raise + 512
[02] msvcrt               0x00007FF98DFBF19E abort + 46
[03] openttd              0x00000000005305C1 assert_msg_error(int, char const*, char const*, char const*, ...) + 113 (/home/jgr/openttd/cross-win64/src/openttd.cpp:149)
[04] openttd              0x00000000004B6FD4 Pool<Engine, unsigned short, 64ull, 64000ull, (PoolType)1, false, true>::Get(unsigned long long) + 18446744073705404596 (/home/jgr/openttd/cross-win64/src/core/pool_type.hpp:113)
[05] openttd              0x00000000004B8258 UpdateTrainGroupID(Train*) + 168 (/home/jgr/openttd/cross-win64/src/group_cmd.cpp:741)
[06] openttd              0x000000000063396F NormaliseTrainHead (/home/jgr/openttd/cross-win64/src/train_cmd.cpp:1221)
[07] openttd              0x0000000000633FBC CmdMoveRailVehicle(unsigned int, DoCommandFlag, unsigned int, unsigned int, char const*) + 1516 (/home/jgr/openttd/cross-win64/src/train_cmd.cpp:1415)
[08] openttd              0x0000000000658045 VirtualTrainFromTemplateVehicle(TemplateVehicle*, unsigned short&) + 165 (/home/jgr/openttd/cross-win64/src/vehicle_cmd.cpp:1003)
[09] openttd              0x000000000059A495 AfterLoadTemplateVehiclesUpdateImage() + 229 (/home/jgr/openttd/cross-win64/src/saveload/tbtr_template_veh_sl.cpp:114)
[10] openttd              0x000000000057C5C6 AfterLoadGame() + 32614 (/home/jgr/openttd/cross-win64/src/saveload/afterload.cpp:3330)
[11] openttd              0x000000000058DD3D DoLoad (/home/jgr/openttd/cross-win64/src/saveload/saveload.cpp:2850)
[12] openttd              0x0000000000592713 SaveOrLoad(char const*, SaveLoadOperation, DetailedFileType, Subdirectory, bool) + 307 (/home/jgr/openttd/cross-win64/src/saveload/saveload.cpp:2961)
[13] openttd              0x00000000005326AF SafeLoad(char const*, SaveLoadOperation, DetailedFileType, GameMode, Subdirectory, LoadFilter*) + 223 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1089)
[14] openttd              0x000000000053285C SwitchToMode(SwitchMode) + 316 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1178)
[15] openttd              0x000000000053424E GameLoop() + 78 (/home/jgr/openttd/cross-win64/src/openttd.cpp:1633)
[16] openttd              0x000000000065F699 VideoDriver_Win32::MainLoop() + 457 (/home/jgr/openttd/cross-win64/src/video/win32_v.cpp:1277)
[17] openttd              0x0000000000531F05 openttd_main(int, char**) + 5461 (/home/jgr/openttd/cross-win64/src/openttd.cpp:918)
[18] openttd              0x0000000000540E4F WinMain + 239 (/home/jgr/openttd/cross-win64/src/os/windows/win32.cpp:466)
[19] openttd              0x00000000004013ED __tmainCRTStartup + 573 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:332)
[20] openttd              0x00000000004014FB WinMainCRTStartup + 27 (/build/mingw-w64-_1w3Xm/mingw-w64-4.0.4/mingw-w64-crt/crt/crtexe.c:184)
[21] KERNEL32             0x00007FF98F7B8364 BaseThreadInitThunk + 20
[22] ntdll                0x00007FF98FC770D1 RtlUserThreadStart + 33

*** End of additional info ***
Tsylatac
Engineer
Engineer
Posts: 50
Joined: 26 Dec 2015 01:04

Re: JGR's Patch Pack

Post by Tsylatac »

Discovered a bug with auto-separation and/or auto-timetabling. If these have already created a timetable for a vehicle, then you turn them off, it will immediately show the timetable cleared but the vehicle will continue waiting (have to manually skip to the next order).

Happens to me basically every time I set up a new freight line, as I have these settings on by default for this game and forget to turn them off, then wonder why my ships are still sitting there trying to load past 100% :lol:
mrjack2
Engineer
Engineer
Posts: 74
Joined: 21 Jan 2016 23:04

Re: JGR's Patch Pack

Post by mrjack2 »

Further comment: cargodist seems excessively sluggish since downloading 16.1. (Could be 16.0 the issue as I just went from 15.1 to 16.1)

With a single passenger/mail line and connecting bus services, it took until August of the first year for it to start assigning destinations for passengers (having done mail straight from the start), and in Feb of year 2 there is still a lot of cargo being produced without destinations. This is with day length factor lengthening the years too.

By comparison it works fine on 15.1, with both passengers and mail being distributed after about a month.

Is there an error somewhere in your 16.0 changes to cargodist?
Attachments
autosave7.sav
(196.46 KiB) Downloaded 69 times
Lollipop
Engineer
Engineer
Posts: 26
Joined: 01 Feb 2011 10:09

Re: JGR's Patch Pack

Post by Lollipop »

mrjack2 wrote:Further comment: cargodist seems excessively sluggish since downloading 16.1. (Could be 16.0 the issue as I just went from 15.1 to 16.1)
Did you tick the 'Do not scale the link graph days by the day length factor'?. If not, with i.e DL 8 and a 'recalculation of 8 days', the thread runs every (DL) 64 days, which is indeed sluggish. If you ticked that option, do you run any GS scripts? Some kill cargo dist performance.

Cargodist is quite speedy here, I usually get destinations between feb. and apr., depending of the number of stations. Dunno about earlier versions, I can only compare to 16.x
BW89
Engineer
Engineer
Posts: 105
Joined: 10 May 2015 11:42

Re: JGR's Patch Pack

Post by BW89 »

Can you add a Feature, that copied vehicles have automatic shared timetables?
Sorry for my bad english ;)
User avatar
Botond P
Engineer
Engineer
Posts: 13
Joined: 05 Jun 2016 17:38
Location: HU

Re: JGR's Patch Pack

Post by Botond P »

The compiling finished successfully. Now I would like to make a server on which a windows and a linux client can play together. However, after setting everything up, I cannot connect, no matter which computer is running the server. It's saying "version mismatch" - the linux machine is running jrgpp 1.16.1-4 and the windows one 1.16.1. Is there any way I can get the either the linux computer run the older version, or the other run 1.16.1-4? Or is there any other method for solving this compatibility issue?
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

McZapkie wrote:Seems that cargo waiting conditional jump works opposite as described: if 'is not' is defined, it will jump if there is any cargo at the next station, but would not, if there is no cargo waiting.
BTW, it would by much more convenient, if default descriptor is 'is not', because commonly you need to skip station without cargo.
Therefore, it is easy to fix, just switch strings in pull-down menu and both problems are solved.
I've fixed the inverted conditional, this will be in the next release. Re-arranging the strings would be a more complicated change, and would be inconsistent with the other conditionals, so I've left it as it is for now.
McZapkie wrote:Another issue: specific cargo loading/unloading is not displaying choosen cargo (still plain buttons, not 'pressed').
I don't really follow what you mean here?
Can you describe what is wrong and what you think the expected behaviour should be?
mrjack2 wrote:Trying to load my saved game, the game crashes. This is after I bought out some companies I was switching between using Crtl-C -- the autosaves from before I did this open fine.
Thanks for the bug report, I'll take a look at this shortly.
Tsylatac wrote:Discovered a bug with auto-separation and/or auto-timetabling. If these have already created a timetable for a vehicle, then you turn them off, it will immediately show the timetable cleared but the vehicle will continue waiting (have to manually skip to the next order).

Happens to me basically every time I set up a new freight line, as I have these settings on by default for this game and forget to turn them off, then wonder why my ships are still sitting there trying to load past 100% :lol:
Thanks for pointing this out, I'll take a look.
BW89 wrote:Can you add a Feature, that copied vehicles have automatic shared timetables?
Sorry for my bad english ;)
This already exists in trunk OpenTTD. Use the control key when cloning vehicles to also setup shared orders.
Botond P wrote:The compiling finished successfully. Now I would like to make a server on which a windows and a linux client can play together. However, after setting everything up, I cannot connect, no matter which computer is running the server. It's saying "version mismatch" - the linux machine is running jrgpp 1.16.1-4 and the windows one 1.16.1. Is there any way I can get the either the linux computer run the older version, or the other run 1.16.1-4? Or is there any other method for solving this compatibility issue?
Run `git checkout jgrpp-0.16.1` and then recompile `make bundle -j4` to get the 0.16.1 release. It's not necessary to repeat any of the other steps.
Ex TTDPatch Coder
Patch Pack, Github
BW89
Engineer
Engineer
Posts: 105
Joined: 10 May 2015 11:42

Re: JGR's Patch Pack

Post by BW89 »

Thanks for the info ^^
vazoun51
Engineer
Engineer
Posts: 20
Joined: 05 Sep 2015 21:23

Re: JGR's Patch Pack

Post by vazoun51 »

Minor bug in list of road vehicles groups: collapse all button is sometimes greyed out if you have 2. level subgroups.
How to reproduce it:
1. Make group 1A and group 2A
2. Make group 1B, subgroup of group 1A and group 2B, subgroup of group 2A
3. Make group 1C, subgroup of group 1B
4. Click Expand all then Collapse all
5. Expand group 2A, Collapse all button is greyed out.
If you expand all and just collapse group 1A leaving group 1B opened it works correctly though.
Also with deeper hierarchical structures it works fine.

Another minor bug: if you click Collapse all with some subgroups opened the button should grey out.

Two questions:
1. Is it possible to make cities build roads under tram tracks?
2. What about possibility of gifting the roads to city in its local authority area in order to get rid of the maintenance costs (if switched on)? For example these you sometimes have to build under tram tracks if you want to make the city grow.
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

mrjack2 wrote:New Game.savTrying to load my saved game, the game crashes. This is after I bought out some companies I was switching between using Crtl-C -- the autosaves from before I did this open fine.
This and various related issues are fixed and will be in the next release. Thanks for the bug report.
Lollipop wrote:Did you tick the 'Do not scale the link graph days by the day length factor'?. If not, with i.e DL 8 and a 'recalculation of 8 days', the thread runs every (DL) 64 days, which is indeed sluggish. If you ticked that option, do you run any GS scripts? Some kill cargo dist performance.

Cargodist is quite speedy here, I usually get destinations between feb. and apr., depending of the number of stations. Dunno about earlier versions, I can only compare to 16.x
It seems to make more sense to have this setting on than off, so I've changed the default to on.
vazoun51 wrote:Minor bug in list of road vehicles groups: collapse all button is sometimes greyed out if you have 2. level subgroups.
How to reproduce it:
1. Make group 1A and group 2A
2. Make group 1B, subgroup of group 1A and group 2B, subgroup of group 2A
3. Make group 1C, subgroup of group 1B
4. Click Expand all then Collapse all
5. Expand group 2A, Collapse all button is greyed out.
If you expand all and just collapse group 1A leaving group 1B opened it works correctly though.
Also with deeper hierarchical structures it works fine.

Another minor bug: if you click Collapse all with some subgroups opened the button should grey out.
These have been fixed and will be in the next release. Thanks for the bug report.
vazoun51 wrote: Two questions:
1. Is it possible to make cities build roads under tram tracks?
I'm not all that familiar with the town growth code, I can't say that it's something that I've ever looked at.
vazoun51 wrote:2. What about possibility of gifting the roads to city in its local authority area in order to get rid of the maintenance costs (if switched on)? For example these you sometimes have to build under tram tracks if you want to make the city grow.
This sounds a bit exploitable, in that it'd be a way to evade paying maintenance fees for company roads.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
Botond P
Engineer
Engineer
Posts: 13
Joined: 05 Jun 2016 17:38
Location: HU

Re: JGR's Patch Pack

Post by Botond P »

JGR wrote:Run `git checkout jgrpp-0.16.1` and then recompile `make bundle -j4` to get the 0.16.1 release. It's not necessary to repeat any of the other steps.
Thank you very much for your answer!
After downloading and extracting the zip from Github (using the link provided), I entered terminal and executed the command ./configure then make bundle -j4, but I still got some other version, like 1.16.1M.... , which wasn't compatible with the Windows download provided in the first post. I would be grateful if somebody linked a zip with either the Linux version of 1.16.1 or the just the latest patchpack build for Windows. If this is impossible, then please tell me how to compile the zip from Github to run on Windows.
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Botond P wrote:
JGR wrote:Run `git checkout jgrpp-0.16.1` and then recompile `make bundle -j4` to get the 0.16.1 release. It's not necessary to repeat any of the other steps.
Thank you very much for your answer!
After downloading and extracting the zip from Github (using the link provided), I entered terminal and executed the command ./configure then make bundle -j4, but I still got some other version, like 1.16.1M.... , which wasn't compatible with the Windows download provided in the first post. I would be grateful if somebody linked a zip with either the Linux version of 1.16.1 or the just the latest patchpack build for Windows. If this is impossible, then please tell me how to compile the zip from Github to run on Windows.
Source and windows binaries for 0.16.1 are in the first post of this thread. viewtopic.php?p=1154208#p1154208
On Github, releases can be downloaded from the releases section: https://github.com/JGRennison/OpenTTD-patches/releases
Ex TTDPatch Coder
Patch Pack, Github
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

JGR wrote:
McZapkie wrote:Another issue: specific cargo loading/unloading is not displaying choosen cargo (still plain buttons, not 'pressed').
I don't really follow what you mean here?
Can you describe what is wrong and what you think the expected behaviour should be?
Sorry for unclear description, I wasn't sure how it should work (thought that you need to press colour rectangles to activate cargo), anyway:
if certain action is choosen, previous action is still displayed.
For example, I changed 'unload if accepted' to 'transfer' for goods, but still action remain default 'unload if accepted'.
I changed it to 'unload all' and 'transfer' is displayed.
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

McZapkie wrote:Sorry for unclear description, I wasn't sure how it should work (thought that you need to press colour rectangles to activate cargo), anyway:
if certain action is choosen, previous action is still displayed.
For example, I changed 'unload if accepted' to 'transfer' for goods, but still action remain default 'unload if accepted'.
I changed it to 'unload all' and 'transfer' is displayed.
In the orders window, you can select "Load by cargo type" and/or "Unload by cargo type" in the drop down lists, the line for that order will then say something to the effect of "load by cargo type" and/or "unload by cargo type".
You can then select the load or unload type respectively for each cargo in the per cargo type window using the respective drop-down box, the contents of the drop down box for each cargo will display what the load/unload action is for that cargo.
Ex TTDPatch Coder
Patch Pack, Github
Lollipop
Engineer
Engineer
Posts: 26
Joined: 01 Feb 2011 10:09

Re: JGR's Patch Pack

Post by Lollipop »

I'd give my left hand (well, maybe not) for an 'industry cargo generation factor' option, equivalent to the town cargo parameter. I like the laid-back feeling of DL >= 4 games, but I also like busy lines and long trains. Both preferences are mutually exclusive.
User avatar
JGR
Tycoon
Tycoon
Posts: 2558
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: JGR's Patch Pack

Post by JGR »

Lollipop wrote:I'd give my left hand (well, maybe not) for an 'industry cargo generation factor' option, equivalent to the town cargo parameter. I like the laid-back feeling of DL >= 4 games, but I also like busy lines and long trains. Both preferences are mutually exclusive.
The NewGRF system makes this impractical to implement unfortunately.
Ex TTDPatch Coder
Patch Pack, Github
Wahazar
Tycoon
Tycoon
Posts: 1451
Joined: 18 Jan 2014 18:10

Re: JGR's Patch Pack

Post by Wahazar »

JGR wrote:
McZapkie wrote:if certain action is choosen, previous action is still displayed.
In the orders window, you can select "Load by cargo type" and/or "Unload by cargo type" in the drop down lists, the line for that order will then say something to the effect of "load by cargo type" and/or "unload by cargo type".
I found source of the problem: it is working exactly as you have described in singleplayer mode, but when I'm connected to my server, pull down list is not being refreshed, as I had described above.

Another bug: I cannot define template with electric locomotives. Then I press OK, it is vanishing.
If I would edit existing steam/diesel template and put electric locomotive, it is also vanishing.
Formerly known as: McZapkie
Projects: Reproducible Map Generation patch, NewGRFs: Manpower industries, PolTrams, Polroad, 600mm narrow gauge, wired, ECS industry extension, V4 CEE train set, HotHut.
Another favorite games: freeciv longturn, OHOL/2HOL.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 26 guests