[patch] advanced train purchase window

[RBC]

so I tried my best to get this done:

atpw_preview.png (26.16 KiB) Viewed 5129 times

I split the engine list for trains into two parts. I find it very usefull when playing with newgrf-sets that have vast amounts of locomotives and wagons and especially when you have vehicles never expire.
It is turned off by default, activate it under advanced settings - interface.

I am not so deep in coding complex programs yet and open for hints. (also for coding style)
One question came across while coding that patch: should there be a check like

Code: Select all

if(type != VEH_TRAIN)

in the new struct, because for other types it will probably crash?

And as english is not my mother tongue, is the term "traction unit" (and even "locomotive") the correct one? In german I would name them "Lokomotive" and "Triebkopf".

[michael blunck]

is the term "traction unit" (and even "locomotive") the correct one? In german I would name them "Lokomotive" and "Triebkopf".

"Triebkopf" -> "power car"

regards
Michael

[RBC]

updated. Also minor improvement: do not show sort option "maximum speed" for wagons when wagon speed limits are disabled.

[Der_tolle_Emil]

I really like this, should be quite handy depending on what NewGRFs are used - especially when vehicles never expire as the list can get incredibly long.

Regarding the translation: Locomotive should be fine but didn't the original use 'Engine'? At least this still shows up in the 'sort' drop down when selecting Classic (EngineID).

[kamnet]

Provided that this follows strict OpenTTD coding guidelines, you should submit it for review by the devs. This would be a welcomed improvement to the menu.

[Alberth]

Provided that this follows strict OpenTTD coding guidelines, you should submit it for review by the devs. This would be a welcomed improvement to the menu.

Don't bother in its current form.

Extending functionality by duplicating the entire build window code is not a feasible path solution.

Edit2: I am also having some reservations about the usefulness. A long list stays a long list even if you split it in some way. In my personal view, preferably, the length of the lists should near to the number of models that you actually use in the game.

[kamnet]

I'm not really concerned about the long lists, just that separating out locomotives from wagons and having them both available for viewing would help me make better decisions as to which I would like to pair up, and save me some mouse clicks. While there are many players who do only use a few select models at any given time, there are also many players who take advantage of the diversity in many NewGRF sets.

[Eddi]

proper filtering might be of more use for that


but much more important than correct code style is getting a well-designed UI first. i.e. one that adapts to both newcomers' and experienced players' needs without becoming overloaded.

[hajo4]

split the engine list .. usefull when playing with newgrf-sets that have vast amounts of locomotives

Can we have a sort/filter-option for that list,
along with a "preference/favorite"-setting for
each engine (e.g. as a pulldown-menu) ?

So the player could set them to
* obsolete (don't show in filtered list)
* bad/weak/old (show name in red)
* default
* good
* favorite (show in green)

[lcd_47]

I updated this patch to 1.6.1. I cleaned it up a little, added hiding / unhiding, and fixed a surprising number of bugs. The overall design still kind of sucks, mainly because the patch keeps the old purchase menu as an option, rather than replace it completely. However, having to use the default purchase menu with something like 2cc trains sucks a few orders of magnitude more. Enjoy.

[lcd_47]

Update: fix a bug related to height calculation for the details panel.