Spring 2013 Patch Pack - English Help (Updated 02/23/2017)

[billw]

I decided to make my own patch pack (but ended up writing a new patch for trunk instead!). But I really just want to play not code cos I get enough of that during the day, so tomorrow I am going to just tweak the values for this patch pack and build my own and leave it that (at least for the weekend anyway!). I tried to apply the diff for this pack against trunk but this was made against a pretty old build and had many conflicts I am not confident I can quickly resolve.
So once I make my changes I can upload a diff and exe here if anyone is interested.

[TinyMusic]

I decided to make my own patch pack (but ended up writing a new patch for trunk instead!). But I really just want to play not code cos I get enough of that during the day, so tomorrow I am going to just tweak the values for this patch pack and build my own and leave it that (at least for the weekend anyway!). I tried to apply the diff for this pack against trunk but this was made against a pretty old build and had many conflicts I am not confident I can quickly resolve.
So once I make my changes I can upload a diff and exe here if anyone is interested.

So this patch pack is based on this one, right? Will you be able to remove the bugs that have been reported in this thread?

[billw]

I haven't ever experienced a problem with this patch pack other than the ridiculous town cargo requirements. I have implemented my own town requirements code that replaces what comes with this pack. It simplifies a lot, now just two numbers matter: small town size (below which requirements are ignored) and requirements "scale factor". Cargo requirements are entirely based on town population and this scale factor (they get plugged into an equation I devised, which looks like this: https://www.desmos.com/calculator/crwf8wejhk).
At the moment the different cargo type requirements all scale linearly relative to each other with fixed ratios (~1000 for food, ~2000 times for water, as they are in kg and l).

I'll try and upload this tonight, and maybe make a stand alone patch for my cargo requirements as there doesn't seem to be one for the trunk at the moment.

[TinyMusic]

I haven't ever experienced a problem with this patch pack other than the ridiculous town cargo requirements.

Have you tried automated vehicle separation?

I'll try and upload this tonight, and maybe make a stand alone patch for my cargo requirements as there doesn't seem to be one for the trunk at the moment.

I'll be waiting

[billw]

I haven't ever experienced a problem with this patch pack other than the ridiculous town cargo requirements.

Have you tried automated vehicle separation?

Yes I always have that on with timetable automation. Haven't found it works very well though, maybe I will have a look at the algorithm and see if it could be improved. But it has never crashed for me.


Out of interest what would you say are good default requirements numbers for goods, food and water for towns of different sizes? Say 500, 3000 (usual size of large towns at game start) and 10000 (I have never had a town this big...)?

[TinyMusic]

I haven't ever experienced a problem with this patch pack other than the ridiculous town cargo requirements.

Have you tried automated vehicle separation?

Yes I always have that on with timetable automation. Haven't found it works very well though, maybe I will have a look at the algorithm and see if it could be improved. But it has never crashed for me.

For me it doesn't crash, but freezes [/quote]

Out of interest what would you say are good default requirements numbers for goods, food and water for towns of different sizes? Say 500, 3000 (usual size of large towns at game start) and 10000 (I have never had a town this big...)?

Don't know, I play with them disabled

[billw]

Full source code:
https://docs.google.com/file/d/0B5aleGn ... sp=sharing

EXE and new lang files (can extract over latest original Spring 2013 install, make sure you have backup!):
https://docs.google.com/file/d/0B5aleGn ... sp=sharing

Tried to create a patch against clean r25337 but can't diff binary files in svn so just including full source instead.

Absolutely no warranty of any kind, I just made this modification so I could play it myself!

This includes a bump to the save version number, but still loads older saves (I don't really fully understand the save system, but this is what I needed to do to make this work).

If you still get the same crashes or freezes using this build then please post here WITH a save game (and grf list) that I can use to reproduce (i.e. the most recent save game before the crash), and a description of exactly what you did that caused the crash. I will try and fix if I can reproduce the error. As I have mentioned, playing how I do (trains only, automatic timetables and separation enabled, < 10 grfs) I have yet to have a single crash or freeze.

[TinyMusic]

Here's your first bug report:

Description:
I started a new game without any NewGRFs. I went to advanced settings and checked if vehicle separation is turned on. It was on, so then I searched for 'train' (don't know why) is the search bar and then this message below appeared and it crashed.

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Tue Aug 13 03:14:38 2013
In game date: 2011-01-01 (0)

Crash reason:
 Exception: E1212012
 Location:  75E0812F
 Message:   Assertion failed at line 1182 of ..\src\settings_gui.cpp: this->level < sizeof(parent_last)

OpenTTD version:
 Version:    r25337M (2)
 NewGRF ver: 140062f9
 Bits:       32
 Endian:     little
 Dedicated:  no
 Build date: Aug 10 2013 21:00:48

Registers:
 EAX: 0012F2C0 EBX: 00000016 ECX: 00000000 EDX: 77C07094
 ESI: 00F89B34 EDI: 00000000 EBP: 0012F310 ESP: 0012F2C0
 EIP: 75E0812F EFLAGS: 00200246

 Bytes at instruction pointer:
 C9 C2 10 00 89 45 C0 EB ED 3D 01 01 00 00 0F 85 6D 96 FF FF E9 49 96 FF

Stack trace:
 E1212012 00000000 00000000 75E0812F 00000000 00F3DB50 00000010 00000000
 00000000 00000000 00000000 00000000 00000000 0012F180 0012F190 00000001
 77C06054 77C1A23C 00000000 00000016 0012F370 00627423 E1212012 00000000
 00000000 00000000 006DBC95 00000016 6AE5C511 00000000 00000000 00F6BD58
 0012F35C 77B4EAA4 00000000 77C06054 00627413 00000001 0012F330 0012EEC4
 0012FCCC 006E2100 6A021C61 FFFFFFFE 0012F580 006DB135 00000016 00448FB2
 65737341 6F697472 6166206E 64656C69 20746120 656E696C 38313120 666F2032
 5C2E2E20 5C637273 74746573 73676E69 6975675F 7070632E 6874203A 3E2D7369
 6576656C 203C206C 657A6973 7028666F 6E657261 616C5F74 00297473 748F67FF
 02694940 00000000 0269477C 02694758 FFFFFFF7 00000000 00000509 0012F410
 748F6765 02694830 000001CD 00000155 0012F4E0 748F672B 02694830 0012F4D8
 0012F514 000E0498 00000084 00010000 00020001 000000A0 00000020 00000011
 00000004 00000003 00000000 00000000 00000004 00000003 00000000 00000000
 00000008 00000004 00000006 00000000 00000000 00000000 00000000 00000000
 00000001 0000001B 00000000 00000000 0000001C 00000011 0000000D 0000000D
 AA100E10 018508F0 18100F6E 00000000 00000017 0000000F 02670808 0012F514
 0241B3D2 0012F4F4 005CFECF 0241AED4 0590A9EA 00000004 FFFFFD30 00000002
 0012F850 748F657E 00000008 0590A9F0 00000002 0012F560 004294E0 00000000
 00000000 0241AED8 00000000 00F6BD58 020B8CF8 0590A514 00F8CB10 00000000
 00000000 00000008 00000008 00000020 00000020 00000051 0000010B 023C5481
 00000500 00000020 00000020 00000020 00000000 00000000 00000000 00000020
 0012F580 00000000 00000006 00000000 00000000 0012F5C4 004D2E60 0000005C
 0012F5C4 004D2E93 00EBFCAC 0000049E 00F1B344 00F1B428 00000000 00000000
 00F668AC 00000020 00000050 00000045 0000010F 000000C2 0000000F 00000004

Operating system:
 Name:     Windows
 Release:  6.1.7601 (Service Pack 1)
 Compiler: MSVC 1600

Configuration:
 Blitter:      8bpp-optimized
 Graphics set: OpenGFX (1021)
 Language:     D:\Stefan Works\OpenTTD-billw_springpatch\lang\english.lng
 Music driver: dmusic
 Music set:    OpenMSX (96)
 Network:      no
 Sound driver: win32
 Sound set:    NoSound (2)
 Video driver: win32

AI Configuration (local: 0):
  0: Human

Libraries:
 FreeType:   2.4.11
 ICU:        51.2
 LZMA:       5.0.4
 LZO:        2.06
 PNG:        1.5.14
 Zlib:       1.2.7

Module information:
 D:\Stefan Works\OpenTTD-billw_springpatch\openttd.exe handle: 00400000 size: 12134400 crc: 29A35328 date: 2013-08-11 00:59:42
 C:\Windows\SYSTEM32\ntdll.dll handle: 77BC0000 size: 1288472 crc: 3D9C2B3F date: 2011-11-17 05:38:39
 C:\Windows\system32\kernel32.dll handle: 778E0000 size: 868352 crc: 6B2E8FB7 date: 2012-11-30 04:47:44
 C:\Windows\system32\KERNELBASE.dll handle: 75E00000 size: 293376 crc: 7FDF0D0B date: 2012-11-30 04:47:45
 C:\Windows\system32\WINMM.dll handle: 71680000 size: 194048 crc: 849223C7 date: 2010-11-20 12:21:36
 C:\Windows\system32\msvcrt.dll handle: 77830000 size: 690688 crc: DAB48B3A date: 2011-12-16 07:52:58
 C:\Windows\system32\USER32.dll handle: 77AF0000 size: 811520 crc: A7CBE597 date: 2010-11-20 12:21:33
 C:\Windows\system32\GDI32.dll handle: 775E0000 size: 304640 crc: 7034A7D3 date: 2010-11-20 12:19:05
 C:\Windows\system32\LPK.dll handle: 762A0000 size: 26624 crc: 13E68B63 date: 2009-07-14 01:15:36
 C:\Windows\system32\USP10.dll handle: 76550000 size: 626688 crc: 6C809B74 date: 2012-11-22 04:45:03
 C:\Windows\system32\WS2_32.dll handle: 761C0000 size: 206848 crc: FD00A753 date: 2010-11-20 12:21:38
 C:\Windows\system32\RPCRT4.dll handle: 764A0000 size: 653312 crc: 859C9823 date: 2010-11-20 12:21:03
 C:\Windows\system32\NSI.dll handle: 76290000 size: 8704 crc: 2ACE9671 date: 2009-07-14 01:16:11
 C:\Windows\system32\ADVAPI32.dll handle: 760C0000 size: 640512 crc: 34D5363F date: 2010-11-20 12:18:02
 C:\Windows\SYSTEM32\sechost.dll handle: 765F0000 size: 92160 crc: B624B29A date: 2009-07-14 01:16:13
 C:\Windows\system32\SHELL32.dll handle: 76610000 size: 12872704 crc: 88F73E0C date: 2013-02-27 04:55:05
 C:\Windows\system32\SHLWAPI.dll handle: 77260000 size: 350208 crc: 23E05F73 date: 2010-11-20 12:21:19
 C:\Windows\system32\IMM32.DLL handle: 772C0000 size: 118272 crc: B45269DC date: 2010-11-20 12:19:22
 C:\Windows\system32\MSCTF.dll handle: 77370000 size: 828928 crc: DFE09EEB date: 2009-07-14 01:15:43
 C:\Windows\system32\ole32.dll handle: 75F60000 size: 1414144 crc: 74A1E844 date: 2010-11-20 12:20:49
 C:\Windows\system32\uxtheme.dll handle: 748F0000 size: 249856 crc: 1CD7BB78 date: 2009-07-14 01:16:17
 C:\Program Files\Unlocker\UnlockerHook.dll handle: 10000000 size: 4608 crc: ACDA95B3 date: 2010-07-04 21:32:36
 C:\Users\user\AppData\Local\FLVService\lib\FLVSrvLib.dll handle: 00180000 size: 18432 crc: 2A740F35 date: 2013-08-13 00:29:27
 C:\Windows\WinSxS\x86_microsoft.vc90.crt_1fc8b3b9a1e18e3b_9.0.30729.6161_none_50934f2ebcb7eb57\MSVCR90.dll handle: 71E20000 size: 653136 crc: 15571C55 date: 2011-06-16 13:19:13
 C:\Windows\system32\dwmapi.dll handle: 744C0000 size: 67072 crc: FC7CA4B8 date: 2009-07-14 01:15:13
 C:\Windows\system32\CRYPTBASE.dll handle: 75B80000 size: 36864 crc: 00308E17 date: 2009-07-14 01:15:07
 C:\Windows\system32\mswsock.dll handle: 75660000 size: 232448 crc: 47C95B42 date: 2010-11-20 12:19:56
 C:\Windows\System32\wshtcpip.dll handle: 75150000 size: 9216 crc: BA963A19 date: 2009-07-14 01:16:20
 C:\Windows\system32\MMDevAPI.DLL handle: 74A60000 size: 213504 crc: 93C0AA4F date: 2010-11-20 12:19:39
 C:\Windows\system32\PROPSYS.dll handle: 74960000 size: 988160 crc: 888D0BCB date: 2010-11-20 12:20:57
 C:\Windows\system32\OLEAUT32.dll handle: 772E0000 size: 571904 crc: 2B85E126 date: 2011-08-27 04:26:27
 C:\Windows\system32\wdmaud.drv handle: 741F0000 size: 172032 crc: D5B9F5FA date: 2010-11-20 12:16:50
 C:\Windows\system32\ksuser.dll handle: 74280000 size: 4608 crc: EBE07232 date: 2009-07-14 01:15:35
 C:\Windows\system32\AVRT.dll handle: 74950000 size: 14336 crc: 9818237B date: 2009-07-14 01:14:58
 C:\Windows\system32\SETUPAPI.dll handle: 77440000 size: 1667584 crc: 1D0104E8 date: 2010-11-20 12:21:14
 C:\Windows\system32\CFGMGR32.dll handle: 75C90000 size: 145920 crc: 4DDC6E9A date: 2010-11-20 12:18:12
 C:\Windows\system32\DEVOBJ.dll handle: 75DE0000 size: 64512 crc: 2B501D62 date: 2009-07-14 01:15:11
 C:\Windows\system32\AUDIOSES.DLL handle: 6E7B0000 size: 195584 crc: 0A7E52B1 date: 2010-11-20 12:18:05
 C:\Windows\system32\msacm32.drv handle: 74120000 size: 20992 crc: 73923147 date: 2009-07-14 01:14:08
 C:\Windows\system32\MSACM32.dll handle: 740F0000 size: 72192 crc: ABA25814 date: 2009-07-14 01:15:42
 C:\Windows\system32\midimap.dll handle: 740E0000 size: 16896 crc: C000494C date: 2009-07-14 01:15:40
 C:\Windows\system32\CLBCatQ.DLL handle: 76200000 size: 522240 crc: 6C130B8A date: 2009-07-14 01:15:03
 C:\Windows\System32\dmime.dll handle: 5E330000 size: 179712 crc: 179D7CFB date: 2009-07-14 01:15:12
 C:\Windows\System32\DSOUND.dll handle: 6EAD0000 size: 453632 crc: EC24F2F8 date: 2009-07-14 01:15:13
 C:\Windows\System32\POWRPROF.dll handle: 74AA0000 size: 145408 crc: 9957ABF4 date: 2009-07-14 01:16:12
 C:\Windows\System32\dmusic.dll handle: 652A0000 size: 101376 crc: F5D0AA6B date: 2009-07-14 01:15:12
 C:\Windows\system32\WINTRUST.dll handle: 75E70000 size: 172544 crc: 1166A078 date: 2012-08-24 16:57:48
 C:\Windows\system32\CRYPT32.dll handle: 75CC0000 size: 1160192 crc: 9CD44DE4 date: 2013-05-13 04:45:55
 C:\Windows\system32\MSASN1.dll handle: 75C70000 size: 34304 crc: BE7DA129 date: 2010-11-20 12:19:45
 C:\Windows\System32\dmsynth.dll handle: 695A0000 size: 105472 crc: 3B102040 date: 2009-07-14 01:15:12
 C:\Windows\System32\dmloader.dll handle: 69590000 size: 38400 crc: 8A3F45D2 date: 2009-07-14 01:15:12
 C:\Windows\system32\psapi.dll handle: 77D00000 size: 6144 crc: 25B988F9 date: 2009-07-14 01:16:12

---- gamelog start ----
Tick 0: new game started
     Revision text changed to r25337M, savegame version 217, modified, _openttd_newgrf_version = 0x140062f9
     New game mode: 1 landscape: 0
---- gamelog end ----

*** End of OpenTTD Crash Report ***

Decoded stack trace:
[00] KERNELBASE           0x75E0812F RaiseException + 84
[01] openttd              0x00627423
[02] openttd              0x006DB135
[03] openttd              0x004D2E93
 <infinite loop>

*** End of additional info ***

[billw]

Delete the contents of your openttd.cfg. Sorry forgot to mention that!

[kamnet]

Since you have modified the OpenTTD Spring 2013 Patch Pack, you should probably request that a moderator split these posts off into their own separate developer topic so that other readers do not become confused about which pack is being discussed.

[billw]

I consider this a fix not a branch, as the only thing it changes is something fundamentally broken in the original (the town growth requirements stuff). So anybody who wants to play this patch pack should play my modification of it imo, at least until a new version comes out. Unless anyone wants to make a case that the original isn't broken in this regard?

[TinyMusic]

I consider this a fix not a branch, as the only thing it changes is something fundamentally broken in the original (the town growth requirements stuff). So anybody who wants to play this patch pack should play my modification of it imo, at least until a new version comes out.

You can also rename the patch pack as Spring Patch Pack v 1.x.x

[pi1985]

I consider this a fix not a branch, as the only thing it changes is something fundamentally broken in the original (the town growth requirements stuff). So anybody who wants to play this patch pack should play my modification of it imo, at least until a new version comes out. Unless anyone wants to make a case that the original isn't broken in this regard?

Well, I do not see what isn't working. In your screenshot you show only one town window, many industries windows and one station with cargos that town does not accept. If you do not transport cargos to town, it will not grow. But you even did not show station in your town and station's train list. How can anyone say to you why your town does not grow?
In FIRS modified by me you have to deliver:

Unnamed, 1950-01-01.png (19.43 KiB) Viewed 5153 times

And what cargos are delivered in your game?

So, today new FULL version released. Changes:

• Added old buy vehicle window, you can choose it into Advanced settings.
• Towns may grow even few goals are complete but in two times slower if you didn't complete 1 goal and four times if 2 goals incompleted (in case you have three of them). If no goals completed town will not grow. You can enable or disable this in Advanced settings.
• Fixed bug with 32bpp-anim-aa blitter and >8x zoom outs.
• minimap screenshots moved to screenshot/minimap folder.

[billw]

Well, I do not see what isn't working. In your screenshot you show only one town window, many industries windows and one station with cargos that town does not accept. If you do not transport cargos to town, it will not grow. But you even did not show station in your town and station's train list. How can anyone say to you why your town does not grow?

The screen shot was just to demonstrate the size of the freight network I had set up that was all set to feeding goods and food to that ONE TOWN, and still not enough to make it grow. The trains were delivering all goods from the transfer station to the town and the town used them all up before it ever had enough to grow. I don't doubt its *possible* to make the town grow I just think it is WAY too difficult. I can't see how I could ever make more than a handful of towns grow at a time even with an immense freight network.

If this is more useful screenshot showing all my industrial stations setup to feed into that town and my settings:


Maybe you could upload a save showing us how it is done?

New UI looks nice by the way

[pi1985]

Okay, in 1.7.69 you have to deliver at least 31*11060=342860 kg of food and at least 31*47=1457 crates of goods. More will be much better.
In 1.7.80 you may deliver only food or goods to grow, but town will grow slower in 2 times.
And to prevent stop growing town, values of delivered goods and food have to be more than shown.

[d0mi3l]

1. - Great job. Most important patchs in one to windows game version.

2. I have problem with town growth. I deliver foods and goods to city but not nothing happen.
I use Firs from yours dropbox (link).
Version of your patch is 1.7.80.
For example: I deliver 21 tons of foods per month and I need to town growth about 36.500 kg ( 1.1760 kg - daily rate) but nothing change.

Edit.
In firs an one of paramets is economy. I must set to firs economy or heart of darknes?
If I deliver to city foods to town growth, can I build a shop there?

[pi1985]

I deliver 21 tons of foods per month and I need to town growth about 36.500 kg ( 1.1760 kg - daily rate) but nothing change.

Food total must be more than Daily rate and your town will grow. In your example, Food total must be more than 36500 kg (36 t).

[d0mi3l]

Food total must be more than Daily rate and your town will grow. In your example, Food total must be more than 36500 kg (36 t).

Ok. I will try. Thanks.

What about shop in town when I deliver foods/goods?
May I set in transport orders to city: unload or transfer?

[Alberth]

'transfer' means 'unload at station so another vehicle can pick it up (and move it to elsewhere)'.

My guess is you want 'unload'

[pi1985]

Food total must be more than Daily rate and your town will grow. In your example, Food total must be more than 36500 kg (36 t).

Ok. I will try. Thanks.

What about shop in town when I deliver foods/goods?

There is no difference where food or goods will go after unloading. Town will count it anyway, even they go into a Hotel.
And there was my mistake. I wrote:

Food total must be more than Daily rate and your town will grow. In your example, Food total must be more than 36500 kg (36 t).

But you have to read:

Food total must be more than Food total and your town will grow. In your example, Food total must be more than 36500 kg (36 t).