Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Thu May 25, 2017 10:05 pm

All times are UTC




Post new topic  Reply to topic  [ 4 posts ] 
Author Message
 Post subject: Patch reviews
PostPosted: Fri Sep 21, 2012 6:27 pm 
Offline
OpenTTD Developer
OpenTTD Developer
User avatar

Joined: Wed Nov 07, 2007 10:44 pm
Posts: 9010
Location: Sol d
Have you ever asked yourself how we work on our patches and discuss about them?
Do you wonder how we come to the solutions which then are finally submitted to svn?
Do you want to see how we address tasks from our bug tracker?
Or you have a patch prepared, either in our bug tracker or under discussion in this forum's development section and want to see our whole review process and maybe discuss it live?

To these questions and similar we now have an answer, we created a new patch review channel:
#openttd.dev

We decided to make our usual internal code discussions more public there. It may help to understand how we review and view patches and design decisions in general.
Everyone is free to join. In that channel only patch and core developers will be able to talk, though, so that the focus stays on the actual patches under review. We'll grant voice in that channel upon request to people who contribute or have proven to contribute to the actual code bases.
You'll find the logs of the channels here, so that you can also read up on what has been said.

_________________
Image
OpenTTD: manual | online content | translations | Wanted contributions and patches
#openttdcoop: blog | wiki | public server | DevZone | NewGRF web translator
DevZone - home of the free NewGRFs: OpenSFX | OpenMSX | OpenGFX | Swedish Rails | OpenGFX+ Trains|RV|Industries|Airports|Landscape | NML


Top
   
 Post subject: Re: Patch reviews
PostPosted: Sat Sep 22, 2012 12:59 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Thu Jun 25, 2009 4:42 pm
Posts: 2362
Location: Location, Location
so #openttd will now get even more off-topic ;)

either way: /me adds #openttd.dev to autostart list

_________________
AroAI - A really feeble attempt at an AI

It is practically impossible to teach good programming to students that have had a prior exposure to BASIC: as potential programmers they are mentally mutilated beyond hope of regeneration. --Edsger Dijkstra


Top
   
 Post subject: Re: Patch reviews
PostPosted: Mon Sep 24, 2012 7:22 pm 
Offline
Director
Director

Joined: Tue Jul 17, 2007 5:56 pm
Posts: 572
A very nice idea.

One question / suggestion: Is there any way of keeping track of what has been discussed when? Currently, there are four log pages for four days, there will quickly be some hundreds of them, and each of them contains discussions about maybe several topics.

So, assume one doesn´t read them regularly, but comes across some particular change, how can one find out if / where that change was discussed? Ok, commit dates might be a hint, but not necessarily.


Regarding the more heightlevels patch, if it makes sense from your side, I would be open for discussions in that channel, and would probably have some time for it during the next months if necessary. In other words, I have no (functional) todos left regarding it except adjusting it to changes in trunk occasionally, so from my side this is a quite finished project which may be discussed / reviewed --- or not.


Top
   
 Post subject: Re: Patch reviews
PostPosted: Tue Sep 25, 2012 8:58 pm 
Offline
OpenTTD Developer
OpenTTD Developer

Joined: Wed Dec 20, 2006 1:31 pm
Posts: 963
Location: Aschaffenburg
You can search all logs on coop (including #openttd.dev) by adding "site:webster.openttdcoop.org" to your google search term. I don't think it can specifically search for #openttd.dev though.

_________________
⢇⡸⢸⠢⡇⡇⢎⡁⢎⡱⢸⡱⢸⣭⠀⢸⢜⢸⢸⣀⢸⣀⢸⣭⢸⡱⠀⢰⠭⡆⣫⠰⣉⢸⢸⠀⢰⠭⡆⡯⡆⢹⠁⠀⢐⠰⡁


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 4 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 5 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000-2017 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2017.
Hosted by Zernebok Hosting.