Page 58 of 69

Re: New map features

Posted: 09 Jan 2017 19:53
by cirdan
Pyoro wrote:Now that's what I call great costumer service ;) ... thanks.
Well, your report was very precise in how to reproduce the crash, and together with the debugger stack trace there was a very prominent suspect to look at (and you were lucky that I read your post right after you posted it :-)).

Re: New map features

Posted: 25 Jan 2017 18:44
by cirdan
I have just updated the repository. A lot of commits have gone in, but the only user-visible change should be the fix for the crash reported by Pyoro two weeks ago.

Re: New map features

Posted: 25 Jan 2017 19:56
by wallyweb
cirdan wrote:I have just updated the repository.
:bow:

Here is the unguaranteed Win32 binary:
OpenTTD-REBASED-r27601-g5fa058ec-Win32.7z
(5.48 MiB) Downloaded 38 times
JGR's Tracerestrict version:
OpenTTD-g0eb8f9da-tracerestrict-cirdan-Win32.7z
(5.5 MiB) Downloaded 39 times
Enjoy. :D

Re: New map features

Posted: 25 Jan 2017 20:08
by TrueSatan
Here is the Ubuntu 14.04 64 version. And yeah i am still on 14.04.

Tanks for the new version cirdan.

And JGR version is attached as well.

Thanks Cirdan and JGR for the new versions :bow: :bow: :bow:

Btw. I found an odd behaviour but I had no time to make a test savegame so far.

If you use the non-stop setting by default and have some rules to replace the trains
if its to old, it just happens that if the depot is behind a train station not in the normal
schedule of the train, it will be inserted between the jump rule and the depot
rule (or order if you like haha). even worse if there is more then one station
the train is traveling through. I think the non stop should always be obeyed.
Because the train never visits the station again until replaced or repaired
but it generates passerngers/goods for the next visist station of the train.
That leads to bad ratings.

Guess its better if I can provide a savegame for the odd behaviour.
Not that important, only somthing i have noticed every now and then,
because I had grayed orders where they did not belong.
Maybe its a trunk fault as well. Not playing the vanilla game anymore haha
Cheers

Re: New map features

Posted: 25 Jan 2017 20:23
by TrueSatan
Here is the savegame with the conditional jump and my config.
Train only serves the lower two stations and (here it will go to depot everytime
on purpose) will only go to depot if the lifetime is over.
As soon as it moves to the trian depot behind the thrird station the non-stop features
will be ignored and the train stop first at the third station then moves on to the depot
and afterwards run back to the next station this time obeying the non-stop feature.
so something is wrong with conditional orders.

Not that important as I said and maybe a design failure, but something to report :D

Cheers and thanks in advance

Re: New map features

Posted: 25 Jan 2017 22:30
by JGR
wallyweb wrote:JGR's Tracerestrict version will ne posted here when available.
I've pushed an updated version to github.

Re: New map features

Posted: 26 Jan 2017 00:12
by wallyweb
JGR wrote:
wallyweb wrote:JGR's Tracerestrict version
I've pushed an updated version to github.
:bow:
The Windows binary is available here.

Enjoy. :D

Re: New map features

Posted: 27 Jan 2017 16:55
by cirdan
TrueSatan wrote:Here is the savegame with the conditional jump and my config. Train only serves the lower two stations and (here it will go to depot everytime on purpose) will only go to depot if the lifetime is over. As soon as it moves to the trian depot behind the thrird station the non-stop features will be ignored and the train stop first at the third station then moves on to the depot and afterwards run back to the next station this time obeying the non-stop feature. so something is wrong with conditional orders.
Thanks for your report. The problem was not with the conditional order but with the nearest depot service order, which was clobbering the non-stop flag when actually finding the nearest depot. Can you try the attached patch?

Re: New map features

Posted: 27 Jan 2017 22:39
by TrueSatan
cirdan wrote:
TrueSatan wrote:Here is the savegame with the conditional jump and my config. Train only serves the lower two stations and (here it will go to depot everytime on purpose) will only go to depot if the lifetime is over. As soon as it moves to the trian depot behind the thrird station the non-stop features will be ignored and the train stop first at the third station then moves on to the depot and afterwards run back to the next station this time obeying the non-stop feature. so something is wrong with conditional orders.
Thanks for your report. The problem was not with the conditional order but with the nearest depot service order, which was clobbering the non-stop flag when actually finding the nearest depot. Can you try the attached patch?

Thanks i see the patch fixes the problem. I tried as well to send the train to the depot with the depot button
and i'll skipped the orders.
Worked like a charm :) :bow:

Have to apply the patch to JGR's tracerestriction branch, because thats the pack i usually use to play.

Thanks and cheers

Re: New map features

Posted: 28 Jan 2017 09:52
by cirdan
I have pushed the fix to the repository. Thanks!

Re: New map features

Posted: 28 Jan 2017 11:27
by wallyweb
cirdan wrote:I have pushed the fix to the repository. Thanks!
:bow:

Here is the fixed Windows binary:
OpenTTD-REBASED-r27601-g174edb7a-Win32.7z
(5.48 MiB) Downloaded 46 times
and JGR's tracerestrict version:
OpenTTD-g57707379-tracerestrict-cirdan-Win32.7z
(5.5 MiB) Downloaded 41 times
Enjoy. :D

(All guarantees were destroyed by an ice storm in Canada, so there are none.)

Re: New map features

Posted: 30 Jan 2017 18:58
by JGR
wallyweb wrote: :bow:

Here is the fixed Windows binary:
OpenTTD-REBASED-r27601-g174edb7a-Win32.7z
JGR's tracerestrict version will be posted here when available.

Enjoy. :D

(All guarantees were destroyed by an ice storm in Canada, so there are none.)
I've pushed an update which merges this.

Re: New map features

Posted: 30 Jan 2017 20:34
by wallyweb
JGR wrote:
wallyweb wrote: :bow:

Here is the fixed Windows binary:
OpenTTD-REBASED-r27601-g174edb7a-Win32.7z
JGR's tracerestrict version will be posted here when available.

Enjoy. :D

(All guarantees were destroyed by an ice storm in Canada, so there are none.)
I've pushed an update which merges this.
:bow:
The Windows 32 bit binary is here.

Enjoy :D

Re: New map features

Posted: 30 Jan 2017 20:56
by TrueSatan
Thank you both, Cridan and JGR :bow:

Here are the versions for Ubuntu 14.04 64bit

Re: New map features

Posted: 28 Feb 2017 21:08
by TrueSatan
Fresh, hot, new.
No clue what was changed, but JGR has updated his tracerestricted version.
As usual ubuntu and still for the old 14.04 64 bit
Thanks JGR.

And Cirdan, I wonder if you have something like the not road type in your mind as well.
Looks interesting that feature.

Cheers

Re: New map features

Posted: 28 Feb 2017 21:41
by JGR
TrueSatan wrote:Fresh, hot, new.
No clue what was changed, but JGR has updated his tracerestricted version.
As usual ubuntu and still for the old 14.04 64 bit
Thanks JGR.

And Cirdan, I wonder if you have something like the not road type in your mind as well.
Looks interesting that feature.

Cheers
This is mainly minor fixes and additions to the tracerestrict GUI which are cherry-picked from the main tracerestrict branch.

Re: New map features

Posted: 01 Mar 2017 13:25
by wallyweb
JGR wrote:... mainly minor fixes and additions to the tracerestrict GUI...
:bow:

Here is the unguaranteed Windows 32bit binary ...
OpenTTD-g3837e961-tracerestrict-cirdan-Win32.7z
(5.51 MiB) Downloaded 40 times
Enjoy :D

Re: New map features

Posted: 05 Mar 2017 00:33
by SimYouLater
How do I get this as a .diff or .patch file?

Re: New map features

Posted: 05 Mar 2017 00:57
by HackaLittleBit
SimYouLater wrote:How do I get this as a .diff or .patch file?
Normally on the first page the author of a patch gives instructions how to get his work.

Re: New map features

Posted: 05 Mar 2017 01:34
by SimYouLater
HackaLittleBit wrote:
SimYouLater wrote:How do I get this as a .diff or .patch file?
Normally on the first page the author of a patch gives instructions how to get his work.
He provides a pre-compiled windows binary and a link to a site where, if I looked hard enough, had instructions to compile a working copy of OpenTTD with his patch.

I need the .patch/.diff file itself, or I need a .patch/.diff of NotRoadTypes which only provides pre-compiled versions as well. Why do you have to make it so difficult to compile several patches into a custom build for personal use?