Transport Tycoon Forums

The place to talk about Transport Tycoon
It is currently Tue May 23, 2017 6:52 pm

All times are UTC




Post new topic  Reply to topic  [ 1221 posts ]  Go to page Previous 155 56 57 58 5962 Next
Author Message
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 10:31 am 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1650
Location: Ipswich
Hi Cirdan, I've added a branch 'cirdan-blitter-scroll-fix' to https://github.com/JGRennison/OpenTTD-patches which fixes this issue.
It's caused by a signed/unsigned arithmetic issue when calculating the src point when scrolling vertically downwards (scroll_y < 0) in the Blitter_*::Surface::scroll methods.

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 1:00 pm 
Offline
Director
Director
User avatar

Joined: Sat Apr 07, 2007 6:08 pm
Posts: 527
You were fast—I was still looking at the code, wondering why the bug did not show up on my box, but it turns out that it is masked if integers and pointers are the same size. Thank you; I have merged your patch and pushed it to the repo, along with another commit to silence this warning.

_________________
My patches: Close airports | Upgrade airports | Autoconvert depots | New map features


Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 3:10 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Nov 27, 2004 3:05 pm
Posts: 4962
Location: Canada
cirdan wrote:
I have merged your (JGR) patch and pushed it to the repo, along with another commit to silence this warning.
:bow:

The bugicidal unguaranteed Win32 binaries are posted below:
Attachment:
File comment: Non gMo bugicidal
OpenTTD-REBASED-r27601-g1ece0fb9-Win32.7z [5.48 MiB]
Downloaded 14 times

and for those who want bridges over stations (free-bridges.diff):
Attachment:
File comment: ** CAUTION ** Contains free-bridges.diff
Known to cause uninhibited fun

OpenTTD-FreeBridge-g1ece0fb9M-Win32.7z [5.48 MiB]
Downloaded 15 times


Enjoy
:D

_________________
wallyweb on tt-forums: Screenshots - Projects - Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016


Last edited by wallyweb on Mon Sep 19, 2016 7:46 pm, edited 1 time in total.

Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 6:03 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Wed Jul 16, 2003 6:33 pm
Posts: 255
Not on my compiling machine, will use this post as dummy to provide the compiled version l8er.
Thank you so much for (hopefully) fixing the problem :)
Cheers

Sure i will test a few things before posting and either post the executable or a bug report :)


Last edited by TrueSatan on Sun Sep 18, 2016 6:42 pm, edited 1 time in total.

Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 6:24 pm 
Offline
Director
Director
User avatar

Joined: Sat Apr 07, 2007 6:08 pm
Posts: 527
After looking at the code, the same bug could affect the smallmap. Could you test this before posting a binary?

_________________
My patches: Close airports | Upgrade airports | Autoconvert depots | New map features


Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 7:15 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1650
Location: Ipswich
cirdan wrote:
After looking at the code, the same bug could affect the smallmap. Could you test this before posting a binary?

I tried the smallmap and got the result in the screenshot.
The vertical stripes seem to appear when tiles are marked dirty and redrawn. When paused the background stays black.
There aren't any crashes when scrolling though.


Attachments:
Unnamed, 1945-02-05.png [618.16 KiB]
Not downloaded yet

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github
Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 7:35 pm 
Offline
Director
Director
User avatar

Joined: Sat Apr 07, 2007 6:08 pm
Posts: 527
Thanks for testing. Displaying the smallmap is the problem here, not scrolling. Even if there is no crash, random locations in memory may be being written to. I am working on a fix.

_________________
My patches: Close airports | Upgrade airports | Autoconvert depots | New map features


Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 7:39 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Nov 27, 2004 3:05 pm
Posts: 4962
Location: Canada
JGR wrote:
cirdan wrote:
After looking at the code, the same bug could affect the smallmap. Could you test this before posting a binary?

I tried the smallmap and got the result in the screenshot.
The vertical stripes seem to appear when tiles are marked dirty and redrawn. When paused the background stays black.
There aren't any crashes when scrolling though.
With my Win32 binaries I saw none of this. All was as expected.

_________________
wallyweb on tt-forums: Screenshots - Projects - Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016


Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 8:08 pm 
Offline
Director
Director
User avatar

Joined: Sat Apr 07, 2007 6:08 pm
Posts: 527
wallyweb wrote:
With my Win32 binaries I saw none of this. All was as expected.
Yes, this is normal. The bug only affects 64-bit platforms, where pointers are usually wider than integers.

_________________
My patches: Close airports | Upgrade airports | Autoconvert depots | New map features


Top
   
 Post subject: Re: New map features
PostPosted: Sun Sep 18, 2016 9:09 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Wed Jul 16, 2003 6:33 pm
Posts: 255
As JGR has posted I got the same result on Minimap. Its black with strips of the normal minimap at random points.
Even tried to enabe graphs (never used before) and other windows.
Beside the minimap it runs okay so far.
Thanks and I will wait for the fix before posting a new version of the Ubuntu binary :)
Cheers


Top
   
 Post subject: Re: New map features
PostPosted: Mon Sep 19, 2016 2:41 pm 
Offline
Director
Director
User avatar

Joined: Sat Apr 07, 2007 6:08 pm
Posts: 527
The attached patch should fix the smallmap on 64-bit platforms. Can you give it a try?


Attachments:
blitter-fix.diff [6.87 KiB]
Downloaded 15 times

_________________
My patches: Close airports | Upgrade airports | Autoconvert depots | New map features
Top
   
 Post subject: Re: New map features
PostPosted: Mon Sep 19, 2016 4:20 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1650
Location: Ipswich
cirdan wrote:
The attached patch should fix the smallmap on 64-bit platforms. Can you give it a try?


All seems to work fine for me with this applied.

On an unrelated note, I get these warnings about maybe uninitialised variables when compiling:
[+] Spoiler
Code:
/home/jgr/openttd/trunk4/src/elrail.cpp: In function ‘void DrawCatenaryRailway(const TileInfo*)’:
/home/jgr/openttd/trunk4/src/elrail.cpp:572:27: warning: ‘sprite_halftile’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   AddSortableSpriteToDraw (ti->vd, wire_base + sss->image_offset[PCPconfig], PAL_NONE, ti->x + sss->x_offset, ti->y + sss->y_offset,

In file included from /home/jgr/openttd/trunk4/src/company_type.h:15:0,
                 from /home/jgr/openttd/trunk4/src/error.h:16,
                 from /home/jgr/openttd/trunk4/src/train_cmd.cpp:13:
/home/jgr/openttd/trunk4/src/core/enum_type.hpp: In function ‘bool TrainController(Train*, Vehicle*, bool)’:
/home/jgr/openttd/trunk4/src/core/enum_type.hpp:109:3: warning: ‘chosen_trackdir’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   m_val = (storage_type)e;
   ^
/home/jgr/openttd/trunk4/src/train_cmd.cpp:3610:13: note: ‘chosen_trackdir’ was declared here
    Trackdir chosen_trackdir;

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: New map features
PostPosted: Mon Sep 19, 2016 5:55 pm 
Offline
Director
Director
User avatar

Joined: Sat Apr 07, 2007 6:08 pm
Posts: 527
JGR wrote:
All seems to work fine for me with this applied.
Thank you, I have pushed the fix to the repository.

JGR wrote:
On an unrelated note, I get these warnings about maybe uninitialised variables when compiling:
Yes, I am aware of those, and they are false positives. I could silence them by initialising the relevant variables with a constant, but I am not too keen on writing worse code to appease the compiler.

_________________
My patches: Close airports | Upgrade airports | Autoconvert depots | New map features


Top
   
 Post subject: Re: New map features
PostPosted: Mon Sep 19, 2016 7:56 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Nov 27, 2004 3:05 pm
Posts: 4962
Location: Canada
cirdan wrote:
I have pushed the fix to the repository.
:bow:

More bugicide ... :mrgreen:
Unguaranteed Windows 32bit binaries:

Attachment:
File comment: Non gMo bugicidal
OpenTTD-REBASED-r27601-g95852d54-Win32.7z [5.48 MiB]
Downloaded 15 times

Attachment:
File comment: ** CAUTION ** Contains free-bridges.diff
Known to cause uninhibited fun

OpenTTD-FreeBridge-g95852d54M-Win32.7z [5.48 MiB]
Downloaded 14 times

JGR's tracerestrict version is available here.

Enjoy!
:D

_________________
wallyweb on tt-forums: Screenshots - Projects - Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016


Last edited by wallyweb on Mon Sep 19, 2016 10:12 pm, edited 2 times in total.

Top
   
 Post subject: Re: New map features
PostPosted: Mon Sep 19, 2016 7:58 pm 
Offline
Traffic Manager
Traffic Manager

Joined: Wed Jul 16, 2003 6:33 pm
Posts: 255
Looks fine over here so I post the usual 64bit version for Ubuntu 14.04
Still see no reason to switch to 16.04 haha

Thanks JGR and Cirdan for the fast fixes.

And as well JGR tracerestriction branch.

:bow:

Cheers


Attachments:
File comment: Version: g95852d54
Ubuntu 14.04 64bit

openttd-custom-g95852d54-UNIX.tar.xz [4.66 MiB]
Downloaded 7 times
File comment: Version: gde262117-tracerestrict
Ubuntu 14.04 64 bit

openttd-custom-gde262117-tracerestrict-cirdan-UNIX.tar.xz [4.68 MiB]
Downloaded 8 times


Last edited by TrueSatan on Mon Sep 19, 2016 10:24 pm, edited 3 times in total.
Top
   
 Post subject: Re: New map features
PostPosted: Mon Sep 19, 2016 8:13 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Mon Aug 08, 2005 1:46 pm
Posts: 1650
Location: Ipswich
wallyweb wrote:
JGR's tracerestrict version will be posted here when we have his push.

TrueSatan wrote:
JGR tracerestriction will be posted as soon as JGR has updated the branch

This is on Github now.

_________________
Ex TTDPatch Coder, Grumpy Greymuzzle
Avatar by MoonsongWolf.
Patch Pack, Github


Top
   
 Post subject: Re: New map features
PostPosted: Mon Sep 19, 2016 9:54 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Sat Nov 27, 2004 3:05 pm
Posts: 4962
Location: Canada
JGR wrote:
This is on Github now.
:bow:

For those who want the JGR tracerestricted Windows 32 bit bugicide we have:

Attachment:
File comment: Non gMo tracerestrict bugicidal
OpenTTD-gde262117-tracerestrict-cirdan-Win32.7z [5.5 MiB]
Downloaded 12 times

Attachment:
File comment: tracerestrict bugicidal enhanced with free-bridges.diff
OpenTTD-gde262117M-FreeBridge-tracerestrict-cirdan-Win32.7z [5.5 MiB]
Downloaded 26 times

The original cirdan variety is available here.

Enjoy.
:D

_________________
wallyweb on tt-forums: Screenshots - Projects - Releases
wallyweb on Simuscape: Projects - Releases
Other Stuff: TTDPatch 2.6 "Nightly" download - cirdan's OpenTTD branch (New Map Features)
Screenshot Of The Month Contest Winner: August 2015 - Tied May 2016


Top
   
 Post subject: Re: New map features
PostPosted: Sun Jan 08, 2017 9:27 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Fri Oct 17, 2008 12:17 pm
Posts: 2049
Location: Virgo Supercluster
This might be something that's due to self-compiling/patching, but I have crashes when building a rail X crossing directly on a bridge head, and then removing only the crossing track. Works fine for roads and demolishing the entire bridge, though.

...

Kinda almost feel like this came up before, but, eh, I don't know. Maybe someone can double-check with the builds posted here?


Top
   
 Post subject: Re: New map features
PostPosted: Sun Jan 08, 2017 9:47 pm 
Offline
Director
Director
User avatar

Joined: Sat Apr 07, 2007 6:08 pm
Posts: 527
Confirmed, the crash happens when trying to update the signals around the segment that contains the bridge head. The attached patch should fix this. Note that it may take some time until I can push this to the repository.


Attachments:
crossing-bridgehead.diff [626 Bytes]
Downloaded 16 times

_________________
My patches: Close airports | Upgrade airports | Autoconvert depots | New map features
Top
   
 Post subject: Re: New map features
PostPosted: Sun Jan 08, 2017 10:06 pm 
Offline
Tycoon
Tycoon
User avatar

Joined: Fri Oct 17, 2008 12:17 pm
Posts: 2049
Location: Virgo Supercluster
Now that's what I call great costumer service ;) ... thanks.


Top
   
Display posts from previous:  Sort by  
Post new topic  Reply to topic  [ 1221 posts ]  Go to page Previous 155 56 57 58 5962 Next

All times are UTC


Who is online

Users browsing this forum: Yahoo [Bot] and 4 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000-2017 phpBB Limited

Copyright © Owen Rudge/The Transport Tycoon Forums 2001-2017.
Hosted by Zernebok Hosting.