New map features

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

And here is the Ubuntu 14.04 Version.

As soon as JGR has updated the branch on his git I will post the tracerestriction
version as well.


btw I won't provide the bridges over all station, because I think the limitation is good.
And I still hope the high on bridges over stations will be a setting parameter one day hehe

As promised JGR's tracerestriction version as well :)

Cheers and thanks again Cirdan.
Attachments
openttd-custom-g7573dfd9-UNIX.tar.xz
Version:g7573dfd9
Ubuntu 14.04 64 bit
(4.65 MiB) Downloaded 47 times
openttd-custom-gea6da8c1-tracerestrict-cirdan-UNIX.tar.xz
Version: gea6da8c1-tracerestrict
Ubuntu 14.04 64 bit
(4.67 MiB) Downloaded 47 times
Last edited by TrueSatan on 22 Jun 2016 05:28, edited 1 time in total.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: New map features

Post by JGR »

I've done the merge and push now.
Ex TTDPatch Coder
Patch Pack, Github
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

JGR wrote:I've done the merge and push now.
:bow:
Here are the Windows 32bit binaries:
OpenTTD-gea6da8c1-tracerestrict-cirdan-Win32.7z
Allows bridges ONLY over Default Stations
(5.5 MiB) Downloaded 49 times
OpenTTD-gea6da8c1M-FreeBridge-tracerestrict-cirdan-Win32.7z
Allows bridges over ALL Stations
(5.5 MiB) Downloaded 62 times
The cat ate the dog who ate the guarantees. :cry:

Cirdan's versions are posted on the previous page.

Enjoy
:D
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

JGR wrote:I've done the merge and push now.
Thanks for the fast update JGR.
I have seen that tracerestriction was updated too, are those changes
in there as well?

Cheers
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: New map features

Post by JGR »

TrueSatan wrote:
Thanks for the fast update JGR.
I have seen that tracerestriction was updated too, are those changes
in there as well?

Cheers
The only change is a correctness change which fixes compilation on MSVC. I'll see about applying that later.
Ex TTDPatch Coder
Patch Pack, Github
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

JGR wrote: The only change is a correctness change which fixes compilation on MSVC. I'll see about applying that later.
Okay thanks, nothing that I need for my linux compiling then.
Haven't looked at the changelog, only my script showed me that something happened on github.

Thanks and cheers
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

JGR wrote:I've done the merge and push now.
tracerestrict-cirdan crashes for me, after making the world. Doesn't matter if it is heightmap or a generated map, this happens:

Code: Select all

Error: Assertion failed at line 603 of /usr/src/OpenTTD-patches/src/saveload/saveload_buffer.cpp: index >= this->array_index
And the crash log:

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Wed Jun 22 08:59:17 2016
In game date: 1935-01-01 (0)

Crash reason:
 Signal:  Segmentation fault (11)
 Message: <none>

Binary:
 Version:    gea6da8c1M-tracerestrict-cirdan (2)
 NewGRF ver: 17006ba4
 Build date: Jun 22 2016 10:48:59
 Flags:      64-bit little-endian

Stacktrace:
 [00] openttd() [0x5e72e9]
 [01] openttd() [0x6b1802]
 [02] openttd() [0x5e727a]
 [03] /usr/lib/libc.so.6(+0x33310) [0x7fc3d9ce8310]
 [04] openttd() [0x6fb860]
 [05] openttd() [0x6fd500]
 [06] openttd() [0x4f81e1]
 [07] openttd() [0x4e4aec]
 [08] openttd() [0x504195]
 [09] openttd() [0x673b5b]
 [10] /usr/lib/libpthread.so.0(+0x7484) [0x7fc3dda94484]
 [11] /usr/lib/libc.so.6(clone+0x6d) [0x7fc3d9d9c6dd]

Operating system:
 Name:     Linux
 Release:  4.6.2-1-ARCH
 Version:  #1 SMP PREEMPT Wed Jun 8 08:40:59 CEST 2016
 Machine:  x86_64
 Compiler: GCC 6.1.1 "6.1.1 20160602"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (5588)
 Language:     /usr/local/share/games/openttd/lang/norwegian_bokmal.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: sdl
 Sound set:    NoSound (2)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  DejaVu Sans
 Mono:   sprite

AI Configuration (local: 255):

Libraries:
 FontConfig: 2.12.0
 FreeType:   2.6.3
 ICU i18n:   57.1
 ICU lx:     57.1
 LZMA:       5.2.2
 LZO:        2.09
 PNG:        1.6.23
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 0: New game
    Revision text changed to gea6da8c1M-tra, savegame version 24, modified, newgrf version 0x17006ba4
    New game mode 1, landscape 1
    Added NewGRF: GRF ID F1250005, checksum 90A95BF1C508C0AE57C364E954E02B65, filename: firs_industry_replacement_set-2.0.0beta1/firs.grf (md5sum matches)
    Added NewGRF: GRF ID 52571201, checksum 9548AAA21E5B7E8168B3B19EF8290A83, filename: grvts32.grf (md5sum matches)
    Added NewGRF: GRF ID 33325A43, checksum 8767596EEC0C25A41B060D834C356402, filename: 32bpp_ez-0.1.grf (md5sum matches)
    Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21/pb_av8w.grf (md5sum matches)
    Added NewGRF: GRF ID 43415000, checksum 4DA9FE9A87DD330EBAD43916771BAF21, filename: opengfx_airports-0.4.2/ogfx-airports.grf (md5sum matches)
    Added NewGRF: GRF ID EC0D9110, checksum D1510A1006B03BCDAAFE562D5D05BACF, filename: raise_landscaping_costs.2/raise_landscaping_costs.grf (md5sum matches)
    Added NewGRF: GRF ID 48530101, checksum EC17E22A38C037D156BD22A96F4A8523, filename: reduced_passenger_payment.1.0/reducedpassengerpayment.grf (md5sum matches)
    Added NewGRF: GRF ID 54670901, checksum F3699B81A7B2BB59EABD49164AE53796, filename: TGrandom.grf (md5sum matches)
    Added NewGRF: GRF ID 414E0201, checksum 536506BDDDBD8644815FC2E7E6A80D7A, filename: fish_2-2.0.2/fish.grf (md5sum matches)
    Added NewGRF: GRF ID 44440000, checksum 31B0CA7C9CBB983F6BDD88E66FC45048, filename: pineapple_trains-1.3/pb_trains_10cc.grf (md5sum matches)
    Added NewGRF: GRF ID 4A430002, checksum 332F5EE83BB1A8F7C1766E610B48A222, filename: indstatr_32.grf (md5sum matches)
    Added NewGRF: GRF ID 4D4E0103, checksum 0727CAF0B249F0D3BD08E6140657FC27, filename: modified_bridge_properties.0.3/bridgeprop.grf (md5sum matches)
    Game started
---- gamelog end ----

*** End of OpenTTD Crash Report ***
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

Generating a new game or loading a game works fine here.
Testes on both builds.
Any special parameters you used hafting?

I am using for example fish and firs as well. maybe in newer versions,
but they are used to generate a new world and work fine.

Cheers
User avatar
wallyweb
Tycoon
Tycoon
Posts: 6102
Joined: 27 Nov 2004 15:05
Location: Canada

Re: New map features

Post by wallyweb »

Windows 32bit binaries for tracerestrict with and without Cirdan's Free-Bridge patch did not crash.
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

TrueSatan wrote: Any special parameters you used hafting?
My error, it seems. I had experimented with the configure parameters. With "./configure" with no parameters, the game runs fine!
TrueSatan
Transport Coordinator
Transport Coordinator
Posts: 291
Joined: 16 Jul 2003 18:33

Re: New map features

Post by TrueSatan »

What have you changed hafting?
Maybe its good to know, so no one else stumbles into the problem
or maybe the problem can be sorted out.

Cheers
Eddi
Tycoon
Tycoon
Posts: 8258
Joined: 17 Jan 2007 00:14

Re: New map features

Post by Eddi »

i would prefer the version where autorenew behaves like autoreplace, i.e. vehicles go for service even if servicing is disabled.

it makes no sense to have autorenew enabled and then complain that you don't want the vehicles to autorenew.
User avatar
JGR
Tycoon
Tycoon
Posts: 2557
Joined: 08 Aug 2005 13:46
Location: Ipswich

Re: New map features

Post by JGR »

TrueSatan wrote:
JGR wrote: The only change is a correctness change which fixes compilation on MSVC. I'll see about applying that later.
Okay thanks, nothing that I need for my linux compiling then.
Haven't looked at the changelog, only my script showed me that something happened on github.

Thanks and cheers
OK, this is done now.

For reference it doesn't require new binaries.
Hafting wrote:My error, it seems. I had experimented with the configure parameters. With "./configure" with no parameters, the game runs fine!
Your crashlog shows that you were running a modified version (i.e. not matching upstream git), this may also have been a factor in the issue.
Ex TTDPatch Coder
Patch Pack, Github
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

Another crash, and this time I believe I had a non-modified version. At least, this is what "git status" says:

Code: Select all

On branch tracerestrict-cirdan
Your branch is up-to-date with 'origin/tracerestrict-cirdan'.
nothing to commit, working directory clean
The crash comes after some time. I tend to start games in 1935, and then it crashes sometimes in the 1940-1950. It apparently crashes in saveload_buffer.cpp, so the crash.sav file is size zero. So no game to attach. I was not doing anything at the moment, just watching ships & trains move.

My crash.log:

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Mon Jul  4 16:17:15 2016
In game date: 1953-07-01 (0)

Crash reason:
 Signal:  Aborted (6)
 Message: Assertion failed at line 603 of /usr/src/OpenTTD-patches/src/saveload/saveload_buffer.cpp: index >= this->array_index

Binary:
 Version:    g78838570-tracerestrict-cirdan (0)
 NewGRF ver: 17006ba4
 Build date: Jun 24 2016 19:54:55
 Flags:      64-bit little-endian

Stacktrace:
 [00] openttd(_ZNK12CrashLogUnix13LogStacktraceEP7stringb+0x69) [0x708b99]
 [01] openttd(_ZNK8CrashLog12FillCrashLogEP7stringb+0x122) [0x5fd712]
 [02] openttd(_ZNK8CrashLog12MakeCrashLogEv+0xa4) [0x5fe124]
 [03] openttd() [0x708ac2]
 [04] /usr/lib/libc.so.6(+0x33310) [0x7fa93da70310]
 [05] /usr/lib/libc.so.6(gsignal+0x35) [0x7fa93da70295]
 [06] /usr/lib/libc.so.6(abort+0x16a) [0x7fa93da716da]
 [07] openttd() [0x6f6e04]
 [08] openttd() [0x76b6f1]
 [09] openttd() [0x7683b6]
 [10] openttd() [0x76c248]
 [11] openttd() [0x6f70bd]
 [12] openttd(_Z8GameLoopv+0x1a5) [0x6f8785]
 [13] openttd(_ZN15VideoDriver_SDL8MainLoopEv+0x1f1) [0x83ef71]
 [14] openttd(_Z12openttd_mainiPPc+0x1308) [0x6f9ce8]
 [15] /usr/lib/libc.so.6(__libc_start_main+0xf1) [0x7fa93da5d741]
 [16] openttd(_start+0x29) [0x560549]

Operating system:
 Name:     Linux
 Release:  4.6.2-rt5-1-rt
 Version:  #1 SMP PREEMPT RT Thu Jun 16 21:04:09 CEST 2016
 Machine:  x86_64
 Compiler: GCC 6.1.1 "6.1.1 20160602"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (5588)
 Language:     /usr/local/share/games/openttd/lang/norwegian_bokmal.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: sdl
 Sound set:    OpenSFX (87)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  DejaVu Sans
 Mono:   sprite

AI Configuration (local: 0):
  0: Human
  1: AdmiralAI (v25)
  2: Chopper (v10)
  3: FastPTPAI (v4)
  4: NoCAB (v499)
  5: ChooChoo (v409)
  6: FastPTPAI (v4)
 GS: Renewed City Growth (v5)

Libraries:
 FontConfig: 2.12.0
 FreeType:   2.6.3
 ICU i18n:   57.1
 ICU lx:     57.1
 LZMA:       5.2.2
 LZO:        2.09
 PNG:        1.6.23
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 0: New game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    New game mode 1, landscape 1
    Added NewGRF: GRF ID F1250006, checksum 53E8DF2FBB221D7ACEF2AE289C61E164, filename: firs_2-2.1.2/firs.grf (md5sum matches)
    Added NewGRF: GRF ID 54670901, checksum F3699B81A7B2BB59EABD49164AE53796, filename: TGrandom.grf (md5sum matches)
    Added NewGRF: GRF ID FBFB9905, checksum F747797A14AAA646402DC4E16DE5E82C, filename: longer_girder__steel_bridge.1/longergirdersteelbridge.grf (md5sum matches)
    Added NewGRF: GRF ID EC0D9110, checksum D1510A1006B03BCDAAFE562D5D05BACF, filename: raise_landscaping_costs.2/raise_landscaping_costs.grf (md5sum matches)
    Added NewGRF: GRF ID 48530101, checksum EC17E22A38C037D156BD22A96F4A8523, filename: reduced_passenger_payment.1.0/reducedpassengerpayment.grf (md5sum matches)
    Added NewGRF: GRF ID 52571201, checksum 9548AAA21E5B7E8168B3B19EF8290A83, filename: grvts32.grf (md5sum matches)
    Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21/pb_av8w.grf (md5sum matches)
    Added NewGRF: GRF ID 4A430002, checksum 332F5EE83BB1A8F7C1766E610B48A222, filename: indstatr_32.grf (md5sum matches)
    Added NewGRF: GRF ID 44440000, checksum A15C21BAFCC06FBB85CDB2E7CB945667, filename: pineapple_trains-1.2/pb_trains_10cc.grf (md5sum matches)
    Added NewGRF: GRF ID 4D4E0103, checksum 0727CAF0B249F0D3BD08E6140657FC27, filename: modified_bridge_properties.0.3/bridgeprop.grf (md5sum matches)
    Added NewGRF: GRF ID 414E0201, checksum 536506BDDDBD8644815FC2E7E6A80D7A, filename: fish_2-2.0.2/fish.grf (md5sum matches)
    Game started
Tick 39662: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 60196: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 26202: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
---- gamelog end ----

*** End of OpenTTD Crash Report ***
This is the console output (minus the crash report that also got printed)

Code: Select all

dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -2587
dbg: [script] [5] [S] [b] 14
dbg: [script] [5] [S] [a] 65
dbg: [script] [5] [S] [cargo] 8
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -3871
dbg: [script] [5] [S] [b] 98
dbg: [script] [5] [S] [a] 19
dbg: [script] [5] [S] [cargo] 16
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -3882
dbg: [script] [5] [S] [b] 66
dbg: [script] [5] [S] [a] 19
dbg: [script] [5] [S] [cargo] 16
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -3882
dbg: [script] [5] [S] [b] 52
dbg: [script] [5] [S] [a] 39
dbg: [script] [5] [S] [cargo] 16
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -3917
dbg: [script] [5] [S] [b] 67
dbg: [script] [5] [S] [a] 65
dbg: [script] [5] [S] [cargo] 3
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -3882
dbg: [script] [5] [S] [b] 14
dbg: [script] [5] [S] [a] 66
dbg: [script] [5] [S] [cargo] 8
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -3882
dbg: [script] [5] [S] [b] 52
dbg: [script] [5] [S] [a] 7
dbg: [script] [5] [S] [cargo] 16
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [55]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [railType] 0
dbg: [script] [5] [S] [maxDistance] -3917
dbg: [script] [5] [S] [b] 14
dbg: [script] [5] [S] [a] 65
dbg: [script] [5] [S] [cargo] 3
dbg: [script] [5] [S] [route] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] Your script made an error: unknown error
dbg: [script] [5] [S] 
dbg: [script] [5] [S] *FUNCTION [FindPath()] choochoo-409/builder_track.nut line [115]
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_track.nut line [56]
dbg: [script] [5] [S] *FUNCTION [RunSubtasks()] choochoo-409/task.nut line [82]
dbg: [script] [5] [S] *FUNCTION [Run()] choochoo-409/builder_cargo.nut line [99]
dbg: [script] [5] [S] *FUNCTION [Start()] choochoo-409/main.nut line [75]
dbg: [script] [5] [S] 
dbg: [script] [5] [S] [maxBridgeCost] 821512
dbg: [script] [5] [S] [u] 100
dbg: [script] [5] [S] [bridgeLength] 18
dbg: [script] [5] [S] [pathfinder] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [indent] ""
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [this] INSTANCE
dbg: [script] [5] [S] [task] INSTANCE
dbg: [script] [5] [S] [minMoney] 0
dbg: [script] [5] [S] [this] INSTANCE
Error: Assertion failed at line 603 of /usr/src/OpenTTD-patches/src/saveload/saveload_buffer.cpp: index >= this->array_index
Crash encountered, generating crash log...
*** OpenTTD Crash Report ***
Not repeating this
*** End of OpenTTD Crash Report ***

Crash log generated.

Writing crash log to disk...
Crash log written to /home/helge/.openttd/crash.log. Please add this file to any bug reports.

Writing crash savegame...
Error: Assertion failed at line 603 of /usr/src/OpenTTD-patches/src/saveload/saveload_buffer.cpp: index >= this->array_index

Apparently, an array index going too far. And when it tries to save the crashing game, it hits the same error and fails again?

I can provide the last saved game, but it may be necessary to play for a while and no guarantee that the same happens.
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

Here is what I can infer from your report: The program crashes when saving the game; since you said that you were not doing anything at the time, it must have been during an autosave, which is compatible with the in-game date of your crash log (1953-07-01). However, I cannot say much more about the crash with the information that you provide, as you seem to be using a non-debug build, so the stack trace is pretty much useless. There are a couple of things that you could do to help me:

1. Try your last saved game, perhaps the last autosave, and let it run until the same date to see if it crashes again.

2. Use a debug build (configure with --enable-debug). This won't help us with the crash at hand, but it will if it happens again, because we will have a usable stack trace, and in my experience it does not have much impact on performance (on linux).
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

cirdan wrote: you seem to be using a non-debug build, so the stack trace is pretty much useless.
Sorry about that. I am now running with --enable-debug=1
cirdan wrote:
1. Try your last saved game, perhaps the last autosave, and let it run until the same date to see if it crashes again.
The game ran 50 game years while I slept - and no crash. I will retry playing it from the last save, and build approximately the same routes as last time.

I guess that the problem is with the number of vehicles. I used to run into problems like "you can only have 300 ships" or whatever the default number was. (No realism, I'm rich and control 90% of my worlds shipping - of course I can have more ships...)

So I increased the maximum numbers of ships/trains/trucks per player. I can only guess that there is an array somewhere with a fixed limit, instead of using the number from the game settings. Or perhaps the error is in the test itself. Anyway, I'll be trying to get a large company going - with debugging enabled.
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

Hafting wrote:Sorry about that. I am now running with --enable-debug=1
Oh, there is nothing be sorry about, but running with debugging enabled helps if you come across a crash.
Hafting wrote:The game ran 50 game years while I slept - and no crash. I will retry playing it from the last save, and build approximately the same routes as last time.
Yes, this was a very long shot. Anyway, if you get a crash again, the stack trace should at least give me somewhere to start looking.
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

Crash - this time with a backtrace. An industry disappeared, obsoleting a ship route. So I sent the ship to a dock. I also demolished its destination harbour, as nothing could be delivered there anymore. Some time later, the game complained about the ship (now docked) having an empty order, so I tried to sell it. The game died!

The crash log:

Code: Select all

*** OpenTTD Crash Report ***

Crash at: Tue Jul 19 23:28:04 2016
In game date: 1981-07-17 (46)

Crash reason:
 Signal:  Aborted (6)
 Message: <none>

Binary:
 Version:    g78838570-tracerestrict-cirdan (0)
 NewGRF ver: 17006ba4
 Build date: Jul  7 2016 20:04:55
 Flags:      64-bit little-endian

Stacktrace:
 [00] openttd(_ZNK12CrashLogUnix13LogStacktraceEP7stringb+0x69) [0x706249]
 [01] openttd(_ZNK8CrashLog12FillCrashLogEP7stringb+0x122) [0x5fc652]
 [02] openttd(_ZNK8CrashLog12MakeCrashLogEv+0xa4) [0x5fd064]
 [03] openttd() [0x706172]
 [04] /usr/lib/libc.so.6(+0x33310) [0x7fe182d41310]
 [05] /usr/lib/libc.so.6(gsignal+0x35) [0x7fe182d41295]
 [06] /usr/lib/libc.so.6(abort+0x16a) [0x7fe182d426da]
 [07] /usr/lib/libc.so.6(+0x2c297) [0x7fe182d3a297]
 [08] /usr/lib/libc.so.6(+0x2c342) [0x7fe182d3a342]
 [09] openttd() [0x6f7e5d]
 [10] openttd(_ZN11OrderBackupD0Ev+0x9) [0x6f7e69]
 [11] openttd(_ZN11OrderBackup11ResetOfUserEjj+0x58) [0x6f8348]
 [12] openttd(_Z19CmdClearOrderBackupj13DoCommandFlagjjPKc+0x1d) [0x6f837d]
 [13] openttd(_ZNK7Command14execp_internalEb13CommandSource+0x4fa) [0x5e98ea]
 [14] openttd(_ZN11OrderBackup5ResetEjb+0xab) [0x6f84fb]
 [15] openttd(_Z17HandleMouseEventsv+0x1434) [0x854064]
 [16] openttd(_ZN15VideoDriver_SDL9PollEventEv+0x17e) [0x83921e]
 [17] openttd(_ZN15VideoDriver_SDL8MainLoopEv+0x60) [0x839420]
 [18] openttd(_Z12openttd_mainiPPc+0x1306) [0x6f7556]
 [19] /usr/lib/libc.so.6(__libc_start_main+0xf1) [0x7fe182d2e741]
 [20] openttd(_start+0x29) [0x560669]

Operating system:
 Name:     Linux
 Release:  4.6.2-rt5-1-rt
 Version:  #1 SMP PREEMPT RT Thu Jun 16 21:04:09 CEST 2016
 Machine:  x86_64
 Compiler: GCC 6.1.1 "6.1.1 20160602"

Configuration:
 Blitter:      32bpp-sse4-anim
 Graphics set: zBase (5588)
 Language:     /usr/local/share/games/openttd/lang/norwegian_bokmal.lng
 Music driver: extmidi
 Music set:    NoMusic (0)
 Network:      no
 Sound driver: sdl
 Sound set:    OpenSFX (87)
 Video driver: sdl

Fonts:
 Small:  DejaVu Sans
 Medium: DejaVu Sans
 Large:  DejaVu Sans
 Mono:   sprite

AI Configuration (local: 0):
  0: Human
  1: Chopper (v10)
  2: OtviAI (v418)
  3: FastPTPAI (v4)
  4: OtviAI (v418)
  5: NoCAB (v499)
  6: Chopper (v10)
 GS: Renewed City Growth (v5)

Libraries:
 FontConfig: 2.12.0
 FreeType:   2.6.5
 ICU i18n:   57.1
 ICU lx:     57.1
 LZMA:       5.2.2
 LZO:        2.09
 PNG:        1.6.23
 SDL:        1.2.15
 Zlib:       1.2.8

---- gamelog start ----
Tick 0: New game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    New game mode 1, landscape 1
    Added NewGRF: GRF ID F1250006, checksum 53E8DF2FBB221D7ACEF2AE289C61E164, filename: firs_2-2.1.2/firs.grf (md5sum matches)
    Added NewGRF: GRF ID 54670901, checksum F3699B81A7B2BB59EABD49164AE53796, filename: TGrandom.grf (md5sum matches)
    Added NewGRF: GRF ID FBFB9905, checksum F747797A14AAA646402DC4E16DE5E82C, filename: longer_girder__steel_bridge.1/longergirdersteelbridge.grf (md5sum matches)
    Added NewGRF: GRF ID EC0D9110, checksum D1510A1006B03BCDAAFE562D5D05BACF, filename: raise_landscaping_costs.2/raise_landscaping_costs.grf (md5sum matches)
    Added NewGRF: GRF ID 48530101, checksum EC17E22A38C037D156BD22A96F4A8523, filename: reduced_passenger_payment.1.0/reducedpassengerpayment.grf (md5sum matches)
    Added NewGRF: GRF ID 52571201, checksum 9548AAA21E5B7E8168B3B19EF8290A83, filename: grvts32.grf (md5sum matches)
    Added NewGRF: GRF ID 44440A01, checksum FCEEC76CF44EC23E7FE9C88048CF11CC, filename: av8_aviators_aircraft_set-2.21/pb_av8w.grf (md5sum matches)
    Added NewGRF: GRF ID 4A430002, checksum 332F5EE83BB1A8F7C1766E610B48A222, filename: indstatr_32.grf (md5sum matches)
    Added NewGRF: GRF ID 44440000, checksum A15C21BAFCC06FBB85CDB2E7CB945667, filename: pineapple_trains-1.2/pb_trains_10cc.grf (md5sum matches)
    Added NewGRF: GRF ID 4D4E0103, checksum 0727CAF0B249F0D3BD08E6140657FC27, filename: modified_bridge_properties.0.3/bridgeprop.grf (md5sum matches)
    Added NewGRF: GRF ID 414E0201, checksum 536506BDDDBD8644815FC2E7E6A80D7A, filename: fish_2-2.0.2/fish.grf (md5sum matches)
    Game started
Tick 39662: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 60196: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 26202: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 4472: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 8977: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 536: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 13737: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 16523: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
Tick 24338: Load game
    Revision text changed to g78838570-trac, savegame version 24, not modified, newgrf version 0x17006ba4
    Game loaded
---- gamelog end ----

*** End of OpenTTD Crash Report ***
As usual, I also got a zero-sized savegame. The final messages on screen looked like this:

Code: Select all

*** End of OpenTTD Crash Report ***

Crash log generated.

Writing crash log to disk...
Crash log written to /home/helge/.openttd/crash.log. Please add this file to any bug reports.

Writing crash savegame...
openttd: /usr/src/OpenTTD-patches/src/saveload/saveload_buffer.cpp:603: void SaveDumper::WriteElementHeader(uint, size_t): Assertion `index >= this->array_index' failed.
Avbrutt (SIGABRT) (core dumped)

The game crashed on 1981-07-17. The last saved game is for 1981-05-21, but I did some railroad building and the above mentioned harbour deletion after that. The ship I tried to sell exists in that game though.
Helge Hafting
User avatar
cirdan
Director
Director
Posts: 539
Joined: 07 Apr 2007 18:08

Re: New map features

Post by cirdan »

The crash did not happen when you sold the ship, but when you closed the depot window, right? Can you try this patch? (It works for me.)
Hafting
Engineer
Engineer
Posts: 106
Joined: 13 Feb 2014 11:22

Re: New map features

Post by Hafting »

cirdan wrote:The crash did not happen when you sold the ship, but when you closed the depot window, right? Can you try this patch? (It works for me.)
You are right, when I closed the window. The crash turned out to be repeatable. Your patch did not apply directly, but solved the problem when I applied it manually.
Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 10 guests