Patch: Partial refit

[Kogut]

All may be long in other languages - for example "wszystkie".

[ChillCore]

I have uploaded a new queue which corrects that bug and completes the tooltips.

I would not mind testing futher/again, can you please re-post the link to your patch space?
I do not see it anymore in the first post and the versions there seem to be the previous still.

[Terkhen]

I'm sorry, you can find them at http://devs.openttd.org/~terkhen/patches/partial_refit/

[ChillCore]

Thank you for the link. It was a bit hard to check without the pacth.

The selection box thinghy is fixed indeed.
How changing the order of two lines can make such a big difference ...

If i spot something else I'll post it , untill now everything seems to be working correctly. (Only tested trains for the moment)

[Terkhen]

The patch has now been committed to trunk and will appear in today's nightly. The only thing missing now is the select all button

Here is my current implementation of the button. What do you think?

select_all.png (89.49 KiB) Viewed 2015 times

You can find the patch queue (of course, now it only includes the new panel and the button) at the usual place.

[Zephyris]

Looks good I think...

[Arie-]

A bit late I guess, but I just thought of it now, a suggestion for the "select total train button": a check box. The looks (image) of the button depends on the state, three possible:
- empty box when no component is selected.
- a box with a greyed x when at least one is selected, but not all.
- a box with a black x when all train parts are selected.
When the button is clicked, the selected parts are set to none or all. Which of the two is chosen when at least one, but not all are selected, is up to the developer.
I've read through the topic, and have seen an image was considered, but have not found why it was discarded as a solution. A quick mock-up is attached, but I think you all know the concept of such a box.

v_mockup.PNG (696 Bytes) Viewed 1944 times

[Terkhen]

You are not late. The rest of the patch has been commited, but the button issue is still open for discussion. The idea of an icon is not discarded; I coded the text version because it is a quite simple patch.

We need the answer to two questions. Where should the button be placed? Should it use an icon or text?

[WWTBAM]

I do like the idea of an icon. I think an icon in the style of Pikka's UKRS2 Multiheaded Engine Purchase List icons wold be suitable.

[Zuu]

Maybe an icon with a train consisting of one engine and one (or two wagons) and the whole train marked as selected? It would have to be maybe about 30-40 pixles long.

[Arie-]

Something like this?

something_like_this.PNG (797 Bytes) Viewed 1907 times

[ChillCore]

The patch has now been committed to trunk and will appear in today's nightly. The only thing missing now is the select all button

Here is my current implementation of the button. What do you think?

Congrats on trunk inclusion.


I think it is OK the way you have implemented the button and the info line.
It looks like the buttons in the company's stations gui, the ones to enable all cargos or all vehicle types, and therefore pretty consistent with the other guis.

About addding a graphical button ...
Can the button remain there if a bigger fonsize is selected? Would that not give problems?
Maybe it would be better to make a sprite that has no "button" shape but is drawn centered in the panel? Like how it is done for vehicle sprites in the guis.
That way if the line gets higher in height the sprite is always drawn in the correct place and the result is not a small button with an extra (little) panel above or below ?
Just an idea ...

Will check out the remaining patch(es) in a bit ...

[Zuu]

I once looked into changing painting of images on buttons so that they are vertically aligned in the middle, but never came around to finalize it. However IIRC it was fairly straight forward to get it working but it might be that there was some pit falls that must be handled as well.

[ChillCore]

For text is was WWT_LABEL IIRC.
I do not know if someting like that exists for images or if text can simply be replaced by an image and then put on a button.
It would be cool though.

[555gln22]

What about a Ctrl-Click option? Might work?

[Zuu]

I personally find it a bit strange that when I have made a selection and then click on the refit button, my specific selection is cleared and the whole train gets selected. I think my selection should remain when I click on the refit-button. Otherwise it looks like the refit fails.

[Terkhen]

What about a Ctrl-Click option? Might work?

The Ctrl+Click option is already included. The button is meant for adding a more visible option to select all vehicles.

I personally find it a bit strange that when I have made a selection and then click on the refit button, my specific selection is cleared and the whole train gets selected. I think my selection should remain when I click on the refit-button. Otherwise it looks like the refit fails.

In most train sets, the selected part will change its graphics to fit the new refitted cargo. IMO it makes sense to change the selection, since it is not very probable that you will want to refit the same part of the train twice.

[Zuu]

I would counter and say that if you have refitted a subset of all wagons, it is not likely that you want refit them again, therefore a complete selection of the train is not more useful than keeping the subset selection.

[Terkhen]

That's true, but I still think that changing the selection is a clear way of showing the user that something happened.

[Zephyris]

Could the cargo icon for the current refit be displayed under each wagon? That would make it clearer when a wagon has been refitted too...