My patch(es) (place house manually)

[zooks]

This bit breaks compilation for me: (something with character encoding?)

Code: Select all

@@ -1,4 +1,4 @@
-##name English (UK)
+<U+FEFF>##name English (UK)
 ##ownname English (UK)
 ##isocode en_GB
 ##plural 0

After removing those lines, compilation went ok until:

Code: Select all

[SRC] Compiling newgrf_house.cpp
/src/newgrf_house.cpp: In function ‘void DrawNewHouseTileInGUI(int, int, HouseID)’:
/src/newgrf_house.cpp:527:71: error: cannot convert ‘const NewGRFSpriteLayout’ to ‘const DrawTileSprites*’ in initialization
make[1]: *** [newgrf_house.o] Error 1
make[1]: Leaving directory `/objs/release'
make: *** [all] Error 1

[Eddi]

<U+FEFF>

that's called a "Byte Order Mark" (BOM). some editors add these to files to determine the file encoding, but it's actually completely useless for UTF-8.

it should, however, not be consisting of the literal letters "<U+FEFF>", that's likely a copy-paste mistake then

[zooks]

Yeah I copied it from Less, which does not show unicode characters. Patch also warns about CR line endings with this diff

[ZxBiohazardZx]

update: removed that weird BOM char, and set the whole patch to UNIX style EOL

not sure on the other error, as the "original" patch also had a notice that it would fail there....