[Patch] Daylength, Cargodist with sprinkles

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Eddi
Tycoon
Tycoon
Posts: 7468
Joined: 17 Jan 2007 00:14

Re: [Patch] Daylength, Cargodist with sprinkles

Post by Eddi »

any chance you can check whether you can include the "Leave on Time" patch (http://bugs.openttd.org/task/2534) into your patch pack? I haven't checked if the patch is any good, but it was requested here: http://www.tt-ms.de/forum/showthread.php?tid=4645 [german]
You might not exactly be interested in Ferion, but if you are, have fun :)

User avatar
bluebottle
Engineer
Engineer
Posts: 29
Joined: 21 Sep 2009 03:23

Re: [Patch] Daylength, Cargodist with sprinkles

Post by bluebottle »

This is a build of r19733 for Ubuntu 9.10 Linux (Karmic Koala), using SpComb's patch above. Check that post for information on the patches included as well as any caveats.
  • As with the distro OpenTTD package, you need to have the data files in /usr/share/games/openttd/data/.
  • This build is unstripped to provide better (i.e. useful) core dumps/backtraces.
  • Any warnings about downgrading to version 1.1_svn_0 can be safely ignored.
Download: openttd_cargodist_sprinkles-r19733M-no_debug-unstripped-i386.deb
Crash reports / feedback:
Please report any and all crashes from this build in this thread, unless you can also reproduce them in a nightly or cargodist/autosep build.

It's a good idea to also post the crash.* files that OpenTTD produces, along with any relevant information relating to the crash (such as a recent savegame and a description of the circumstances of the crash).

Additionally, comments or suggestions as to the behavior of the auto-separation patch should go into the Automated timetables and separation topic.
I won't be producing any binaries for Ubuntu 10.04 for at least a couple of weeks. :|

Freak_NL
Engineer
Engineer
Posts: 48
Joined: 13 Mar 2009 18:56

Re: [Patch] Daylength, Cargodist with sprinkles

Post by Freak_NL »

Are there any Ubuntu users that actually need binaries? Building and patching OpenTTD is quite manageable on Linux.

I'm ten years into playing a game (starting in 1920, 2048*2048) with Chill's patch-pack (including this patch set) and the daylength set to 3. No complaints so far; it's nice to be able to take your time to build and extend a large network without having to worry about upgrading all those steam engines when you've barely started.

User avatar
DJ Nekkid
Tycoon
Tycoon
Posts: 2141
Joined: 30 Nov 2006 20:33

Re: [Patch] Daylength, Cargodist with sprinkles

Post by DJ Nekkid »

is this build compatible with 19601's savegames?
Member of the
ImageImage

User avatar
SpComb
Tycoon
Tycoon
Posts: 1109
Joined: 13 Nov 2003 20:26
Location: Finland
Contact:

Re: [Patch] Daylength, Cargodist with sprinkles

Post by SpComb »

DJ Nekkid wrote:is this build compatible with 19601's savegames?
Tentatively, yes, since fonso hasn't changed cargodist's savegame stuff since then.

User avatar
SpComb
Tycoon
Tycoon
Posts: 1109
Joined: 13 Nov 2003 20:26
Location: Finland
Contact:

Re: [Patch] Daylength, Cargodist with sprinkles

Post by SpComb »

If you want something (like an updated version), you need to learn to ask for it (or has everyone moved over to CPP?). It won't come by itself.

Updated version, including many hours of messing around with git to rebase everything against fonso's new branches. The public git repo has not been updated yet.

Includes recent changes from cargodist, as well as ~1.5 months worth of trunk.

Download: openttd-cargodist-sprinkles-r19964M-win32.zip (.pdb.gz, .patch, .svn.patch, .log).

The git .patch is also attached, but the win32 .zip doesn't fit in the 4MiB attachment size limit anymore. Download from the above link.

Savegame compatibility:
This build should be able to load games saved by all previous official OpenTTD versions, as well as the matching vanilla cargodist build.

No word on compatibility with previous cargodist-sprinkles builds.

Crash reports / feedback:
Please report any and all crashes from this build in this thread, unless you can also reproduce them in a nightly or vanilla cargodist/autosep build.

It's a good idea to also post the crash.* files that OpenTTD produces, along with any relevant information relating to the crash (such as a recent savegame and a description of the circumstances of the crash).

Additionally, comments or suggestions as to the behavior of the auto-separation patch should go into the Automated timetables and separation topic
Attachments
openttd-cargodist-sprinkles-r19964.patch
(353.17 KiB) Downloaded 510 times

User avatar
ostlandr
Chairman
Chairman
Posts: 882
Joined: 12 May 2007 01:09
Location: Northeastern USA

Re: [Patch] Daylength, Cargodist with sprinkles

Post by ostlandr »

Thankyouthankyouthankyou!!!!!!!! :D

I really appreciate the update.
Who is John Galt?

User avatar
fonso
President
President
Posts: 945
Joined: 13 Oct 2007 08:28

Re: [Patch] Daylength, Cargodist with sprinkles

Post by fonso »

I'm sorry for the butchering in my git repository, but it had to be done sometime. I didn't know anyone was regularly pulling from it. I'll be more careful from now on.
The guy on the picture is not me, it's Alonso.

User avatar
SpComb
Tycoon
Tycoon
Posts: 1109
Joined: 13 Nov 2003 20:26
Location: Finland
Contact:

Re: [Patch] Daylength, Cargodist with sprinkles

Post by SpComb »

fonso wrote:I'm sorry for the butchering in my git repository, but it had to be done sometime. I didn't know anyone was regularly pulling from it. I'll be more careful from now on.
Agreed; It was inconvenient, but understandable.

I had based my own feature-branches off your master branch, to be in sync with cargodist in terms of what trunk revision it's based off.

Kogut
Tycoon
Tycoon
Posts: 2493
Joined: 26 Aug 2009 06:33
Location: Poland

Re: [Patch] Daylength, Cargodist with sprinkles

Post by Kogut »

Crash, but not with newest version
Attachments
Przechwytywanie.PNG
Przechwytywanie.PNG (56.51 KiB) Viewed 10826 times
Correct me If I am wrong - PM me if my English is bad
AIAI - AI for OpenTTD

Kogut
Tycoon
Tycoon
Posts: 2493
Joined: 26 Aug 2009 06:33
Location: Poland

Re: [Patch] Daylength, Cargodist with sprinkles

Post by Kogut »

Click on aircraft in station menu results in list of ships, clicking on ship results in aircraft list.
Thanks for that pathpack!
Attachments
Przechwytywanie.PNG
Przechwytywanie.PNG (128.16 KiB) Viewed 10747 times
Correct me If I am wrong - PM me if my English is bad
AIAI - AI for OpenTTD

User avatar
ChillCore
Tycoon
Tycoon
Posts: 2658
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: [Patch] Daylength, Cargodist with sprinkles

Post by ChillCore »

The second one was a bug in trunk which has been fixed in r19968.
I do not know if the crash is related.

And I agree very nice patchpack indeed.
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.

Kogut
Tycoon
Tycoon
Posts: 2493
Joined: 26 Aug 2009 06:33
Location: Poland

Re: [Patch] Daylength, Cargodist with sprinkles

Post by Kogut »

OK, so I am waiting for new pathpack version.
Correct me If I am wrong - PM me if my English is bad
AIAI - AI for OpenTTD

boogieman1402
Engineer
Engineer
Posts: 11
Joined: 14 Jun 2010 17:11

Re: [Patch] Daylength, Cargodist with sprinkles

Post by boogieman1402 »

First of all, thanks for all the effort put into this, makes for a nice game experience :)

Second, apologies if I'm 'blaming' the wrong patch, I'm making a bit of an educated guess.

I'm playing a game running ColdIce's build of Chillcore's patchpack, R20030 (v7). I've noticed when I set the daylength factor to a large value (64 in the current game), town growth goes negative. In about 6 months time, one town I just started servicing dropped in population from over 6000 to slightly less than 3000, another from 4000 to 2000. Both towns were being services with a single station where passengers, goods and food were being delivered (I'm using FIRS). Another town, being serviced by 6 different stations grew to a 20k population with a shorter daylength setting, then dropped to barely 5000 in a few months with the high daylength setting.

When I set daylength to 4, I see those towns start growing almost immediately, so it seems I did get the idea :)

Potentially relevant settings: Town growth speed is normal, town cargo generation factor -1

I'm running this game with TTRS 3.02a, but I don't think that's involved. I noticed the same behaviour with the previous version of Chill's pack (V6.3) and I wasn't using TTRS then.

Any other info needed, let me know. I'll also be happy to provide a savegame.

User avatar
ChillCore
Tycoon
Tycoon
Posts: 2658
Joined: 04 Oct 2008 23:05
Location: Lost in spaces

Re: [Patch] Daylength, Cargodist with sprinkles

Post by ChillCore »

SpComb, just for information,
I have increased the running_ticks in vehicle_base.h and in vehicle_sl.cpp from byte to uint16 in my patchpack.
I have not (yet) increased other values.

Maybe there are a few more places where values need to be increased for higher daylenght settings.
-- .- -.-- / - .... . / ..-. --- .-. -.-. . / -... . / .-- .. - .... / -.-- --- ..- .-.-.-
--- .... / -.-- . .- .... --..-- / .- -. -.. / .--. .-. .- .. ... . / - .... . / .-.. --- .-. -.. / ..-. --- .-. / .... . / --. .- ...- . / ..- ... / -.-. .... --- --- -.-. .... --- --- ... .-.-.- / ---... .--.

Playing with my patchpack? Ask questions on usage and report bugs in the correct thread first, please.
All included patches have been modified and are no longer 100% original.

Dante123
Chief Executive
Chief Executive
Posts: 670
Joined: 11 Aug 2009 16:10
Location: The Nederlands
Contact:

Re: [Patch] Daylength, Cargodist with sprinkles

Post by Dante123 »

for better money/income balancing due daylength the following suggestions:
would it be nice to add a function/multiplier to make trains and vehicles get old faster ? (example: make vehicles/trains/boats/plains get old faster with daylength factor ? y/n)
same thing for the running cost ?

User avatar
ostlandr
Chairman
Chairman
Posts: 882
Joined: 12 May 2007 01:09
Location: Northeastern USA

Re: [Patch] Daylength, Cargodist with sprinkles

Post by ostlandr »

One of the things I like about the daylength patch is that vehicles stick around longer. If I'm making too much money, I can always tweak the running costs in difficulty settings, and add some fun grfs like increased building costs.
Dante123 wrote:for better money/income balancing due daylength the following suggestions:
would it be nice to add a function/multiplier to make trains and vehicles get old faster ? (example: make vehicles/trains/boats/plains get old faster with daylength factor ? y/n)
same thing for the running cost ?
Who is John Galt?

aantono
Traffic Manager
Traffic Manager
Posts: 211
Joined: 15 Apr 2010 21:01
Location: Midwest, US

Re: [Patch] Daylength, Cargodist with sprinkles

Post by aantono »

Any chance we could get a new version of the Cargodist merged into this patch? It has a new model of supply scaling added and it would be nice to try?

User avatar
SpComb
Tycoon
Tycoon
Posts: 1109
Joined: 13 Nov 2003 20:26
Location: Finland
Contact:

Re: [Patch] Daylength, Cargodist with sprinkles

Post by SpComb »

I've updated the git repo with a freshly merged copy. The old git repo was replaced entirely due to the changes from back in June, so you'll need to check out a fresh copy to use it (or rebase...).
Dante123 wrote:for better money/income balancing due daylength the following suggestions:
would it be nice to add a function/multiplier to make trains and vehicles get old faster ? (example: make vehicles/trains/boats/plains get old faster with daylength factor ? y/n)
same thing for the running cost ?
Fixing the money/incoming balancing issues in the game isn't my priority, and "add a new advanced option" isn't really a good solution for it either.
ChillCore wrote:I have increased the running_ticks in vehicle_base.h and in vehicle_sl.cpp from byte to uint16 in my patchpack.
Check, I've included this as well.
boogieman1402 wrote:I'm playing a game running ColdIce's build of Chillcore's patchpack, R20030 (v7). I've noticed when I set the daylength factor to a large value (64 in the current game), town growth goes negative. In about 6 months time, one town I just started servicing dropped in population from over 6000 to slightly less than 3000, another from 4000 to 2000. Both towns were being services with a single station where passengers, goods and food were being delivered (I'm using FIRS). Another town, being serviced by 6 different stations grew to a 20k population with a shorter daylength setting, then dropped to barely 5000 in a few months with the high daylength setting.
This is very likely to be a direct result of this patch, since it directly modifies the town growth rates (more ticks between town growth steps; ~same number of town growth steps per month). This was because it was difficult to service a town with 20k pop using just BR92's...

I've only ever play-tested with a daylength factor of 4 or so, and it's defiantly plausible that there's a decrease in town pop in the long term, and that the effect is more drastically visible with extreme daylength settings (64 counts as such).

Currently, I'm not exactly sure what time interval is used for shrinking the towns, but there's some mechanism going awry when the town growth happens too rarely.

Needs more investigation.

aantono
Traffic Manager
Traffic Manager
Posts: 211
Joined: 15 Apr 2010 21:01
Location: Midwest, US

Re: [Patch] Daylength, Cargodist with sprinkles

Post by aantono »

Just to clarify - do a git pop from http://git.qmsk.net/?p=openttd;a=shortl ... -sprinkles and compile? No more need to patch the official trunk?

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: MagicBuzz and 7 guests