[Patch] Watch Other Companies GUI

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Console Watch Command

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:19, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Console Watch Command

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:20, edited 2 times in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

Yexo
Tycoon
Tycoon
Posts: 3653
Joined: 20 Dec 2007 12:49

Re: Patch: Console Watch Command

Post by Yexo »

I got a lot of compile errors so it didn't even get to a linking stage. This might be because I applied it to r17734 though.

My best guess at the reason for that error is because you declare WatchWindow twice. Try declaring it once in a header file and then just implementing the functions in smallmap_gui.cpp instead of duplicating the definition.

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Console Watch Command

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:20, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Console Watch Command [GUI]

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:20, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Console Watch Command [GUI]

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:20, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Console Watch Command [GUI]

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:21, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Watch Other Companies GUI

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:21, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

petert
Tycoon
Tycoon
Posts: 3008
Joined: 02 Apr 2009 22:43
Location: Massachusetts, USA

Re: Patch: Watch Other Companies GUI

Post by petert »

I got these errors (against 0.7.4) when making.
Attachments
make.txt
(1.46 KiB) Downloaded 107 times

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Watch Other Companies GUI

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:21, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Watch Other Companies GUI

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:21, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

petert
Tycoon
Tycoon
Posts: 3008
Joined: 02 Apr 2009 22:43
Location: Massachusetts, USA

Re: Patch: Watch Other Companies GUI

Post by petert »

Muxy wrote:Hello,

Just updated the diff file.

The two files watch_gui.h & watch_gui.cpp were missing.
Is this for the new release, OpenTTD 1.0.0-beta1?

User avatar
WWTBAM
Moderator
Moderator
Posts: 3682
Joined: 02 Apr 2005 07:01
Location: Sydney NSW Antipodea
Contact:

Re: Patch: Watch Other Companies GUI

Post by WWTBAM »

If this was updated for nightly versions, I could see a potential pthe use for this patch if combined with an older patch that allows OpenTTD to be run as a windows screensaver.
Formerly known as r0b0t_b0y2003, robotboy, roboboy and beclawat. The best place to get the most recent nightly builds of TTDPatch is: http://roboboy.users.tt-forums.net/TTDPatch/nightlies/

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Watch Other Companies GUI

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:21, edited 3 times in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

petert
Tycoon
Tycoon
Posts: 3008
Joined: 02 Apr 2009 22:43
Location: Massachusetts, USA

Re: Patch: Watch Other Companies GUI

Post by petert »

I got an error when trying to compile your patch against 1.0.0-beta3:

Code: Select all

3>command.obj : error LNK2001: unresolved external symbol "public: void __thiscall WatchCompany::OnDoCommand(struct TinyEnumT<enum Owner>,unsigned int)" (?OnDoCommand@WatchCompany@@QAEXU?$TinyEnumT@W4Owner@@@@I@Z)
3>toolbar_gui.obj : error LNK2001: unresolved external symbol "void __fastcall ShowWatchWindow(enum Owner)" (?ShowWatchWindow@@YIXW4Owner@@@Z)
3>..\objs\Win32\Release\\openttd.exe : fatal error LNK1120: 2 unresolved externals
Attachments
BuildLog.zip
(9.16 KiB) Downloaded 70 times

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Watch Other Companies GUI

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:22, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

petert
Tycoon
Tycoon
Posts: 3008
Joined: 02 Apr 2009 22:43
Location: Massachusetts, USA

Re: Patch: Watch Other Companies GUI

Post by petert »

I've managed to get it compiling on MSYS. I've also made a diff with the changes to the vcprojects included.

Also, I thought it was funny that you can use the watch gui on the main screen :-)
Attachments
watchgui_main-screen.PNG
watchgui_main-screen.PNG (105.36 KiB) Viewed 2396 times

petert
Tycoon
Tycoon
Posts: 3008
Joined: 02 Apr 2009 22:43
Location: Massachusetts, USA

Re: Patch: Watch Other Companies GUI

Post by petert »

Ok, the MSVC compile now works on my system with watch GUI. You can find 0.7.5 binaries at my dev site: http://users.tt-forums.net/petert/dev/Watch_GUI/

User avatar
Muxy
Engineer
Engineer
Posts: 80
Joined: 05 Oct 2008 17:06
Location: Goulp, FR
Contact:

Re: Patch: Watch Other Companies GUI

Post by Muxy »

[..]
Last edited by Muxy on 19 Sep 2010 15:22, edited 1 time in total.
Pourquoi faire simple quand on peut faire compliqué ?
KISS - Keep It Simple, Stupid.
Open TTD Goulp Web Service
OpenTTD Goulp Web Forum

User avatar
Ammler
President
President
Posts: 953
Joined: 18 Jun 2006 18:18
Location: Switzerland
Contact:

Re: [Patch] Watch Other Companies GUI

Post by Ammler »

Hello

Might it be possible to make (and use for releases) a bit less "cheatish" version of that patch. Something like

- only watch other companies with rcon
- only watch unpassworded companies
- everybody can only watch the own company

I am fully aware someone could still patch it to use with the features you have already. But somehow the way to do it should be made a bit harder. At least no easy access to binaries.

I guess, from develpment view, there is no possibility to make something against this feature.

Don't get me wrong, it is a nice patch, we use this kind already quite some time on #openttdcoop too. But for competition games, it is a simply cheat, specially if not everyone has access to that patch.

Greets
Ammler

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 6 guests