[Patch] Improved Build Station GUI [r19159]

[Dante123]

i'm kind of new to the patching,

but this patch wont work for ottd 0.7.2 right ? (i seem to get some errors when patching for latest version)

[2007Alain2007]

I going with it need updateing

If you are going to do that please update from the frist post that is V4 not V3

[Thief^]

My mistake, I only saw "v3" on the last page, so I thought that's all there was. scoz's post just says "updated to 16206", not "v4".

Terkhen's seems to be v3, because it's in the patchpack I play with and that doesn't have the "tooltips now show up on mouseover instead of right-click" from v4.

[Dante123]

compiling the version 4 will give me these errors:

i hope this helps you

[Rubidium]

Apply patches to the revision they were made from. Anything else and you need to know what you're doing/what you need to do when it goes wrong, which requires knowledge of how OpenTTD is implemented.

By the kind of posts you have made lately I am fairly certain you don't have enough knowledge. As such you should keep to applying patches to ONLY the revision they were made from.

[2007Alain2007]

or look in to learning more about patching the game i am still learning myself

but it takes A LOT of time and if you anit got the time theres not much point in trying

[Dante123]

aah ok, starting to understand it more and more
i think i'll dive into ottd some more

[2007Alain2007]

have some music in the back ground or your go loopy lol and all ways keep an eye on the time

[neob]

any hope for this one?




it will going to make thing much easier to build those custom stations

[NekoMaster]

Would it be possible to get a update for r19009?

[Ammler]

Hmm, I guess, I need to unsubscribe from this thread.

Now the 2nd time, I am excited about a update and then I see just a request for a update.

I hope next mail will be a bit more "contentish"...

Greets
Ammler

[tobols]

And a 3rd time. Guess I should unsubscribe too.

Oh, did I just make it the 4th?

[sbr]

Attached is an update of this patch to r19054 based on v3-r15948. There is no functional change and the support of RTL languages isn't properly working.

[NekoMaster]

How do you make patches work for a newer revison when theres nothing new in the patch. Do you just have to change some numbers and words around?

[petert]

How do you make patches work for a newer revison when theres nothing new in the patch. Do you just have to change some numbers and words around?

Developers change code which then causes rejections when the patch is applied. Sure, you could leave the rejections unchecked, but then your make would probably fail. Solving the rejections usually takes some kind of C++ skill, especially when someone like sbr had to update it 4000 revisions

[NekoMaster]

How do you make patches work for a newer revison when theres nothing new in the patch. Do you just have to change some numbers and words around?

Developers change code which then causes rejections when the patch is applied. Sure, you could leave the rejections unchecked, but then your make would probably fail. Solving the rejections usually takes some kind of C++ skill, especially when someone like sbr had to update it 4000 revisions

Ahh... would you happen to have a cargo dist patch that will work with the most recent one here?

[petert]

Update to current trunk:

[sbr]

A bit of work on this patch:

• Tooltips always shown in black
• Window height adapts itself to fit station coverage area text
• Take current font height in account to define window size
• Keep selected station class and type visible over resize
• Ready for RTL languages
• Reuse previous window size on next invocation
• Station class matrix enlarge to fit the widest class name

Todo: Directly replace the current 'newstations gui' instead of introducing a third 'station build' gui. That should clean up a lot of the patched code.

Thanks to scoz for the previous versions of this patch.

[scoz]

Thanks to scoz for the previous versions of this patch.

Thanks to you for overhauling my cruddy code. I felt so bad not having the time to learn the nested widgets system and leaving this patch in a pretty bad state due to school :\ Not only did you do that, you managed to fix every annoyance I had with the stupid thing I spent so many hours trying to get those darn tooltips to stay black, I swear that function didn't work like that before or something, who knows.

I'll update the first post with a link to yours in a minute with some serious props, thank you so much for updating this

[WWTBAM]

The patch suplied seems to look for english.txt under src/a/lang/english.txt which doesn't exist.
Edit: I am trying to patch on Windows 7 with Tortoise Merge.