[Patch] Improved Build Station GUI [r19159]
Moderator: OpenTTD Developers
Re: [Patch] Improved Build Station GUI
Updated to nightly and it should actually patch this time(doh). Should patch cleaning for a couple days back as well.
Download in first post.
Download in first post.
- planetmaker
- OpenTTD Developer
- Posts: 9432
- Joined: 07 Nov 2007 22:44
- Location: Sol d
Re: [Patch] Improved Build Station GUI
Thanks for the update - this now really works fine
I've included this version in my client-side patch pack: (diff file).
I've included this version in my client-side patch pack: (diff file).
OpenTTD: manual | online content | translations | Wanted contributions and patches
#openttdcoop: blog | wiki | public server | DevZone | NewGRF web translator
DevZone - home of the free NewGRFs: OpenSFX | OpenMSX | OpenGFX | Swedish Rails | OpenGFX+ Trains|RV|Industries|Airports|Landscape | NML
-
- Chief Executive
- Posts: 658
- Joined: 11 Nov 2007 12:06
- Contact:
Re: [Patch] Improved Build Station GUI
hi i cant seem to add your patch and Copy & Paste patch
i am thinknig its becuse of theres lines in copy and pasted ===================================================================
--- src/rail_gui.cpp (revision 15892)
+++ src/rail_gui.cpp (working copy)
@@ -30,7 +30,7 @@
#include "table/sprites.h"
#include "table/strings.h"
-static RailType _cur_railtype; ///< Rail type of the current build-rail toolbar.
+RailType _cur_railtype; ///< Rail type of the current build-rail toolbar.
static bool _remove_button_clicked; ///< Flag whether 'remove' toggle-button is currently enabled
static DiagDirection _build_depot_direction; ///< Currently selected depot direction
static byte _waypoint_count = 1; ///< Number of waypoint types
Index: src/rail_gui.h
===================================================================
--- src/rail_gui.h (revision 15892)
+++ src/rail_gui.h (working copy)
@@ -7,6 +7,8 @@
#include "rail_type.h"
+extern RailType _cur_railtype;
+
void ShowBuildRailToolbar(RailType railtype, int button);
void ReinitGuiAfterToggleElrail(bool disable);
bool ResetSignalVariant(int32 = 0);
but i have a look at it a bit more
i am thinknig its becuse of theres lines in copy and pasted ===================================================================
--- src/rail_gui.cpp (revision 15892)
+++ src/rail_gui.cpp (working copy)
@@ -30,7 +30,7 @@
#include "table/sprites.h"
#include "table/strings.h"
-static RailType _cur_railtype; ///< Rail type of the current build-rail toolbar.
+RailType _cur_railtype; ///< Rail type of the current build-rail toolbar.
static bool _remove_button_clicked; ///< Flag whether 'remove' toggle-button is currently enabled
static DiagDirection _build_depot_direction; ///< Currently selected depot direction
static byte _waypoint_count = 1; ///< Number of waypoint types
Index: src/rail_gui.h
===================================================================
--- src/rail_gui.h (revision 15892)
+++ src/rail_gui.h (working copy)
@@ -7,6 +7,8 @@
#include "rail_type.h"
+extern RailType _cur_railtype;
+
void ShowBuildRailToolbar(RailType railtype, int button);
void ReinitGuiAfterToggleElrail(bool disable);
bool ResetSignalVariant(int32 = 0);
but i have a look at it a bit more
For Community Integrated Version http://code.google.com/p/civopenttd/
- planetmaker
- OpenTTD Developer
- Posts: 9432
- Joined: 07 Nov 2007 22:44
- Location: Sol d
Re: [Patch] Improved Build Station GUI
You posted some part of a diff file ... which tells us nothing about any conflict as I see it.2007Alain2007 wrote:hi i cant seem to add your patch and Copy & Paste patch
Besides, it's not intention of this patch to be compatible with copy & paste
OpenTTD: manual | online content | translations | Wanted contributions and patches
#openttdcoop: blog | wiki | public server | DevZone | NewGRF web translator
DevZone - home of the free NewGRFs: OpenSFX | OpenMSX | OpenGFX | Swedish Rails | OpenGFX+ Trains|RV|Industries|Airports|Landscape | NML
-
- Chief Executive
- Posts: 658
- Joined: 11 Nov 2007 12:06
- Contact:
Re: [Patch] Improved Build Station GUI
sorry it was my fault
For Community Integrated Version http://code.google.com/p/civopenttd/
Re: [Patch] Improved Build Station GUI
I tried the new GUI and I am missing one little thing from the old GUI - in new GUI, you select station tiles by image, not by name. However, the name sometimes contain useful information in some sets, so I think it would be nice for the name to be shown for currently selected item too (perhaps somewhere near the Cargo information?).
While you can query the name by using right mouse button, just displaying it for selected station would mean less clicks :)
While you can query the name by using right mouse button, just displaying it for selected station would mean less clicks :)
If you need something, do it yourself or it will be never done.
My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility
Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
My patches: Extra large maps (1048576 high, 1048576 wide) (FS#1059), Vehicle + Town + Industry console commands (FS#1060), few minor patches (FS#2820, FS#1521, FS#2837, FS#2843), AI debugging facility
Other: Very large ships NewGRF, Bilbo's multiplayer patch pack v5 (for OpenTTD 0.7.3)
Re: [Patch] Improved Build Station GUI
Fewer! Clicks are countable.Bilbo wrote:less clicks
If it is countable, there are fewer of them. If it's uncountable, there is less of it.
To get a good answer, ask a Smart Question. Similarly, if you want a bug fixed, write a Useful Bug Report. No TTDPatch crashlog? Then follow directions.
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
Projects: NFORenum (download) | PlaneSet (Website) | grfcodec (download) | grfdebug.log parser
-
- Route Supervisor
- Posts: 415
- Joined: 07 Oct 2004 10:05
Re: [Patch] Improved Build Station GUI
I updated the rail_gui.cpp file from the original patch to update current string changes in trunk. I hope the original patch creator doesn't mind. I really like this patch, it helps a lot!
- Attachments
-
- v3.1-imp-station-build-rail_gui_update.diff
- Updated strings.
- (19.53 KiB) Downloaded 147 times
-
- Tycoon
- Posts: 1828
- Joined: 10 Jul 2006 00:43
- Location: Spain
Re: [Patch] Improved Build Station GUI
I agree. These strings should be displayed.Bilbo wrote:I tried the new GUI and I am missing one little thing from the old GUI - in new GUI, you select station tiles by image, not by name. However, the name sometimes contain useful information in some sets, so I think it would be nice for the name to be shown for currently selected item too (perhaps somewhere near the Cargo information?).
While you can query the name by using right mouse button, just displaying it for selected station would mean less clicks
Sorry if my english is too poor, I want learn it, but it isn't too easy.
- [list][*]Why use PNG screenshots in 8 bpp games.
[*]Caravan site New Industry. · Spain set. · Some spanish trains for locomotion[*]Favourites:GRVTS · ECS · FIRS
Re: [Patch] Improved Build Station GUI
Hi,
I like the look of this patch very much, and wanted to apply it but unfortunately the compilation doesn't work! I am running it on Mac OSX 10.4.11 with the latest nightlies, the ./configure only works if i use --without-makedepend, but the make bundle keeps coming up with errors... (see below) Otherwise i've done exactly as prescribed on the wiki...
Thanks for any help...
I like the look of this patch very much, and wanted to apply it but unfortunately the compilation doesn't work! I am running it on Mac OSX 10.4.11 with the latest nightlies, the ./configure only works if i use --without-makedepend, but the make bundle keeps coming up with errors... (see below) Otherwise i've done exactly as prescribed on the wiki...
Any ideas why this might be?[SRC] DEP CHECK (all files)
make[1]: *** [Makefile.dep] Error 1
make: *** [all] Error 2
Thanks for any help...
- planetmaker
- OpenTTD Developer
- Posts: 9432
- Joined: 07 Nov 2007 22:44
- Location: Sol d
Re: [Patch] Improved Build Station GUI
I don't have an idea so far, it works for me - if applied to the correct version e.g. not to latest trunk.
What is the result, if you do a "normal" ./configure without any further options?
make failed at some earlier stage. There should be more to the error message which you skipped; you cut away a bit too much, maybe paste that output, too.
What is the result, if you do a "normal" ./configure without any further options?
make failed at some earlier stage. There should be more to the error message which you skipped; you cut away a bit too much, maybe paste that output, too.
OpenTTD: manual | online content | translations | Wanted contributions and patches
#openttdcoop: blog | wiki | public server | DevZone | NewGRF web translator
DevZone - home of the free NewGRFs: OpenSFX | OpenMSX | OpenGFX | Swedish Rails | OpenGFX+ Trains|RV|Industries|Airports|Landscape | NML
-
- Chief Executive
- Posts: 658
- Joined: 11 Nov 2007 12:06
- Contact:
Re: [Patch] Improved Build Station GUI
patch file with chrissicom fixs
and a build for R16135
and a build for R16135
For Community Integrated Version http://code.google.com/p/civopenttd/
Re: [Patch] Improved Build Station GUI
Updated to 16206. Fiddled with the layout some.
Changed it so tooltips now show up on mouseover instead of right-click as an experiment. Let me know what you think.
This of course brings to light the fact that the tooltip colors keep changing randomly. Going in to the tooltips class draw function and forcing the multiline string to draw TC_BLACK makes no difference. Anybody have any ideas on how to fix this? It seems to rotate between white, pink, grey, and whether or not it has a border, so I'm really at a loss as to why this is happening ;__;
Diff in the first post.
Changed it so tooltips now show up on mouseover instead of right-click as an experiment. Let me know what you think.
This of course brings to light the fact that the tooltip colors keep changing randomly. Going in to the tooltips class draw function and forcing the multiline string to draw TC_BLACK makes no difference. Anybody have any ideas on how to fix this? It seems to rotate between white, pink, grey, and whether or not it has a border, so I'm really at a loss as to why this is happening ;__;
Diff in the first post.
Re: [Patch] Improved Build Station GUI
So we got nested widgets for the build gui now. I'll try and have an updated patch sometime this week.
Re: [Patch] Improved Build Station GUI
Later which week?
I would quite like an updated version of this patch.
I would quite like an updated version of this patch.
Melt with the Shadows,
Embrace your destiny...
Embrace your destiny...
Re: [Patch] Improved Build Station GUI
This is an update of the version found at planetmaker's patch queue. I don't remember if I only applied it to current trunk or if I had to make soem changes to fix rejects. Anyways there's no changes to features.
- Attachments
-
- improved_build_station_gui_r16750.diff
- (23.09 KiB) Downloaded 170 times
Spanish translation of OpenTTD
Extended heightmaps
Have fun, don't quarrel too much and add as many advanced settings as you can.
Extended heightmaps
Have fun, don't quarrel too much and add as many advanced settings as you can.
Re: [Patch] Improved Build Station GUI
Thanks, applied cleanly to my patch pack
Melt with the Shadows,
Embrace your destiny...
Embrace your destiny...
-
- Chief Executive
- Posts: 658
- Joined: 11 Nov 2007 12:06
- Contact:
Re: [Patch] Improved Build Station GUI
Was this V4 or V3 of this patch
For Community Integrated Version http://code.google.com/p/civopenttd/
Re: [Patch] Improved Build Station GUI
There is no v4.
Melt with the Shadows,
Embrace your destiny...
Embrace your destiny...
-
- Chief Executive
- Posts: 658
- Joined: 11 Nov 2007 12:06
- Contact:
Re: [Patch] Improved Build Station GUI
Thief^
Have you looked at the frist post on the fist page
Have you looked at the frist post on the fist page
For Community Integrated Version http://code.google.com/p/civopenttd/
Who is online
Users browsing this forum: No registered users and 25 guests