Tib's Patch Pack v2.6 (r14004)

[SVW-Gigant]

Hello, I have downloaded the r13704 and there are nice patches in it, but the opponents dont work at all! They built a few railroad crosses and nothing else. Whats happen? And I also have problems with the sound. On right side of the screen, there is normal (only on my left box), on the left, there is nothing with crossover. And only 1 sound channel!?! Other patches worked well.
Grz

[Chico008]

true, i didn't mean that.
i was telling myself the intro is pretty noisy normaly.

only 1 sound playing at a time.
and midi music doesn't work in the game.

[Nickel_Plate]

Have downloaded above patch and set autosave to 1 WEEK but at the end of each month I get

Assertion failed at c:\temp\openttd\patchpack\src\tile_map.h:70: tile < MapSize()

This also happens on the Russian patch pack

Is this anything todo with Bigger maps

[zooks]

what mapsize you play?

[Chico008]

juts got a bug on the same file :

Code: Select all

openttd: /srv/OTTD/src/tile_map.h:135: Owner GetTileOwner(TileIndex): Assertion `!IsTileType(tile, MP_HOUSE)' failed.

Playing in multi on a 1024 sided map.

[SVW-Gigant]

For players with oppunent companies, there exists a temporary resolution: You can start a map on 0.6.1 and wait a time, until the oppunents build enough an than you can switch your version to r13704. Now load and play with daylength you want. The other companies have unfortunately no actitity during this time, than you can switch back...

[ostlandr]

Hey! Thanks again for the patchpack.

Had a game pack up on me the other day- first crash-to-desktop with OTTD ever. Was running r13481. Related files are attached, but probably moot since v2.3 (r13704) is out. I installed r13704, but have two problems:

1. No sound at all.

2. Savegames from the previous verson (edit: of the patchpack) don't load ("broken savegame-invalid chunk size"). Is this expected? The games still load in the old version (of the patchpack), but crash & burn- "too many orders". Edit: sometimes the saves load, sometimes they don't, and I get the fatal application error and OTTD crashes to desktop.

[CommanderZ]

This pack has YAPP, the saves are incompatible with those saved without YAPP.

[ostlandr]

I guess I wasn't clear. I was running the previous version of the patchpack (with YAPP, which I love) and then upgraded to v2.3 of the patchpack.

This pack has YAPP, the saves are incompatible with those saved without YAPP.

[Tiberius]

The left-channel-only issue was a new bug introduced by r13695:
http://hg.openttd.org:8000/trunk.hg/rev/e5069c3b836d
see that repeating buffer[0] ?
it's fixed in r13706, so perhaps I'll upload a new binary later.

And about the savegame issue.

First I want to make it clear that I'm not the original author of these patches. Though I tried to fix some obvious bugs that prevents it from compiling/running, I'm by no means thoroughly understand how these patches work down to every bit, so I won't be able to fix it if they really do something that break savegame compatibility ...

[ostlandr]

Understood. Thanks! I figured out that my left speaker wasn't working.

Just putting everything into a working binary is more than good enough. For free, I don't even expect the release versions of OTTD to be perfect.

BTW I have been playing aroud with the daylength option. Wow! What a difference to station ratings, industry production, etc. I may actually start a map with 6 or 8 tile stations/signal blocks, and rather than run 8 car trains, run 12/16 car trains half as often. Will set the weight modifier lower than 10 and still be able to justify 2 and 3 units on a train- at a good profit. SD45s snaking around the hills with long coal drags. . .

Anyway, the patchpack as is works perfectly for the way I play. Thanks again.

The left-channel-only issue was a new bug introduced by r13695:
http://hg.openttd.org:8000/trunk.hg/rev/e5069c3b836d
see that repeating buffer[0] ?
it's fixed in r13706, so perhaps I'll upload a new binary later.

And about the savegame issue.

First I want to make it clear that I'm not the original author of these patches. Though I tried to fix some obvious bugs that prevents it from compiling/running, I'm by no means thoroughly understand how these patches work down to every bit, so I won't be able to fix it if they really do something that break savegame compatibility ...

[Chico008]

Code: Select all

openttd: /srv/src/train.h:33: bool IsFrontEngine(const Vehicle*): Assertion `v->type == VEH_TRAIN' failed.

:/

[Chico008]

BUGS when launching a dedicated server on debian.

Code: Select all

Error: EngineRenews: failed loading savegame: too many EngineRenews
openttd: /srv/r13810-HFR_source/src/openttd.cpp:143: void error(const char*, ...): Assertion `0' failed. <= BUG
Your 'OPENTTDW.GRF' file is corrupted or missing! The file was part of your installation. <= not a problem
dbg: [net] [core] starting network...
dbg: [net] [core] network online, multiplayer available
dbg: [net] Detected broadcast addresses:
dbg: [net] 0) 88.191.31.255
Error: EngineRenews: failed loading savegame: too many EngineRenews <= BUG
openttd: /srv/r13810-HFR_source/src/openttd.cpp:143: void error(const char*, ...): Assertion `0' failed. <= BUG

and then the server crash.

unplayable on multi.

[trainboy2004]

Do you have YAPP v7 or v8 in your pack?

[Tiberius]

I used yapp-v8.4_r13809.patch in the 2.4 pack for r13810.

[ropiku]

I tried compiling on OS X but it gives the following error:

[SRC] Compiling group_cmd.cpp
/Users/mihai/Download/ottd/trunk/src/graph_gui.cpp: In member function 'void NewGraphWindow::MakePlayerHistoryData()':
/Users/mihai/Download/ottd/trunk/src/graph_gui.cpp:375: error: operands to ?: have different types
/Users/mihai/Download/ottd/trunk/src/graph_gui.cpp:386: error: operands to ?: have different types
make[1]: *** [graph_gui.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
mihais-macbook:trunk mihai$ uname -a
Darwin mihais-macbook 9.4.0 Darwin Kernel Version 9.4.0: Mon Jun 9 19:30:53 PDT 2008; root:xnu-1228.5.20~1/RELEASE_I386 i386

Thanks

[Chico008]

replace 0 after the ? by
OverflowSafeInt64(0)
and the compilation will work.

[ropiku]

replace 0 after the ? by
OverflowSafeInt64(0)
and the compilation will work.

Thank you, it worked.

[SVW-Gigant]

Yes, good work an the sound bug is totally away
further on its pity with the AI. May be one of the patch-experts can tear to pieces of the PP to search for the error patchfile? I dont have the time, sorry...

grz

[planetmaker]

Hi Tiberius,

your patchpack for r13810 doesn't apply nor compile for me (not current, but r13810):

Code: Select all

patching file src/order_type.h
The next patch would create the file src/ottdres.rc,
which already exists!  Assume -R? [n] yes
patching file src/ottdres.rc

patching file src/rail_map.h
The next patch would create the file src/rev.cpp,
which already exists!  Assume -R? [n] yes
patching file src/rev.cpp
Hunk #1 FAILED at 1.
File src/rev.cpp is not empty after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file src/rev.cpp.rej

Code: Select all

[LANG] Compiling language bulgarian
/Users/ingo/ottd/trunk/src/lang/brazilian_portuguese.txt:2322: warning: STR_7062_DAYS_IN_TRANSIT: template string and language string have a different # of commands

and a zillion more language issues like this

and worse

Code: Select all

[SRC] Compiling cheat.cpp
/Users/ingo/ottd/trunk/src/build_vehicle_gui.cpp: In member function 'virtual void BuildVehicleWindow::OnPaint()':
/Users/ingo/ottd/trunk/src/build_vehicle_gui.cpp:1399: warning: unused variable 'xb'

[SRC] Compiling group_gui.cpp
/Users/ingo/ottd/trunk/src/graph_gui.cpp: In member function 'void NewGraphWindow::MakePlayerHistoryData()':
/Users/ingo/ottd/trunk/src/graph_gui.cpp:375: error: operands to ?: have different types
/Users/ingo/ottd/trunk/src/graph_gui.cpp:386: error: operands to ?: have different types
make[1]: *** [graph_gui.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2