Patch: Autoreplace only old vehicles

[Gollum]

Well, pardon me if I missed something, but I wasn't entirely satisfied with the way autoreplace & autorenew worked. What I wanted was this kind of behaviour:
1. I set autoreplace for a particular engine, but I really don't want to change ALL (maybe just recently bought) vehicles to the new type.
2. Engines are replaced only when they are old (needing autorenew). This requires autorenew to be on.
3. Vehicle types with no autoreplace set are renewed to the same type (if available) just like autorenew always worked.

Maybe this should be in form of some check box when setting autoreplace "route" but I had no time to get into openttd's gui system yet, so I just made it as a patch option which is saved to the config file.

Works with r12892

autoreplace_only_old1.png (11.66 KiB) Viewed 4304 times

autoreplace_only_old2.png (12.03 KiB) Viewed 4305 times

[Ar4i]

Yes especially with those train sets it would be good if you can set autoreplace to replace only the vehicles that are getting old, buthas to get into the GUI somehow because sometimes it also good idea to replace all engines of some type with new ones.

[Gollum]

Any ideas for the design?
I don't recall any similar features (tell something to do with conditions) in the game gui...
Well... Ah, there's a switch for wagon removal. Maybe a similar button next to this one will work?

[Gollum]

Update: remade as gui option in autoreplace dialog.
WORKS ONLY FOR TRAINS AT THE MOMENT.

[sulai]

I really like this idea!

I was thinking of a more general idea (with the same goal), using the concept of groups.

What if you could define "property based groups". Just as you can do using this patch: http://www.tt-forums.net/viewtopic.php?f=33&t=36648
You could define a group with old vehicles in there and apply the mass command "replace".

Looking at the ottd code, it's not easy to apply "replace" on those general groups.

Also see http://wiki.openttd.org/index.php/User: ... ehicleList the chapters "propterty based groups" and "changes on autoreplace".

[Ar4i]

BTW This patch is a very good idea to use in conjunction with some trainsets like cnidarian, because you loco's would often get obsolete w/o actually having notably better new locos and thus replacing all your trains is very inefficient, so replacing only the old ones is the best solution at least until the GRF starts handling this by itself and forces the autoreplace to choose some new engine automatically.