[Patch] Industry Station Names (v1; r12436)
Moderator: OpenTTD Developers
Re: [Patch] Industry Station Names (r12044)
Arrrr, fair enough.
He's like, some kind of OpenTTD developer.
-
- Engineer
- Posts: 111
- Joined: 08 Feb 2007 11:59
- Skype: a.locritani
- Location: Italy
Re: [Patch] Industry Station Names (v1; r12436)
Sorry for resurrecting this post: I only want to signal that with a big help of Micheal Blunk, I wrote a grf that does (almost) what your patch does. I know that now it's doesn't works for OTTD, but when property 24 is implemented, I hope it can be useful.
- Vaulter
- Traffic Manager
- Posts: 185
- Joined: 21 Dec 2004 05:35
- Skype: andrey-zaharov
- Location: St. Petersburg, Russia
- Contact:
Re: [Patch] Industry Station Names (v1; r12436)
a.locritani wrote:Sorry for resurrecting this post: I only want to signal that with a big help of Micheal Blunk, I wrote a grf that does (almost) what your patch does. I know that now it's doesn't works for OTTD, but when property 24 is implemented, I hope it can be useful.
But, judging by posts in this threads, this patch works with any industriesPlease note that this grf is not intended to be used with another industries' grf - only use it with default industries (thanks Michael for pointing it out)
Re: [Patch] Industry Station Names (v1; r12436)
It's also 2 years old, and over 8000 revisions out of date.
Which would seem to make it rather obsolete all the same.
Which would seem to make it rather obsolete all the same.
Re: [Patch] Industry Station Names (v1; r12436)
Yes. On the other hand the patch is now nearly 2 years old while that newgrf still works. Also that patch will never be included in trunk (since it can be done by a newgrf). So what exactly is the reason to resurrect this topic?
- Vaulter
- Traffic Manager
- Posts: 185
- Joined: 21 Dec 2004 05:35
- Skype: andrey-zaharov
- Location: St. Petersburg, Russia
- Contact:
Re: [Patch] Industry Station Names (v1; r12436)
read carefully. Again:Yexo wrote:Yes. On the other hand the patch is now nearly 2 years old while that newgrf still works. Also that patch will never be included in trunk (since it can be done by a newgrf). So what exactly is the reason to resurrect this topic?
Please note that this grf is not intended to be used with another industries' grf - only use it with default industries (thanks Michael for pointing it out)
Re: [Patch] Industry Station Names (v1; r12436)
Yes, I know that. Did you also read my answer to that?
1. The patch is very old, it needs to be updated to actually work.
2. This patch (even if updated) will never be included in trunk.
3. The newgrf still works, and if you want the same behavior while using industry newgrfs you're better of posting in those newgrf topics to ask them to implement this too.
Who is going to update a patch that has exactly 0 chance of getting in trunk?
1. The patch is very old, it needs to be updated to actually work.
2. This patch (even if updated) will never be included in trunk.
3. The newgrf still works, and if you want the same behavior while using industry newgrfs you're better of posting in those newgrf topics to ask them to implement this too.
Who is going to update a patch that has exactly 0 chance of getting in trunk?
- Vaulter
- Traffic Manager
- Posts: 185
- Joined: 21 Dec 2004 05:35
- Skype: andrey-zaharov
- Location: St. Petersburg, Russia
- Contact:
Re: [Patch] Industry Station Names (v1; r12436)
1. No problemYexo wrote:Yes, I know that. Did you also read my answer to that?
1. The patch is very old, it needs to be updated to actually work.
2. This patch (even if updated) will never be included in trunk.
3. The newgrf still works, and if you want the same behavior while using industry newgrfs you're better of posting in those newgrf topics to ask them to implement this too.
Who is going to update a patch that has exactly 0 chance of getting in trunk?
2. Didn't even mind
3. Ok.
Patch Updated
- Attachments
-
- industry-stationnames.patch
- against tags/1.0.3
- (5.85 KiB) Downloaded 153 times
- JacobD88
- Chief Executive
- Posts: 708
- Joined: 16 Aug 2008 17:51
- Location: Long Eaton, Nottinghamshire. UK
- Contact:
Re: [Patch] Industry Station Names (v1; r12436)
Thanks vaulter , this is much more useful to me than requesting that all the NewGRF Industry authors update their GRFs or altering them myself where we are allowed to. It's a shame this is unlikely to make it into trunk. A centralised feature to control station naming by industry is much more appealing to me than having to rely on the GRF authors wanting to include that feature as it gives me control without having to mod GRFsVaulter wrote:Patch Updated
High-Functioning Autistic & Proud... National Autistic Society * Asperger Foundation
My (O)TTD Work...BIGGER DEPOTS (REL.) & SERVICING-STATIONS (WIP) * Advanced DEPOT DESIGNS * SCREENSHOTS
My personal website is occasionally here - sometimes it's just the family site - it's basically a lucky dip
My (O)TTD Work...BIGGER DEPOTS (REL.) & SERVICING-STATIONS (WIP) * Advanced DEPOT DESIGNS * SCREENSHOTS
My personal website is occasionally here - sometimes it's just the family site - it's basically a lucky dip
Re: [Patch] Industry Station Names (v1; r12436)
Out of curiosity, does that patch only apply against 1.0.3, or trunk as well? If trunk plays nice with it, I've got an idea I want to experiment with using this patch.
- Vaulter
- Traffic Manager
- Posts: 185
- Joined: 21 Dec 2004 05:35
- Skype: andrey-zaharov
- Location: St. Petersburg, Russia
- Contact:
Re: [Patch] Industry Station Names (v1; r12436)
You just should to check. Patch is very simple to have any issues applying to trunk.Gremnon wrote:Out of curiosity
Re: [Patch] Industry Station Names (v1; r12436)
I'm having a few slight arguments with the computer at the moment that are preventing me from actually checking, which is why I asked. Will check myself soon as I can.
-
- Engineer
- Posts: 36
- Joined: 06 Jan 2010 18:06
Re: [Patch] Industry Station Names (v1; r12436)
The Patch didn't apply anymore after the changes in
I am attaching an updated patch against r21459.(svn r21444) -Codechange: compute the type of elements in the argv string array on the fly and compare it with the type set by strgen
- Attachments
-
- industry_stationnames_21459.diff
- Patch for Industry Station Names against trunk r21459
- (6.5 KiB) Downloaded 144 times
-
- Engineer
- Posts: 36
- Joined: 06 Jan 2010 18:06
Re: [Patch] Industry Station Names (v1; r12436)
These changes broke the patch:
Attaching the patch against trunk r22502.(svn r22258) -Codechange: introduce a wrapper class to clean up the arguments to FormatString
- Attachments
-
- industry_stationnames_r22502.diff
- (6.52 KiB) Downloaded 134 times
-
- Engineer
- Posts: 36
- Joined: 06 Jan 2010 18:06
Re: [Patch] Industry Station Names (v1; r12436)
Patch updated to apply against current trunk
- Attachments
-
- industry_stationnames_r22502.diff
- (6.52 KiB) Downloaded 132 times
-
- Engineer
- Posts: 36
- Joined: 06 Jan 2010 18:06
Re: [Patch] Industry Station Names (v1; r12436)
Updated to current trunk
- Attachments
-
- industry_stationnames_r22958.diff
- (6.52 KiB) Downloaded 170 times
Re: [Patch] Industry Station Names (v1; r12436)
Update to latest nightly, and also a shot at the coding style used for openttd
Edit: Oh yes, I changed the distance from 4 to 3, so stations will get the industry name only if it services the industry.
Edit: Oh yes, I changed the distance from 4 to 3, so stations will get the industry name only if it services the industry.
- Attachments
-
- Station_Names_From_Industries_r25754.patch
- (5.07 KiB) Downloaded 151 times
Re: [Patch] Industry Station Names (v1; r12436)
Hi there.
I start by thanking you so much because this patch, although not dramatic, is SO nice to have, especially when you have a big map and you want remember where things are: THANK YOU.
And... I bring you good news: I have just applied it to r26156 and it works just fine! Among the many patches I tried, this is the first one that just works without complaining
So, happy transporting everyone!
I start by thanking you so much because this patch, although not dramatic, is SO nice to have, especially when you have a big map and you want remember where things are: THANK YOU.
And... I bring you good news: I have just applied it to r26156 and it works just fine! Among the many patches I tried, this is the first one that just works without complaining
So, happy transporting everyone!
Re: [Patch] Industry Station Names (v1; r12436)
Good enough having the industry type (or resource type) in the station name, but when multiple industries are within the area of a station, names could be {Town} Industries, {Town} Industrial Park, etc.
So we could have the following stations:
Sometown Coal Mines
Sometown Factory
Sometown Power Plant
Sometown Iron Ore
Sometown Farms
Sometown Industries
Sometown Oil Wells
So we could have the following stations:
Sometown Coal Mines
Sometown Factory
Sometown Power Plant
Sometown Iron Ore
Sometown Farms
Sometown Industries
Sometown Oil Wells
Skippern
OpenTTD Mac user
OpenTTD Mac user
Re: [Patch] Industry Station Names (v1; r12436)
Shouldn't be too hard to add a multiple industries check in, would have to go in just before the added industry check...
Who is online
Users browsing this forum: No registered users and 46 guests