Updated extra-large-maps patch, version 12 (for r23992)

[planetmaker]

That's a general trunk bug with the SE as found in r20773: http://bugs.openttd.org/task/4116

[Wasila]

OK, that should solve the first one. How about the second?

Thanks,
Wasila

[Sveen]

I'm probably an idiot for asking this, but here goes... Is there a way to get this patch in the standard OpenTTD 1.0.3 downloaded from openttd.org?

[Lord Aro]

no (unless you bump the patch yourself), but you can download the diff from the previous page and compile it to that version of trunk

EDIT: also, @devs: why hasn't this been included yet?

[Alberth]

as you may have expect, "no".

patches here are source patches, meaning you have to pull/download the source code, apply the patch, and recompile.

Even if there would be a version of the patch compatible with 1.0.3, if you did the above, you have something different than standard 1.0.3.

It is a good custom to also give the program a different number then, to eliminate confusion, and desyncs, and to prevent people giving false version numbers in problem discussions and bug reports.

@lord aro:
What's the point, as in, why is 2Kx2K not enough?
A single player is never going to fill such a map, it seems quite useless for MP (openttdcoop stops at 1e6 tiles already)

[Sveen]

no (unless you bump the patch yourself), but you can download the diff from the previous page and compile it to that version of trunk

EDIT: also, @devs: why hasn't this been included yet?

Tried that earlier today, but I've got the same problems as the guy on the bottom of last page

[Lord Aro]

in that case it's up to chillcore (or someone else) to fix it, as i can't

[Bilbo]

What's the point, as in, why is 2Kx2K not enough?
A single player is never going to fill such a map, it seems quite useless for MP (openttdcoop stops at 1e6 tiles already)

Well, point of this patch is that it sort of "moves" the limit to just three constants - so if anybody decides to raise the limit for any reason, he just redefines these constants in the source, recompile and he's done. Plus, with the default constants it adds posibility to use larger map sides, while keeping the same maximal number of tiles plus you can for example play on noodly map, like 4K x 256, where you can still make quite long efficient routes on relatively small space.

Also, I think I'll have look at the patch, seems it get somewhat outdated since the last time I've updated it :)

[Eddi]

what i always wondered: how does this patch handle "patch variable 13" (map size information)?

[Bilbo]

It does not handle it, because I didn't knew there is such variable.

I looked into source where OpenTTD replies to this query and there are 4 bits for individual map dimensions, specified in log2 (0=64 tiles, 1=128 tiles .... 15=2097152) and 8 bits for total map dimension (number of tiles), specified in log2 - 0 = 64*64, .... 255=2.37142198758024e+80 .... err no chance for map that large :)

Since maximum from my patch is 1048576 (half of GRF max) and 64M tiles (way below GRF max), this is not a problem.

In some of the tests with this patch I even tried higher limits (like 16K * 16K or 4M * 64, though you need 64 bit system for these sizes) - now I know that map side size over 2M tiles may break some NewGRFs :)

So .... not an issue for my patch, even with the version with increased limits, though now I know about one extra limit to be aware of ...

[Bilbo]

Note: I've posted updated version of the patch (for r20820) to the first post of this thread.

[ChillCore]

Hello Bilbo. thank you for the update,


You may want to have a little looksie at newgrf_debug_gui.ccp.

Below is the relevant information quoted from my patchpack thread. (Slightly out of context when posted here ...)

Also I am afraid to report a crash. According to my own investigations (I had the same problem in my own custom build), I believe that it is a result of the extra-large-maps patch. .log and .png attached.

...
...

ps: do not post 8k *8k savegames as my pc can not handle them because of the memory usage with such big maps.

Then you can't reproduce at least the first of the two crashes. Well, with any map having 16 777 216 or more tiles would allow you to reproduce it; so 4k*8k should make it possible as well. Also make sure that you've got the NewGRF debugging tools enabled and you're using the land query tool on a tile with index >= 16 777 216.

crashlog is here: http://www.tt-forums.net/viewtopic.php? ... &start=385
Two post downs is another crash that was also fixed by changing newgrf_debug_gui.cpp.
Search for "24" to easely find the 5 sweetspots.
In my patchpack I changed the 24s to 26. I have not yet checked if more places need adjustment and I can not check if 26 is enough as I can not generate 8K * 8k maps on my pc.

[Bilbo]

Well, that crash-causing function generated id's for combination of GRF feature (there are about 20 of them (+GSF_INVALID = 0xFF), I think we can assume there likely won't be more than 32 of them, at least not in near future ...)

So we need 5 bits for the feature, thus leaving 27 usable bits for the tileindex. This means we can still have 8K * 16K maps, but for 16K * 16K this would need some modification - either extending windownumber and such to 64 bits or somewhat rewriting the affected NewGRF debug window ....
I am not sure whether GSF_INVALID can appear there - if yes, then we could have another problem when changing that offset from 24 to 26 or 27.

Since 16K * 16K maps are way too slow on basically any existing processor out there (tile loop consumes way too much CPU time on that map sizes) I won't consider it much of an issue.

Edit: Updated patch with this issue fixed can be now found at first post of this thread.

[hyckor]

Please help.

When I tried to play binary, originally posted by petert http://www.tt-forums.net/download/file.php?id=123663
the game crashed on start ....
I'm playing a modified carst world scenario on TPPP 16578-v03 but air crashes are annoying me so much (more than 2300 planes in the game in world airliners liveries) - a beautiful realistic global network with only this little trouble. I suppose that no air crashes were added to trunk before 19000, so this is my only chance.

*** OpenTTD Crash Report ***

Crash at: Fri Mar 25 06:43:09 2011
In game date: 1974-01-01 (0)

Crash reason:
Exception: C0000005
Location: 005DAE60
Message: <none>

OpenTTD version:
Version: r19009M (2)
NewGRF ver: 10004a41
Bits: 32
Endian: little
Dedicated: no
Build date: Feb 4 2010 15:14:00

Registers:
EAX: 00000000 EBX: 0022F4A0 ECX: 0022F766 EDX: 00000000
ESI: FFFFFFFF EDI: 00000000 EBP: FFFFFFFF ESP: 0022F0F0
EIP: 005DAE60 EFLAGS: 00010297

Bytes at instruction pointer:
0F B6 02 84 C0 74 09 88 03 43 42 39 CB 75 F1 90 C6 03 00 39 CB 74 07 83

Stack trace:
00000000 00000000 00000000 00000000 021A0050 002575A8 00000104 004D734C
0022F4A0 00000000 0022F766 00E467B0 007C1918 00000000 FFFFFFFF 7C9101DB
77C2C3C9 00E40000 00000008 77C2C3CE 00000005 0000000D 00000010 010A4E20
0022F164 0022F140 00000038 00000000 007C1B87 00000007 00000000 0022FB2C
FFFFFFFF 00000010 0022F188 77C2C42E 00000010 00647110 00780670 0022F890
004D7541 0022F110 0022F220 FFFFFFFF 0022F220 010A3850 0022FB2C 00000001
77C35C94 77C12088 FFFFFFFF 77C2C3CE 00647110 0078154C 0022F1DC 00648AE0
0022F190 010A4E48 0000F1E8 010A4E20 0000000D 00000005 FFFFFFFF 004BF3EF
63657865 72637300 73747069 7475612F 6578656F 63732E63 00300072 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000

Operating system:
Name: Windows
Release: 5.1.2600 (Service Pack 3)
Compiler: GCC 3.4.5 "3.4.5 (mingw-vista special r3)"

Configuration:
Blitter: 8bpp-optimized
Graphics set: OpenGFX
Language: english_US.lng
Music driver: win32
Music set: NoMusic
Network: no
Sound driver: win32
Sound set: NoSound
Video driver: win32

AI Configuration (local: 255):

Libraries:
LZO: 2.03
PNG: 1.2.35
Zlib: 1.2.3

Module information:
C:\TTDX\openttd.exe handle: 0x400000 size: 5943046 crc: B9BCC8CC date: 2010-02-04 14:28:18
C:\WINDOWS\system32\ntdll.dll handle: 0x7c900000 size: 718336 crc: EA097CED date: 2010-12-09 15:15:09
C:\WINDOWS\system32\kernel32.dll handle: 0x7c800000 size: 989696 crc: 8A0508E5 date: 2009-03-21 14:06:58
C:\WINDOWS\system32\GDI32.dll handle: 0x77f10000 size: 286720 crc: B5F6B116 date: 2008-10-23 12:36:14
C:\WINDOWS\system32\USER32.dll handle: 0x7e410000 size: 578560 crc: F7C72264 date: 2008-04-14 00:12:08
C:\WINDOWS\system32\msvcrt.dll handle: 0x77c10000 size: 343040 crc: 0B7B1677 date: 2008-04-14 00:12:01
C:\WINDOWS\system32\SHELL32.DLL handle: 0x7c9c0000 size: 8462336 crc: A88619FE date: 2011-01-21 14:44:37
C:\WINDOWS\system32\ADVAPI32.dll handle: 0x77dd0000 size: 617472 crc: C9027432 date: 2009-02-09 12:10:48
C:\WINDOWS\system32\RPCRT4.dll handle: 0x77e70000 size: 590848 crc: E9ECB923 date: 2010-08-16 08:45:00
C:\WINDOWS\system32\Secur32.dll handle: 0x77fe0000 size: 56832 crc: 3D0002B7 date: 2009-06-25 08:25:26
C:\WINDOWS\system32\SHLWAPI.dll handle: 0x77f60000 size: 474112 crc: BDFA6F45 date: 2009-12-08 09:23:28
C:\WINDOWS\system32\WINMM.DLL handle: 0x76b40000 size: 176128 crc: 9676D976 date: 2008-04-14 00:12:09
C:\WINDOWS\system32\WS2_32.DLL handle: 0x71ab0000 size: 82432 crc: 7C519ECA date: 2008-04-14 00:12:10
C:\WINDOWS\system32\WS2HELP.dll handle: 0x71aa0000 size: 19968 crc: 3F24E096 date: 2008-04-14 00:12:10
C:\WINDOWS\system32\IMM32.DLL handle: 0x76390000 size: 110080 crc: C1486DA0 date: 2008-04-14 00:11:54
C:\WINDOWS\WinSxS\x86_Microsoft.Windows.Common-Controls_6595b64144ccf1df_6.0.2600.6028_x-ww_61e65202\comctl32.dll handle: 0x773d0000 size: 1054208 crc: 350BBD1B date: 2010-08-23 16:12:02
C:\WINDOWS\system32\comctl32.dll handle: 0x5d090000 size: 617472 crc: B00C920E date: 2010-08-23 16:12:04
C:\WINDOWS\system32\SHFolder.dll handle: 0x76780000 size: 25088 crc: 8009EA65 date: 2008-04-14 00:12:05
C:\WINDOWS\system32\WINTRUST.dll handle: 0x76c30000 size: 177664 crc: 10F114B4 date: 2009-12-24 06:59:40
C:\WINDOWS\system32\CRYPT32.dll handle: 0x77a80000 size: 599040 crc: F04E4319 date: 2008-04-14 00:11:51
C:\WINDOWS\system32\MSASN1.dll handle: 0x77b20000 size: 58880 crc: 63D6A79F date: 2009-09-04 21:03:36
C:\WINDOWS\system32\IMAGEHLP.dll handle: 0x76c90000 size: 144384 crc: F7A06429 date: 2008-04-14 00:11:54
C:\WINDOWS\system32\wdmaud.drv handle: 0x72d20000 size: 23552 crc: EEB914CA date: 2008-04-14 00:12:45
C:\WINDOWS\system32\msacm32.drv handle: 0x72d10000 size: 20480 crc: D5406BAE date: 2001-08-23 10:00:00
C:\WINDOWS\system32\MSACM32.dll handle: 0x77be0000 size: 71680 crc: EDE4B266 date: 2008-04-14 00:11:58
C:\WINDOWS\system32\midimap.dll handle: 0x77bd0000 size: 18944 crc: 2E6D5FD1 date: 2008-04-14 00:11:57
C:\WINDOWS\system32\uxtheme.dll handle: 0x5ad70000 size: 218624 crc: A4A915A5 date: 2008-04-14 00:12:08
C:\WINDOWS\system32\nView.dll handle: 0x10000000 size: 835654 crc: E45233A2 date: 2003-05-02 07:19:00
C:\WINDOWS\system32\PSAPI.DLL handle: 0x76bf0000 size: 23040 crc: 75BBDCAD date: 2008-04-14 00:12:03
C:\WINDOWS\system32\ole32.dll handle: 0x774e0000 size: 1288192 crc: 2C4B341E date: 2010-07-16 12:05:55
C:\WINDOWS\system32\VERSION.dll handle: 0x77c00000 size: 18944 crc: 558B1DAF date: 2008-04-14 00:12:08
C:\WINDOWS\system32\OLEPRO32.DLL handle: 0x5edd0000 size: 84992 crc: 0EFC6591 date: 2008-04-14 00:12:02
C:\WINDOWS\system32\OLEAUT32.dll handle: 0x77120000 size: 551936 crc: 1EE83658 date: 2008-04-14 00:12:02
C:\WINDOWS\system32\DDRAW.dll handle: 0x73760000 size: 279552 crc: BB2C1248 date: 2008-04-14 00:11:51
C:\WINDOWS\system32\DCIMAN32.dll handle: 0x73bc0000 size: 8704 crc: FA01F98E date: 2008-04-14 00:11:51
C:\WINDOWS\system32\NVWRSSK.DLL handle: 0x1c20000 size: 167936 crc: B1383B15 date: 2003-05-02 07:19:00
C:\WINDOWS\system32\MSCTF.dll handle: 0x74720000 size: 297984 crc: 392BE0B0 date: 2008-04-14 00:11:58
C:\WINDOWS\system32\msctfime.ime handle: 0x755c0000 size: 177152 crc: 6D3663FE date: 2008-04-14 00:10:06
C:\WINDOWS\system32\mswsock.dll handle: 0x71a50000 size: 245248 crc: FBBA0828 date: 2008-06-20 17:46:57
C:\WINDOWS\system32\hnetcfg.dll handle: 0x662b0000 size: 344064 crc: 96358152 date: 2008-04-14 00:11:54
C:\WINDOWS\System32\wshtcpip.dll handle: 0x71a90000 size: 19456 crc: F5533E87 date: 2008-04-14 00:12:10

---- gamelog start ----
---- gamelog end ----

*** End of OpenTTD Crash Report ***

[Eddi]

both r16578 and r19009 are incredibly old, besides, you likely won't be able to load your game in an updated build, as that requires a more difficult update process.

[hyckor]

so, there is no possibility to update my version by some binary compilation with no air crashes and extra large maps?
If I understand correct. Only a newer version could correctly load my scenario or save game?

[Leanden]

Sorry to perform such a massive grave dig, but does anyone know why this was abandoned?

It seems to me that with the increasing amount of memory that computers have and the fact using a larger map is an option, not being forced upon the player, then aside from any actual coding issues, this shouldnt really be a problem to run.

Or am i missing something?

[Yexo]

Same as why a lot of other patches and patch-packs disappear: the original author disappears or loses interest.

And yes, you're missing something. The limiting factor is not memory but CPU time. While CPUs do get a bit faster, they mostly get more cores which OpenTTD can't make use of.

[scififan]

I found the idea of larger maps quite appealing, so I took the liberty to once again port this patch to the current SVN revision (r23824 at the time I checked it out). Tested it a few hours with 8192*8192, takes some time to generate and load savegames, but compiles and runs OK on my Win7 x64 machine (i5 2500k with 12GB RAM and SSD).

Maybe Bilbo (or a mod) finds the time to evaluate the patch and update the original post.

[willyDK]

Hello.
I have tried to compile the file. But had no success with it.
Tried to use TortoiseSVN.
Is the file not downloadable anywhere after it is compiler?
And why are all these patch files. Why not just lie with downloadable files that can be used by novices in computer programming?
Willy