More diesel_smoke patch

Forum for technical discussions regarding development. If you have a general suggestion, problem or comment, please use one of the other forums.

Moderator: OpenTTD Developers

Post Reply
User avatar
JacobD88
Chief Executive
Chief Executive
Posts: 675
Joined: 16 Aug 2008 17:51
Location: Long Eaton, Nottinghamshire. UK
Contact:

Re: More diesel_smoke patch

Post by JacobD88 »

Bennythen00b wrote:Why isn't this in trunk? Does it have any bugs?
I love the patch by the way! :D
I don't think it has any bugs, not that i've seen yet anyway, but as SirkoZ said on the thread i created asking for this the other day (http://www.tt-forums.net/viewtopic.php? ... 30&start=0), there just doesn't seem much interest from the OTTD Devs, but lots of interest from the community, so i guess we just have to wait until a dev wants to pick it up, if they decide its for OTTD of course...

dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: More diesel_smoke patch

Post by dihedral »

thankfully it's not always the community that decides if a patch / suggestion is accepted ;-)
there are many patches that the community would like, however the community simply lacks the oversight of the project!

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

And there comes dihedral with the truth that sweeps every comment away. :-/

Everyone, minus dihedral, I thank you for your kind words, I'm glad you're enjoying the patch.
As always with my patches, they're small, simple, bugless/well tested and as enjoyable as my programming skills allow me to make them (not that I'm particularly fond on programming - it's more like the "necessary evil"). :)

dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: More diesel_smoke patch

Post by dihedral »

i actually had written a lovely post, but i thought to myself that you would not really appreciate it!
i come to that assumption that you thought my post above was directed at anybody/anything in particular rather than it being a pretty general statement applicable to any patch rejected in the history of OpenTTD and the community though strongly asking for the feature. at this point i shall kindly direct you to threads regarding 'copy & paste', 'undo knob' or 'undo button', 'random closure of industries' (i think that is enough reference) and end my comment here.

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

:-)

I am well aware, dihedral, that you meant all the "orphan" patches, you just kinda broke the array of kind posts above yours and I just couldn't resist. ;-)

dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: More diesel_smoke patch

Post by dihedral »

i thought of that post as rather "neutral" :-P hehe

User avatar
LaDoncella
Traffic Manager
Traffic Manager
Posts: 226
Joined: 28 Sep 2004 16:01
Contact:

Re: More diesel_smoke patch

Post by LaDoncella »

then just let return to the previous mood...

great patch! :P
Pipelines for the people! PIPE

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

Indeed, La Doncella.

Here's my part of returning to previous mood: new version - some tweaks, especially for diesel trains. Consider it v31. :-)

EDIT: How could I forgot - the 0.7.0 ß1 version. ;-)
Attachments
diesel_smoke_sz_finetune_r15587.patch
diff for source r15587
(3.23 KiB) Downloaded 107 times
diesel_smoke_sz_finetune_r15587_070-ß1.patch
diff for 070-ß1
(3.23 KiB) Downloaded 87 times

dihedral
Tycoon
Tycoon
Posts: 1053
Joined: 14 Feb 2007 17:48

Re: More diesel_smoke patch

Post by dihedral »

there is one thing you truly amaze me in: this is like the only patch i know of, that's been around for 13K+ revs, and has been updated most of the time ;-)

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

:lol:

Thank you, dih. If people like it I gladly update it. :-)

User avatar
HackaLittleBit
Director
Director
Posts: 550
Joined: 10 Dec 2008 16:08
Location: tile 0x0000

Re: More diesel_smoke patch

Post by HackaLittleBit »

SirkoZ

Thanks for making this patch.
I applied it and had a look at it.
If you don't mind I would like to make some comments to it.
Originally the patch started out for diesel smoke and to be honest it is that part of the patch that i like the most.
The electric sparks should be very occasional an work fine as they are now.
I also think steam works fine as it is now.

Maybe the reason it was not adopted by the devs is because they want to limit the amount of instructions in this part of the code as much as possible.

So I suggest you should propose only the "more diesel smoke patch" and don't give it as an option but simply as an improvement for the game. ("YAB" Yet Another Button).

Regards HackaLittleBit

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

Thank you for your comments, hackalittlebit.

While I agree with you - I would be happy if only the diesel_smoke part would be included - noone of the developers said anything about such a solution... Perhaps they will...

User avatar
HackaLittleBit
Director
Director
Posts: 550
Joined: 10 Dec 2008 16:08
Location: tile 0x0000

Re: More diesel_smoke patch

Post by HackaLittleBit »

Made a tiny patch just with diesel smoke from your patch.
Tell me if you mind
If you want I'll take it away.

Maybe the devs will react?

regards HackaLittleBit
Attachments
diesel_only_r15590.patch
(486 Bytes) Downloaded 94 times

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

Thanks - that's OK, but I would really add the upper line too - it additionally prevents train from smokin' :-) when player stops it or when train is entering the station, slowing down. Also I would add the comments. Oh what the heck I'll quickly paste it together. :-)
Attachments
diesel_smoke_only_sz_r15591.patch
diesel diff
(1.72 KiB) Downloaded 97 times

User avatar
LaDoncella
Traffic Manager
Traffic Manager
Posts: 226
Joined: 28 Sep 2004 16:01
Contact:

Re: More diesel_smoke patch

Post by LaDoncella »

the no-smoke in station, looks weird in some situations.

Imagine a very long heavy train entering a very long station, after a slope. The train is struggling to get in the station, yet no smoke.
Pipelines for the people! PIPE

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

Indeed - it is weird sometimes... Perhaps I'll just change it back to 3/4 smoke, becuase it's a very tricky part. Slowing at stations isn't covered by and train statuses it's just a function that occurs when train enters the station tiles with certain orders and in certain way... :?

User avatar
SirkoZ
Tycoon
Tycoon
Posts: 1507
Joined: 06 Mar 2004 23:51
Location: The sunny side of Alps

Re: More diesel_smoke patch

Post by SirkoZ »

Finally I got good station entering smoke/non-smoke formula (I just used all the key elements instead of just many :) ) from station-entering speed formula.

Here is the true version 3.0 (full for r15594, diesel_only for r15594 and of course full patch for 0.7.0-beta1 (r15549)):
Attachments
diesel_smoke_sz_3-0_r15594.patch
diff
(3.39 KiB) Downloaded 110 times
diesel_smoke_only_sz_3-0_r15594.patch
diff (improvement for diesel trains only)
(1.88 KiB) Downloaded 96 times
diesel_smoke_sz_3-0_0-7-0-ß1.patch
diff - full patch for 0.7.0-beta1
(3.39 KiB) Downloaded 97 times

W_neun
Engineer
Engineer
Posts: 24
Joined: 03 Apr 2009 11:03

Re: More diesel_smoke patch

Post by W_neun »

Could you update this patch, please? Doesn't work with recent nightlies. Thank you.

User avatar
Benny
Tycoon
Tycoon
Posts: 2185
Joined: 25 Aug 2007 17:03
Location: ~/

Re: More diesel_smoke patch

Post by Benny »

And maybe also a patch that heavily increases the smoke from steam trains? :mrgreen:
Image

User avatar
bebeto94
Engineer
Engineer
Posts: 99
Joined: 30 Sep 2002 19:39
Location: Plymouth UK

Re: More diesel_smoke patch

Post by bebeto94 »

Bennythen00b wrote:And maybe also a patch that heavily increases the smoke from steam trains? :mrgreen:
DITTO !!! :bow:

Post Reply

Return to “OpenTTD Development”

Who is online

Users browsing this forum: No registered users and 2 guests